_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 250 seconds]
ziggie has quit [Quit: Connection closed for inactivity]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
micha_ has quit [Quit: Connection closed for inactivity]
micha_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 264 seconds]
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
<jarolrod> provoostenator: i just finished syncing from master on a couple of different test machines, including a 2020 intel macbook pro, maybe overheating issues with your macbook?
hashfunc has joined #bitcoin-core-dev
halosghost has quit [Quit: WeeChat 3.6]
mikehu44 has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 252 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
chipxxx has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 264 seconds]
micha_ has quit [Quit: Connection closed for inactivity]
mikehu44 has quit [Read error: Connection reset by peer]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 264 seconds]
mikehu44 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
nanotube has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 252 seconds]
gleb1068924 has quit [Ping timeout: 265 seconds]
chip_x has joined #bitcoin-core-dev
chipxxx has quit [Ping timeout: 252 seconds]
hashfunc has quit [Ping timeout: 264 seconds]
chip_x has quit [Read error: Connection reset by peer]
vasild has quit [Remote host closed the connection]
<provoostenator> jarolrod: it rebooted itself last night so I can't even use ldb on it. Ready for recycling.
vasild has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 258 seconds]
Guyver2 has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 250 seconds]
AaronvanW has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 244 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
Murch has quit [Quit: Bridge terminating on SIGTERM]
bitcoin-git has quit [Quit: Bridge terminating on SIGTERM]
provoostenator has quit [Quit: Bridge terminating on SIGTERM]
willcl_ark has quit [Quit: Bridge terminating on SIGTERM]
sipa has quit [Quit: Bridge terminating on SIGTERM]
BlueMatt[m] has quit [Quit: Bridge terminating on SIGTERM]
robertspigler has quit [Quit: Bridge terminating on SIGTERM]
kvaciral has quit [Quit: Bridge terminating on SIGTERM]
denise[m] has quit [Quit: Bridge terminating on SIGTERM]
ishaanam[m] has quit [Quit: Bridge terminating on SIGTERM]
dunxen has quit [Quit: Bridge terminating on SIGTERM]
kakolainen[m] has quit [Quit: Bridge terminating on SIGTERM]
arturomf94[m] has quit [Quit: Bridge terminating on SIGTERM]
josie[m] has quit [Quit: Bridge terminating on SIGTERM]
stratospher[m] has quit [Quit: Bridge terminating on SIGTERM]
Murch has joined #bitcoin-core-dev
kvaciral has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
willcl_ark has joined #bitcoin-core-dev
denise[m] has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
robertspigler has joined #bitcoin-core-dev
provoostenator has joined #bitcoin-core-dev
stratospher[m] has joined #bitcoin-core-dev
arturomf94[m] has joined #bitcoin-core-dev
ishaanam[m] has joined #bitcoin-core-dev
kakolainen[m] has joined #bitcoin-core-dev
josie[m] has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 265 seconds]
kexkey has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5558d2f5496d...995fdef14af2
<bitcoin-git> bitcoin/master beb9426 Hennadii Stepanov: Revert "guix: Build depends/qt with our platform definition"
<bitcoin-git> bitcoin/master 995fdef fanquake: Merge bitcoin/bitcoin#26059: Revert "guix: Build depends/qt with our platf...
<bitcoin-git> [bitcoin] fanquake merged pull request #26059: Revert "guix: Build depends/qt with our platform definition" (master...220910-guix) https://github.com/bitcoin/bitcoin/pull/26059
af_mencken has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/995fdef14af2...e9e943cfb7c4
<bitcoin-git> bitcoin/master 2870a97 furszy: RPC: unify arg type error message
<bitcoin-git> bitcoin/master e9e943c fanquake: Merge bitcoin/bitcoin#26069: rpc: unify arg type error message
<bitcoin-git> [bitcoin] fanquake merged pull request #26069: rpc: unify arg type error message (master...2022_rpc_unify_error_type) https://github.com/bitcoin/bitcoin/pull/26069
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9e943cfb7c4...a361c6cae766
<bitcoin-git> bitcoin/master 0cd7928 fanquake: guix: use git-minimal over git
<bitcoin-git> bitcoin/master a361c6c fanquake: Merge bitcoin/bitcoin#26047: guix: use git-minimal over git
<bitcoin-git> [bitcoin] fanquake merged pull request #26047: guix: use git-minimal over git (master...guix_use_git_minimal) https://github.com/bitcoin/bitcoin/pull/26047
__afmencken has quit [Ping timeout: 265 seconds]
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 252 seconds]
gleb1068924 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #25948: doc: added note about brew and Qt 6 on macOS (master...docs-macos-qt6) https://github.com/bitcoin/bitcoin/pull/25948
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #26073: build: fix depends bdb compilation for BSDs (master..._BSD_bdb_compilation) https://github.com/bitcoin/bitcoin/pull/26073
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26074: refactor: Set RPCArg options with designated initializers (master...2209-rpc-refactor-🐿) https://github.com/bitcoin/bitcoin/pull/26074
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a361c6cae766...94d17845d04e
<bitcoin-git> bitcoin/master 2d0b4e4 Vasil Dimov: init: allow startup with -onlynet=onion -listenonion=1
<bitcoin-git> bitcoin/master 94d1784 fanquake: Merge bitcoin/bitcoin#24991: init: allow startup with -onlynet=onion -list...
<bitcoin-git> [bitcoin] fanquake merged pull request #24991: init: allow startup with -onlynet=onion -listenonion=1 (master...onlynet_onion_with_listenonion_is_ok) https://github.com/bitcoin/bitcoin/pull/24991
bitdex has quit [Quit: = ""]
gleb1068924 has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94d17845d04e...141540a71f51
<bitcoin-git> bitcoin/master faa3d38 MacroFake: refactor: Pass reference to LookUpStats
<bitcoin-git> bitcoin/master 141540a MacroFake: Merge bitcoin/bitcoin#25222: refactor: Pass reference to LookUpStats
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25222: refactor: Pass reference to LookUpStats (master...2205-ref-stat-😶) https://github.com/bitcoin/bitcoin/pull/25222
gleb1068924 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #26075: contrib: remove 32bit linux code from release scripts (master...remove_32bit_linux_scripts) https://github.com/bitcoin/bitcoin/pull/26075
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #26076: Switch hardened derivation marker to h in descriptors (master...2022/09/descriptors_h) https://github.com/bitcoin/bitcoin/pull/26076
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #24737: Remove taproot chain param (master...2204-rem-code-🥊) https://github.com/bitcoin/bitcoin/pull/24737
fjMSX has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
__afmencken has joined #bitcoin-core-dev
af_mencken has quit [Ping timeout: 250 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 268 seconds]
szkl has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 268 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
halosghost has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/141540a71f51...3a7e0a210c86
<bitcoin-git> bitcoin/master 00eeb31 James O'Beirne: scripted-diff: rename CChainState -> Chainstate
<bitcoin-git> bitcoin/master 3a7e0a2 glozow: Merge bitcoin/bitcoin#24513: CChainState -> Chainstate
<bitcoin-git> [bitcoin] glozow merged pull request #24513: CChainState - Chainstate (master...2022-03-chainstate-rename) https://github.com/bitcoin/bitcoin/pull/24513
<bitcoin-git> [bitcoin] fanquake opened pull request #26077: guix: switch from `guix environment` to `guix shell` (master...guix_shell_over_environment) https://github.com/bitcoin/bitcoin/pull/26077
mikehu44_ has quit [Ping timeout: 265 seconds]
andrewtoth has joined #bitcoin-core-dev
<jamesob> wow, it actually happened. CChainState is now Chainstate. Feel free to direct all rebase ire at me
<bitcoin-git> [bitcoin] jamesob reopened pull request #24364: refactor: remove duplicate code from BlockAssembler (master...2022-02-ba-dup-code) https://github.com/bitcoin/bitcoin/pull/24364
<halosghost> lol
<halosghost> am I understanding the history correctly that the prefix-C was a hungarian-notation holdover?
<halosghost> (namely, for “class”)
<jamesob> halosghost: yeah, Satoshi had a penchant for it
<halosghost> to be fair, a lot of people at the time did ☺
andrewtoth has quit [Remote host closed the connection]
Guyver2__ has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
Guyver2_ has quit [Ping timeout: 268 seconds]
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
jamesob has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3a7e0a210c86...c85688347eac
<bitcoin-git> bitcoin/master d26c3cc furszy: wallet: bugfix, load wallet with an unknown descriptor cause fatal error
<bitcoin-git> bitcoin/master e066763 furszy: wallet: coverage for loading an unknown descriptor
<bitcoin-git> bitcoin/master c856883 Andrew Chow: Merge bitcoin/bitcoin#26021: wallet: bugfix, load a wallet with an unknown...
<bitcoin-git> [bitcoin] achow101 merged pull request #26021: wallet: bugfix, load a wallet with an unknown/corrupt descriptor causes a fatal error (master...2022_wallet_fix_descriptor_unserialization) https://github.com/bitcoin/bitcoin/pull/26021
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
jamesob has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c85688347eac...29d540b7ada8
<bitcoin-git> bitcoin/master b50a4b7 Cory Fields: build: quiet warnings in system headers installed from homebrew
<bitcoin-git> bitcoin/master 29d540b fanquake: Merge bitcoin/bitcoin#26070: build: Quiet warnings in symlinked headers in...
<bitcoin-git> [bitcoin] fanquake merged pull request #26070: build: Quiet warnings in symlinked headers installed from homebrew (master...fix-brew-usrlocal) https://github.com/bitcoin/bitcoin/pull/26070
szkl has quit [Quit: Connection closed for inactivity]
fjMSX has quit [Remote host closed the connection]
<fanquake> wallet / psbt concerned folks, we need some opinons in regards to #25856 vs #25858
<gribble> https://github.com/bitcoin/bitcoin/issues/25856 | [BugFix] Make PSBT serializations 174 compliant by excluding empty taptree from serialization by JeremyRubin · Pull Request #25856 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
fjMSX has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
DeanGuss has quit [Quit: buhbye]
Copinmalin has joined #bitcoin-core-dev
DeanGuss has joined #bitcoin-core-dev
DeanGuss has quit [Changing host]
DeanGuss has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
gleb1068924 has quit [Ping timeout: 268 seconds]
gleb1068924 has joined #bitcoin-core-dev
Guest94 has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
Guest94 has quit [Client Quit]
Copinmalin has quit [Ping timeout: 252 seconds]
Copinmalin has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
Copinmalin has quit [Quit: Client closed]
bomb-on has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 258 seconds]
dougefish has joined #bitcoin-core-dev
Guyver2__ has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<bitcoin-git> [bitcoin] brunoerg opened pull request #26078: p2p: return `CSubNet` in `LookupSubNet` (master...2022-09-csubnet-lookup) https://github.com/bitcoin/bitcoin/pull/26078
brunoerg has quit []
realies has quit [Quit: ~]
<bitcoin-git> [bitcoin] hebasto opened pull request #26079: Revert "doc: note that brew installed qt is not supported" (master...220913-brew) https://github.com/bitcoin/bitcoin/pull/26079
halosghost has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] ishaanam opened pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
bitdex has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] luke-jr opened pull request #26082: RPC/Wallet: Access wallets via interfaces::Wallet (master...rpc_wallet_interfaces) https://github.com/bitcoin/bitcoin/pull/26082
<bitcoin-git> [bitcoin] glozow merged pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29d540b7ada8...57a17de05ea2
<bitcoin-git> bitcoin/master 6f8e381 ishaanam: sendall: check if the maxtxfee has been exceeded
<bitcoin-git> bitcoin/master 57a17de Gloria Zhao: Merge pull request #26081 from ishaanam/sendall_maxtxfee
<glozow> OMG that was a total accident, fat finger on mobile
<luke-jr> people have GitHub accounts logged into on mobile? <.<
<achow101> huh. didn't know that button still worked
<luke-jr> huh, the merge is GPG-signed
<luke-jr> how is that possible? :x
<achow101> I think the github webui has a gpg key
bomb-on has quit [Quit: aллилѹіа!]
<sipa> ... the correct one?
<achow101> no, I expect CI will fail verify-commits now
<luke-jr> ah, it's not her normal one
<glozow> no way, it should be on my yubikey
<luke-jr> 8 minutes now. probably should just revert and deal with verify-commits consequences :x
<luke-jr> (or branch off 24.x from the older commit and deal with the PR as-is)
jespada has quit [Ping timeout: 252 seconds]
<sipa> can't you force push the previous state?
<achow101> should I try?
<achow101> going to try force pushing 29d540b7ada890dd588c4825d40c27c5e6f20061
<achow101> goign to need an owner to do that: remote: error: Cannot force-push to this protected branch
<luke-jr> sipa: it will break anyone who pulled in the last 10 mins
<luke-jr> otoh, maybe we should take advantage of this to treat it as a malicious push to the git repo
<luke-jr> and see who notices / can adapt
<luke-jr> I assume in that scenario, we'd force push
<luke-jr> is laanwj the only one with needed access?
<achow101> I believe fanquake can force too
<sipa> i may still be able to, should i try?
<luke-jr> IMO yes, but I'm treating it as malicious (no offense to glozow intended)
<achow101> sipa: I think so
<glozow> I will open a revert. If somebody is able to push, please do.
<luke-jr> glozow: no point in a revert if sipa force pushes
<luke-jr> though the PR itself will need to be reopened
<sipa> give me a minute
<luke-jr> re-created*
<bitcoin-git> [bitcoin] sipa force pushed 0 commit to master: https://github.com/bitcoin/bitcoin/compare/57a17de05ea2...29d540b7ada8
<bitcoin-git> [bitcoin] glozow opened pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
<luke-jr> glozow: might I suggest a second unprivileged github account for your mobile?
<achow101> that appears to have worked
<luke-jr> also confirming the force push worked as results in the expected head commit
<glozow> luke-jr: yes indeed, I will need to stop having my account on mobile, lessons learned. Sincerest apologies!
<bitcoin-git> [bitcoin] glozow closed pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
<glozow> Thank you sipa! I’m very, very sorry, it was an accident
<sipa> There is a setting to require signed commits, though I don't know how it works.
<sipa> Or whether it applies to all commits or just the merge commits, or which keys it would accept.
<achow101> sipa: I believe that would apply to all commits
<achow101> we could probably turn on "Require pull request reviews before merging"?
<luke-jr> too bad there's no "don't allow merging via GitHub" XD
<achow101> although that would require at least one person to use the "review approval" thing as it probably won't understand ACKs. At least we could set it to 1 and before merging a pr, the maintainer needs to click that button before they can merge it
<luke-jr> hmm
<luke-jr> does it enforce these policies on git pushes at all?
<luke-jr> maybe we can enable an unsatisfiable one to just block the button
<achow101> it does block on git pushes too
<luke-jr> oh well :/
<achow101> it would have to be some policy which can be disabled per pr right before merging
sipsorcery has quit [Ping timeout: 244 seconds]
_apex_ has joined #bitcoin-core-dev
<_aj_> achow101: drahtbot could translate ACKs into a review approval by drahtbot, i suppose