ziggie has quit [Quit: Connection closed for inactivity]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
micha_ has quit [Quit: Connection closed for inactivity]
micha_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 264 seconds]
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
<jarolrod>
provoostenator: i just finished syncing from master on a couple of different test machines, including a 2020 intel macbook pro, maybe overheating issues with your macbook?
hashfunc has joined #bitcoin-core-dev
halosghost has quit [Quit: WeeChat 3.6]
mikehu44 has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 252 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
chipxxx has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 264 seconds]
micha_ has quit [Quit: Connection closed for inactivity]
mikehu44 has quit [Read error: Connection reset by peer]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 264 seconds]
mikehu44 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] fanquake opened pull request #26075: contrib: remove 32bit linux code from release scripts (master...remove_32bit_linux_scripts) https://github.com/bitcoin/bitcoin/pull/26075
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Sjors opened pull request #26076: Switch hardened derivation marker to h in descriptors (master...2022/09/descriptors_h) https://github.com/bitcoin/bitcoin/pull/26076
<bitcoin-git>
[bitcoin] fanquake merged pull request #26070: build: Quiet warnings in symlinked headers installed from homebrew (master...fix-brew-usrlocal) https://github.com/bitcoin/bitcoin/pull/26070
szkl has quit [Quit: Connection closed for inactivity]
fjMSX has quit [Remote host closed the connection]
<fanquake>
wallet / psbt concerned folks, we need some opinons in regards to #25856 vs #25858
<gribble>
https://github.com/bitcoin/bitcoin/issues/25856 | [BugFix] Make PSBT serializations 174 compliant by excluding empty taptree from serialization by JeremyRubin · Pull Request #25856 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
fjMSX has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
DeanGuss has quit [Quit: buhbye]
Copinmalin has joined #bitcoin-core-dev
DeanGuss has joined #bitcoin-core-dev
DeanGuss has quit [Changing host]
DeanGuss has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
gleb1068924 has quit [Ping timeout: 268 seconds]
gleb1068924 has joined #bitcoin-core-dev
Guest94 has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
Guest94 has quit [Client Quit]
Copinmalin has quit [Ping timeout: 252 seconds]
Copinmalin has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
Copinmalin has quit [Quit: Client closed]
bomb-on has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 258 seconds]
dougefish has joined #bitcoin-core-dev
Guyver2__ has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26078: p2p: return `CSubNet` in `LookupSubNet` (master...2022-09-csubnet-lookup) https://github.com/bitcoin/bitcoin/pull/26078
brunoerg has quit []
realies has quit [Quit: ~]
<bitcoin-git>
[bitcoin] hebasto opened pull request #26079: Revert "doc: note that brew installed qt is not supported" (master...220913-brew) https://github.com/bitcoin/bitcoin/pull/26079
halosghost has quit [Ping timeout: 260 seconds]
<bitcoin-git>
[bitcoin] ishaanam opened pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
bitdex has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] luke-jr opened pull request #26082: RPC/Wallet: Access wallets via interfaces::Wallet (master...rpc_wallet_interfaces) https://github.com/bitcoin/bitcoin/pull/26082
<bitcoin-git>
[bitcoin] glozow merged pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
<bitcoin-git>
[bitcoin] glozow opened pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
<luke-jr>
glozow: might I suggest a second unprivileged github account for your mobile?
<achow101>
that appears to have worked
<luke-jr>
also confirming the force push worked as results in the expected head commit
<glozow>
luke-jr: yes indeed, I will need to stop having my account on mobile, lessons learned. Sincerest apologies!
<bitcoin-git>
[bitcoin] glozow closed pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
<glozow>
Thank you sipa! I’m very, very sorry, it was an accident
<sipa>
There is a setting to require signed commits, though I don't know how it works.
<sipa>
Or whether it applies to all commits or just the merge commits, or which keys it would accept.
<achow101>
sipa: I believe that would apply to all commits
<achow101>
we could probably turn on "Require pull request reviews before merging"?
<luke-jr>
too bad there's no "don't allow merging via GitHub" XD
<achow101>
although that would require at least one person to use the "review approval" thing as it probably won't understand ACKs. At least we could set it to 1 and before merging a pr, the maintainer needs to click that button before they can merge it
<luke-jr>
hmm
<luke-jr>
does it enforce these policies on git pushes at all?
<luke-jr>
maybe we can enable an unsatisfiable one to just block the button
<achow101>
it does block on git pushes too
<luke-jr>
oh well :/
<achow101>
it would have to be some policy which can be disabled per pr right before merging
sipsorcery has quit [Ping timeout: 244 seconds]
_apex_ has joined #bitcoin-core-dev
<_aj_>
achow101: drahtbot could translate ACKs into a review approval by drahtbot, i suppose