<_aj_> robertspigler: maybe just means most i2p nodes aren't i2p-only (and thus make most of their outbound connections on ipv4/ipv6/onion)?
_apex_ has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 252 seconds]
gleb1068924 has quit [Quit: Ping timeout (120 seconds)]
gleb1068924 has joined #bitcoin-core-dev
dougefish_ has quit [Ping timeout: 244 seconds]
gleb10689249 has joined #bitcoin-core-dev
gleb1068924 has quit [Ping timeout: 252 seconds]
_apex2_ has quit [Ping timeout: 268 seconds]
<lightlike> also, it could be a bit of a chicken-and-egg problem: If you start out with an addrman that has predominantly clearnet peers, your chance to pick an i2p peer for an outgoing connection is small. But if you don't make outgoing connections to i2p peers, you probably won't advertise your i2p address but your clearnet address, so that your i2p address won't propagate to other i2p peers. As a result you also won't get incoming i2p peers
<lightlike> because others don't know you exist.
<robertspigler> Makes sense
<robertspigler> _aj_: Should there not be a preference to make atleast 1 i2p connection for network diversity sake
_apex2_ has joined #bitcoin-core-dev
<_aj_> lightlike: that sounds suboptimal?
<_aj_> robertspigler: i could see biasing addrfetch and the temporary block-relay-only connections to ensure connections are regularly made to each reachable net, to help maintain connectivity; but biasing a permanent connection might be risky?
dougefish has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
_apex2_ has quit [Ping timeout: 252 seconds]
mikehu44 has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
af_mencken has joined #bitcoin-core-dev
afmencken has quit [Ping timeout: 244 seconds]
realies has quit [Quit: Ping timeout (120 seconds)]
realies has joined #bitcoin-core-dev
dougefish has joined #bitcoin-core-dev
<vasild> robertspigler: lightlike: _aj_: indeed if addrman has just e.g. 5% i2p peers, then the chance of randomly selecting one is... well... 5%
<vasild> for outbound 10 connections that means 0 i2p peers
<_aj_> 40% chance of at least 1 peer at 5% each
<vasild> I have been thinking before to change the logic of "randomly" selecting outbound peers. This is very much related to #26035
<gribble> https://github.com/bitcoin/bitcoin/issues/26035 | Finding peers to connect to after -onlynet changes may be problematic · Issue #26035 · bitcoin/bitcoin · GitHub
<vasild> what about this: try to maintain at least 1 outbound to each reachable network? so when choosing a peer to connect to, ask addrman to give us a random i2p peer if we dont have i2p out connections and i2p is reachable
<vasild> s/i2p/any reachable network/
<vasild> _aj_: how did you derive that 40%?
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a56876e6b9da...27351fb9159e
<bitcoin-git> bitcoin/master b0349a7 fanquake: doc: consolidate & remove release-note fragments
<bitcoin-git> bitcoin/master 27351fb MacroFake: Merge bitcoin/bitcoin#26093: doc: consolidate release-note fragments pre-w...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26093: doc: consolidate release-note fragments pre-wiki (master...consolidate_release_notes) https://github.com/bitcoin/bitcoin/pull/26093
<_aj_> 1-((1-0.05)**10)
<vasild> +1
<vasild> in my addrman: total: 68234, ipv4: 46391, onion: 11491, ipv6: 10237, i2p: 111, cjdns: 4
<vasild> _aj_: so, at least for my addrman, that is 1.6% instead of 40% :/
baldur has quit [Remote host closed the connection]
<vasild> that node has 12 inbound and 0 outbound i2p connections
<_aj_> vasild: yeah, that sounds more plausible
baldur has joined #bitcoin-core-dev
<_aj_> vasild: lot of inbounds, but i guess your node was early or is a seed node?
<vasild> was early for sure, maybe also is a seed one
<_aj_> i think early would help if it's selected as a block-relay-only node by i2p-only peers
<vasild> hmm, looking only at inbound connections, why do I have 12/107=11% i2p connections if i2p peers are 111/68234=0.16% from all peers?
<vasild> well, ok, that 111/68234 is _listening_ ones
<_aj_> doesn't i2p make it easy to be a listening node?
<vasild> I guess people concerned about privacy dont listen
<vasild> _aj_: yes, it is a matter of setting i2pacceptincoming=1 which is the default
<_aj_> if p% of i2p nodes are i2p *only* then the average i2p node would expect to have p%/100% * 10 inbound connections
mikehu44 has joined #bitcoin-core-dev
<vasild> _aj_: that seems to be wrong for p=100?
<_aj_> i rounded the 0.87% down to 0 :)
<_aj_> (but 12 is still mroe than p%/100%*10 anyway ofc)
<vasild> ok
<vasild> posted a comment here, so it does not get forgotten: https://github.com/bitcoin/bitcoin/issues/26035#issuecomment-1249006795
Neojack has quit [Quit: See you around ;)]
xNSN has joined #bitcoin-core-dev
xNSN has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/27351fb9159e...19526d937fbd
<bitcoin-git> bitcoin/master 8b2891a Vasil Dimov: i2p: use the same destination type for transient and persistent addresses
<bitcoin-git> bitcoin/master 19526d9 fanquake: Merge bitcoin/bitcoin#26065: i2p: use the same destination type for transi...
<bitcoin-git> [bitcoin] fanquake merged pull request #26065: i2p: use the same destination type for transient and persistent addresses (master...i2p_transient_addr_type) https://github.com/bitcoin/bitcoin/pull/26065
kexkey has quit [Ping timeout: 265 seconds]
kexkey has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/19526d937fbd...2530a246896c
<bitcoin-git> bitcoin/master 04fee75 Pieter Wuille: Use ReadLE64 in uint256::GetUint64() instead of duplicating logic
<bitcoin-git> bitcoin/master 2530a24 fanquake: Merge bitcoin/bitcoin#26105: Use ReadLE64 in uint256::GetUint64 instead of...
<bitcoin-git> [bitcoin] fanquake merged pull request #26105: Use ReadLE64 in uint256::GetUint64 instead of duplicating logic (master...202209_uint256_readle64) https://github.com/bitcoin/bitcoin/pull/26105
jespada has quit [Quit: Textual IRC Client: www.textualapp.com]
bomb-on has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
mikehu44 has quit [Quit: No Ping reply in 180 seconds.]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2530a246896c...1d6c605165d6
<bitcoin-git> bitcoin/master 55e468f Hennadii Stepanov: build: Add `-no-mimetype-database` option to qt package in depends
<bitcoin-git> bitcoin/master d0433a3 Hennadii Stepanov: guix: Drop perl package
<bitcoin-git> bitcoin/master 1d6c605 fanquake: Merge bitcoin/bitcoin#26057: build, guix: Get rid of perl dependency
<bitcoin-git> [bitcoin] fanquake merged pull request #26057: build, guix: Get rid of perl dependency (master...220910-perl) https://github.com/bitcoin/bitcoin/pull/26057
mikehu44 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1d6c605165d6...08785aa75bf0
<bitcoin-git> bitcoin/master fa521c9 MacroFake: Use steady clock for all millis bench logging
<bitcoin-git> bitcoin/master 08785aa fanquake: Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging
<bitcoin-git> [bitcoin] fanquake merged pull request #25499: Use steady clock for all millis bench logging (master...2206-steady-🏑) https://github.com/bitcoin/bitcoin/pull/25499
cold has quit [Ping timeout: 252 seconds]
midnight has quit [Ping timeout: 255 seconds]
midnight has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/08785aa75bf0...5eb9781763a4
<bitcoin-git> bitcoin/master 97f5b20 stickies-v: refactor: use std::string for thread names
<bitcoin-git> bitcoin/master 200d84d stickies-v: refactor: use std::string for index names
<bitcoin-git> bitcoin/master 26cf9ea stickies-v: scripted-diff: rename pszThread to thread_name
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25971: refactor: Use std::string for thread and index names (master...baseindex-getname-string) https://github.com/bitcoin/bitcoin/pull/25971
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5eb9781763a4...5a724d1161ee
<bitcoin-git> bitcoin/master 22dada5 fanquake: build: prune compat event headers
<bitcoin-git> bitcoin/master 5a724d1 fanquake: Merge bitcoin/bitcoin#25918: build: prune event2 compat headers
<bitcoin-git> [bitcoin] fanquake merged pull request #25918: build: prune event2 compat headers (master...libevent_prune_compat_h) https://github.com/bitcoin/bitcoin/pull/25918
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 258 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5a724d1161ee...3d892d869585
<bitcoin-git> bitcoin/master f839697 fanquake: build: remove BOOST_CPPFLAGS usage from bitcoin-tx
<bitcoin-git> bitcoin/master 3d892d8 fanquake: Merge bitcoin/bitcoin#26086: build: remove BOOST_CPPFLAGS usage from bitco...
<bitcoin-git> [bitcoin] fanquake merged pull request #26086: build: remove BOOST_CPPFLAGS usage from bitcoin-tx (master...bitcoin_tx_prune_boost_cpp) https://github.com/bitcoin/bitcoin/pull/26086
darosior has quit [Remote host closed the connection]
darosior has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow opened pull request #26107: [test] only run feature_rbf.py once (master...2022-09-rbf-notwallet) https://github.com/bitcoin/bitcoin/pull/26107
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
bitdex has quit [Quit: = ""]
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
AaronvanW has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
halosghost has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3d892d869585...9fefd00d8e67
<bitcoin-git> bitcoin/master 667401a glozow: [test] only run feature_rbf.py once
<bitcoin-git> bitcoin/master 9fefd00 MacroFake: Merge bitcoin/bitcoin#26107: [test] only run feature_rbf.py once
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26107: [test] only run feature_rbf.py once (master...2022-09-rbf-notwallet) https://github.com/bitcoin/bitcoin/pull/26107
chipxxx has joined #bitcoin-core-dev
<vasild> MacroFake: any idea how to deterministically reproduce #25365? Putting sleep in BaseIndex::SetBestBlockIndex() does not trigger it, nor in MainSignalsImpl::Iterate()
<gribble> https://github.com/bitcoin/bitcoin/issues/25365 | ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) in BaseIndex · Issue #25365 · bitcoin/bitcoin · GitHub
chipxxx has quit [Ping timeout: 250 seconds]
chipxxx has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
chipxxx has quit [Read error: Connection reset by peer]
_apex2_ has quit [Ping timeout: 265 seconds]
<fanquake> 0.20.x is EOL, so I've just closed the 0.20.3 milestone on GH.
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9fefd00d8e67...a688ff9046a9
<bitcoin-git> bitcoin/master a10df7c fanquake: build: prune BOOST_CPPFLAGS from libbitcoin_zmq
<bitcoin-git> bitcoin/master a688ff9 fanquake: Merge bitcoin/bitcoin#26087: build: prune BOOST_CPPFLAGS from libbitcoin_z...
<bitcoin-git> [bitcoin] fanquake merged pull request #26087: build: prune BOOST_CPPFLAGS from libbitcoin_zmq (master...libbitcoin_zmq_prune_boost_cppflags) https://github.com/bitcoin/bitcoin/pull/26087
<bitcoin-git> [bitcoin] jonatack opened pull request #26109: rpc, cli: getpeerinfo and -netinfo updates (master...2022-09-getpeerinfo-netinfo-updates) https://github.com/bitcoin/bitcoin/pull/26109
halosghost has quit [Quit: WeeChat 3.6]
szkl has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] yancyribbens opened pull request #26110: test: Remove unused coin_selection param (master...remove-unused-bnb-test-param) https://github.com/bitcoin/bitcoin/pull/26110
bcdarc has joined #bitcoin-core-dev
<lightlike> vasild: "indeed if addrman has just e.g. 5% i2p peers, then the chance of randomly selecting one is... well... 5%" - It could be less due to the Selection logic in AddrMan, where we flip a coin to choose from new or tried, and then pick a random peer from whatever we chose in the first step.
<lightlike> E.g. if we just enabled i2p so that all known i2p addrs are still in the new table, the chance could be closer to 2.5%.
<vasild> lightlike: ah, that too! :)
fjMSX has quit [Quit: Уш'лЪЬ їз єтой IRC сетї]
<sdaftuar1> hi, do i need to request write access to edit the release notes wiki page? i was going to add a note regarding headers presync.
<fanquake> sdaftuar: have invited you
<fanquake> although I'm not sure if write access is needed to make edits? Maybe just being a member of bitcoin-core orgnanisation (which it doesn't look like you were a part of either)
<sipa> It looks to me that being a member of the "frequent contributors" group on the bitcoin-core org is sufficient.
<fanquake> Yes I think so. Have edited that invite to just be the "frequent contributors" group
<sdaftuar1> thanks, i have an edit button now!
<bitcoin-git> [bitcoin] yancyribbens opened pull request #26111: refactor: Simplify bnb coin_selection test params (master...simplify-bnb-test-params) https://github.com/bitcoin/bitcoin/pull/26111
chipxxx has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
fjMSX has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 250 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
bcdarc has joined #bitcoin-core-dev
sdaftuar1 has joined #bitcoin-core-dev
F1nny has quit [Quit: Termd]
<jb55> has anyone experienced not being able to sync headers? I'm on master and still have this issue.
<sipa> jb55: that's concerning, you have any more details? Due to #25717 it may take longer to sync headers.
<gribble> https://github.com/bitcoin/bitcoin/issues/25717 | p2p: Implement anti-DoS headers sync by sdaftuar · Pull Request #25717 · bitcoin/bitcoin · GitHub
<instagibbs> jb55, if your connection is flapping during pre-sync, it can take "forever"
<_aj_> jb55: bitcoin-cli getpeerinfo | grep presync # ?
<jb55> sipa: not sure maybe I'll try tracing. but it seems like it's just stuck and is not receiving any data from peers, even from a local node on my network.
<jb55> _aj_: sec
<instagibbs> no presyncing logs at all?
<instagibbs> that would be surprising
<jb55> > ./src/bitcoin-cli getpeerinfo | grep presync | sort | uniq -c
<jb55> 11 "presynced_headers": -1,
<jb55> synced_blocks and synced_headers is all -1 as well for all 11 peers
<_aj_> bitcoin-cli getblockchaininfo | jq .headers,.blocks # both 0 i guess?
<sipa> there is a chance it gets unstuck once a block gets announced
<sipa> but this shouldn't happen
<jb55> _aj_: both 752167
<_aj_> oh
<_aj_> shouldn't be a presync problem per se then
<jb55> this is my laptop node that I spin up on occasion. it's stuck 2 weeks behind
<sipa> it's just over 2000 + 144 headers behind, so it very well could be.
<jb55> should I try to bisect?
<sipa> having logs with -debug=net would be helpful, but i assume that restarting with it will resolve the issue too
<jb55> ok sec
<sipa> have you already restarted
<sipa> ?
<sipa> if not, i suggest you don't, and see if it gets automatically resolved by a new block announcement
<sipa> because i expect that restarting will fix it without givin us any information
<_aj_> bitcoin-cli logging ["net"] # to turn it on without restarting, on the offchance that's helpful?
<_aj_> oh, more quotes needed i guess
__afmencken has joined #bitcoin-core-dev
<jb55> I've restarted multiple times and it's still stuck
<sipa> oh, ok
<sipa> that's concerning
<sipa> what does getchaintips say?
af_mencken has quit [Ping timeout: 260 seconds]
<jb55> that looks bad
<sipa> seems like you've rejected the honest chain
<jb55> indeed
<sipa> try `reconsiderblock <hash>`, with hash the invalid hash from getchaintips
<sipa> and observe what appears in debug.log
<_aj_> shouldn't the active block be 752661 in that case?
<jb55> I didn't see anything happen in the log but now it says "status": "headers-only"
<jb55> (the one that was previously had status invalid)
<jb55> I'll restart now...
<_aj_> does getblock 000000000000000000079ba062298aa7cef1888f870c23e303a361c19b097ff8 (752168) work?
<jb55> fixed it
<jb55> guess corruption or something?
<_aj_> didn't write everything to disk when it last powered down, maybe?
<jb55> _aj_: does reconsiderblock fetch the block again or something?
<jb55> never used that before
<sipa> It doesn't
<sipa> It just clears invalidity flags, and re-evaluates.
<jb55> cosmic ray I guess
<jb55> would be cool if getchaintips gave a reason why it was invalid ...
<sipa> Yeah, that's not cached, so it only appears in the logs.
<jb55> ah so it might be in my logs somewhere
<jb55> well that explains it... https://jb55.com/s/nospace.txt
<sipa> Ugh.
<sipa> That is bad.
<sipa> Out of disk space should not result in database corruption.
<instagibbs> TODO: Add out of disk space regression tests...
<jb55> I'll open an issue
<sipa> Database errors propagating up and being interpreted as (permanent) block invalidity was one of the contributing factors to the BDB/LevelDB fork in the 0.7/0.8 transition.
_apex2_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
bytes1440000 has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 252 seconds]
<bytes1440000> Blockstream and Chaincodelabs should find a way to not mess with open source bitcoin core wallet
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
<instagibbs> *squints*
<jb55> instagibbs: I wonder how you would do that... tmpfs mount perhaps?
<sipa> or have some means of stubbing out the disk space check
<jb55> not sure if mocking would be the best here but perhaps
<sipa> Oh, no, that wouldn't work.
<sipa> It's not our own disk space check that triggered, but leveldb being unable to write to disk.
* jb55 nods
sipsorcery has quit [Ping timeout: 265 seconds]
<jb55> fault injection testing might be interesting, if we could randomly simulate write failures...
vasild has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 258 seconds]
sipsorcery has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
__afmencken has quit [Ping timeout: 244 seconds]
kexkey has quit [Ping timeout: 265 seconds]
afmencken has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 258 seconds]
vasild has joined #bitcoin-core-dev
af_mencken has joined #bitcoin-core-dev
afmencken has quit [Ping timeout: 252 seconds]
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
koolazer has joined #bitcoin-core-dev
__afmencken has joined #bitcoin-core-dev
af_mencken has quit [Ping timeout: 265 seconds]
_apex2_ has joined #bitcoin-core-dev
<earnestly> (There's also a libfiu but I don't know anything about it)
_apex2_ has quit [Ping timeout: 264 seconds]
chipxxx has quit [Read error: Connection reset by peer]
<jb55> Earnestly: TIL the kernel has this feature. very cool.
DeanGuss has quit [Remote host closed the connection]
DeanGuss has joined #bitcoin-core-dev
DeanGuss has quit [Changing host]
DeanGuss has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
<jamesob> anyone seeing approx. 500 bazillion " [lock] Enter: lock contention m_mutex, ./checkqueue.h:78 " lines when enabling -debug?
<jamesob> it makes debug.log basically unusable
<bitcoin-git> [bitcoin] mzumsande opened pull request #26114: net: Make AddrFetch connections to fixed seeds (master...202209_addrfetch_fixedseeds) https://github.com/bitcoin/bitcoin/pull/26114
brunoerg has quit []
bitdex has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 252 seconds]
<achow101> jamesob: happens if you configured with --enable-debug which will enable DEBUG_LOCKCONTENTION
<achow101> it can be turned off with -debugexclude=lock
KamiK4Z3 has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 265 seconds]
sipsorcery has joined #bitcoin-core-dev
KamiK4Z3 has quit [Remote host closed the connection]
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit []