andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 258 seconds]
_apex2_ has quit [Ping timeout: 246 seconds]
robertspigler has quit [Ping timeout: 248 seconds]
kvaciral has quit [Ping timeout: 248 seconds]
robertspigler has joined #bitcoin-core-dev
vincenzopalazzo has quit [Ping timeout: 268 seconds]
bitcoin-git has quit [Ping timeout: 264 seconds]
josie[m] has quit [Ping timeout: 264 seconds]
arturomf94[m] has quit [Ping timeout: 268 seconds]
dunxen has quit [Ping timeout: 268 seconds]
kvaciral has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 250 seconds]
Evel-Knievel has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
vincenzopalazzo has joined #bitcoin-core-dev
josie[m] has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
arturomf94[m] has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 248 seconds]
bitdex has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 246 seconds]
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
sudoforge has quit [Ping timeout: 244 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
bomb-on has joined #bitcoin-core-dev
kouloumos has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
jon_atack has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
kakolainen[m] has quit [Quit: Bridge terminating on SIGTERM]
sipa has quit [Quit: Bridge terminating on SIGTERM]
willcl_ark has quit [Quit: Bridge terminating on SIGTERM]
provoostenator has quit [Quit: Bridge terminating on SIGTERM]
BlueMatt[m] has quit [Quit: Bridge terminating on SIGTERM]
robertspigler has quit [Quit: Bridge terminating on SIGTERM]
josie[m] has quit [Quit: Bridge terminating on SIGTERM]
bitcoin-git has quit [Quit: Bridge terminating on SIGTERM]
dunxen has quit [Quit: Bridge terminating on SIGTERM]
arturomf94[m] has quit [Quit: Bridge terminating on SIGTERM]
vincenzopalazzo has quit [Quit: Bridge terminating on SIGTERM]
stratospher[m] has quit [Quit: Bridge terminating on SIGTERM]
SakshamSolanki[m has quit [Quit: Bridge terminating on SIGTERM]
ishaanam[m] has quit [Quit: Bridge terminating on SIGTERM]
Murch has quit [Quit: Bridge terminating on SIGTERM]
denise[m] has quit [Quit: Bridge terminating on SIGTERM]
cotsuka has quit [Quit: Bridge terminating on SIGTERM]
kvaciral has quit [Quit: Bridge terminating on SIGTERM]
mudsip has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] glozow closed pull request #22867: test: Extend test coverage of BIP125 and document confusing/inconsistent behavior (master...test_bip125_edge_cases) https://github.com/bitcoin/bitcoin/pull/22867
<bitcoin-git>
[bitcoin] glozow closed pull request #19443: rpc: Add options argument to listtransactions, with paginatebypointer options (master...listtransactions-paginatebypointer) https://github.com/bitcoin/bitcoin/pull/19443
<bitcoin-git>
[bitcoin] glozow closed pull request #19677: Switch BlockMap to use an unordered_set under the hood (master...refactor-blockmap-blockset) https://github.com/bitcoin/bitcoin/pull/19677
<bitcoin-git>
[bitcoin] glozow closed pull request #22049: rpc: allow specifying min chain depth for inputs in fund calls (master...psbt_coin_control) https://github.com/bitcoin/bitcoin/pull/22049
<bitcoin-git>
[bitcoin] glozow reopened pull request #19443: rpc: Add options argument to listtransactions, with paginatebypointer options (master...listtransactions-paginatebypointer) https://github.com/bitcoin/bitcoin/pull/19443
<bitcoin-git>
[bitcoin] glozow closed pull request #15129: rpc: Added ability to remove watch only addresses (master...remove_watch_only_address) https://github.com/bitcoin/bitcoin/pull/15129
<bitcoin-git>
[bitcoin] glozow closed pull request #9245: Drop IO priority to idle while reading blocks for peer requests and startup verification (master...ionice) https://github.com/bitcoin/bitcoin/pull/9245
mudsip has quit [Client Quit]
Murch has joined #bitcoin-core-dev
kvaciral has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
stratospher[m] has joined #bitcoin-core-dev
provoostenator has joined #bitcoin-core-dev
kakolainen[m] has joined #bitcoin-core-dev
denise[m] has joined #bitcoin-core-dev
willcl_ark has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
robertspigler has joined #bitcoin-core-dev
vincenzopalazzo has joined #bitcoin-core-dev
arturomf94[m] has joined #bitcoin-core-dev
ishaanam[m] has joined #bitcoin-core-dev
SakshamSolanki[m has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
josie[m] has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
<glozow>
^for context, they all needed rebase for 1 year or more
<bitcoin-git>
[bitcoin] fanquake opened pull request #26183: build: split ARM crc & crypto extension checks (master...duplicate_crc_rypto_check) https://github.com/bitcoin/bitcoin/pull/26183
_apex2_ has joined #bitcoin-core-dev
bcdarc has joined #bitcoin-core-dev
sdaftuar1 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
jon_atack has joined #bitcoin-core-dev
mudsip has quit []
_apex2_ has quit [Ping timeout: 250 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
ghost43 has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
chipxxx has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 252 seconds]
<luke-jr>
glozow: "Feel free to reopen" - is not something people can actually do
<luke-jr>
I actually did rebase 9245, but I guess forgot to push it
<fanquake>
luke-jr: what's preventing you from re-opening the PR?
<sipa>
if a maintainer closes a PR, I think the author can't reopen it
<fanquake>
Really? I didn't realise that actually made a difference. I guess there's some slight permissions thing?
<luke-jr>
yes
<luke-jr>
the only option I have is "Delete branch"
<fanquake>
What options are in the comment dialouge?
<luke-jr>
just "Comment" (greyed until I type something)
<luke-jr>
this isn't new - it's always been like this
<fanquake>
Trying to find the github docs that indicate this is the case. I guess it's tied to the write permission.
brunoerg has joined #bitcoin-core-dev
<fanquake>
"Feel free to re-open" should be changed to "Let us know if you plan to continue working on this" / "Leave a comment for this to be re-opened".
<luke-jr>
I suppose ideally we should ask GitHub to add a "Close as waiting for author" or soemthing
<luke-jr>
they did similar for issues not long ago
<luke-jr>
not quite identical, but different ways to close them
SpellChecker has quit [Ping timeout: 258 seconds]
SpellChecker has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 268 seconds]
<glozow>
Oh wow didn't know this either. luke-jr: I can reopen #9245 if you want
<gribble>
https://github.com/bitcoin/bitcoin/issues/9245 | Drop IO priority to idle while reading blocks for peer requests and startup verification by luke-jr · Pull Request #9245 · bitcoin/bitcoin · GitHub
<luke-jr>
glozow: k
<bitcoin-git>
[bitcoin] glozow reopened pull request #9245: Drop IO priority to idle while reading blocks for peer requests and startup verification (master...ionice) https://github.com/bitcoin/bitcoin/pull/9245
<luke-jr>
doh, my rebase needs a rebase >_<
<luke-jr>
I'll get to it soon :x
<sipa>
yo dawg
<luke-jr>
XD
jon_atack has joined #bitcoin-core-dev
<glozow>
well i'm glad the PR close party was productive hahaha
_andrewtoth_ has joined #bitcoin-core-dev
jonatack1 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 268 seconds]
jonatack2 has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
jonatack1 has quit [Ping timeout: 248 seconds]
dlb76 has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] theStack opened pull request #26184: test: p2p: check that headers message with invalid proof-of-work disconnects peer (master...202209-test-check_for_invalid_pow_headers_msg) https://github.com/bitcoin/bitcoin/pull/26184
bitdex has quit [Quit: = ""]
jonatack2 has quit [Ping timeout: 252 seconds]
halosghost has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 248 seconds]
jonatack2 has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 246 seconds]
<dergoegge>
could i get #25515 added to "High-priority for review" under "Chasing Concept ACK" ?
<gribble>
https://github.com/bitcoin/bitcoin/issues/25515 | net, test: Virtualise CConnman and add initial PeerManager unit tests by dergoegge · Pull Request #25515 · bitcoin/bitcoin · GitHub
_andrewtoth_ has quit [Remote host closed the connection]