brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
ghost43_ has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
SpellChecker has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
qxk_ has joined #bitcoin-core-dev
qxk has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
as2333 has quit [Changing host]
as2333 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
weylin_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
MrFrancis has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
as2333 has quit [Quit: Ping timeout: 264 seconds]
as2333 has joined #bitcoin-core-dev
as2333 has quit [Changing host]
as2333 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Norrin has quit [Ping timeout: 255 seconds]
Norrin has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<phantomcircuit>
sipa: how big would the performance cost be for putting ~47GiB in leveldb?
<sipa>
The one big performance-suboptimality LevelDB has is that it effectively writes e everything twice.
<sipa>
(once to logs, once to the level files)
<sipa>
But I don't think that once written there is much of a penalty for large datasets.
<phantomcircuit>
sipa: so putting the gcs filters for the wallet lookups directly into leveldb would be ok?
<sipa>
how big are the records?
<sipa>
one per block?
<phantomcircuit>
sipa: one per block, each filter is ~10% the size of the block, although i could make them much smaller at the cost of increased false positives
<phantomcircuit>
sipa: i was going to get all the plumbing done and then try various parameters to just benchmark which one is best, but i realized if the best was large filters maybe putting ~50GiB into leveldb wasn't the best idea
<phantomcircuit>
the existing filters use the flat files
<sipa>
ah, just reuse their code
<phantomcircuit>
i cant remember what kind of guarantees if any leveldb makes about detecting corruption
<sipa>
it has a crc
<phantomcircuit>
sipa: they're doing things like storing the block filter metadata using either the block height or the block hash when there's a reorg, it seems more complicated than any potential performance advantage could possibly be worth
SpellChecker has quit [Ping timeout: 255 seconds]
qxk_ has quit [Ping timeout: 255 seconds]
<phantomcircuit>
sipa: there's even a comment about it being to improve sequential performance when reading the metadata back but like...
SpellChecker has joined #bitcoin-core-dev
qxk has joined #bitcoin-core-dev
<phantomcircuit>
the actual leveldb database for the existing ones is only 87MiB, i cant imagine any kind of optimization there is ever going to be worth the (in my opinion) significantly increased complexity
<phantomcircuit>
looks like it was written by Jim Posen is he in here?
<sipa>
No, he's not contributing anymore.
brunoerg has joined #bitcoin-core-dev
<phantomcircuit>
you think he would remember why he made the choice to do this? i feel like no
<phantomcircuit>
it was a long time ago
<sipa>
I don't know if I ever reviewed it in detail.
Zeit has quit [Remote host closed the connection]
<phantomcircuit>
sipa: yeah i just know that you did work on the filters, so i was hoping for some spill over heh
<phantomcircuit>
i've read the minimizing writeup before, the last time i tried to do this and got the parameters very wrong at first
AaronvanW has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 265 seconds]
Norrin has quit [Remote host closed the connection]
AmunRa has joined #bitcoin-core-dev
<phantomcircuit>
sipa: the actual block files aren't checksumed right? so checksuming the filters would be going beyond what we already do?
<sipa>
i don't remember
<sipa>
i think they just have a magic + length descriptor as metadata per block
<sipa>
but block data is self-checksumming of course; if it gets corrupted, its PoW won't be valid
<phantomcircuit>
does the wallet rescan check the PoW and the merkle tree?
<phantomcircuit>
maybe it does and that's why it's slow
<sipa>
unsure
<phantomcircuit>
sipa: so it checks the header pow and that the block deserializes, but no the merkle tree
<phantomcircuit>
so a filter that didn't have a checksum would be slightly more likely to miss disk corruption, but only +- corruption that doesn't deserialize correctly
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
MrFrancis has quit [Ping timeout: 252 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
weylin_ has quit [Remote host closed the connection]
weylin_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
qxk has quit [Remote host closed the connection]
qxk has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
weylin__ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
weylin_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
AaronvanW has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
weylin__ has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 255 seconds]
ghost43 has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
AmunRa has quit [Remote host closed the connection]
AmunRa has joined #bitcoin-core-dev
dviola has quit [Ping timeout: 272 seconds]
AmunRa has quit [Remote host closed the connection]
dviola has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 255 seconds]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 255 seconds]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #26904: build: move rpc/request from util lib to common (master...move_rpc_request_out_util) https://github.com/bitcoin/bitcoin/pull/26904
qxk has quit [Quit: leaving]
MrFrancis has quit [Ping timeout: 256 seconds]
Guest45 has joined #bitcoin-core-dev
Guest45 has left #bitcoin-core-dev [#bitcoin-core-dev]
MrFrancis has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
SpellChecker_ has quit [Read error: Connection reset by peer]
SpellChecker has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
<bitcoin-git>
[gui] MarcoFalke opened pull request #697: Remove reindex special case from the progress bar label (master...2301-gui-reindex-๐) https://github.com/bitcoin-core/gui/pull/697
<bitcoin-git>
bitcoin/master faec09f MarcoFalke: test: Return chain of MiniWallet txs from MiniWallet chain method
<bitcoin-git>
[bitcoin] fanquake merged pull request #26625: test: Run mempool_packages.py with MiniWallet (master...2212-test-mini-wallet-๐) https://github.com/bitcoin/bitcoin/pull/26625
salvatoshi has quit [Ping timeout: 260 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
AmunRa has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jamesob opened pull request #26906: test: add an easy way to run linters locally (master...2023-01-lint-container) https://github.com/bitcoin/bitcoin/pull/26906
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
salvatoshi has joined #bitcoin-core-dev
bytes1440000 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bytes1440000>
- i apologize for some of my things and already did it. none of you did it including someone who shared a vuln on github publicly.
<bytes1440000>
- who are these mods?
<bytes1440000>
- doxxed by one maintainer, harassed by contributor, and bullied by another contributor many times. What would you do?
<bytes1440000>
- what would you do do if your real identity becomes a life threat because of a mistake?
<bytes1440000>
- if some "long-term" contributors bully others and I prove it, what would you do? if not how would it look in courts of different countries?
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
<bytes1440000>
you have no clues about a few things... I will share once this CoC is taken seriously. And how this last maintainer wants to be boss of bitcoin. Maybe last 2 maintainers to add them in PR were mistake and not reviewed properly.
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
<theStack>
is there a way to set peer-permissions on outbound peers? we use "-whitelist=noban@127.0.0.1" in many of the functional tests to relax txs immediately (i.e. disable trickle), but IIUC, this is only effective if a tx originates at node0, since it's the only one that only has only inbound peers (the default test framework topology is node0 <- node1 <- ... <- nodeN)
<theStack>
s/relax/relay/
weylin_ has joined #bitcoin-core-dev
<brunoerg>
theStack: something like #26441 and 17167?
<bitcoin-git>
[bitcoin] mzumsande opened pull request #26909: addrdb: prevent peers.dat corruptions by only serializing once (master...202301_peersdat_corruption) https://github.com/bitcoin/bitcoin/pull/26909
<bitcoin-git>
[bitcoin] furszy opened pull request #26910: wallet: migrate wallet, exit early if no legacy data exist (master...2022_wallet_prevent_descriptors_migration) https://github.com/bitcoin/bitcoin/pull/26910
jespada has joined #bitcoin-core-dev
as2333 has joined #bitcoin-core-dev
qxs has quit [Remote host closed the connection]
dviola has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
weylin_ has joined #bitcoin-core-dev
AmunRa has quit [Ping timeout: 255 seconds]
salvatoshi has quit [Ping timeout: 268 seconds]
AmunRa has joined #bitcoin-core-dev
jespada has quit [Read error: Connection reset by peer]
jespada has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 272 seconds]
MrFrancis has joined #bitcoin-core-dev
orville has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has left #bitcoin-core-dev [#bitcoin-core-dev]
amovfx_ has joined #bitcoin-core-dev
amovfx_ has quit [Client Quit]
andrewmo has joined #bitcoin-core-dev
andrewmo has quit [Remote host closed the connection]
andrew_m_ has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
AmunRa has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
weylin__ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
___nick___ has quit [Ping timeout: 256 seconds]
weylin_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
bytes144000019 has joined #bitcoin-core-dev
<bytes144000019>
i wouldnt answer
<bytes144000019>
no time
<bytes144000019>
pls contact *@bitcoincore.org and this might even help if flight/x crashes.
bytes144000019 has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
user has joined #bitcoin-core-dev
user has quit [Client Quit]
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AmunRa has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
mudsip has quit [Client Quit]
AmunRa has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
bytes1440000 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
<bytes1440000>
I am sleeping. Keep with you.
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 265 seconds]
qxs has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
weylin__ has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
MrFrancis has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
bitdex has joined #bitcoin-core-dev
AmunRa has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
weylin_ has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]