orville has quit [Quit: <exit all I/O streams / EOF>]
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
hashfunc has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
aureleoules has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
as2333 has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
as2333 has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
aureleoules has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
AmunRa has quit [Ping timeout: 255 seconds]
AmunRa has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_m_ has joined #bitcoin-core-dev
<phantomcircuit>
theStack: can you explain why the fast rescan is descriptor only? i think im missing something
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 260 seconds]
hashfunc has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
MrFrancis has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
weylin_ has quit [Remote host closed the connection]
weylin_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
MrFrancis has quit [Ping timeout: 256 seconds]
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
qxs has quit [Remote host closed the connection]
bitdex has quit [Ping timeout: 255 seconds]
qxs has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
yanmaani has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 256 seconds]
weylin_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_m_ has joined #bitcoin-core-dev
Guest72 has joined #bitcoin-core-dev
hsmiths1 has joined #bitcoin-core-dev
<sipa>
@phantomcircuit For descriptor wallets we can trivially compute the set of all corresponding scriptPubKeys.
<sipa>
The legacy to descriptor wallet conversion code needs to effectively do the same thing, though.
<sipa>
For legacy wallets that's potentially pretty complicated (when n-of-n multisigs exists which we have all private keys for, for example)
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 272 seconds]
hsmiths has quit []
hsmiths1 is now known as hsmiths
hsmiths_ has joined #bitcoin-core-dev
hsmiths_ is now known as hsmith_s
brunoerg has quit [Ping timeout: 256 seconds]
Guest72 has quit [Quit: Client closed]
Levi5 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
hsmiths has quit [Quit: hsmiths]
hsmiths has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
hsmiths has quit [Quit: hsmiths]
andrew_mo_ has quit [Remote host closed the connection]
hsmiths has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
hsmith_s has quit []
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
Levi5 has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
hsmiths has quit [Quit: hsmiths]
hsmiths has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
jarthur_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 255 seconds]
bitdex has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
andrew_mo_ has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
AmunRa has quit [Ping timeout: 255 seconds]
AmunRa has joined #bitcoin-core-dev
weylin_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
AmunRa has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
<phantomcircuit>
sipa: there's legacy to descriptor wallet conversion code? how does that even work
brunoerg has joined #bitcoin-core-dev
as2333 has quit [Quit: as2333]
<phantomcircuit>
sipa: yeah i see that there's a LegacyScriptPubKeyMan::GetScriptPubKeys now, which is what you need to do the filter based scan
brunoerg has quit [Ping timeout: 268 seconds]
jarthur_ has quit [Quit: jarthur_]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<phantomcircuit>
sipa: i guess i could also include in the filter which blocks even contain "interesting" transactions
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
weylin_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
<phantomcircuit>
sipa: personally i think it's pretty reasonable for this not to detect n-of-n multisig where we have all the keys, but i absolutely could make the filter work more like bip37 and include each data push to make that possibl
jespada has quit [Remote host closed the connection]
jespada has joined #bitcoin-core-dev
<theStack>
phantomcircuit: +1 on what sipa said. it was just easier to implement for descriptor wallets only in a first step (see also PR description). when i started working on the PR the wallet migration code was not merged yet, which provides a method to get all scriptPubKeys also for legacy wallets (method `LegacyScriptPubKeyMan::GetScriptPubKeys()`).
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
bitdex_ has quit [Quit: = ""]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
<sipa>
@phantomcircuit Legacy wallets have an IsMine that (traditionally) acts as a function: you give it a scriptPubKey and it determines whether it matches the wallet. That approach is not good for fast rescanning, because the filter cannot store the actual scriptPubKeys, only a probabilistic data structure with some data of it.
<sipa>
Having data pushes and what not in the filter isn't relevant, that's not issue.
<sipa>
The only realistic approach is being able to generate the set of all IsMine scriptPubKeys, hashin them, and then looking them up in the filter.
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
AmunRa has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
kexkey has quit [Quit: kexkey]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
AaronvanW has quit [Remote host closed the connection]
<jamesob>
So part of me wants to really stir the pot, bench how much faster 3.11 runs the test suite, and then push for containerizing all test runs for people who don't have 3.11 on-host
<sipa>
if we want fast, we should try to make things work in pypy instead
<sipa>
that's like 3x faster
<jamesob>
"Python 3.11 is between 10-60% faster than Python 3.10. On average, we measured a 1.25x speedup on the standard benchmark suite. See Faster CPython for details." https://docs.python.org/3/whatsnew/3.11.html
<fanquake>
I think everyone should basically be using 3.11 locally anyways. I always just pyenv install whatever is the latest python, and use that
<jamesob>
fanquake: most def
___nick___ has joined #bitcoin-core-dev
<jamesob>
man you guys are making me want to write that ill-advised PR
andrew_mo_ has quit [Ping timeout: 256 seconds]
<achow101>
our ci should probably just use pyenv too
<jamesob>
achow101: IMO our CI should be using pre-built containers that are trivial to reuse locally so there's never any issue about reproducing CI
<jamesob>
Cirrus would (probably?) automatically cache the container layers and builds would probably be faster
andrew_mo_ has joined #bitcoin-core-dev
<achow101>
yeah, we should convert the install scripts to Dockerfiles
<jamesob>
bingo
andrew_mo_ has quit [Ping timeout: 256 seconds]
bcdarc has joined #bitcoin-core-dev
sdaftuar has quit [Ping timeout: 268 seconds]
andrew_mo_ has quit [Read error: Connection reset by peer]
<sipa>
Intersting, I can just run test_runner in pypy now (IIRC I tried that a while ago and it didn't work). It's significantly slower than cpython (3x more wall clock time at -j30, lol).
<sipa>
Its IPC must be a lot slower.
andrew_mo_ has joined #bitcoin-core-dev
as2333 has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<jamesob>
sipa: yeah I bet we're IO bound on bitcoind for most of the time. So maybe .py performance isn't so meaningful
andrew_mo_ has quit [Ping timeout: 246 seconds]
AaronvanW has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
bcdarc has joined #bitcoin-core-dev
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
sdaftuar has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has quit [Ping timeout: 272 seconds]
b_101 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
MrFrancis has quit [Ping timeout: 252 seconds]
raj has joined #bitcoin-core-dev
raj is now known as Guest5800
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Read error: Connection reset by peer]
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_m_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
raj has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
raj is now known as Guest7558
AmunRa has quit [Remote host closed the connection]
AmunRa has joined #bitcoin-core-dev
TheRec has quit []
cotsuka has quit [Quit: Bye!]
cotsuka has joined #bitcoin-core-dev
Guest798 has joined #bitcoin-core-dev
<instagibbs>
Guest798, what commands did you run, and on what version (if you can share)
metallicc has joined #bitcoin-core-dev
AmunRa has quit [Ping timeout: 255 seconds]
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
AmunRa has joined #bitcoin-core-dev
b_101 has quit [Read error: Connection reset by peer]
b_101 has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Guest7558 has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest5800 has quit [Quit: Leaving]
raj has joined #bitcoin-core-dev
raj is now known as Guest3116
Guest798 has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest798 has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
MrFrancis has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 255 seconds]
roze_paul has joined #bitcoin-core-dev
roze_paul has quit [Client Quit]
roze_paul has joined #bitcoin-core-dev
outfox has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 268 seconds]
brunoerg has quit [Remote host closed the connection]
<_aj_>
sipa: any thoughts on the bip324 shortid negotitation? having net_processing do the shortid/command mapping seems like it makes sense, and just requires a bit of tweaking of the CNetMsgMaker api so that it can choose a shortid instead of the lower level Serializer
MrFrancis has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] john-moffett closed pull request #26915: test: Skip copying BDB database directory in wallet backwards compatibility test (master...2023_01_FixWalletCompatibilityTestFailure) https://github.com/bitcoin/bitcoin/pull/26915
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 272 seconds]
<sipa>
_aj_: I haven't really looked deeply at the code... conceptually I can see it go either way.
andrew_mo_ has joined #bitcoin-core-dev
<_aj_>
sipa: i guess i was more wondering about whether it's a "let's ignore the issue and get all the other stuff done first; can always patch over it after it's released" or a "patches welcome" or somewhere in between topic? haven't seen much comments from others, so not sure if it's just me obsessing over a pet topic
<jamesob>
sipa: am I correct in assuming that SpanPopBack() doesn't actually modify the underlying vector?
<sipa>
jamesob: It returns a reference to the last element of the span, and shrinks the span to no longer include that. I can't change anything underlying, since it has no idea what can lie underneath (there might not even be anything modifiable, like an array).
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
<sipa>
_aj_: Do you mean patches to the BIP, or the code, or both?
andrew_mo_ has joined #bitcoin-core-dev
<sipa>
_aj_: I'd say I'd like to get the approach we want to take w.r.t. shortid negotation/signalling/encoding/coordination/procedure better fleshed out (whether that means just sticking to what is in the BIP now, or something else), but ideally not something that requires too much *spec* work now (because who knows... it may never be needed).
<sipa>
Regarding the code, I don't have too many opinions.
andrew_m_ has quit [Ping timeout: 260 seconds]
<sipa>
(I've only started reviewing parts of the non-cryptography stuff myself recently)
b_101 has joined #bitcoin-core-dev
<_aj_>
sipa: either/both, i guess. i guess i'm convinced at this point it'd be possible to do it pretty well as an add-on after the fact; so it's probably just that not doing it right straight away grates on my sense of aesthetics
b_101__ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 252 seconds]
b_101_ has joined #bitcoin-core-dev
b_101__ has quit [Ping timeout: 272 seconds]
b_101_ has quit [Quit: leaving]
b_101_ has joined #bitcoin-core-dev
b_101_ has quit [Client Quit]
b_101_ has joined #bitcoin-core-dev
b_101_ has quit [Ping timeout: 272 seconds]
b_101 has joined #bitcoin-core-dev
halosghost has quit [Quit: WeeChat 3.8]
AaronvanW has quit [Quit: Leaving...]
orville has quit [Quit: <exit all I/O streams / EOF>]
b_101 has quit [Killed (NickServ (GHOST command used by b_101_))]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Killed (NickServ (GHOST command used by b_101_))]
b_101 has joined #bitcoin-core-dev
<phantomcircuit>
sipa: so the filter logic can identify multisig scripts that have been imported by the user manually, which seems fine to me
<phantomcircuit>
iirc there's a very small number of bare multisig scripts in the entire blockchain
b_101 has quit [Killed (NickServ (GHOST command used by b_101_))]
<phantomcircuit>
sipa: whose the wallet maintainer?
<sipa>
@phantomcircuit @achow101
EPiSKiNG- has quit [Quit: EPiSKiNG-]
<phantomcircuit>
achow101: what do you think of the fast rescan filters only working on multisig that the user has explicitly imported for legacy wallets
<phantomcircuit>
sipa: im not misremembering about there being almost no bare multisig right?
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
EPiSKiNG- has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 256 seconds]
<sipa>
@phantomcircuit I think it's much easier to tell people that want this feature to migrate to descriptor wallets.
andrew_mo_ has joined #bitcoin-core-dev
<sipa>
But I haven't paid attention to that code in a long time, so I'm not the one to ask.