AmunRa has quit [Remote host closed the connection]
cold has quit [Ping timeout: 256 seconds]
midnight has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
midnight has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27004: test: Use std::unique_ptr over manual delete in coins_tests (master...2301-test-uniq-ptr-🕴) https://github.com/bitcoin/bitcoin/pull/27004
gwillen has quit [Ping timeout: 255 seconds]
MrFrancis has joined #bitcoin-core-dev
gwillen has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
Lightsword has quit [Read error: Connection reset by peer]
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 268 seconds]
Talkless has joined #bitcoin-core-dev
Talkless has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
Lightsword has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27005: util: Use steady clock for logging timer (master...2301-log-steady-clock-🔆) https://github.com/bitcoin/bitcoin/pull/27005
<PaperSword>
How would I get access to this variable? I am having trouble capturing the scope or creating the class instance needed to call this.
<bitcoin-git>
[bitcoin] furszy opened pull request #27006: reduce cs_main scope, guard block index 'nFile' under a local mutex (master...2022_reduce_cs_main_scope_blockindex_nfile) https://github.com/bitcoin/bitcoin/pull/27006
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<fjahr>
#proposedmeetingtopic ASMap in the release process
<fjahr>
I have put my thoughts into a write-up here: https://gist.github.com/fjahr/bf0ff0917e03a4e49fac0617b2b35747 Would be great if people could take a look before the meeting. I am especially interested in feedback from maintainers if I am right with my assumptions of how they see those things.
<fjahr>
I have put one up at gitlab.sighash.org. I only cloned the bitcoin core repos so far, happy to give people access if they want to try stuff out or to hear ideas what would be interesting next steps. Just ping me in a DM.
<fjahr>
I am also working on a Gitea instance but ran into problems, will get back to it soon.
<instagibbs>
sipa, would it be reasonable for the "segwit" part of decodescript response to extract miniscript policy since it's in the right context?
<instagibbs>
I can open an issue at least
<sipa>
yeah, i think so
<sipa>
not policy, the bitcoin core codebase has nothing to do with that
andrew_mo_ has joined #bitcoin-core-dev
<instagibbs>
errrr miniscript
<instagibbs>
sorry
<sipa>
but i lt should be able to report inferred miniscript
<instagibbs>
terminology still difficult sometimes
<bitcoin-git>
bitcoin/master 6d58117 Hennadii Stepanov: build: Build minisketch test in `make check`, not in `make`
<bitcoin-git>
bitcoin/master b5868f4 fanquake: Merge bitcoin/bitcoin#23670: build: Build minisketch test in `make check`,...
<bitcoin-git>
[bitcoin] fanquake merged pull request #23670: build: Build minisketch test in `make check`, not in `make` (master...211204-check) https://github.com/bitcoin/bitcoin/pull/23670
<larryruane>
Has anyone looked into thread fuzzing? Ping @MacroFake @lightlike ... I'm thinking I'd look into what's out there and seeing if we can apply these ideas to bitcoin core to discover and fix thread synchronization bugs
andrew_m_ has quit [Ping timeout: 264 seconds]
<lightlike>
LarryRuane: No, never looked into this, maybe @dergoegge has?
<MacroFake>
We already use the thread sanitizer, and the functional test should already cover a good portion of thread sync stuff
<MacroFake>
Not sure if tsan goes well with rr, but you could try
<MacroFake>
Not sure if there are any threads worth fuzz testing that aren't already covered by the functional tests?
<MacroFake>
Could make sense to get a bare metal CPU to run a nightly rr task (with or without tsan)
andrew_mo_ has joined #bitcoin-core-dev
<larryruane>
What is rr? Yes, I was thinking that tsan and our locking annotations might be sufficient already, but the kind of thing I'm thinking is a test mode where there's a test-only thread that would suspend and resume threads randomly while the system is under load (like running functional tests),
<larryruane>
the idea being, if there are currently any narrow timing windows that are so unlikely that we never (or rarely) see them, this would open up the windows and discover them... basically, change the timing between threads in extreme ways
Talkless has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
SpellChecker has quit [Ping timeout: 255 seconds]
<bitcoin-git>
[bitcoin] mzumsande opened pull request #27009: validation: Skip VerifyDB checks of level =3 if dbcache is too small (master...202301_verifychain_assertfix) https://github.com/bitcoin/bitcoin/pull/27009
SpellChecker has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
MrFrancis has quit [Remote host closed the connection]
MrFrancis has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #27010: refactor: use `Hash` helpers for double-SHA256 calculations (master...202301-refactor-use_double_sha256_helper) https://github.com/bitcoin/bitcoin/pull/27010
MrFrancis has quit [Ping timeout: 248 seconds]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
szkl has quit [Quit: Connection closed for inactivity]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
mudsip has joined #bitcoin-core-dev
Victor_sueca has quit [Ping timeout: 268 seconds]
Victor_sueca has joined #bitcoin-core-dev
roze_paul has quit [Remote host closed the connection]
jarthur has joined #bitcoin-core-dev
mudsip has quit []
AmunRa has joined #bitcoin-core-dev
halosghost has quit [Read error: Connection reset by peer]
halosghost has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 252 seconds]
andrewtoth has quit [Remote host closed the connection]
<fjahr>
sipa: thanks! looking forward to your feedback!
<sipa>
Hmm, I don't think I ever knew about that asmap-admin team (or any associated repo).
<fjahr>
laanwj created it after the conversation here https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2021-11-11#736102 but it was probably deleted at some point because it wasn't used yet, just would have been nice to get a heads-up. Or maybe my head made up the repo and it was just the admin group.