andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
<phantomcircuit>
sipa: change the veriable name heh
<phantomcircuit>
sipa: but yeah if you have hungarian and dont change the variable names when the type is changed everybody will be sad
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
MrFrancis has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Guest39 has joined #bitcoin-core-dev
Guest39 has quit [Client Quit]
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
as2333 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
as2333 has quit [Remote host closed the connection]
as2333 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew___ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew___ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
MrFrancis has quit [Ping timeout: 248 seconds]
jarthur has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] pablomartin4btc opened pull request #26990: bitcoin:cli add validation to -generate command to avoid confusion when it's used with -rpcwallet (master...bitcoin-cli-generate-validation-when-rpcwallet) https://github.com/bitcoin/bitcoin/pull/26990
andrew_mo_ has quit [Ping timeout: 252 seconds]
dviola has quit [Quit: WeeChat 3.7.1]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
AmunRa has quit [Remote host closed the connection]
andrew_m_ has quit [Ping timeout: 252 seconds]
AmunRa has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
BitcoinCharlie has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
as2333 has quit [Quit: as2333]
andrew_mo_ has quit [Ping timeout: 252 seconds]
BitcoinCharlie has quit [Ping timeout: 252 seconds]
<bitcoin-git>
bitcoin/master eeee610 MarcoFalke: Use AutoFile and HashVerifier where possible
<bitcoin-git>
bitcoin/master 0a1d372 fanquake: Merge bitcoin/bitcoin#26649: refactor: Use AutoFile and HashVerifier (with...
<bitcoin-git>
[bitcoin] fanquake merged pull request #26649: refactor: Use AutoFile and HashVerifier (without ser-type and ser-version) where possible (master...2212-ser-type-ver-👬) https://github.com/bitcoin/bitcoin/pull/26649
<bitcoin-git>
bitcoin/master 79cedc3 James O'Beirne: coins: add Sync() method to allow flush without cacheCoins drop
<bitcoin-git>
bitcoin/master 6d8affc James O'Beirne: test: refactor: clarify the coins simulation
<bitcoin-git>
bitcoin/master 2c3cbd6 James O'Beirne: test: add use of Sync() to coins tests
<bitcoin-git>
[bitcoin] fanquake merged pull request #17487: coins: allow write to disk without cache drop (master...2019-11-au-coins-erase) https://github.com/bitcoin/bitcoin/pull/17487
<bitcoin-git>
[bitcoin] fanquake opened pull request #26998: depends: ensure we are appending to sqlite cflags (master...msan_flags_missing) https://github.com/bitcoin/bitcoin/pull/26998
<freedom-core-dev>
_aj_: 1. Why did you post publicly on github about a vulnerability when you are skilled enough to understand what would happen?
<freedom-core-dev>
2. Why are you against UASF and cheered by devs like sipa?
<freedom-core-dev>
3. Why was your (1) not shared in bitcoin optech?
<freedom-core-dev>
4. Why do you share CIA links in normal bitcoin discussions?
<freedom-core-dev>
5. Is it because of the organization you get paid for?
<freedom-core-dev>
Are you an attacker on bitcoin?
andrew_mo_ has quit [Ping timeout: 256 seconds]
freedom-core-dev has quit [Quit: Client closed]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sipa opened pull request #26999: A few follow-ups to #17487 (coins write without cache drop) (master...202301_flush_coins_followup) https://github.com/bitcoin/bitcoin/pull/26999
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
Talkless has joined #bitcoin-core-dev
roze_paul has quit [Remote host closed the connection]
freedom-core-dev has joined #bitcoin-core-dev
freedom-core-dev has quit [Client Quit]
freedom-core-dev has joined #bitcoin-core-dev
freedom-core-dev has left #bitcoin-core-dev [#bitcoin-core-dev]
andrew_mo_ has joined #bitcoin-core-dev
AmunRa has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew___ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
freedom-core-dev has joined #bitcoin-core-dev
<freedom-core-dev>
_aj_: you have done more to send devs and users away from bitcoin
<freedom-core-dev>
nobody needs your policing anymore and its more than i see here when do something related to government
<freedom-core-dev>
i know you celebrate rage quits, now you would have to deal with some people who really believe in bitcoin and wont quit
roze_paul has joined #bitcoin-core-dev
<freedom-core-dev>
using my real ip not vpn, let me know if you or others can affect me
freedom-core-dev has left #bitcoin-core-dev [#bitcoin-core-dev]
<fanquake>
laanwj achow101 ops?
andrew_m_ has quit [Ping timeout: 255 seconds]
<fanquake>
freedom-core-dev: please stop turning up here and posting this garbage. It’s getting old. Feel free to engage in constructive development discussion.
andrew___ has quit [Ping timeout: 248 seconds]
roze_paul has quit [Ping timeout: 252 seconds]
freedom-core-dev has joined #bitcoin-core-dev
<freedom-core-dev>
fanquake: i wont and you can try to stop me as you did with other things. brink is not bitcoin. i will engage in constructive dev discussion when you stop politics and censorship.
freedom-core-dev has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] achow101 merged pull request #26999: A few follow-ups to #17487 (coins write without cache drop) (master...202301_flush_coins_followup) https://github.com/bitcoin/bitcoin/pull/26999
<bitcoin-git>
bitcoin/master 56a03f1 fanquake: depends: ensure we are appending to sqlite cflags
<bitcoin-git>
bitcoin/master ceb74b8 Andrew Chow: Merge bitcoin/bitcoin#26998: depends: ensure we are appending to sqlite cf...
<bitcoin-git>
[bitcoin] achow101 merged pull request #26998: depends: ensure we are appending to sqlite cflags (master...msan_flags_missing) https://github.com/bitcoin/bitcoin/pull/26998
MrFrancis has joined #bitcoin-core-dev
<willcl_ark>
Is decodescript supposed to be able to decode scriptSigs, or only scriptPubKeys?
<sipa>
It should be able to decode any valid script, but scriptSigs generally just consist of a few pushes, so decoding them won't give much interesting.
MrFrancis has quit [Ping timeout: 252 seconds]
<willcl_ark>
Ok thanks. It did appear that way from the functional test. But the release notes from v12.0 seemed to indicate that it was unsupported.
PaperSword has quit [Quit: PaperSword]
<sipa>
Just checked, the 0.12 release notes even mention the new sighash decoding that was introduced there for scriptSig decoding?
<willcl_ark>
I am curious then about the decodescript output for this scriptsig: `bitcoin-cli decoderawtransaction (bitcoin-cli getrawtransaction 061959f1a3360d3781a870b2d43f73f7105b194b22f3765fcb9b8f545f9c8317) | jq -r ."vin"[0]."scriptSig"."hex"` ? I don't think this is a witness_v0_scripthash? But I also might be interpreting this wrong
halosghost has quit [Quit: WeeChat 3.8]
<sipa>
It's a P2PKH spend. The asm and hex scriptSig look correct me.
<sipa>
The decoded asm shows two pushes, the first being an ECDSA signature, the second the public key.
AmunRa has quit [Remote host closed the connection]
<willcl_ark>
I agree, the asm field appears correct for me. But I guess I don't understand the rest of the output, which for me looks like: https://snippet.host/uohzrk Are the optional fields (address, p2sh and segwit) only describing how this script would look if wrapped in these output script template types? `type` shows "nonstandard" instead of expected `pubkeyhash` too...
AmunRa has joined #bitcoin-core-dev
<sipa>
yes
<sipa>
decodescript doesn't know anything about the context in which that script occurs
<willcl_ark>
right
<sipa>
it just tells you "if this were a segwit script, these would be some of its properties"
<sipa>
"if it were wrapped in p2sh, that's what the address would be"
<willcl_ark>
Fine, ok. Also backed up by the rpchelp then :)
<willcl_ark>
Should it know that this is a pubkeyhash script, and not just nonstandard?
<sipa>
no, it can't know that
<sipa>
it's just a script that pushes two things
<sipa>
it's not a P2PKH script, it's a scriptSig spending a P2PKH output
<sipa>
but in theory it could be many other things too
<willcl_ark>
ok got it. Thanks Pieter!
AmunRa has quit [Remote host closed the connection]