roze_paul has quit [Remote host closed the connection]
mably has quit [Quit: Connection closed for inactivity]
andrewtoth_ has quit [Remote host closed the connection]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
MrFrancis has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
baldur has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AmunRa has quit [Ping timeout: 255 seconds]
andrew_m_ has joined #bitcoin-core-dev
AmunRa has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
PaperSword has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
PaperSword has quit [Quit: PaperSword]
andrew_mo_ has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
<phantomcircuit> achow101: i've seen multiple people comment that they want more explanation for #26951 but i genuinely don't know what needs more explanation, any ideas?
<gribble> https://github.com/bitcoin/bitcoin/issues/26951 | wallet: improve rescan performance 640% by pstratem · Pull Request #26951 · bitcoin/bitcoin · GitHub
AmunRa has quit [Ping timeout: 255 seconds]
AmunRa has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
<PaperSword> Working on #25899 right now and was wondering to test for the OP_RETURN outputs do i just pass though is standard?
<gribble> https://github.com/bitcoin/bitcoin/issues/25899 | rpc: prevent non-zero value OP_RETURN outputs in sendrawtransaction · Issue #25899 · bitcoin/bitcoin · GitHub
andrew_mo_ has joined #bitcoin-core-dev
<PaperSword> Secondly can I assume that a TX could have more than one OP_RETURN?
andrew_mo_ has quit [Ping timeout: 248 seconds]
<phantomcircuit> PaperSword: stolen from blockfilter.cpp if (script.empty() || script[0] == OP_RETURN) continue;
andrew_mo_ has joined #bitcoin-core-dev
<PaperSword> phantomcircuit: Thanks, what about using this TxoutType Solver (https://github.com/bitcoin/bitcoin/blob/58da1619be7ac13e686cb8bbfc2ab0f836eb3fa5/src/script/standard.cpp#L168) On the CTxOut(s) of the CTransactionRef
MrFrancis has quit [Ping timeout: 248 seconds]
<sipa> Both work.
<phantomcircuit> sipa: the solver would be much slower though right?
<sipa> Yes , but that won't matter for an RPC like this
andrew_mo_ has quit [Ping timeout: 268 seconds]
<PaperSword> There is another larger issue in terms of implementation
<PaperSword> Should this check go in the RPC call RPCHelpMan sendrawtransaction() or the BroadcastTransaction()
andrew_mo_ has joined #bitcoin-core-dev
<PaperSword> I am leaning tward the former ...
<PaperSword> phantomcircuit: sipa: Thank you for the assistance.
<phantomcircuit> PaperSword: in the sendrawtransaction rpc call, broadcast is used by other things
<PaperSword> Sweet that's what I thought. Though the error return in broadcast would perfect for this kind of flag. Okay last one for a bit I promise.
<PaperSword> In the issue it doesn't state how this should be handled explicitly. Should I throw an error code with a desc? Or was there another way this was meant to be handled?
<sipa> @PaperSword These are generally questions that you, as implementor, have to decide.
<PaperSword> Okay great!
<PaperSword> I will do that.
<sipa> The goal isn't to write the code that someome else has in mind; if they did, they'd have written it already.
<sipa> The goal is to solve the issue, in whatever way you, and code reviewers, consider best.
andrew_mo_ has quit [Ping timeout: 260 seconds]
<sipa> I don't know whether sendrawtransaction or BroadcastTransaction is better. The former would likely be simpler, but the latter would make sure it also works for other (perhaps future) sending RPCs.
<sipa> I haven't personally looked at this part of the codebase in a while, so don't consider this expert advice.
<PaperSword> Agreed thank you for that. As a first issue, was just kind of trying to get a finger pointed in the best direction. None the less time for me to swim. Thank you
andrew_mo_ has joined #bitcoin-core-dev
<PaperSword> IsUnspendable() would be fastest :D
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 268 seconds]
as2333 has quit [Quit: Ping timeout: 264 seconds]
as2333 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
<PaperSword> Why are so many Classes prefixed with a 'C' yet in the contributing guidelines it states 'Do not prefix class names with C'
cmirror has joined #bitcoin-core-dev
<_aj_> hungarian notation likes prefixing names with their type, in this case C for class. satoshi used hungarian notation. later contributors decided to move away from that
yancy has quit [Ping timeout: 252 seconds]
helo has quit [Ping timeout: 252 seconds]
roasbeef has quit [Ping timeout: 260 seconds]
<PaperSword> Thanks :_aj_, so after a certain point all code implemented must apply the new rules. Prior to that though the hungarian notions was the standard?
andrew_mo_ has joined #bitcoin-core-dev
<_aj_> hungarian notation's pretty rate outside of windows C code, i think, so it's a bit weird and annoying. i think maybe 2012-2014 saw people doing different things? before my time really
andrew_mo_ has quit [Ping timeout: 248 seconds]
bitdex has quit [Ping timeout: 255 seconds]
helo has joined #bitcoin-core-dev
roasbeef has joined #bitcoin-core-dev
yancy has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
helo has quit [Ping timeout: 252 seconds]
helo has joined #bitcoin-core-dev
as2333 has quit [Quit: as2333]
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
Guest49 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
Guest49 has quit [Client Quit]
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
<achow101> phantomcircuit: I think people are looking for a bit more on the specifics of the new index, e.g. what option(s) are being added, the setup time for the index, what the index stores, how that differs from existing indexes. I think people also want some more details on the benchmark like what kind of wallet, keypool size, how many used addresses.
<achow101> although I think most of the "explain more" comments were for the first version of the description which just had some benchmarking numbers
andrew_mo_ has joined #bitcoin-core-dev
<phantomcircuit> _aj_: i personally kind of like hungarian notation but i don't use an ide, i think lots of people do now so it's just spam to them
andrew_mo_ has quit [Ping timeout: 260 seconds]
<phantomcircuit> achow101: makes sense, im not sure how to bench mark this in a useful way that isn't insanely slow, the setup takes orders of magnitude longer than the scan, so any benchmark would take hours
<phantomcircuit> or you can just benchmark against the actual blockchain where the setup is one time
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Guyver2 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Guest699 has joined #bitcoin-core-dev
BitcoinCharlie has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
Talkless has joined #bitcoin-core-dev
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 252 seconds]
BitcoinCharlie has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Guyver2 has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
MrFrancis has joined #bitcoin-core-dev
theHeap has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AmunRa has quit [Ping timeout: 255 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
Guyver2 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
AaronvanW has quit [Quit: Leaving...]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
MrFrancis has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
vasild_ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 255 seconds]
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 260 seconds]
Talkless has quit [Quit: Konversation terminated!]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Guest699 has quit [Quit: Client closed]
andrew_mo_ has joined #bitcoin-core-dev
BitcoinCharlie has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
salvatoshi has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
Guest72 has joined #bitcoin-core-dev
Guest72 has quit [Client Quit]
Guest72 has joined #bitcoin-core-dev
Guest72 has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 255 seconds]
vasild_ has quit [Remote host closed the connection]
Guyver2__ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
Guyver2_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
<sipa> phantomcircuit: Never used an IDE, never liked Hungarian.
<sipa> The worst part is when code gets updated, and a data type changes, but the variable name stays the same... now it's not just ugly, but also confusing and wrong.
Guyver2_ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
Guyver2__ has quit [Ping timeout: 248 seconds]
Guyver2__ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Guyver2_ has quit [Ping timeout: 252 seconds]
vasild has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
roze_paul has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
BitcoinCharlie has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
BitcoinCharlie has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 255 seconds]
AmunRa has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<theStack> to quote the linux kernel coding style doc: "Encoding the type of a function into the name (so-called Hungarian notation) is brain damaged - the compiler knows the types anyway and can check those, and it only confuses the programmer. No wonder MicroSoft makes buggy programs."
<sipa> :D
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] aguycalled opened pull request #26987: Fix attempt Msvc wip (master...msvc-wip) https://github.com/bitcoin/bitcoin/pull/26987
andrew_mo_ has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #26987: Fix attempt Msvc wip (master...msvc-wip) https://github.com/bitcoin/bitcoin/pull/26987
Guyver2_ has joined #bitcoin-core-dev
Guyver2__ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
bugs_ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
BitcoinCharlie has quit [Ping timeout: 255 seconds]
___nick___ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
Zenton has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
mably has joined #bitcoin-core-dev
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
andrew___ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
andrewtoth has quit [Ping timeout: 255 seconds]
andrew___ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
as2333 has joined #bitcoin-core-dev
MrFrancis has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker_ has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
MrFrancis has quit [Ping timeout: 248 seconds]
MrFrancis has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] stratospher opened pull request #26988: [rpc]: Add test-only RPC addrmaninfo for new/tried table address count (master...rpc_addrmaninfo) https://github.com/bitcoin/bitcoin/pull/26988
andrew_m_ has joined #bitcoin-core-dev
roze_paul has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
andrew___ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
andrew___ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
PaperSword has quit [Remote host closed the connection]
MrFrancis has quit [Ping timeout: 248 seconds]
PaperSword has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
MrFrancis has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
MrFrancis has quit [Ping timeout: 248 seconds]
bitdex has quit [Ping timeout: 255 seconds]
as2333 has quit [Ping timeout: 264 seconds]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 255 seconds]
bitdex has joined #bitcoin-core-dev