andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
jrayhawk has quit [Ping timeout: 264 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
as2333 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
aurum has joined #bitcoin-core-dev
aurum has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] LarryRuane opened pull request #26963: update copyright tool to write mit-licenses URL with https rather than http (master...2023-01-licenses-https) https://github.com/bitcoin/bitcoin/pull/26963
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_mo_ has quit [Ping timeout: 255 seconds]
MrFrancis has quit [Ping timeout: 252 seconds]
MrFrancis has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
AaronvanW has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
MrFrancis has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
as2333 has quit [Quit: as2333]
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew___ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
andrew___ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
jrayhawk has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
b_101_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
AmishNick has quit [Quit: Leaving]
AmishNick has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
sudoforge has quit [Quit: 404]
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 252 seconds]
w0xlt has quit []
w0xlt has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sloorush has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
sloorush has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
sloorush has joined #bitcoin-core-dev
<PaperSword>
Why is is that when I cumulatively add the getblock(n) size from blocks 0 to the tip. The size is about 50GB less than the blocks directory size?
da2ce7 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
sloorush has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
sloorush has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
RubenSomsen_ is now known as RubenSomsen
brunoerg has quit [Ping timeout: 255 seconds]
andrew_mo_ has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
dviola has left #bitcoin-core-dev [WeeChat 3.7.1]
dviola has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] willcl-ark opened pull request #26964: Assert RPC Server binds before creating cookie (master...2023-01-cookie-bind) https://github.com/bitcoin/bitcoin/pull/26964
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
AmishNick has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
cotsuka has quit [Quit: Bye!]
Talkless has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
pablomartin has quit [Quit: Leaving]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
AmishNick has quit [Quit: Leaving]
brunoerg has quit [Ping timeout: 256 seconds]
as2333 has quit [Ping timeout: 264 seconds]
AmishNick has joined #bitcoin-core-dev
as2333 has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
<jamesob>
Man it's pretty annoying that script_asset_test.json isn't bundled with the repo; can't reproduce CI failures locally. It's not clear to me how to change these test vectors; anyone have experience with this?
andrew_mo_ has joined #bitcoin-core-dev
AmishNick has quit [Quit: Leaving]
<jamesob>
I'm assuming the failure has something to do with overriding deprecated opcodes for use as OP_SUCCESSx, but the test vector generation is pretty opaque
AmishNick has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
<jamesob>
sipa: am I understand it correctly that script_assets_test_minimizer.cpp basically uses the fuzzer to generate test cases? We take a random buffer and then check to see if it encodes a valid test case in the fuzz target; does that then get somehow serialized out to the script_asset_test.json file?
<jamesob>
*understanding it
<sipa>
The tests are generated by feature_taproot.py.
<sipa>
And then minimized by script_assets_test_minimizer.cpp
<sipa>
Just starting from random buffers won't construct anything interesting, as the fuzzer can't produce valid signatures (if it could, bitcoin would be broken...)
<jamesob>
heh, right
<jamesob>
What's the suggested workflow for updating those vectors? Regenerate with feature_taproot.py --dumptests and then PR the resulting file against the QA assets repo?
<sipa>
Pretty much.
<sipa>
But the generated tests are not deterministic, so maybe instead of re-running you'd probably just want to generate tests for whatever you're adding.
<jamesob>
It seems that the existings vectors fail for OP_SUCCESSx overrides, so I'm not sure how to update them aside from re-running
<sipa>
My best guess is that you've actually broken the code then.
<jamesob>
Definitely possible
<sipa>
No soft-fork change should be able to make the tests fail.
<sipa>
Because the tests list which script verification flags to run with, and if those don't change, the behavior of script validation by definition shouldn't change.
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
salvatoshi has quit [Ping timeout: 268 seconds]
<jamesob>
Do we have anything that's like the reverse of ParseScript? I.e. CScript -> std::string?
<sipa>
CCoinsViewCache::Flush() (and ::Sync()) hands it map of coins to the underlying CCoinsView's BatchWrite function. If that underlying CCoinsView is a CCoinsViewCache as well, the CCoinsViewCache::BatchWrite implementation is used.
<sipa>
*its
jonatack has joined #bitcoin-core-dev
<jamesob>
yep
brunoerg has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Ping timeout: 252 seconds]
tripleslash has joined #bitcoin-core-dev
<provoostenator>
And then who calls CCoinsViewDB::BatchWrite?
_andrewtoth_ has quit [Ping timeout: 255 seconds]
<sipa>
Same thing.
<sipa>
Typically the cache hierarchy is something like a CCoinsViewDB, and then two CCoinsViewCaches on top.
<sipa>
With some wrappers in between.
<achow101>
why 2?
brunoerg has joined #bitcoin-core-dev
<sipa>
To be able to undo changes in case block validation fails.
<provoostenator>
I very vaguely remember this...
<provoostenator>
But where is the recursion?
<sipa>
Both of the CCoinsViewCache objects can get Flush called.
<sipa>
The bottom one when block validation has failed, and we want to "commit" those changes to the permanent cache.
<sipa>
And the intermediary one when we want to push changes to disk.
<sipa>
Eh, has succeeded.
<sipa>
In case block validation fails, the bottom cache is just destroyed without flushing, thereby undoing the changes.
<provoostenator>
Ah, I guess one call site is CoinsTip().Flush() in validation.cpp at FlushStateToDisk(), but there's other Flush() calls too, and those involve different objects.
<sipa>
Exactly.
<provoostenator>
Anyone happens to have drawn this somewhere?
<sipa>
The one is FlushStateToDisk applies to the CCoinsViewCache that sits directly on top of CCoinsViewDB.
<sipa>
That's the huge one.
<sipa>
There are other places (block validation, at least) where temporary, small, CCoinsViewCache objects are created on top of the big CCoinsViewCache.
brunoerg has quit [Ping timeout: 252 seconds]
<provoostenator>
So in the case IBD doing its flushing when the cache gets too full and/or when there's a prune event, we're dealing with just one CCoinsViewCache on top of CCoinsViewDB and only CCoinsViewDB::BatchWrite is involved?
_andrewtoth_ has joined #bitcoin-core-dev
<sipa>
Indeed.
<sipa>
And CCoinsViewCache::BatchWrite is not invoked in that case.
brunoerg has joined #bitcoin-core-dev
<sipa>
So arguably, it may be possible to not support erase=false in CCoinsViewCache::BatchWrite, because it'll only get invoked when the smaller sub-cache gets flushed, and sync makes no sense there (I think).