brunoerg has joined #bitcoin-core-dev
halosghost has quit [Quit: WeeChat 3.8]
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Norrin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 252 seconds]
Norrin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
jeremyrubin has quit [Quit: Ping timeout (120 seconds)]
jeremyrubin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
FrancisMr has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
as2333 has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
theStack has quit [Quit: theStack]
theStack has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Norrin has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Norrin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
AmishNick has quit [Quit: Leaving]
as2333 has joined #bitcoin-core-dev
AmishBTC has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Norrin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
as2333 has quit [Remote host closed the connection]
Norrin has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 252 seconds]
as2333 has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] theStack opened pull request #26970: test: fix immediate tx relay in wallet_groups.py (master...202301-test-fix_wallet_groups_immediate_tx_relay) https://github.com/bitcoin/bitcoin/pull/26970
andrew_mo_ has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 252 seconds]
Norrin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Norrin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Read error: Connection reset by peer]
jarthur_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 260 seconds]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
Norrin has joined #bitcoin-core-dev
andrew_m_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
Norrin has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
Norrin has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
jarthur_ is now known as jarthur
FrancisMr has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
as2333 has quit [Quit: as2333]
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
Norrin has quit [Ping timeout: 255 seconds]
Norrin has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 248 seconds]
bitdex has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
cmirror has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 255 seconds]
cmirror has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
amishbtc_ has joined #bitcoin-core-dev
AmishBTC has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
bitdex has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
amishbtc_ has left #bitcoin-core-dev [#bitcoin-core-dev]
AmishBTC has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab98673f0588...d4c180ecc9ae
<bitcoin-git> bitcoin/master fab9582 MarcoFalke: refactor: Remove c_str from util/check
<bitcoin-git> bitcoin/master d4c180e MarcoFalke: Merge bitcoin/bitcoin#26960: refactor: Remove c_str from util/check
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26960: refactor: Remove c_str from util/check (master...2301-c-str-🔋) https://github.com/bitcoin/bitcoin/pull/26960
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
szkl has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
Guyver2 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
raj has joined #bitcoin-core-dev
raj is now known as Guest5245
raj21 has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
sudoforge has quit [Quit: 404]
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
jarthur has quit [Quit: jarthur]
andrew_mo_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Guest5 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
metallicc has quit [Ping timeout: 260 seconds]
Guest5 has quit [Client Quit]
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
AaronvanW has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
gwillen has quit [Ping timeout: 246 seconds]
gwillen has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
FrancisMr has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
ZeroMaster has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Norrin has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] glozow pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d4c180ecc9ae...77a36033b5ec
<bitcoin-git> bitcoin/master a4fe099 Anthony Towns: txorphanage: index workset by originating peer
<bitcoin-git> bitcoin/master be23046 Anthony Towns: txorphange: Drop redundant originator arg from GetTxToReconsider
<bitcoin-git> bitcoin/master c583775 Anthony Towns: net_processing: only process orphans before messages
<bitcoin-git> [bitcoin] glozow merged pull request #26551: p2p: Track orphans by who provided them (master...202211-orphanguardians) https://github.com/bitcoin/bitcoin/pull/26551
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
___nick___ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 264 seconds]
AaronvanW has joined #bitcoin-core-dev
metallicc has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
FrancisMr has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
Norrin has quit [Remote host closed the connection]
PaperSword has quit [Quit: PaperSword]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/77a36033b5ec...79e007d1d60b
<bitcoin-git> bitcoin/master fa9becf MarcoFalke: streams: Add DataStream without ser-type and ser-version
<bitcoin-git> bitcoin/master fa29e73 MarcoFalke: Use DataStream where possible
<bitcoin-git> bitcoin/master fa035fe MarcoFalke: Remove unused CDataStream::SetType
brunoerg has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #25296: Add DataStream without ser-type and ser-version and use it where possible (master...2206-datastream-🎑) https://github.com/bitcoin/bitcoin/pull/25296
___nick___ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] stickies-v opened pull request #26974: refactor: rpc: set TxToJSON default verbosity to SHOW_DETAILS (master...txtojson-default-verbosity-details) https://github.com/bitcoin/bitcoin/pull/26974
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 248 seconds]
___nick___ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
josie_ is now known as info
info is now known as josie
___nick___ has quit [Ping timeout: 268 seconds]
___nick___ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #25261: rpc: fetch multiple headers in getblockheader() (master...rpc_getblockheader_count) https://github.com/bitcoin/bitcoin/pull/25261
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<phantomcircuit> so uh DescriptorScriptPubKeyMan::GetID() does a sha256 everytime it's called
<phantomcircuit> is it possible for the descriptor it's hashing to change?
<furszy> would say that if the ID changes, then it would no longer be an ID.
<achow101> phantomcircuit: no. we should probably cache it on startup
andrew_mo_ has quit [Ping timeout: 255 seconds]
<phantomcircuit> achow101: ok cause it's current about 10% of the cpu time for the fast wallet rescan im working on lol
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/79e007d1d60b...eee2c2898575
<bitcoin-git> bitcoin/master a66d82e fanquake: depends: systemtap 4.8
<bitcoin-git> bitcoin/master df7ae8b Cory Fields: depends: systemtap: remove variadic params that trigger compiler warnings
<bitcoin-git> bitcoin/master eee2c28 fanquake: Merge bitcoin/bitcoin#26945: depends: systemtap 4.8
<bitcoin-git> [bitcoin] fanquake merged pull request #26945: depends: systemtap 4.8 (master...systemtap_4_8) https://github.com/bitcoin/bitcoin/pull/26945
FrancisMr has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
FrancisMr has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
fjMSX has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<theStack> phantomcircuit: fwiw, an early version of 25957 used pointers instead of these IDs to reference to DescriptorPubKeyMans. but since GetID() is only called if a top-up happened in the previous block, the performance loss wasn't noticable
AaronvanW has quit [Remote host closed the connection]
<theStack> caching the ID on startup seems to be a good idea though
bugs_ has joined #bitcoin-core-dev
<phantomcircuit> theStack: there's something weird going on here so im working to get a better idea of what it is
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
jonatack has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<sipa> @phantomcircuit For the decode performance, I think a possibility would be to store the filter data in uint64_t's, and iterate over them one by one, and using shifts and __builtin_ctz on ~input to count consecutive 1 bits for the exponent.
<sipa> But it's also not worth spending too much time on optimizing the exponent decoding, as on average, every element should have only 1.05 such one bits.
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eee2c2898575...ffc22b7d42c6
<bitcoin-git> bitcoin/master 7aa4b32 Sebastian Falbesoner: test: refactor: simplify p2p_tx_download.py by using MiniWallet
<bitcoin-git> bitcoin/master ffc22b7 MarcoFalke: Merge bitcoin/bitcoin#26923: test: refactor: simplify p2p_{tx_download,evi...
<bitcoin-git> bitcoin/master 8609f24 Sebastian Falbesoner: test: refactor: simplify p2p_eviction.py by using MiniWallet
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26923: test: refactor: simplify p2p_{tx_download,eviction}.py by using MiniWallet (master...202301-test-simplify_p2p_tx_download_MiniWallet) https://github.com/bitcoin/bitcoin/pull/26923
jonatack has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
halosghost has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
bitdex has quit [Quit: = ""]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Guyver2 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
Norrin has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
as2333 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dergoegge opened pull request #26975: [PoC] Structure aware fuzzing with libprotobuf-mutator (master...2023-01-lpm-poc) https://github.com/bitcoin/bitcoin/pull/26975
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
AaronvanW has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
jarthur has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
cotsuka has quit [Quit: Bye!]
cotsuka has joined #bitcoin-core-dev
Norrin has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Talkless has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 248 seconds]
Norrin has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
qxs has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
<achow101> #startmeeting
<core-meetingbot> Meeting started Thu Jan 26 19:00:30 2023 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<core-meetingbot> Available commands: action commands idea info link nick
<achow101> #bitcoin-core-dev Meeting: achow101 aj amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
<achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
<hebasto> hi
<brunoerg> hi
<jonatack> hi
kmartin has joined #bitcoin-core-dev
<fjahr> hi
<sipa> hi
<achow101> There are no preproposed meeting topics today. Does anyone have any last minute topics they would like to add?
<achow101> #topic High priority for review
<core-meetingbot> topic: High priority for review
<achow101> https://github.com/orgs/bitcoin/projects/1 anything to add/remove/merge?
<hebasto> may I have #26762 in hi-prio?
<gribble> https://github.com/bitcoin/bitcoin/issues/26762 | refactor: Make `CCheckQueue` RAII-styled by hebasto · Pull Request #26762 · bitcoin/bitcoin · GitHub
<achow101> hebasto: done
<hebasto> thanks!
<kanzure> hi
<jonatack> Could use more reviewers on hi-prio pulls #26837 and #25325
<gribble> https://github.com/bitcoin/bitcoin/issues/25325 | Add pool based memory resource by martinus · Pull Request #25325 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/26837 | I2P network optimizations by vasild · Pull Request #26837 · bitcoin/bitcoin · GitHub
andrew_mo_ has quit [Ping timeout: 252 seconds]
<achow101> anything else to discuss this week?
<Murch1> No
<achow101> #endmeeting
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<core-meetingbot> Meeting ended Thu Jan 26 19:07:56 2023 UTC.
<Murch1> lol, achow101
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 256 seconds]
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 246 seconds]
AaronvanW has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
MrFrancis has joined #bitcoin-core-dev
kmartin has quit [Ping timeout: 260 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
MrFrancis has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
<jamesob> late hi
<sipa> jamesob: have you been living under a vault?
salvatoshi has joined #bitcoin-core-dev
<jamesob> sipa: I was stuck in the withdrawal timelock
<jamesob> question for the mempool afficianados: under the current thinking, will package relay/EAs facilitate a packaged relay of multiple unconfirmed parents, each of which has an EA, with a common child providing fees by consuming all the EAs?
<jamesob> cc glozow instagibbs sdaftuar ^
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
Norrin has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
Norrin has joined #bitcoin-core-dev
<jamesob> sipa: have you thought at all about how post-CScriptCheck() transaction validation might work? Like say, for example, if you wanted to accumulate some information about each vin's script during CScriptCheck() and then use that to do some general validation on the outputs of the transaction. I think something like that might be necessary for
<jamesob> cross-input sig. agg., and there may be a use in vaults too...
<sipa> batch validation will need that too
<sipa> my idea would be that there is first a phase of per-script validation, using the existing mechanism, just as it is today
<sipa> but instead of just returning true/false, they'd return more complex data structures that get accumulated in per-thread, and then a global structure
<jamesob> yep... and then I think _either_ you could do synchronized writes into some shared data structure outside of the script check pool _or_ you could have each cscriptcheck return some data
<sipa> and then a second phase runs whatever is necessary on the global structure
<sipa> for batch validation, that'd be an unordered list of (sighash, pubkey, sig) tuples.
<jamesob> sounds good to me... any code written as far as you know?
<sipa> i don't think the implementation is very hard, but i haven't tried
<jamesob> yeah agreed
brunoerg has joined #bitcoin-core-dev
<jamesob> I'm inclined to try... any good reason not to?
<sipa> well we don't even have batch validation implementation at the signature level
<jamesob> yeah, but it might let me do combined vault operations across vaults even without compatible parameters... the value there being that I wouldn't have to hardcode "vout[0] is always the main value output"
<sipa> in your proposed code you can do whatever you want of course
<jamesob> sure, I just don't want to expand the scope wildly or tread on toes if there was already code underway
<sipa> right, sure
<jamesob> such a change isn't a change to consensus, but it does seem like a pretty profound shift in the execution model
<sipa> do make sure the script verification threads don't need locking when adding their post-script-validation data in accumulators; i'd expect that you'd get a serious performance penalty otherwise
<sipa> right, exactly
<jamesob> right
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [gui] john-moffett opened pull request #704: Correctly limit overview transaction list (master...2023_01_FixOverviewTxList) https://github.com/bitcoin-core/gui/pull/704
jonatack has quit [Ping timeout: 248 seconds]
<glozow> jamesob: unfortunately there is no batching with v3 at the moment (1 parent 1 child only)
<jamesob> glozow: so not even a single EA-based bump?
<jamesob> oh nevermind, that fits into 1p1c...
<jamesob> glozow: what makes batching difficult? is there a canonical place where a discussion of this stuff lives? Is this the thread to follow? https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-May/020493.html
___nick___ has quit [Ping timeout: 248 seconds]
<glozow> 2 problems. (1) allowing multiple parents means an attacker can still "rule 3 pin" by adding a small but high-fee child spending from an additional large, low-feerate ancestor
<glozow> (2) if a child is fee-bumping n 0-fee parents and you replace that child without spending from any of the parents, you now have n dangling 0-fee transactions in the mempool. replacements can do 100 at a time, so 100*n maximum. It would be nice if 100*n is 100 rather than 2400 for example.
<glozow> all the discussion is on #25038 at the moment, I've mostly been posting "big" updates to the ML otherwise I feel like I'm spamming everyone
<gribble> https://github.com/bitcoin/bitcoin/issues/25038 | policy: nVersion=3 and Package RBF by glozow · Pull Request #25038 · bitcoin/bitcoin · GitHub
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<jamesob> glozow: cool, thanks
brunoerg has joined #bitcoin-core-dev
<glozow> i imagine EA could also work with a future v4 proposal that allows batching but has some other restrictions
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
baldur has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
Norrin has quit [Remote host closed the connection]
adiabat has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
Norrin has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 255 seconds]
ghost43_ has joined #bitcoin-core-dev
MrFrancis has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ghost43_ has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
Norrin has quit [Remote host closed the connection]
sudoforge has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
Norrin has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
MrFrancis has quit [Ping timeout: 256 seconds]