<MacroFake>
DrahtBot morning news: (1) There is a corecheck coverage feature in the summary comment. Please leave any feedback/suggestions with aureleoules
mudsip has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
<MacroFake>
(2) Reviewers will be selected from a broader pool, which may help to collect review and re-review faster. There shouldn't be any downside, because (like before) the review notification will only be sent when there is another non-bot notification sent in the thread already immediately prior.
jQrgen has quit [Ping timeout: 240 seconds]
<MacroFake>
The code is open source, so it is possible for anyone to report issues and propose improvements, see https://github.com/maflcko/DrahtBot
<bitcoin-git>
bitcoin/master f0cebbd fanquake: qt: enable -ltcg for windows HOST
<bitcoin-git>
bitcoin/master 634b68f fanquake: Merge bitcoin/bitcoin#28532: qt: enable` -ltcg` for windows under LTO
<bitcoin-git>
[bitcoin] fanquake merged pull request #28532: qt: enable` -ltcg` for windows under LTO (master...fix_windows_depends_qt_lto) https://github.com/bitcoin/bitcoin/pull/28532
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<vasild>
compiling with cmake using "Unix Makefiles" generator: 1m17s, using Ninja generator: 1m6s (cmake -G Ninja ...)
jQrgen has joined #bitcoin-core-dev
<hebasto>
I think, it is expected that ninja is quicker than GNU make, no?
<vasild>
yes, somebody told me that (you?) some time ago, I just now checked it for the first time myself and sharing here so people can use the faster one
brunoerg has joined #bitcoin-core-dev
brunoerg has quit []
johnzweng has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 245 seconds]
<earnestly>
vasild: Does the cmake gnumakefiles disable the internal suffix rules?
<earnestly>
(Or makefiles if it generates posix makefiles)
<earnestly>
hebasto: Not particularly, a lot of the old benchmarks don't disable the 50+ suffix rules so (g)make ends up calling stat() for non-existant files 50 times per potential file
<earnestly>
And when the synthetic benchmark is 10,000,000 files, that * 50 can get pretty slow
<earnestly>
cmake used to not disable those rules which gave people such an impression
<earnestly>
(ninja is better than make in other ways though)
<vasild>
Earnestly: I do not know. How do I check? What are the "internal suffix rules"?
jQrgen has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 240 seconds]
<sipa>
Earnestly: pretty sure the speed benefit has nothing to do with gnu make's computation cost, and just with better scheduling of the jobs
<sipa>
vasild: implicit rules that e.g. say a x.o can be created from x.c by invoking $CC -c
Guest17 has joined #bitcoin-core-dev
Guest17 has quit [Client Quit]
jQrgen has joined #bitcoin-core-dev
jburgers has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 246 seconds]
jQrgen has joined #bitcoin-core-dev
jburgers has quit [Quit: Konversation terminated!]
<earnestly>
sipa: I doubt that would make much difference, any cost at that level is completely subsummed by the time taken by the commands producing the targets. I've not seen benchmarks of this aspect though
jburgers has joined #bitcoin-core-dev
<earnestly>
vasild: gnu make has rules which will even look for files in a local RCS repo, check out the file, and then compile it, for example
<earnestly>
By default
jQrgen has quit [Ping timeout: 260 seconds]
jQrgen has joined #bitcoin-core-dev
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
jburgers has quit [Client Quit]
jburgers has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 258 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jburgers has quit [Client Quit]
jburgers has joined #bitcoin-core-dev
jQrgen has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 240 seconds]
Guyver2 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<Sjors[m]>
The first one is useful on its own. The combination makes -debug=validation a lot more useful imo.
jQrgen has quit [Ping timeout: 240 seconds]
preimage has joined #bitcoin-core-dev
test_ is now known as _flood
jQrgen has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 252 seconds]
AaronvanW has quit [Remote host closed the connection]
jQrgen has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
jQrgen has quit [Remote host closed the connection]
jQrgen has joined #bitcoin-core-dev
Guest99 has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
Guest99 has quit [Client Quit]
Guest99 has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 240 seconds]
Guest99 has quit [Client Quit]
mudsip has quit []
AaronvanW has joined #bitcoin-core-dev
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
<sdaftuar>
is there a way to disable fee estimation (and all its calculations) via command line flag? (not seeing one, but the way the code is laid out it seems like this was contemplated?)
bitdex has quit [Quit: = ""]
jarthur has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 258 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
benwestgate has quit [Quit: Leaving.]
mudsip has joined #bitcoin-core-dev
preimage has quit [Ping timeout: 272 seconds]
preimage has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
DarrylTheFiish has quit [Remote host closed the connection]
preimage has quit [Ping timeout: 264 seconds]
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
gribble` has quit [Ping timeout: 272 seconds]
kalle has quit [Ping timeout: 272 seconds]
kalle has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
lightningbot has quit [Remote host closed the connection]
lightningbot has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 272 seconds]
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #28609: wallet: Reload watchonly and solvables wallets after migration (master...reload-all-migrated) https://github.com/bitcoin/bitcoin/pull/28609
jQrgen has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #28610: wallet: Migrate entire address book entries to watchonly and solvables too (master...migrate-avoidreuse) https://github.com/bitcoin/bitcoin/pull/28610
brunoerg has quit [Ping timeout: 272 seconds]
jQrgen has quit [Ping timeout: 240 seconds]
justache is now known as justHaunting
brunoerg has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin is now known as pablomartin4btc
jburgers has quit [Quit: Konversation terminated!]
jburgers has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
<bitcoin-git>
[gui] theStack opened pull request #766: gui: fix coin control input size accounting for taproot spends (master...202310-gui-fix_input_size_estimation_for_taproot_spends) https://github.com/bitcoin-core/gui/pull/766
brunoerg has joined #bitcoin-core-dev
jburgers has quit [Quit: Konversation terminated!]