#bitcoin-core-dev on 2023-10-30 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:03 brunoerg has joined #bitcoin-core-dev

00:08 brunoerg has quit [Ping timeout: 258 seconds]

00:20 brunoerg has joined #bitcoin-core-dev

00:25 flooded has joined #bitcoin-core-dev

00:26 brunoerg has quit [Ping timeout: 264 seconds]

00:29 test__ has quit [Ping timeout: 264 seconds]

00:39 brunoerg has joined #bitcoin-core-dev

00:46 brunoerg has quit [Ping timeout: 246 seconds]

00:47 brunoerg has joined #bitcoin-core-dev

00:52 brunoerg has quit [Ping timeout: 240 seconds]

01:20 brunoerg has joined #bitcoin-core-dev

01:25 brunoerg has quit [Ping timeout: 240 seconds]

01:26 brunoerg has joined #bitcoin-core-dev

01:30 brunoerg has quit [Ping timeout: 246 seconds]

01:31 brunoerg has joined #bitcoin-core-dev

01:36 brunoerg has quit [Ping timeout: 240 seconds]

01:37 brunoerg has joined #bitcoin-core-dev

01:41 brunoerg has quit [Ping timeout: 246 seconds]

01:44 kanzure has quit [Quit: leaving]

01:45 kanzure has joined #bitcoin-core-dev

02:02 brunoerg has joined #bitcoin-core-dev

02:06 brunoerg has quit [Ping timeout: 255 seconds]

02:22 brunoerg has joined #bitcoin-core-dev

02:27 brunoerg has quit [Ping timeout: 272 seconds]

02:56 brunoerg has joined #bitcoin-core-dev

03:01 brunoerg has quit [Ping timeout: 240 seconds]

03:01 brunoerg has joined #bitcoin-core-dev

03:06 brunoerg has quit [Ping timeout: 246 seconds]

03:22 brunoerg has joined #bitcoin-core-dev

03:27 brunoerg has quit [Ping timeout: 264 seconds]

03:43 brunoerg has joined #bitcoin-core-dev

03:45 micha_ has quit [Quit: Connection closed for inactivity]

03:48 brunoerg has quit [Ping timeout: 260 seconds]

03:59 brunoerg has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:04 brunoerg has quit [Ping timeout: 245 seconds]

04:09 brunoerg has joined #bitcoin-core-dev

04:14 brunoerg has quit [Ping timeout: 240 seconds]

04:16 brunoerg has joined #bitcoin-core-dev

04:22 brunoerg has quit [Ping timeout: 246 seconds]

04:51 brunoerg has joined #bitcoin-core-dev

04:56 brunoerg has quit [Ping timeout: 264 seconds]

04:57 brunoerg has joined #bitcoin-core-dev

05:05 brunoerg has quit [Ping timeout: 240 seconds]

05:12 brunoerg has joined #bitcoin-core-dev

05:14 szkl has joined #bitcoin-core-dev

05:17 brunoerg has quit [Ping timeout: 240 seconds]

05:32 pablomartin has quit [Ping timeout: 264 seconds]

05:40 brunoerg has joined #bitcoin-core-dev

05:45 brunoerg has quit [Ping timeout: 258 seconds]

06:03 test__ has joined #bitcoin-core-dev

06:07 flooded has quit [Ping timeout: 255 seconds]

06:16 brunoerg has joined #bitcoin-core-dev

06:21 brunoerg has quit [Ping timeout: 258 seconds]

06:25 vysn has joined #bitcoin-core-dev

06:50 brunoerg has joined #bitcoin-core-dev

06:54 brunoerg has quit [Ping timeout: 272 seconds]

06:58 katsu_ has quit [Ping timeout: 272 seconds]

07:04 katsu_ has joined #bitcoin-core-dev

07:04 conman has quit [Quit: Konversation terminated!]

07:23 brunoerg has joined #bitcoin-core-dev

07:29 brunoerg has quit [Ping timeout: 264 seconds]

07:57 brunoerg has joined #bitcoin-core-dev

08:02 brunoerg has quit [Ping timeout: 255 seconds]

08:24 AaronvanW has joined #bitcoin-core-dev

08:30 brunoerg has joined #bitcoin-core-dev

08:35 brunoerg has quit [Ping timeout: 264 seconds]

08:39 Guyver2 has joined #bitcoin-core-dev

09:03 dberkelmans has joined #bitcoin-core-dev

09:07 brunoerg has joined #bitcoin-core-dev

09:12 brunoerg has quit [Ping timeout: 258 seconds]

09:31 abubakarsadiq has joined #bitcoin-core-dev

09:43 brunoerg has joined #bitcoin-core-dev

09:44 Chris_Stewart_5 has quit [Ping timeout: 272 seconds]

09:46 Chris_Stewart_5 has joined #bitcoin-core-dev

09:47 brunoerg has quit [Ping timeout: 246 seconds]

10:08 earnestly has quit [Ping timeout: 255 seconds]

10:09 earnestly has joined #bitcoin-core-dev

10:22 <bitcoin-git> [bitcoin] BrandonOdiwuor opened pull request #28753: [27.x] test: Remove feature_txindex_compatibility.py in V27 (master...remove_feature_txindex_compatibility_py) https://github.com/bitcoin/bitcoin/pull/28753

10:26 brunoerg has joined #bitcoin-core-dev

10:31 brunoerg has quit [Ping timeout: 260 seconds]

10:43 szkl has quit [Quit: Connection closed for inactivity]

10:46 vasild has quit [Quit: leaving]

11:00 dberkelmans has quit [Quit: Client closed]

11:01 brunoerg has joined #bitcoin-core-dev

11:05 brunoerg has quit [Ping timeout: 258 seconds]

11:07 kingjollie has joined #bitcoin-core-dev

11:15 kingjollie has quit [Quit: Client closed]

11:34 Jackielove4u has quit [Quit: Connection closed for inactivity]

11:35 brunoerg has joined #bitcoin-core-dev

11:39 brunoerg has quit [Ping timeout: 240 seconds]

11:41 flooded has joined #bitcoin-core-dev

11:45 test__ has quit [Ping timeout: 258 seconds]

11:48 ghost43 has quit [Remote host closed the connection]

11:51 ghost43 has joined #bitcoin-core-dev

12:00 brunoerg has joined #bitcoin-core-dev

12:05 brunoerg has quit [Ping timeout: 264 seconds]

12:11 Guest19 has joined #bitcoin-core-dev

12:25 Guest19 has quit [Quit: Client closed]

12:25 Guest91 has joined #bitcoin-core-dev

12:30 Guest91 has quit [Client Quit]

12:30 Guest67 has joined #bitcoin-core-dev

12:37 brunoerg has joined #bitcoin-core-dev

12:37 ghost43 has quit [Read error: Connection reset by peer]

12:39 ghost43 has joined #bitcoin-core-dev

12:39 Guest67 has quit [Quit: Client closed]

12:40 Guest96 has joined #bitcoin-core-dev

12:40 ghost43 has quit [Remote host closed the connection]

12:41 ghost43 has joined #bitcoin-core-dev

12:42 Guest96 has quit [Client Quit]

12:42 Guest96 has joined #bitcoin-core-dev

12:43 Guest96 has quit [Client Quit]

12:43 ghost43 has quit [Remote host closed the connection]

12:44 ghost43 has joined #bitcoin-core-dev

12:55 jonatack has quit [Read error: Connection reset by peer]

13:09 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/feae4e04389b...a3670b227333

13:09 <bitcoin-git> bitcoin/master 897d6dd Brandon Odiwuor: Remove feature_txindex_compatibility.py in V27

13:09 <bitcoin-git> bitcoin/master a3670b2 fanquake: Merge bitcoin/bitcoin#28753: test: Remove feature_txindex_compatibility.py

13:09 <bitcoin-git> [bitcoin] fanquake merged pull request #28753: test: Remove feature_txindex_compatibility.py (master...remove_feature_txindex_compatibility_py) https://github.com/bitcoin/bitcoin/pull/28753

13:21 jonatack has joined #bitcoin-core-dev

13:25 <bitcoin-git> [bitcoin] fanquake opened pull request #28754: [26.x] Backports for rc2 (26.x...backports_26_0_rc2) https://github.com/bitcoin/bitcoin/pull/28754

13:33 dberkelmans has joined #bitcoin-core-dev

13:44 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a3670b227333...ec5116ae14d9

13:44 <bitcoin-git> bitcoin/master cf70a8d dergoegge: [net] Check i2p private key constraints

13:44 <bitcoin-git> bitcoin/master 5cf4d26 Vasil Dimov: [test] Test i2p private key constraints

13:44 <bitcoin-git> bitcoin/master ec5116a fanquake: Merge bitcoin/bitcoin#28695: net: Sanity check private keys received from ...

13:44 <bitcoin-git> [bitcoin] fanquake merged pull request #28695: net: Sanity check private keys received from SAM proxy (master...2023-10-i2p-sanitize-priv) https://github.com/bitcoin/bitcoin/pull/28695

13:54 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec5116ae14d9...6391644b6607

13:54 <bitcoin-git> bitcoin/master faa769d MarcoFalke: Fix bugprone-lambda-function-name errors

13:54 <bitcoin-git> bitcoin/master 6391644 fanquake: Merge bitcoin/bitcoin#28737: doc: Fix bugprone-lambda-function-name errors

13:54 <bitcoin-git> [bitcoin] fanquake merged pull request #28737: doc: Fix bugprone-lambda-function-name errors (master...2310-bugprone-lambda-function-name-) https://github.com/bitcoin/bitcoin/pull/28737

13:54 pablomartin has joined #bitcoin-core-dev

14:02 vasild has joined #bitcoin-core-dev

14:09 Guyver2 has left #bitcoin-core-dev [Closing Window]

14:10 kevkevin has joined #bitcoin-core-dev

14:12 dberkelmans has quit [Quit: Client closed]

14:17 bitdex has quit [Ping timeout: 256 seconds]

14:40 preimage has joined #bitcoin-core-dev

14:43 kevkevin_ has joined #bitcoin-core-dev

14:46 kevkevin has quit [Ping timeout: 260 seconds]

14:55 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6391644b6607...7d6c646cc79e

14:55 <bitcoin-git> bitcoin/master faea58e MarcoFalke: Bump g++ minimum supported version to 10

14:55 <bitcoin-git> bitcoin/master fa918d3 MarcoFalke: Always enable -Wsuggest-override

14:55 <bitcoin-git> bitcoin/master fa5423b MarcoFalke: refactor: Remove unused gcc-9 workaround in txrequest

14:56 <bitcoin-git> [bitcoin] fanquake merged pull request #28348: build: Bump g++ minimum supported version to 10 (master...2308-g++-10-) https://github.com/bitcoin/bitcoin/pull/28348

15:00 brunoerg has quit [Remote host closed the connection]

15:00 <bitcoin-git> [bitcoin] fanquake opened pull request #28755: build: remove duplicate `-lminiupnpc` linking (master...remove_duplicate_linking) https://github.com/bitcoin/bitcoin/pull/28755

15:03 brunoerg has joined #bitcoin-core-dev

15:05 Jackielove4u has joined #bitcoin-core-dev

15:07 brunoerg has quit [Remote host closed the connection]

15:12 brunoerg has joined #bitcoin-core-dev

15:12 kevkevin_ has quit [Read error: Connection reset by peer]

15:12 kevkevin has joined #bitcoin-core-dev

15:17 brunoerg has quit [Ping timeout: 240 seconds]

15:18 brunoerg has joined #bitcoin-core-dev

15:23 brunoerg has quit [Ping timeout: 258 seconds]

15:27 kevkevin_ has joined #bitcoin-core-dev

15:27 bugs_ has joined #bitcoin-core-dev

15:29 kevkevin has quit [Ping timeout: 258 seconds]

15:41 vasild has quit [Remote host closed the connection]

15:41 vasild has joined #bitcoin-core-dev

15:47 kevkevin has joined #bitcoin-core-dev

15:50 kevkevin_ has quit [Ping timeout: 248 seconds]

15:51 brunoerg has joined #bitcoin-core-dev

15:54 rolf has quit [Quit: WeeChat 4.1.0]

15:56 brunoerg has quit [Ping timeout: 264 seconds]

15:59 kevkevin_ has joined #bitcoin-core-dev

16:02 kevkevin has quit [Ping timeout: 248 seconds]

16:09 Vinny has joined #bitcoin-core-dev

16:09 Vinny has quit [K-Lined]

16:26 brunoerg has joined #bitcoin-core-dev

16:31 brunoerg has quit [Ping timeout: 255 seconds]

16:36 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d6c646cc79e...4458ae811a26

16:36 <bitcoin-git> bitcoin/master fa56067 MarcoFalke: refactor: Fix bugprone-string-constructor warning

16:36 <bitcoin-git> bitcoin/master 4458ae8 fanquake: Merge bitcoin/bitcoin#28741: refactor: Fix bugprone-string-constructor war...

16:36 <bitcoin-git> [bitcoin] fanquake merged pull request #28741: refactor: Fix bugprone-string-constructor warning (master...2310-bugprone-string-constructor-) https://github.com/bitcoin/bitcoin/pull/28741

16:42 brunoerg has joined #bitcoin-core-dev

16:49 qxs has joined #bitcoin-core-dev

16:58 qxs has quit [Remote host closed the connection]

17:03 qxs has joined #bitcoin-core-dev

17:04 qxs has quit [Remote host closed the connection]

17:05 qxs has joined #bitcoin-core-dev

17:19 test__ has joined #bitcoin-core-dev

17:23 flooded has quit [Ping timeout: 240 seconds]

17:40 jonatack has quit [Ping timeout: 245 seconds]

17:43 jonatack has joined #bitcoin-core-dev

17:49 jonatack has quit [Remote host closed the connection]

18:03 jonatack has joined #bitcoin-core-dev

18:18 Talkless has joined #bitcoin-core-dev

18:30 <bitcoin-git> [bitcoin] achow101 opened pull request #28757: guix: Zip needs the recursive flag (master...macos-zip-recursive) https://github.com/bitcoin/bitcoin/pull/28757

18:47 qxs has quit [Ping timeout: 256 seconds]

18:50 bomb-on_ has quit [Read error: Connection reset by peer]

19:03 qxs has joined #bitcoin-core-dev

19:05 justache is now known as justHaunted

20:03 Talkless has quit [Quit: Konversation terminated!]

20:29 brunoerg has quit [Remote host closed the connection]

20:39 <bitcoin-git> [bitcoin] jonatack closed pull request #28749: test: add peer connection unit test coverage (master...2023-10-net_peer_connection_tests) https://github.com/bitcoin/bitcoin/pull/28749

20:39 <jonatack> Closing as the unit tests were pulled into #28155

20:40 <gribble> https://github.com/bitcoin/bitcoin/issues/28155 | net: improves addnode / m_added_nodes logic by sr-gi · Pull Request #28155 · bitcoin/bitcoin · GitHub

20:44 brunoerg has joined #bitcoin-core-dev

20:47 <jonatack> The first 2 commits of that pull (PR28155) might be worth backporting.

20:49 henmeh has joined #bitcoin-core-dev

20:49 henmeh has quit [Client Quit]

21:18 mudsip has joined #bitcoin-core-dev

21:20 mudsip has quit [Client Quit]

21:20 <bitcoin-git> [gui] theStack opened pull request #774: gui: fix crash on selecting "Mask values" in transaction view (master...202310-gui-fix_mask_values_crash_in_transaction_view) https://github.com/bitcoin-core/gui/pull/774

21:36 kevkevin has joined #bitcoin-core-dev

21:39 kevkevin_ has quit [Ping timeout: 248 seconds]

21:50 vysn has quit [Remote host closed the connection]

21:50 brunoerg has quit [Remote host closed the connection]

21:56 brunoerg has joined #bitcoin-core-dev

22:00 brunoerg has quit [Ping timeout: 264 seconds]

22:06 preimage has quit [Quit: WeeChat 4.1.0]

22:07 bugs_ has quit [Quit: Leaving]

22:33 AaronvanW has quit [Quit: Leaving...]

22:40 vasild has quit [Remote host closed the connection]

22:45 vasild has joined #bitcoin-core-dev

22:46 vasild has quit [Remote host closed the connection]

22:50 vasild has joined #bitcoin-core-dev

22:57 flooded has joined #bitcoin-core-dev

22:58 brunoerg has joined #bitcoin-core-dev

23:01 test__ has quit [Ping timeout: 248 seconds]

23:03 brunoerg has quit [Ping timeout: 258 seconds]

23:14 bcdarc_ has joined #bitcoin-core-dev

23:14 shiza has quit [Read error: Connection reset by peer]

23:14 bcdarc has quit [Read error: Connection reset by peer]

23:14 puchka has quit [Ping timeout: 264 seconds]

23:16 GoldmanSats___ has joined #bitcoin-core-dev

23:16 sanket1729_ has joined #bitcoin-core-dev

23:16 jonasschnelli_ has joined #bitcoin-core-dev

23:16 admin2 has joined #bitcoin-core-dev

23:16 bw___ has joined #bitcoin-core-dev

23:16 puchka1101 has joined #bitcoin-core-dev

23:18 brunoerg has joined #bitcoin-core-dev