#bitcoin-core-dev on 2023-10-12 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:38 brunoerg has joined #bitcoin-core-dev

00:41 abubakarsadiq has quit [Quit: Connection closed for inactivity]

00:43 brunoerg has quit [Ping timeout: 272 seconds]

00:59 brunoerg has joined #bitcoin-core-dev

01:00 delicateglitter4 has quit [Remote host closed the connection]

01:01 benwestgate has quit [Quit: Leaving.]

01:03 brunoerg has quit [Ping timeout: 240 seconds]

01:14 jQrgen_ has joined #bitcoin-core-dev

01:19 jQrgen_ has quit [Ping timeout: 240 seconds]

01:39 jQrgen_ has joined #bitcoin-core-dev

01:43 jQrgen_ has quit [Ping timeout: 240 seconds]

01:54 brunoerg has joined #bitcoin-core-dev

01:59 brunoerg has quit [Ping timeout: 264 seconds]

02:06 qxs has quit [Ping timeout: 252 seconds]

02:09 qxs has joined #bitcoin-core-dev

02:14 brunoerg has joined #bitcoin-core-dev

02:15 PaperSword has joined #bitcoin-core-dev

02:19 brunoerg has quit [Ping timeout: 248 seconds]

02:30 brunoerg has joined #bitcoin-core-dev

02:30 Guest52 has joined #bitcoin-core-dev

02:31 Guest52 has quit [Client Quit]

02:31 bitdex has joined #bitcoin-core-dev

02:32 brunoerg has quit [Remote host closed the connection]

02:33 Guest23 has joined #bitcoin-core-dev

02:39 brunoerg has joined #bitcoin-core-dev

02:41 Guest52 has joined #bitcoin-core-dev

02:44 brunoerg has quit [Ping timeout: 260 seconds]

02:53 Guest26 has joined #bitcoin-core-dev

02:54 Guest26 has quit [Client Quit]

03:09 vasild_ has joined #bitcoin-core-dev

03:10 PaperSword has quit [Quit: PaperSword]

03:10 Guest23 has quit [Ping timeout: 245 seconds]

03:11 jarthur has quit [Quit: jarthur]

03:11 vasild has quit [Ping timeout: 252 seconds]

03:13 test__ has joined #bitcoin-core-dev

03:14 test_ has quit [Remote host closed the connection]

03:16 brunoerg has joined #bitcoin-core-dev

03:21 brunoerg has quit [Ping timeout: 240 seconds]

03:24 PaperSword has joined #bitcoin-core-dev

03:25 TallTim_ has joined #bitcoin-core-dev

03:27 TallTim has quit [Ping timeout: 258 seconds]

03:28 TallTim_ has quit [Client Quit]

04:01 cmirror has quit [Remote host closed the connection]

04:02 cmirror has joined #bitcoin-core-dev

04:13 jQrgen_ has joined #bitcoin-core-dev

04:18 jQrgen_ has quit [Ping timeout: 255 seconds]

04:38 MrPaz has quit [Read error: Connection reset by peer]

05:55 Guest42 has joined #bitcoin-core-dev

05:55 Guest42 has quit [Client Quit]

07:01 jQrgen_ has joined #bitcoin-core-dev

07:06 jQrgen_ has quit [Ping timeout: 272 seconds]

07:13 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3eb3aae3026...ccf7895e179f

07:14 <bitcoin-git> bitcoin/master 78d3062 Hennadii Stepanov: ci: Install Android API 31 platform as Qt expects

07:14 <bitcoin-git> bitcoin/master ccf7895 fanquake: Merge bitcoin/bitcoin#28633: ci: Install Qt's default Android API platform

07:14 <bitcoin-git> [bitcoin] fanquake merged pull request #28633: ci: Install Qt's default Android API platform (master...231010-android) https://github.com/bitcoin/bitcoin/pull/28633

07:30 abubakarsadiq has joined #bitcoin-core-dev

07:35 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ccf7895e179f...4a5aae933078

07:35 <bitcoin-git> bitcoin/master 3bb51c2 Sebastian Falbesoner: test: BIP324: add check for missing garbage terminator detection

07:35 <bitcoin-git> bitcoin/master 4a5aae9 fanquake: Merge bitcoin/bitcoin#28634: test: BIP324: add check for detection of miss...

07:35 <bitcoin-git> [bitcoin] fanquake merged pull request #28634: test: BIP324: add check for detection of missing garbage terminator (master...202310-test-bip324-check_for_missing_garbage_terminator) https://github.com/bitcoin/bitcoin/pull/28634

07:37 cotsuka_ has joined #bitcoin-core-dev

07:37 cotsuka has quit [Remote host closed the connection]

07:38 luke-jr has quit [Remote host closed the connection]

07:38 luke-jr has joined #bitcoin-core-dev

07:42 cotsuka_ is now known as cotsuka

07:59 Guyver2 has joined #bitcoin-core-dev

07:59 vasild_ has quit [Quit: leaving]

07:59 vasild has joined #bitcoin-core-dev

08:01 jQrgen_ has joined #bitcoin-core-dev

08:06 jQrgen_ has quit [Ping timeout: 258 seconds]

08:54 jQrgen_ has joined #bitcoin-core-dev

08:59 jQrgen_ has quit [Ping timeout: 255 seconds]

09:00 jonatack has quit [Read error: Connection reset by peer]

09:01 jonatack has joined #bitcoin-core-dev

09:09 PaperSword has quit [Quit: PaperSword]

09:16 <bitcoin-git> [bitcoin] maflcko opened pull request #28639: refactor: Remove unused nchaintx from SnapshotMetadata constructor, fix test, add test (master...2310-au-test-) https://github.com/bitcoin/bitcoin/pull/28639

09:20 Guest23 has joined #bitcoin-core-dev

09:22 mudsip has joined #bitcoin-core-dev

09:22 mudsip has quit [Client Quit]

09:22 Guest23 has left #bitcoin-core-dev [#bitcoin-core-dev]

09:23 Guest54fewfwefwe has joined #bitcoin-core-dev

09:23 Guest54fewfwefwe has quit [Client Quit]

09:46 Guest52 has quit [Quit: Client closed]

09:51 puchka has quit [Ping timeout: 240 seconds]

09:53 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a5aae933078...a927d5cabefb

09:53 <bitcoin-git> bitcoin/master 850670e Sjors Provoost: test: don't run old binaries under valgrind

09:53 <bitcoin-git> bitcoin/master a927d5c fanquake: Merge bitcoin/bitcoin#27228: test: exempt previous release binaries from v...

09:53 <bitcoin-git> [bitcoin] fanquake merged pull request #27228: test: exempt previous release binaries from valgrind (master...2023/03/valgrind_prev_release) https://github.com/bitcoin/bitcoin/pull/27228

09:56 <bitcoin-git> [bitcoin] maflcko opened pull request #28640: ci: Bump asan (master...2310-ci-asan-) https://github.com/bitcoin/bitcoin/pull/28640

09:56 puchka has joined #bitcoin-core-dev

09:56 Guest64 has joined #bitcoin-core-dev

09:57 Guest64 has quit [Client Quit]

10:00 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a927d5cabefb...06d469c26b55

10:00 <bitcoin-git> bitcoin/master 4077e43 willcl-ark: test: fix usdt undeclared function errors on mantis

10:00 <bitcoin-git> bitcoin/master 06d469c fanquake: Merge bitcoin/bitcoin#28629: test: fix usdt undeclared function errors on ...

10:00 <bitcoin-git> [bitcoin] fanquake merged pull request #28629: test: fix usdt undeclared function errors on mantis (master...mantis-usdt-fix) https://github.com/bitcoin/bitcoin/pull/28629

10:05 <bitcoin-git> [bitcoin] hebasto opened pull request #28641: ci: Drop no longer needed `NOLINTNEXTLINE` (master...231012-nolint) https://github.com/bitcoin/bitcoin/pull/28641

10:06 jQrgen has joined #bitcoin-core-dev

10:10 jQrgen has quit [Ping timeout: 248 seconds]

10:46 Guyver2 has left #bitcoin-core-dev [Closing Window]

10:47 bitdex has quit [Quit: = ""]

11:10 brunoerg has joined #bitcoin-core-dev

11:34 pablomartin has joined #bitcoin-core-dev

11:38 mudsip has joined #bitcoin-core-dev

11:55 benwestgate has joined #bitcoin-core-dev

11:57 vasild has quit [Remote host closed the connection]

11:57 jQrgen_ has joined #bitcoin-core-dev

11:57 vasild has joined #bitcoin-core-dev

12:02 jQrgen_ has quit [Ping timeout: 240 seconds]

12:04 mudsip has quit []

12:05 jQrgen_ has joined #bitcoin-core-dev

12:05 brunoerg has quit [Remote host closed the connection]

12:16 brunoerg has joined #bitcoin-core-dev

12:35 puchka has quit [Ping timeout: 255 seconds]

12:53 pablomartin has quit [Ping timeout: 252 seconds]

12:58 jonatack has quit [Read error: Connection reset by peer]

12:58 jon_atack has joined #bitcoin-core-dev

13:11 ppisati has quit [Remote host closed the connection]

13:20 DarrylTheFiish has joined #bitcoin-core-dev

13:20 johnzweng has quit [Quit: Leaving...]

13:21 johnzweng has joined #bitcoin-core-dev

13:22 DarrylTheFiiish has quit [Ping timeout: 255 seconds]

14:00 <achow101> #startmeeting

14:00 <stickies-v> hi

14:00 <luke-jr> hi

14:00 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild

14:00 <pinheadmz> yo

14:00 <brunoerg> hi

14:00 <Sjors[m]> hi

14:00 <dergoegge> hi

14:00 <furszy> hi

14:00 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?

14:00 <hebasto> hi

14:01 guest-127 has joined #bitcoin-core-dev

14:01 <sipa> hi

14:01 <lightlike> Hi

14:01 <willcl-ark> hi

14:02 AmishBTC has joined #bitcoin-core-dev

14:02 <achow101> Since we're in feature freeze for 26.0, we won't be going through the priority project updates as we are now voting on the next set of priority projects

14:02 <achow101> you can leave your vote at #28642

14:02 <gribble> https://github.com/bitcoin/bitcoin/issues/28642 | Voting on Priority Projects for 27.0 · Issue #28642 · bitcoin/bitcoin · GitHub

14:02 <glozow> hi

14:02 <achow101> #topic Ad-hoc high priority for review

14:03 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4

14:03 <abubakarsadiq> hi

14:03 <stickies-v> to be clear - there is no importance to the order of the votes, right?

14:04 <achow101> stickies-v: that's correct

14:05 <sdaftuar> oh hi

14:05 <achow101> #topic 26.0

14:06 puchka has joined #bitcoin-core-dev

14:06 <achow101> also wanted to remind everyone that there's still a bunch of stuff in the 26.0 milestone: https://github.com/bitcoin/bitcoin/milestone/60

14:06 <achow101> most of these seem to be bug fixes, although I wonder if #28608 should be there since it's still a draft?

14:06 <gribble> https://github.com/bitcoin/bitcoin/issues/28608 | assumeutxo state and locking cleanup by ryanofsky · Pull Request #28608 · bitcoin/bitcoin · GitHub

14:06 <hebasto> and https://github.com/bitcoin-core/gui/milestone/11

14:07 <ryanofsky> it should not be there

14:07 <achow101> ryanofsky: ok, dropped it

14:08 <achow101> otherwise, does anyone have anything they want to discuss?

14:10 <achow101> #endmeeting

14:12 <bitcoin-git> [bitcoin] hebasto opened pull request #28643: ci: Add missing CI_RETRY_EXE before git clone (master...231012-retry) https://github.com/bitcoin/bitcoin/pull/28643

14:14 bugs_ has joined #bitcoin-core-dev

14:29 <vasild> hi

14:29 <vasild> I think it would be good to have #28077 and #27071 in 26.0

14:29 <gribble> https://github.com/bitcoin/bitcoin/issues/28077 | I2P: also sleep after errors in Accept() & destroy the session if we get an unexpected error by vasild · Pull Request #28077 · bitcoin/bitcoin · GitHub

14:29 <gribble> https://github.com/bitcoin/bitcoin/issues/27071 | Handle CJDNS from LookupSubNet() by vasild · Pull Request #27071 · bitcoin/bitcoin · GitHub

14:32 <TheCharlatan> hi

14:34 guest-127 has quit [Quit: Client closed]

14:39 <darosior> cmake is happening whether it's in the list or not isn't it?

14:41 <dergoegge> yes

14:43 guest-127 has joined #bitcoin-core-dev

14:43 AmishBTC has quit [Quit: Leaving]

14:50 <bitcoin-git> [bitcoin] pinheadmz closed pull request #27216: wallet: Add wallet method to detect if a key is "active" (master...used-addr-ui) https://github.com/bitcoin/bitcoin/pull/27216

14:51 <bitcoin-git> [gui] pinheadmz closed pull request #723: Add warnings for non-active addresses in receive tab and address book (master...used-addr-ui-gui) https://github.com/bitcoin-core/gui/pull/723

14:51 <pinheadmz> oh bitcoin-git bot is working on IRC again eh

14:52 <sipa> yeah, through BlueMatt's matrix bridge

14:53 vysn has joined #bitcoin-core-dev

14:54 <bitcoin-git> [bitcoin] maflcko opened pull request #28644: test: Fuzz merge with -use_value_profile=0 for now (master...2310-fuzz-less-value-) https://github.com/bitcoin/bitcoin/pull/28644

15:03 guest-127 has quit [Quit: Client closed]

15:04 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/06d469c26b55...bf8c41d251b3

15:04 <bitcoin-git> bitcoin/master 79789cc Hennadii Stepanov: ci: Drop no longer needed `NOLINTNEXTLINE`

15:04 <bitcoin-git> bitcoin/master bf8c41d fanquake: Merge bitcoin/bitcoin#28641: ci: Drop no longer needed `NOLINTNEXTLINE`

15:04 <bitcoin-git> [bitcoin] fanquake merged pull request #28641: ci: Drop no longer needed `NOLINTNEXTLINE` (master...231012-nolint) https://github.com/bitcoin/bitcoin/pull/28641

15:07 dviola has quit [Ping timeout: 255 seconds]

15:13 mudsip has joined #bitcoin-core-dev

15:13 mudsip has quit [Client Quit]

15:18 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bf8c41d251b3...5ea4fc05edde

15:18 <bitcoin-git> bitcoin/master fa2843e MarcoFalke: ci: Bump asan

15:18 <bitcoin-git> bitcoin/master 5ea4fc0 fanquake: Merge bitcoin/bitcoin#28640: ci: Use clang-17 in Asan task

15:18 <bitcoin-git> [bitcoin] fanquake merged pull request #28640: ci: Use clang-17 in Asan task (master...2310-ci-asan-) https://github.com/bitcoin/bitcoin/pull/28640

15:27 jonatack has joined #bitcoin-core-dev

15:27 jon_atack has quit [Read error: Connection reset by peer]

15:44 <jonatack> hi

15:45 <jonatack> I agree with vasild's above suggested additions to 26.0

15:45 <jonatack> and would suggest also adding #28248

15:45 <gribble> https://github.com/bitcoin/bitcoin/issues/28248 | p2p: peer connection bug fixes, logic and logging improvements by jonatack · Pull Request #28248 · bitcoin/bitcoin · GitHub

15:46 <jonatack> that has a half dozen p2p bugfixes

15:46 <jonatack> vasild: will re-review the 2 PRs you mentioned

15:46 <vasild> Thanks! :)

15:48 <jonatack> (thank you for your high quality and very helpful reviewing of the peer connection bug fixes!)

15:54 DarrylTheFiiish has joined #bitcoin-core-dev

15:57 DarrylTheFiish has quit [Ping timeout: 252 seconds]

15:57 <vasild> yw, it was on my todo for quite some time, sorry for the delay.

16:05 salvatoshi has joined #bitcoin-core-dev

16:10 Flow has quit [Ping timeout: 272 seconds]

16:18 mekster669493 has quit [Quit: Ping timeout (120 seconds)]

16:18 mekster669493 has joined #bitcoin-core-dev

16:19 ajonas__ has joined #bitcoin-core-dev

16:19 SpellChecker has quit [Quit: bye]

16:19 fanquake has quit [Read error: Connection reset by peer]

16:19 cncr04s has quit [Quit: See you real soon!]

16:19 fanquake has joined #bitcoin-core-dev

16:19 SpellChecker has joined #bitcoin-core-dev

16:20 BlueMatt has quit [Quit: Quit]

16:20 valwal has quit [Read error: Connection reset by peer]

16:20 Nebraskka has quit [Quit: Good day old chaps]

16:20 gleb has quit [Read error: Connection reset by peer]

16:20 gleb has joined #bitcoin-core-dev

16:20 valwal has joined #bitcoin-core-dev

16:20 BlueMatt has joined #bitcoin-core-dev

16:20 cncr04s has joined #bitcoin-core-dev

16:20 ajonas has quit [Ping timeout: 252 seconds]

16:20 ajonas__ is now known as ajonas

16:21 Nebraskka has joined #bitcoin-core-dev

16:21 aureleoules has quit [Ping timeout: 246 seconds]

16:21 JTL has quit [Ping timeout: 258 seconds]

16:26 JTL has joined #bitcoin-core-dev

16:32 Flow has joined #bitcoin-core-dev

16:34 aureleoules has joined #bitcoin-core-dev

16:44 <instagibbs> gleb maybe a bit longer OP describing the plan of attack on #28488 would help get some approach acks before too much digging into implementation

16:44 <gribble> https://github.com/bitcoin/bitcoin/issues/28488 | p2p: Evict outbound peers with high minFeeRate by naumenkogs · Pull Request #28488 · bitcoin/bitcoin · GitHub

16:52 DarrylTheFiiish has quit [Remote host closed the connection]

16:53 DarrylTheFiiish has joined #bitcoin-core-dev

17:16 jQrgen_ has quit [Remote host closed the connection]

17:20 ifuensan has joined #bitcoin-core-dev

17:24 jarthur has joined #bitcoin-core-dev

17:27 salvatoshi has quit [Ping timeout: 252 seconds]

17:28 salvatoshi has joined #bitcoin-core-dev

17:29 ifuensan23 has joined #bitcoin-core-dev

17:29 ifuensan23 has quit [Client Quit]

17:35 salvatoshi has quit [Ping timeout: 245 seconds]

17:58 ifuensan has quit [Quit: Client closed]

18:00 ibiko1 has joined #bitcoin-core-dev

18:03 Talkless has joined #bitcoin-core-dev

18:14 diego has joined #bitcoin-core-dev

18:14 diego is now known as Guest3264

18:15 test_ has joined #bitcoin-core-dev

18:19 test__ has quit [Ping timeout: 260 seconds]

18:58 ghost43 has quit [Remote host closed the connection]

18:58 ghost43 has joined #bitcoin-core-dev

19:04 mudsip has joined #bitcoin-core-dev

19:05 mudsip has quit [Client Quit]

19:12 Guest3264 has left #bitcoin-core-dev [#bitcoin-core-dev]

19:13 dviola has joined #bitcoin-core-dev

19:17 jQrgen_ has joined #bitcoin-core-dev

19:19 Talkless has quit [Quit: Konversation terminated!]

19:21 jQrgen_ has quit [Ping timeout: 240 seconds]

19:23 Guest66 has joined #bitcoin-core-dev

19:24 Guest66 has quit [Client Quit]

19:32 Guest11 has joined #bitcoin-core-dev

19:34 Guest11 has quit [Client Quit]

19:59 ibiko1 has quit [Remote host closed the connection]

20:08 ibiko1 has joined #bitcoin-core-dev

20:12 ibiko1 has quit [Ping timeout: 252 seconds]

20:18 jQrgen has joined #bitcoin-core-dev

20:20 ___nick___ has joined #bitcoin-core-dev

20:23 jQrgen has quit [Ping timeout: 252 seconds]

20:35 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

20:50 puchka has quit [Ping timeout: 264 seconds]

21:08 AaronvanW has joined #bitcoin-core-dev

21:18 SpellChecker has quit [Quit: bye]

21:18 lightningbot has quit [Remote host closed the connection]

21:18 lightningbot has joined #bitcoin-core-dev

21:18 SpellChecker has joined #bitcoin-core-dev

21:19 jQrgen has joined #bitcoin-core-dev

21:23 jQrgen has quit [Ping timeout: 258 seconds]

21:34 brunoerg has quit []

21:40 luke-jr has quit [Ping timeout: 260 seconds]

21:51 jQrgen has joined #bitcoin-core-dev

21:56 jQrgen has quit [Ping timeout: 264 seconds]

22:17 DarrylTheFiish has joined #bitcoin-core-dev

22:19 DarrylTheFiiish has quit [Ping timeout: 258 seconds]

22:20 abubakarsadiq has quit [Quit: Connection closed for inactivity]

22:25 jQrgen has joined #bitcoin-core-dev

22:29 jQrgen has quit [Ping timeout: 255 seconds]

22:33 bugs_ has quit [Quit: Leaving]

22:36 jQrgen has joined #bitcoin-core-dev

22:40 jQrgen has quit [Ping timeout: 258 seconds]

22:51 vysn has quit [Remote host closed the connection]