velgin has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
jetpack has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] pablomartin4btc opened pull request #28670: assumeutxo, rpc: Improve EOF error when reading snapshot metadata in loadtxoutset (master...assumeutxo-improve-EOF-error-when-reading-snapshot-also-on-autofile) https://github.com/bitcoin/bitcoin/pull/28670
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
pablomartin4btc has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
mikehu44 has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
mikehu44 has quit [Ping timeout: 260 seconds]
mikehu44 has joined #bitcoin-core-dev
jQrgen has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
test_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
salvatoshi_ has joined #bitcoin-core-dev
salvatoshi has quit [Quit: Leaving]
salvatoshi_ has quit [Client Quit]
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
<vasild>
instagibbs: in my experience "no", but that does not mean much. I would put an assert(0) next to a line which I think is executed but reported as not
brunoerg has quit [Ping timeout: 252 seconds]
ibiko1 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ibiko1 has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
jQrgen has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 252 seconds]
dviola has quit [Quit: WeeChat 4.1.0]
brunoerg has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
<vasild>
What is the preferred way to hash a std::string for the purposes of std::unordered_set? If the set is directly from strings, then std::hash<std::string> is going to be used implicitly. But if the string is a member of a to-be-hashed object, then we have to do the hashing explicitly and std::hash is not used anywhere (in non-test code). I am asking wrt
someone235 has quit [Quit: Connection closed for inactivity]
<instagibbs>
itshappening
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Ping timeout: 240 seconds]
<sdaftuar>
\o/
<sdaftuar>
instagibbs: glozow: we should brainstorm what package validation ought to look like
<instagibbs>
yes
<instagibbs>
helpful to see a full implementation, to think ahead a bit for next steps
<instagibbs>
im hoping a bunch if reusable(except we do better with package rbf)
<sdaftuar>
The rbf implementation changed substantially from what i thought i had working back in April (that approach had several significant bugs). The new design is much better and I'm pretty happy with it, but figuring out how to extend it to package RBF will take some thought.
<sdaftuar>
Also, there is no notion of sibling eviction (eg in the event that a cluster size limit is hit) that is implemented here. My thought is that in adversarial scenarios, this is hopeless due to RBF pinning. And in non adversarial scenarios, this seems like fairly edge-case behavior that is not clearly worth optimizing for?
<sdaftuar>
I'm open to being convinced otherwise though
bboerst has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jQrgen_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
benwestgate has quit [Quit: Leaving.]
brunoerg has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
qxs has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
realies7 has joined #bitcoin-core-dev
realies has quit [Ping timeout: 255 seconds]
realies7 is now known as realies
vasild has joined #bitcoin-core-dev
bob_x1 has joined #bitcoin-core-dev
realies has quit [Quit: Ping timeout (120 seconds)]
realies has joined #bitcoin-core-dev
ibiko1 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
pablomartin4btc has quit [Ping timeout: 255 seconds]
realies has quit [Ping timeout: 255 seconds]
realies has joined #bitcoin-core-dev
bboerst has quit [Quit: Client closed]
<bitcoin-git>
[bitcoin] luke-jr opened pull request #28677: [25.x] descriptors: Disallow hybrid keys, and disallow uncompressed keys when inferring (25.x...descr_disallow_hybrid_and_uncompr_pubkeys-25.1) https://github.com/bitcoin/bitcoin/pull/28677
abubakarsadiq has quit [Quit: Connection closed for inactivity]
test_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 258 seconds]
<instagibbs>
sibling eviction aka package(cluster) limit pinning it's no worse than before, we can continue iterating on ideas to mitigate that in adversarial cases
ibiko1 has quit [Remote host closed the connection]
ibiko1 has joined #bitcoin-core-dev
realies8 has joined #bitcoin-core-dev
realies has quit [Ping timeout: 252 seconds]
realies8 is now known as realies
jQrgen has joined #bitcoin-core-dev
jQrgen has quit [Read error: Connection reset by peer]
AaronvanW has quit [Remote host closed the connection]
lattice has quit [Quit: WeeChat 4.1.0]
puchka has quit [Ping timeout: 255 seconds]
bugs_ has quit [Quit: Leaving]
ibiko1 has quit [Remote host closed the connection]
realies has quit [Quit: Ping timeout (120 seconds)]
realies has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] sipa opened pull request #28678: miniscript: convert non-critical asserts to Assumes (master...202310_miniscript_assume) https://github.com/bitcoin/bitcoin/pull/28678
brunoerg has joined #bitcoin-core-dev
DarrylTheFiish has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
AaronvanW has quit [Ping timeout: 255 seconds]
DarrylTheFish has quit [Ping timeout: 255 seconds]