ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
bitdex has joined #bitcoin-core-dev
paddingtonbear has quit [Quit: Client closed]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
<_aj_> sipa: hmm, which shards you make available would probably allow fingerprinting your node (so, if you run a tor node, you could identify what your ipv4 address is)... maybe that's okay if you only supply shards to incoming connections?
<sipa> _aj_: hmm, good point - or pick different shards for every network interface
<sipa> but that's perhaps too high a price
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
<_aj_> if it was 32 or 64 shares needed instead of 16, you'd need 12-14 or 24-30 peers instead of 6 or 7; could be okay
<_aj_> (assuming each peer offered 3 shards to inbounds)
brunoerg has quit [Ping timeout: 252 seconds]
<sipa> that's pretty high, i'd say?
<sipa> compared to the 8 regular outbound peers currently
<_aj_> they're more like block-relay-only connections though, since you're not doing tx relay while you're downloading an initial utxo set
<sipa> unless the specific utxoset checking hash structure we use commits to the FEC data directly, you must pretty have all these peers simultaneously, and download from them in lockstep to decode and verify chunks
brunoerg has joined #bitcoin-core-dev
<lightlike> is the idea that serving assumeutxo shards would be something all non-pruned nodes would do automatically? Or more of a configuration thing tied to a service flag, that is opt-in?
<_aj_> lightlike: s/non-pruned// even
<_aj_> lightlike: (maybe still opt-in, but in an "everyone should opt-in" way)
<sipa> i hope we can make it lightweight enough that the default can be on for all nodes
<_aj_> sipa: i guess i'd argue a downloading peer should connect to more peers even then, so that the load on any given sending peer is lower?
<sipa> and i guess these can be block-only (or utxo-only...?) connections, without all the txrelay overhead
<_aj_> utxo-only, then reconnect after you've setup the utxo set is i guess what i was thinking
brunoerg has quit [Ping timeout: 272 seconds]
<_aj_> random linux iso seems to jump straight to ~30 seeds
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
<sipa> ha
<sipa> i am now hoping that "random linux" is the name of some actual distro
<_aj_> have it manage your editor/desktop/window manager/browser/shell, and choose a different one every day
<_aj_> on first april, it restricts you to a freebsd vm
<sipa> or android
<_aj_> i was going for mind-expanding, not mind-flaying
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
mxz has quit [Quit: cya]
mxz has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
xzmeng has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
ibiko1 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
xzmeng has quit [Quit: Client closed]
qxs has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
ibiko1 has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Read error: Connection reset by peer]
qxs has quit [Remote host closed the connection]
bitdex has quit [Read error: Connection reset by peer]
ghost43 has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test__ has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 260 seconds]
test_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
flooded has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
test__ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
dougefish has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
Guyver2 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 240 seconds]
puchka has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
asoltys has quit [Ping timeout: 255 seconds]
ibiko1 has joined #bitcoin-core-dev
asoltys has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
ibiko1 has quit [Ping timeout: 240 seconds]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
greypw2546002161 has quit [Quit: I'll be back!]
greypw2546002161 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/77f0ceb7175d...fc1073bb450d
<bitcoin-git> bitcoin/master 1c2132d Hennadii Stepanov: Revert "ci: Upgrading pip version in macos environment"
<bitcoin-git> bitcoin/master b705bad Hennadii Stepanov: ci: Export `IN_GETOPT_BIN` on macOS
<bitcoin-git> bitcoin/master 6889a80 MarcoFalke: ci: Add missing CI_RETRY_EXE before git clone
<bitcoin-git> [bitcoin] fanquake merged pull request #28643: ci: Add missing CI_RETRY_EXE before git clone (master...231012-retry) https://github.com/bitcoin/bitcoin/pull/28643
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
narodnik has joined #bitcoin-core-dev
<narodnik> where can i find a list of DoS mitigations and p2p network attacks inside bitcoin core, or can someone point me where to look in the code?
<narodnik> for example scoring of connections based off traffic
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] TheCharlatan opened pull request #28690: build: Introduce internal kernel library (master...kernelInternalLib) https://github.com/bitcoin/bitcoin/pull/28690
brunoerg has quit [Ping timeout: 248 seconds]
puchka has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
dougefish has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
dougefish has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] maflcko opened pull request #28691: refactor: Remove CBlockFileInfo::SetNull (master...2310-LessSetNull-) https://github.com/bitcoin/bitcoin/pull/28691
dougefish has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
bitdex has quit [Quit: = ""]
dougefish has joined #bitcoin-core-dev
jQrgen has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
jQrgen_ has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
jamesob443688173 has joined #bitcoin-core-dev
jamesob has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
Guest97 has joined #bitcoin-core-dev
Guest97 has quit [Client Quit]
Guest97 has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
Guest54 has joined #bitcoin-core-dev
Guest54 has quit [Client Quit]
Guest97 has quit [Quit: Client closed]
I35827 has joined #bitcoin-core-dev
I35827 has quit [Client Quit]
<bitcoin-git> [bitcoin] dergoegge opened pull request #28692: fuzz: Delete i2p fuzz test (master...2023-10-fuzz-🗑️) https://github.com/bitcoin/bitcoin/pull/28692
<bitcoin-git> [bitcoin] hebasto opened pull request #28693: Include `config/bitcoin-config.h` explicitly in `util/trace.h` (master...231020-trace) https://github.com/bitcoin/bitcoin/pull/28693
brunoerg has joined #bitcoin-core-dev
<glozow> achow101: do I understand correctly that before we do #28037, we first want to fix #28609 and then #28546?
<gribble> https://github.com/bitcoin/bitcoin/issues/28037 | rpc: Drop migratewallet experimental warning by achow101 · Pull Request #28037 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28609 | wallet: Reload watchonly and solvables wallets after migration by achow101 · Pull Request #28609 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28546 | bugfix: watchonly wallets created after migration have incorrect height values by ryanofsky · Pull Request #28546 · bitcoin/bitcoin · GitHub
brunoerg has quit [Ping timeout: 245 seconds]
jQrgen has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fc1073bb450d...3c856e2fe86a
<bitcoin-git> bitcoin/master ec84f99 Fabian Jahr: log: Don't log cache rebalancing in absense of a snapshot chainstate
<bitcoin-git> bitcoin/master 3c856e2 fanquake: Merge bitcoin/bitcoin#28569: log: Don't log cache rebalancing in absense o...
<bitcoin-git> [bitcoin] fanquake merged pull request #28569: log: Don't log cache rebalancing in absense of a snapshot chainstate (master...2023-10-au-cache-log) https://github.com/bitcoin/bitcoin/pull/28569
jQrgen_ has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<achow101> glozow: yes
<glozow> achow101: ok thanks. And how much of the legacy wallet removal plan would need to be pushed back if the rpc isn't marked experimental in v26.0 (not that I'm suggesting it)?
bugs_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
boris has quit [Ping timeout: 272 seconds]
boris has joined #bitcoin-core-dev
boris has quit [Client Quit]
boris has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
<achow101> if it's still marked experimental in 26.0, the final removal would be pushed back at least 1 release
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3c856e2fe86a...abfc8c901df6
<bitcoin-git> bitcoin/master dd4dcbd dergoegge: [fuzz] Delete i2p target
<bitcoin-git> bitcoin/master abfc8c9 fanquake: Merge bitcoin/bitcoin#28692: fuzz: Delete i2p fuzz test
<bitcoin-git> [bitcoin] fanquake merged pull request #28692: fuzz: Delete i2p fuzz test (master...2023-10-fuzz-🗑️) https://github.com/bitcoin/bitcoin/pull/28692
<achow101> I mainly don't want to remove the legacy wallet and then tell people that the only way they can continue to use their wallet is to do this thing that we're saying is experimental
pablomartin is now known as pablomartin4btc
dougefish has quit [Remote host closed the connection]
dougefish has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<achow101> hmm, I guess it doesn't actually have to push anything back. we have final removal targeted for 28.0, not 27.0. For some reason I thought the plan was to get everything done for 27.0.
<glozow> Right, so you could still get most things for 27.0 - stop creating legacy, make things independent of bdb
dougefish has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 245 seconds]
dougefish has joined #bitcoin-core-dev
dougefish has quit [Remote host closed the connection]
mikehu44 has joined #bitcoin-core-dev
dougefish has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #28677: [25.x] descriptors: Disallow hybrid keys, and disallow uncompressed keys when inferring (25.x...descr_disallow_hybrid_and_uncompr_pubkeys-25.1) https://github.com/bitcoin/bitcoin/pull/28677
dougefish has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
jQrgen has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
jQrgen has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
dougefish has joined #bitcoin-core-dev
dougefish has quit [Client Quit]
jQrgen has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dergoegge opened pull request #28695: net: Sanitize private keys recevied from SAM proxy (master...2023-10-i2p-sanitize-priv) https://github.com/bitcoin/bitcoin/pull/28695
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] beawkiattisak opened pull request #28696: Example.c Optimize (master...optimize) https://github.com/bitcoin/bitcoin/pull/28696
<bitcoin-git> [bitcoin] maflcko closed pull request #28696: Example.c Optimize (master...optimize) https://github.com/bitcoin/bitcoin/pull/28696
jQrgen has joined #bitcoin-core-dev
jQrgen has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] maflcko opened pull request #28697: fuzz: Increase merge -rss_limit_mb (master...2310-fuzz-oom-) https://github.com/bitcoin/bitcoin/pull/28697
brunoerg has joined #bitcoin-core-dev
jQrgen has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
pablomartin4btc has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
jQrgen_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 246 seconds]
jQrgen_ has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 240 seconds]
Guest35 has joined #bitcoin-core-dev
Guest35 has quit [Client Quit]
jQrgen has joined #bitcoin-core-dev
jQrgen has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
jQrgen has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
Guest18 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guest18 has quit [Client Quit]
brunoerg has quit [Ping timeout: 258 seconds]
jQrgen has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
jQrgen has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
realies has quit [Read error: Connection reset by peer]
realies has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
jQrgen has quit [Remote host closed the connection]
jQrgen has joined #bitcoin-core-dev
realies has quit [Read error: Connection reset by peer]
pablomartin4btc has joined #bitcoin-core-dev
jQrgen has quit []
jonatack has quit [Ping timeout: 260 seconds]
ibiko1 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
ibiko1 has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
ibiko1 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/abfc8c901df6...c1106cfef514
<bitcoin-git> bitcoin/master 0a576d6 Fabian Jahr: test: check au file with changed outpoint index
<bitcoin-git> bitcoin/master d322368 Fabian Jahr: test: De-dublicate/optimize assumeutxo test for further extensions
<bitcoin-git> bitcoin/master c1106cf Andrew Chow: Merge bitcoin/bitcoin#28669: test: check assumeutxo file for changed outpo...
<bitcoin-git> [bitcoin] achow101 merged pull request #28669: test: check assumeutxo file for changed outpoint index + de-duplications (master...2023-10-au-tests) https://github.com/bitcoin/bitcoin/pull/28669
abubakarsadiq has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 255 seconds]
DarrylTheFish has joined #bitcoin-core-dev
ibiko1 has quit [Remote host closed the connection]
ibiko1 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 258 seconds]
jonatack has joined #bitcoin-core-dev
ibiko1 has quit [Remote host closed the connection]
ibiko1 has joined #bitcoin-core-dev
ibiko1 has quit [Remote host closed the connection]
ibiko1 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
ibiko1 has quit [Remote host closed the connection]
Guest65 has joined #bitcoin-core-dev
ibiko1 has joined #bitcoin-core-dev
Guest65 has quit [Client Quit]
hsmith_s has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 240 seconds]
nanotube has joined #bitcoin-core-dev
nanotube has quit [Quit: *poof*]
ibiko1 has quit [Remote host closed the connection]
nanotube has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
Nekorand has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] pablomartin4btc opened pull request #28698: assumeutxo, blockstorage: Prevent core dump on invalid hash (master...assumeutxo-safer-exit-on-init-core-dumped) https://github.com/bitcoin/bitcoin/pull/28698
pablomartin4btc has quit [Ping timeout: 248 seconds]
Nekorand has quit [Quit: Leaving]
jonatack has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 272 seconds]
ibiko1 has joined #bitcoin-core-dev
ibiko1 has quit [Ping timeout: 255 seconds]
nanotube has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
earnestly has quit [Ping timeout: 255 seconds]