<fanquake>
Looks like there is an issue with the codesigned macOS bins. Just an empty app inside the .zip?
TheRec has quit []
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<fanquake>
The unsigned binaries run fine after manual (adhoc) signing, so not an issue with the bins, just a packaging issue during the codesigning step
<fanquake>
Should be an easy fixup for rc2
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
<laanwj>
that's strange, i'll test the macos bin later today, good to catch this in the rc phase at least
brunoerg has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #28740: refactor: Add LIFETIMEBOUND to all (w)txid getters (master...2310-LIFETIMEBOUND-txid-get-) https://github.com/bitcoin/bitcoin/pull/28740
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
<fanquake>
laanwj: we simplified the packaging slightly, from dmg to zip, so it’ll just be a side effect of that
Guyver2 has left #bitcoin-core-dev [Closing Window]
brunoerg has quit [Ping timeout: 264 seconds]
kvaciral[m] has joined #bitcoin-core-dev
bob_x1 has quit [Remote host closed the connection]
bob_x1 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
benwestgate has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
bob_x1 has quit [Remote host closed the connection]
bob_x1 has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
DarrylTheFiiish has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] ClaytonNorthey92 opened pull request #28742: utils: returning a "moved" unique pointer from LoadAddrman (master...move-unique-addrman-ptr) https://github.com/bitcoin/bitcoin/pull/28742
<bitcoin-git>
[bitcoin] ClaytonNorthey92 opened pull request #28743: utils: returning "moved" pointers from functions in interfaces.cpp (master...move-unique-interfaces-ptr) https://github.com/bitcoin/bitcoin/pull/28743
<bitcoin-git>
[bitcoin] maflcko closed pull request #28743: utils: returning "moved" pointers from functions in interfaces.cpp (master...move-unique-interfaces-ptr) https://github.com/bitcoin/bitcoin/pull/28743
<bitcoin-git>
[bitcoin] ClaytonNorthey92 closed pull request #28742: utils: returning a "moved" unique pointer from LoadAddrman (master...move-unique-addrman-ptr) https://github.com/bitcoin/bitcoin/pull/28742
<achow101>
fanquake: are we skipping publishing rc1?
<fanquake>
I don’t think so. Everything else is useable, and we should get some testing underway. Can just not publish the signed macOS bins, with a note they’ll be in rc2
meshcollider has quit [Ping timeout: 246 seconds]
<achow101>
also everyone's codesigned macos mismatch
<achow101>
won't be able upload these since the SHA256SUMS mismatch
<fanquake>
I assume due to the packaging issue, we might be copying some garbage somewhere
<fanquake>
Can we just alter SHA256SUMS, and drop the macOS entries?
<fanquake>
Or is everything hardcoded?
<achow101>
signatures won't verify
<fanquake>
We might also need to adjust signapple. It seems to be skipping parsing a section in the bins
meshcollider has joined #bitcoin-core-dev
rolf has quit [Quit: WeeChat 4.1.0]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]