ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
BUSY has joined #bitcoin-core-dev
pakaro has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
ghost43 has quit [Ping timeout: 256 seconds]
ghost43 has joined #bitcoin-core-dev
uncounta1le has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
uncounta1le has quit [Quit: leaving]
brunoerg has quit [Ping timeout: 240 seconds]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
ibiko1 has joined #bitcoin-core-dev
ibiko1 has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
pakaro has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
PaperSword has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
pablomartin4btc has quit [Ping timeout: 245 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
puchka has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 240 seconds]
PaperSword has quit [Quit: PaperSword]
dviola has quit [Quit: WeeChat 4.1.0]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
test_ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
DarrylTheFiish has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
DarrylTheFish has quit [Ping timeout: 255 seconds]
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
bob_x1 has quit [Remote host closed the connection]
bob_x1 has joined #bitcoin-core-dev
DarrylTheFiiish has joined #bitcoin-core-dev
DarrylTheFiish has quit [Ping timeout: 252 seconds]
puchka has quit [Ping timeout: 245 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d724bb52910c...ab61087a7ee4
<bitcoin-git> bitcoin/master 5a0688a Matthew Zipkin: test: enable reindex readonly test on *BSD and macOS as root
<bitcoin-git> bitcoin/master ab61087 fanquake: Merge bitcoin/bitcoin#28660: test: enable reindex readonly test on *BSD
<bitcoin-git> [bitcoin] fanquake merged pull request #28660: test: enable reindex readonly test on *BSD (master...readonly-bsd) https://github.com/bitcoin/bitcoin/pull/28660
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab61087a7ee4...96ec3b67a7a7
<bitcoin-git> bitcoin/master 3f482ac fanquake: doc: add historical release notes for 24.2
<bitcoin-git> bitcoin/master 96ec3b6 fanquake: Merge bitcoin/bitcoin#28707: doc: add historical release notes for 24.2
<bitcoin-git> [bitcoin] fanquake merged pull request #28707: doc: add historical release notes for 24.2 (master...add_24_2_rel_notes) https://github.com/bitcoin/bitcoin/pull/28707
jonatack has quit [Ping timeout: 255 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 0 commit to 26.x: https://github.com/bitcoin/bitcoin/compare/26.x
<bitcoin-git> [bitcoin] fanquake opened pull request #28713: doc: consolidate release note fragments (26.x...consolidate_rel_notes) https://github.com/bitcoin/bitcoin/pull/28713
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #28714: doc: remove release note fragments for 26.x branch (master...cleanout_master_rel_notes) https://github.com/bitcoin/bitcoin/pull/28714
mikehu44 has quit [Ping timeout: 260 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #28715: [26.x] qt: 26.0rc1 translations update (26.x...231024-26.0rc1-tr) https://github.com/bitcoin/bitcoin/pull/28715
abubakarsadiq has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #28716: build: bump to 26.99 (master...bump_version_numbers) https://github.com/bitcoin/bitcoin/pull/28716
<bitcoin-git> [bitcoin] fanquake closed pull request #28716: build: bump to 26.99 (master...bump_version_numbers) https://github.com/bitcoin/bitcoin/pull/28716
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to 26.x: https://github.com/bitcoin/bitcoin/compare/96ec3b67a7a7...df28880ec050
<bitcoin-git> bitcoin/26.x b226e27 fanquake: doc: consolidate release note fragments
<bitcoin-git> bitcoin/26.x df28880 fanquake: Merge bitcoin/bitcoin#28713: [26.x] doc: consolidate release note fragments
<bitcoin-git> [bitcoin] fanquake merged pull request #28713: [26.x] doc: consolidate release note fragments (26.x...consolidate_rel_notes) https://github.com/bitcoin/bitcoin/pull/28713
Guest89 has joined #bitcoin-core-dev
Guest89 has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/96ec3b67a7a7...004367dba8a3
<bitcoin-git> bitcoin/master 799ce4d fanquake: build: bump version to 26.99
<bitcoin-git> bitcoin/master 1ac5584 fanquake: doc: remove release note fragments for 26.x branch
<bitcoin-git> bitcoin/master 004367d fanquake: Merge bitcoin/bitcoin#28714: doc: remove release note fragments for 26.x b...
<bitcoin-git> [bitcoin] fanquake merged pull request #28714: doc: remove release note fragments for 26.x branch (master...cleanout_master_rel_notes) https://github.com/bitcoin/bitcoin/pull/28714
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to 26.x: https://github.com/bitcoin/bitcoin/compare/df28880ec050...f40d7fc180dd
<bitcoin-git> bitcoin/26.x 7460466 Hennadii Stepanov: qt: 26.0rc1 translations update
<bitcoin-git> bitcoin/26.x f40d7fc fanquake: Merge bitcoin/bitcoin#28715: [26.x] qt: 26.0rc1 translations update
<bitcoin-git> [bitcoin] fanquake merged pull request #28715: [26.x] qt: 26.0rc1 translations update (26.x...231024-26.0rc1-tr) https://github.com/bitcoin/bitcoin/pull/28715
<bitcoin-git> [bitcoin] fanquake opened pull request #28717: [26.x] Bump version to v26.0rc1 (26.x...26_0_rc1) https://github.com/bitcoin/bitcoin/pull/28717
ghost43 has quit [Quit: Leaving]
ghost43 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 246 seconds]
jonatack has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
<laanwj> ive added bitcoin-detached-sigs to the notifications of the bot, if everything is ok it will send a notification for tags being made there now
<josie> laanwj: thanks! big improvement
Guest73 has joined #bitcoin-core-dev
Guest73 has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
<fanquake> laanwj: great, thanks
DarrylTheFiiish has quit [Ping timeout: 255 seconds]
dviola has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
jQrgen_ has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 258 seconds]
benwestgate has quit [Ping timeout: 258 seconds]
benwestgate has joined #bitcoin-core-dev
<jon_atack> Hi. #28248 has been open for 2.5 months now and contains a half dozen+ bug fixes for the current release, including addressing new issues. Mentioning as it was not tagged. (Big thanks to vasild for his excellent repeated reviews.)
<gribble> https://github.com/bitcoin/bitcoin/issues/28248 | p2p: peer connection bug fixes by jonatack · Pull Request #28248 · bitcoin/bitcoin · GitHub
<vasild> (just re-reviewing it now, fwiw)
<jon_atack> vasild: thanks! (i'll review the socks5 handshake and addnodes logic ones today)
bugs_ has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
<dergoegge> jon_atack: have you thought about adding tests to that PR? 6+ bug fixes are easier to review if you include tests
<jon_atack> dergoegge: 100% agree and may try adding tests, and am happy to review and pull tests in if anyone who would like to propose some. My focus until now was finding and trying to implement good fixes, and the added logging made the issues clear for me when running a node. Testing would complete that..
<jon_atack> dergoegge: #28695 on my review list today too
<gribble> https://github.com/bitcoin/bitcoin/issues/28695 | net: Sanitize private keys received from SAM proxy by dergoegge · Pull Request #28695 · bitcoin/bitcoin · GitHub
Chris_Stewart_5 has joined #bitcoin-core-dev
benwestgate has quit [Quit: Leaving.]
preimage has joined #bitcoin-core-dev
<jonasschnelli> is there a reason why getblockstats has minfeerate, maxfeerate, avgfeerate but no medianfeerate (it has all other medianX values)?
eval-exec has joined #bitcoin-core-dev
pablomartin4btc has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
surfer46 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin-detached-sigs] achow101 pushed 1 commit to 24.0: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/302911e54730...5b85142a828c
<bitcoin-git> bitcoin-detached-sigs/24.0 5b85142 Andrew Chow: 24.2: win signature for final
benwestgate has quit [Client Quit]
benwestgate has joined #bitcoin-core-dev
benwestgate has quit [Client Quit]
benwestgate has joined #bitcoin-core-dev
benwestgate has quit [Client Quit]
benwestgate has joined #bitcoin-core-dev
benwestgate has quit [Client Quit]
benwestgate has joined #bitcoin-core-dev
benwestgate has quit [Client Quit]
surfer46 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin-detached-sigs] fanquake pushed 1 commit to 24.0: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/5b85142a828c...b440a49658d9
<bitcoin-git> bitcoin-detached-sigs/24.0 b440a49 fanquake: 24.2: macOS signature for final
<bitcoin-git> [bitcoin-detached-sigs] fanquake pushed tag v24.2: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/v24.2
<laanwj> it's working!
<fanquake> 🎉
<fanquake> good stuff
<achow101> \o/
<josie> niiice
ghost43 has quit [Ping timeout: 256 seconds]
ghost43 has joined #bitcoin-core-dev
<achow101> is the fuzzer ci task expected to time out?
<fanquake> yes, until we delete some unputs
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to 26.x: https://github.com/bitcoin/bitcoin/compare/f40d7fc180dd...11254a34d7f9
<bitcoin-git> bitcoin/26.x c4fa45c fanquake: build: bump version to v26.0rc1
<bitcoin-git> bitcoin/26.x d1fe90c fanquake: doc: generate manual pages for v26.0rc1
<bitcoin-git> bitcoin/26.x 958ee5d fanquake: doc: generate example bitcoin.conf for v26.0rc1
<bitcoin-git> [bitcoin] fanquake merged pull request #28717: [26.x] Bump version to v26.0rc1 (26.x...26_0_rc1) https://github.com/bitcoin/bitcoin/pull/28717
<bitcoin-git> [bitcoin] fanquake pushed tag v26.0rc1: https://github.com/bitcoin/bitcoin/compare/v26.0rc1
<dergoegge> re-running the qa-assets input pruning rn for review, PR should go in ~tomorrow
jQrgen_ has quit [Remote host closed the connection]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 240 seconds]
<MacroFake> dergoegge: -set_cover_merge seems not very reproducible
<MacroFake> I did two runs and got a diff of those over 24k files, with a total number of files of 60k
<MacroFake> Ok, maybe not too bad. More than half of the inputs were picked twice
<dergoegge> could be caused by targets that aren't deterministic? or maybe libFuzzer has some randomness in the merge...
<dergoegge> doesn't sound to bad overall as long as we end up with significantly less inputs with the same coverage
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/004367dba8a3...43704827b4c9
<bitcoin-git> bitcoin/master fa8996b MarcoFalke: ci: Bump i686_multiprocess.sh to latest Ubuntu LTS
<bitcoin-git> bitcoin/master faf70c1 MarcoFalke: Bump python minimum version to 3.9
<bitcoin-git> bitcoin/master fa25e8b MarcoFalke: doc: Recommend lint image build on every call
<bitcoin-git> [bitcoin] fanquake merged pull request #28211: Bump python minimum supported version to 3.9 (master...2308-py39-) https://github.com/bitcoin/bitcoin/pull/28211
jQrgen_ has joined #bitcoin-core-dev
emzy has quit [Ping timeout: 252 seconds]
eval-exec has quit [Quit: Client closed]
Talkless has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
brunoerg has quit []
<bitcoin-git> [bitcoin] ryanofsky opened pull request #28721: multiprocess compatibility updates (master...pr/ipcfix) https://github.com/bitcoin/bitcoin/pull/28721
jQrgen_ has quit [Remote host closed the connection]
benwestgate has joined #bitcoin-core-dev
emzy has joined #bitcoin-core-dev
jQrgen_ has joined #bitcoin-core-dev
ibiko1 has joined #bitcoin-core-dev
ibiko1 has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
cman has joined #bitcoin-core-dev
conman has quit [Ping timeout: 255 seconds]
<laanwj> jonasschnelli: there's feerate_percentiles.50th_percentile_feerate which should be equivalent to the median
benwestgate has quit [Quit: Leaving.]
<jonasschnelli> laanwj: Thanks! Totally missed the feerate_percentiles array.
jQrgen_ has quit [Remote host closed the connection]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Remote host closed the connection]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Remote host closed the connection]
ibiko1 has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
ibiko1 has quit [Ping timeout: 258 seconds]
benwestgate has quit [Quit: Leaving.]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 264 seconds]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 255 seconds]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/43704827b4c9...ba0313d84b71
<bitcoin-git> bitcoin/master fab1ef9 MarcoFalke: Bump .python-version from 3.9.17 to 3.9.18
<bitcoin-git> bitcoin/master fae379b MarcoFalke: build: Bump minimum supported Clang to clang-13
<bitcoin-git> bitcoin/master ba0313d fanquake: Merge bitcoin/bitcoin#28210: build: Bump clang minimum supported version t...
<bitcoin-git> [bitcoin] fanquake merged pull request #28210: build: Bump clang minimum supported version to 13 (master...2308-clang-13-) https://github.com/bitcoin/bitcoin/pull/28210
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ba0313d84b71...d53400e75e2a
<bitcoin-git> bitcoin/master 986d7fe fanquake: depends: zeromq 4.3.5
<bitcoin-git> bitcoin/master d53400e fanquake: Merge bitcoin/bitcoin#28627: depends: zeromq 4.3.5
<bitcoin-git> [bitcoin] fanquake merged pull request #28627: depends: zeromq 4.3.5 (master...zeromq_4_3_5) https://github.com/bitcoin/bitcoin/pull/28627
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
jQrgen_ has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.1.0]
jQrgen_ has quit [Ping timeout: 260 seconds]
<bitcoin-git> [gui] achow101 opened pull request #773: gui: Check for private keys disabled before attempting unlock (master...gui-skip-encryption-check-for-watchonly) https://github.com/bitcoin-core/gui/pull/773
jQrgen_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
jQrgen_ has quit [Remote host closed the connection]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 264 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
jQrgen_ has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
boris- has quit [Ping timeout: 255 seconds]
<bitcoin-git> [bitcoin] achow101 opened pull request #28724: wallet: Cleanup accidental encryption keys in watchonly wallets (master...cleanup-accidental-watchonly-mkeys) https://github.com/bitcoin/bitcoin/pull/28724
AaronvanW has quit [Quit: Leaving...]
jespada has quit [Ping timeout: 264 seconds]
jespada has joined #bitcoin-core-dev
jQrgen__ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 255 seconds]
flooded has joined #bitcoin-core-dev
test__ has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 272 seconds]
test_ has joined #bitcoin-core-dev
jQrgen__ has quit [Remote host closed the connection]
flooded has quit [Ping timeout: 255 seconds]
jQrgen_ has joined #bitcoin-core-dev
test__ has quit [Ping timeout: 255 seconds]
jQrgen_ has quit [Ping timeout: 255 seconds]
jQrgen_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theStack opened pull request #28725: test: use built-in collection types for type hints (Python 3.9 / PEP 585) (master...test-type_hints_use_builtin_collection_types) https://github.com/bitcoin/bitcoin/pull/28725
jQrgen__ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 272 seconds]
jQrgen__ has quit [Ping timeout: 264 seconds]