realies has quit [Read error: Connection reset by peer]
realies has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jarthur has quit [Quit: jarthur]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
no-world has joined #bitcoin-core-dev
<no-world>
Hi! When will Bitcoin read legacy wallets addresses created with 2009-2013 Bitcoin core hardware wallets? And, when will the coin generation feature be added back? And, under the MIT license, can I or the Nevada Gaming Commission do these things and more? I believe I know, but I prefer to ask again!
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
no-world has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
puchka has quit [Ping timeout: 255 seconds]
puchka has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 246 seconds]
<vasild>
What is the point of using SaltedTxidHasher for unordered_map/set of tx ids? Why not just use e.g. the first 64 bits of the tx id? What's the point of using a salt? Surely we are not worred that a malicious actor could send us transactions with special ids to ruin the quality of our unordered_set containers and turn them into O(n) search/insert/delete containers.
<sipa>
vasild: that is exactly what we're worried about
<vasild>
L-O
<vasild>
that would require work by the malicious actor, right? generating transactions with pre-determined ids
<sipa>
it wouldn't need much grinding
<vasild>
and to cause troubles they have to generate 1000s of them
<sipa>
yes
<sipa>
hashing is pretty cheap, bitcoin may have encourage some hardware developments in that regard
<vasild>
ok, switching my container to use saltedhasher then...
<instagibbs>
sipa citation needed
<vasild>
hmm, for the private broadcast where we store only locally submitted transactions in the unordered_map it is less of a concern... will use SaltedTxidHasher anyway
<sipa>
vasild: yeah, i think it's just good best practice; there are probably some data structures where it doesn't actually matter
<sipa>
but it's easier not having to reason about that
<bitcoin-git>
[bitcoin] sipa closed pull request #29284: Choose earliest-activatable as tie breaker between equal-work chains (master...202401_better_block_tiebreak) https://github.com/bitcoin/bitcoin/pull/29284
Talkless has quit [Ping timeout: 272 seconds]
dzxzg has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] sr-gi opened pull request #29640: Adds missing test to chain ties (CBlockIndexWorkComparator) (master...202403-block-tiebreak) https://github.com/bitcoin/bitcoin/pull/29640
<bitcoin-git>
[bitcoin] maflcko opened pull request #29641: scripted-diff: Use LogInfo/LogDebug over LogPrintf/LogPrint (master...2403-log-) https://github.com/bitcoin/bitcoin/pull/29641
dzxzg has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
jarthur has quit [Ping timeout: 268 seconds]
Akshat19 has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.2.1]
szkl has quit [Quit: Connection closed for inactivity]
Akshat19 has quit [Ping timeout: 250 seconds]
<bitcoin-git>
[bitcoin] TheCharlatan opened pull request #29642: kernel: Handle fatal errors through return values (master...returnTypeShutdown) https://github.com/bitcoin/bitcoin/pull/29642