#bitcoin-core-dev on 2024-03-25 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:03 kevkevin has joined #bitcoin-core-dev

00:07 kevkevin has quit [Ping timeout: 260 seconds]

00:16 kevkevin has joined #bitcoin-core-dev

00:38 asher has joined #bitcoin-core-dev

00:59 Gbolarhan has joined #bitcoin-core-dev

01:05 Gbolarhan has quit [Quit: Client closed]

02:11 mudsip has joined #bitcoin-core-dev

02:14 pablomartin4btc has quit [Ping timeout: 256 seconds]

02:15 mudsip has quit [Client Quit]

02:19 kevkevin has quit [Remote host closed the connection]

03:48 kevkevin has joined #bitcoin-core-dev

03:56 <bitcoin-git> [bitcoin] Abhinavnamballa opened pull request #29717: Fix Typo in cypter.cpp (master...patch-text) https://github.com/bitcoin/bitcoin/pull/29717

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:25 asher has quit [Ping timeout: 255 seconds]

05:00 kevkevin has quit [Remote host closed the connection]

05:48 kevkevin has joined #bitcoin-core-dev

05:54 kevkevin has quit [Ping timeout: 256 seconds]

05:54 puchka has joined #bitcoin-core-dev

05:56 kevkevin has joined #bitcoin-core-dev

06:02 kevkevin has quit [Ping timeout: 260 seconds]

06:07 kevkevin has joined #bitcoin-core-dev

06:07 bitdex has quit [Ping timeout: 260 seconds]

06:11 kevkevin has quit [Ping timeout: 256 seconds]

06:24 kevkevin has joined #bitcoin-core-dev

06:31 kevkevin has quit [Ping timeout: 268 seconds]

06:42 <bitcoin-git> [bitcoin] BenWestgate opened pull request #29718: Correct '-dbcache' to '-prune' (master...patch-2) https://github.com/bitcoin/bitcoin/pull/29718

06:45 kevkevin has joined #bitcoin-core-dev

06:50 kevkevin has quit [Ping timeout: 256 seconds]

07:02 kevkevin has joined #bitcoin-core-dev

07:08 kevkevin has quit [Ping timeout: 268 seconds]

07:22 kevkevin has joined #bitcoin-core-dev

07:27 kevkevin has quit [Ping timeout: 268 seconds]

07:41 kevkevin has joined #bitcoin-core-dev

07:46 kevkevin has quit [Ping timeout: 264 seconds]

08:02 kevkevin has joined #bitcoin-core-dev

08:07 kevkevin has quit [Ping timeout: 240 seconds]

08:22 kevkevin has joined #bitcoin-core-dev

08:25 lbia has quit [Ping timeout: 264 seconds]

08:26 lbia has joined #bitcoin-core-dev

08:27 kevkevin has quit [Ping timeout: 268 seconds]

08:35 Guyver2 has joined #bitcoin-core-dev

08:41 kevkevin has joined #bitcoin-core-dev

08:46 kevkevin has quit [Ping timeout: 256 seconds]

08:55 S3RK_ has quit [Quit: Reconnecting]

08:55 S3RK has joined #bitcoin-core-dev

09:01 kevkevin has joined #bitcoin-core-dev

09:03 BrandonOdiwuor has joined #bitcoin-core-dev

09:09 kevkevin has quit [Ping timeout: 256 seconds]

09:11 <bitcoin-git> [bitcoincore.org] glozow opened pull request #1009: Bitcoin Core 26.1 (master...2024-03-announce-26.1) https://github.com/bitcoin-core/bitcoincore.org/pull/1009

09:14 BrandonOdiwuor has quit [Quit: Ping timeout (120 seconds)]

09:24 kevkevin has joined #bitcoin-core-dev

09:27 <bitcoin-git> [bitcoin] fanquake closed pull request #29717: Fix Typo in cypter.cpp (master...patch-text) https://github.com/bitcoin/bitcoin/pull/29717

09:29 kevkevin has quit [Ping timeout: 260 seconds]

09:41 kevkevin has joined #bitcoin-core-dev

09:46 kevkevin has quit [Ping timeout: 246 seconds]

09:51 <bitcoin-git> [bitcoin] glozow opened pull request #29719: [26.x] final changes for 26.1 (26.x...2024-03-26.1-final) https://github.com/bitcoin/bitcoin/pull/29719

09:59 kevkevin has joined #bitcoin-core-dev

10:10 kevkevin has quit [Ping timeout: 268 seconds]

10:14 jadi_ has left #bitcoin-core-dev [#bitcoin-core-dev]

10:15 <bitcoin-git> [bitcoin] maflcko opened pull request #29720: rpc: Avoid getchaintxstats invalid results (master...2403-rpc-int-wrap-) https://github.com/bitcoin/bitcoin/pull/29720

10:23 kevkevin has joined #bitcoin-core-dev

10:28 kevkevin has quit [Ping timeout: 272 seconds]

10:43 kevkevin has joined #bitcoin-core-dev

10:48 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c1223188e0a5...f22bca647321

10:48 <bitcoin-git> bitcoin/master 89b84ea 0xb10c: test: check that addrman seeding is successful

10:48 <bitcoin-git> bitcoin/master 3047c3e 0xb10c: addrman: drop /*deterministic=*/ comment

10:48 <bitcoin-git> bitcoin/master 9a44a20 0xb10c: init: clarify -test error

10:48 <bitcoin-git> [bitcoin] fanquake merged pull request #29636: test: #29007 follow ups (master...2024-03-29007-follow-ups) https://github.com/bitcoin/bitcoin/pull/29636

10:48 kevkevin has quit [Ping timeout: 268 seconds]

10:50 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f22bca647321...556074143f58

10:50 <bitcoin-git> bitcoin/master e037c4f fanquake: depends: always configure with --with-pic

10:50 <bitcoin-git> bitcoin/master 5560741 fanquake: Merge bitcoin/bitcoin#29488: depends: always configure with `--with-pic`

10:50 <bitcoin-git> [bitcoin] fanquake merged pull request #29488: depends: always configure with `--with-pic` (master...depends_with_pic_cleanup) https://github.com/bitcoin/bitcoin/pull/29488

11:01 kevkevin has joined #bitcoin-core-dev

11:01 BrandonOdiwuor has joined #bitcoin-core-dev

11:11 kevkevin has quit [Ping timeout: 260 seconds]

11:23 <bitcoin-git> [bitcoin] crazeteam opened pull request #29721: chore: fix some comments (master...master) https://github.com/bitcoin/bitcoin/pull/29721

11:25 the_mariner has joined #bitcoin-core-dev

11:26 kevkevin has joined #bitcoin-core-dev

11:30 kevkevin has quit [Ping timeout: 240 seconds]

11:35 pablomartin has joined #bitcoin-core-dev

11:45 kevkevin has joined #bitcoin-core-dev

11:48 <bitcoin-git> [bitcoin] crazeteam closed pull request #29721: chore: fix some comments (master...master) https://github.com/bitcoin/bitcoin/pull/29721

11:53 kevkevin has quit [Ping timeout: 256 seconds]

12:15 pablomartin has quit [Ping timeout: 268 seconds]

12:18 pablomartin has joined #bitcoin-core-dev

12:20 pablomartin has quit [Remote host closed the connection]

12:20 pablomartin has joined #bitcoin-core-dev

12:25 kevkevin has joined #bitcoin-core-dev

12:31 kevkevin has quit [Ping timeout: 272 seconds]

12:34 <bitcoin-git> [bitcoin] instagibbs opened pull request #29722: 28950 followups (master...2024-03-maxfee-followup) https://github.com/bitcoin/bitcoin/pull/29722

12:42 pablomartin has quit [Ping timeout: 264 seconds]

12:54 <bitcoin-git> [bitcoin] maflcko closed pull request #29318: test: Check object hashes in wait_for_getheaders (master...wait-for-getheaders-hash) https://github.com/bitcoin/bitcoin/pull/29318

12:56 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/556074143f58...53f4607cc8c6

12:56 <bitcoin-git> bitcoin/master 24410e5 fanquake: tidy: set minimum CMake to 3.22

12:56 <bitcoin-git> bitcoin/master 5b690ae fanquake: tidy: remove terminfo TODO

12:56 <bitcoin-git> bitcoin/master c3a4ea1 fanquake: tidy: set CMAKE_CXX_STANDARD to 20

12:56 <bitcoin-git> [bitcoin] fanquake merged pull request #29696: tidy: remove todo, set minimum CMake to 3.22 (master...clang_tidy_todo) https://github.com/bitcoin/bitcoin/pull/29696

12:59 jamesob443688173 has joined #bitcoin-core-dev

12:59 jamesob has joined #bitcoin-core-dev

13:01 kevkevin has joined #bitcoin-core-dev

13:04 twistedline has quit []

13:04 twistedline has joined #bitcoin-core-dev

13:06 kevkevin has quit [Ping timeout: 260 seconds]

13:08 kevkevin has joined #bitcoin-core-dev

13:08 Guyver2 has left #bitcoin-core-dev [Closing Window]

13:13 kevkevin has quit [Ping timeout: 256 seconds]

13:15 kevkevin has joined #bitcoin-core-dev

13:21 kevkevin has quit [Ping timeout: 264 seconds]

13:23 test_ is now known as _flood

13:34 kevkevin has joined #bitcoin-core-dev

13:38 kevkevin has quit [Ping timeout: 268 seconds]

13:49 jamesob has quit [Ping timeout: 260 seconds]

13:49 jamesob443688173 has quit [Ping timeout: 260 seconds]

13:50 kevkevin has joined #bitcoin-core-dev

13:55 kevkevin has quit [Ping timeout: 255 seconds]

14:04 kevkevin has joined #bitcoin-core-dev

14:12 bugs_ has joined #bitcoin-core-dev

14:14 AaronvanW has quit [Remote host closed the connection]

14:22 jamesob443688173 has joined #bitcoin-core-dev

14:22 jamesob has joined #bitcoin-core-dev

14:41 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/53f4607cc8c6...2e1c84b333dc

14:41 <bitcoin-git> bitcoin/master fa1146d MarcoFalke: lint: Fix COMMIT_RANGE issues

14:41 <bitcoin-git> bitcoin/master 2e1c84b fanquake: Merge bitcoin/bitcoin#29660: lint: Fix COMMIT_RANGE issues

14:41 <bitcoin-git> [bitcoin] fanquake merged pull request #29660: lint: Fix COMMIT_RANGE issues (master...2403-lint-commit-range-) https://github.com/bitcoin/bitcoin/pull/29660

14:44 AaronvanW has joined #bitcoin-core-dev

14:49 AaronvanW has quit [Ping timeout: 252 seconds]

14:50 <bitcoin-git> [bitcoin] fanquake opened pull request #29723: depends: build zeromq with CMake (master...zeromq_cmake_switch) https://github.com/bitcoin/bitcoin/pull/29723

15:02 AaronvanW has joined #bitcoin-core-dev

15:07 AaronvanW has quit [Ping timeout: 255 seconds]

15:07 <luke-jr_> hebasto: yes, there's been some interest in translating the strings missing in Core too; bonus this could mean when those things get merged into Core, there's already a translation ready to go

15:49 <darosior> So SCRIPT_VERIFY_SIGPUSHONLY isn't actually enabled as a standardness check

15:49 <darosior> h/t Sjors[m]

15:50 <instagibbs> correct

15:50 <instagibbs> https://github.com/bitcoin/bitcoin/issues/26113

15:51 kevkevin has quit [Remote host closed the connection]

15:54 <darosior> Maybe we should consider making those non-standard?..

15:55 <sipa> it's consensus in P2SH though

15:55 <sipa> and irrelevant in segwit

15:59 kevkevin has joined #bitcoin-core-dev

16:07 zeropoint has joined #bitcoin-core-dev

16:13 <bitcoin-git> [bitcoin] instagibbs opened pull request #29724: 29242 Diagram check followups (master...2024-03-diagram-followups) https://github.com/bitcoin/bitcoin/pull/29724

16:21 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e1c84b333dc...220487bafdaa

16:21 <bitcoin-git> bitcoin/master 416b9d9 Ben Westgate: correct '-dbcache' to '-prune'

16:21 <bitcoin-git> bitcoin/master 220487b fanquake: Merge bitcoin/bitcoin#29718: Correct '-dbcache' to '-prune'

16:21 <bitcoin-git> [bitcoin] fanquake merged pull request #29718: Correct '-dbcache' to '-prune' (master...patch-2) https://github.com/bitcoin/bitcoin/pull/29718

16:29 asher has joined #bitcoin-core-dev

16:47 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/220487bafdaa...2102c978b5f2

16:47 <bitcoin-git> bitcoin/master d046236 fanquake: depends: always set CMAKE_INSTALL_LIBDIR=lib/

16:47 <bitcoin-git> bitcoin/master 76045bb fanquake: depends: always set CMAKE_POSITION_INDEPENDENT_CODE=ON

16:47 <bitcoin-git> bitcoin/master 2102c97 fanquake: Merge bitcoin/bitcoin#29706: depends: set two CMake options globally

16:48 <bitcoin-git> [bitcoin] fanquake merged pull request #29706: depends: set two CMake options globally (master...cmake_pic_libdir) https://github.com/bitcoin/bitcoin/pull/29706

16:51 <bitcoin-git> [bitcoin] fanquake pushed 6 commits to 26.x: https://github.com/bitcoin/bitcoin/compare/c33e83a53a86...0b4aa31c34b2

16:51 <bitcoin-git> bitcoin/26.x 324e562 Hennadii Stepanov: ci: Add workaround for Homebrew's python link error

16:51 <bitcoin-git> bitcoin/26.x b53bf22 Hennadii Stepanov: ci, macos: Use `--break-system-packages` with Homebrew's python

16:51 <bitcoin-git> bitcoin/26.x 5f06dcf glozow: [build] bump version to 26.1 final

16:51 <bitcoin-git> [bitcoin] fanquake merged pull request #29719: [26.x] final changes for 26.1 (26.x...2024-03-26.1-final) https://github.com/bitcoin/bitcoin/pull/29719

16:58 jon_atack has quit [Ping timeout: 264 seconds]

17:03 <bitcoin-git> [bitcoin] glozow pushed tag v26.1: https://github.com/bitcoin/bitcoin/compare/v26.1

17:05 AaronvanW has joined #bitcoin-core-dev

17:09 <bitcoin-git> [bitcoin-detached-sigs] achow101 pushed 1 commit to 25.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/69cbceeea10c...35616933b0a7

17:09 <bitcoin-git> bitcoin-detached-sigs/25.x 3561693 Ava Chow: 25.2: win signature for rc2

17:15 ___nick___ has joined #bitcoin-core-dev

17:21 AaronvanW has quit [Remote host closed the connection]

17:42 gnusha_ has joined #bitcoin-core-dev

17:42 ppisati_ has joined #bitcoin-core-dev

17:43 dermoth_ has joined #bitcoin-core-dev

17:43 gribble` has joined #bitcoin-core-dev

17:46 gnusha has quit [*.net *.split]

17:46 gribble has quit [*.net *.split]

17:46 dermoth has quit [*.net *.split]

17:46 ppisati has quit [*.net *.split]

17:46 Sjors[m] has quit [*.net *.split]

17:46 Murch[m] has quit [*.net *.split]

17:47 dermoth_ is now known as dermoth

17:53 <bitcoin-git> [bitcoin-detached-sigs] fanquake pushed 1 commit to 25.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/35616933b0a7...ecb1ee0ace8c

17:53 <bitcoin-git> bitcoin-detached-sigs/25.x ecb1ee0 fanquake: 25.2: macOS signature for rc2

17:53 Murch[m] has joined #bitcoin-core-dev

17:53 Sjors[m] has joined #bitcoin-core-dev

18:00 <bitcoin-git> [bitcoin-detached-sigs] achow101 pushed tag v25.2rc2: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/v25.2rc2

18:01 BrandonOdiwuor has quit [Ping timeout: 250 seconds]

18:12 <bitcoin-git> [bitcoin] fanquake opened pull request #29725: depends: build libqrencode with CMake (master...libqrencode_cmake) https://github.com/bitcoin/bitcoin/pull/29725

18:17 asher has quit [Ping timeout: 260 seconds]

18:38 ___nick___ has quit [Ping timeout: 255 seconds]

19:00 <bitcoin-git> [bitcoin] mzumsande opened pull request #29726: assumeutxo: Fix -reindex before snapshot was validated (master...202403_assumeutxo_reindex_fix) https://github.com/bitcoin/bitcoin/pull/29726

19:32 asher has joined #bitcoin-core-dev

19:45 Guest4 has joined #bitcoin-core-dev

19:47 Guest4 has quit [Client Quit]

19:50 Guest28 has joined #bitcoin-core-dev

19:51 Guest28 has quit [Client Quit]

19:52 ___nick___ has joined #bitcoin-core-dev

19:52 ___nick___ has quit [Client Quit]

19:54 ___nick___ has joined #bitcoin-core-dev

20:04 <bitcoin-git> [bitcoin] bombastictranz opened pull request #29727: bombastictranz/bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/29727

20:05 <bitcoin-git> [bitcoin] fanquake closed pull request #29727: bombastictranz/bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/29727

20:19 AaronvanW has joined #bitcoin-core-dev

20:33 kevkevin has quit [Remote host closed the connection]

20:49 kevkevin has joined #bitcoin-core-dev

20:52 AaronvanW has quit [Ping timeout: 256 seconds]

21:03 dermoth has quit [Ping timeout: 268 seconds]

21:04 ___nick___ has quit [Ping timeout: 256 seconds]

21:19 kevkevin has quit [Quit: Leaving...]

21:31 dermoth has joined #bitcoin-core-dev

21:34 dermoth has quit [Remote host closed the connection]

21:37 dermoth has joined #bitcoin-core-dev

21:49 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2102c978b5f2...b44f9e4645c0

21:49 <bitcoin-git> bitcoin/master a8bfc3d brunoerg: test: add coverage for bech32m in `wallet_keypool_topup`

21:49 <bitcoin-git> bitcoin/master b44f9e4 Ava Chow: Merge bitcoin/bitcoin#28928: test: add coverage for bech32m in `wallet_key...

21:49 <bitcoin-git> [bitcoin] achow101 merged pull request #28928: test: add coverage for bech32m in `wallet_keypool_topup` (master...2023-11-test-keypool-bech32m) https://github.com/bitcoin/bitcoin/pull/28928

21:53 bugs_ has quit [Quit: Leaving]

22:00 dermoth has quit [Ping timeout: 260 seconds]

22:01 ghost43 has quit [Remote host closed the connection]

22:02 ghost43 has joined #bitcoin-core-dev

22:14 pablomartin has joined #bitcoin-core-dev

22:33 bitdex has joined #bitcoin-core-dev

22:38 bitdex has quit [Remote host closed the connection]

22:38 bitdex has joined #bitcoin-core-dev

22:50 AaronvanW has joined #bitcoin-core-dev

23:10 asher has quit [Ping timeout: 272 seconds]

23:17 cbergqvist has quit [Ping timeout: 260 seconds]

23:23 AaronvanW has quit [Ping timeout: 246 seconds]

23:40 asher has joined #bitcoin-core-dev

23:42 cguida has joined #bitcoin-core-dev

23:47 <bitcoin-git> [bitcoin] slayerment opened pull request #29728: fix: 'having' misspelling (master...master) https://github.com/bitcoin/bitcoin/pull/29728