cygnet3 has quit [Remote host closed the connection]
asher has quit [Ping timeout: 268 seconds]
asher has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Safety has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
noonien80831042 has joined #bitcoin-core-dev
noonien8083104 has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] luke-jr closed pull request #29147: guix: Use DOS newlines for SHA256SUMS files (master...guix_attachable_sigs) https://github.com/bitcoin/bitcoin/pull/29147
asher has quit [Ping timeout: 260 seconds]
preimage has quit [Quit: WeeChat 4.2.1]
<bitcoin-git>
[bitcoin] instagibbs closed pull request #29743: test: add V3 test case for inpool-inpackage-inpackage (master...2024-03-v3-mixed-linear-case) https://github.com/bitcoin/bitcoin/pull/29743
cmirror has quit [Remote host closed the connection]
pablomartin has quit [Ping timeout: 268 seconds]
cmirror has joined #bitcoin-core-dev
cguida has quit [Remote host closed the connection]
cguida has joined #bitcoin-core-dev
Safety has quit [Quit: Client closed]
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
<laanwj>
willcl-ark: i think the .tar.gz are the unsigned binaries, the .zip is the signed one, you should probably be using the zip
<laanwj>
but tbh i don't know why both are being shipped
<laanwj>
running non-signed binaries is possible on macos but it needs some special step to allowlist them
<laanwj>
looks like the .tar.gz contain some more eg, also the command line utilities and tests, that makes sense for whoever neesd that
AaronvanW has quit [Ping timeout: 264 seconds]
Guyver2 has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
jamesob4 has joined #bitcoin-core-dev
jamesob has quit [Ping timeout: 252 seconds]
jamesob443688173 has quit [Ping timeout: 252 seconds]
jamesob4 is now known as jamesob
aleggg has quit [Remote host closed the connection]
aleggg has joined #bitcoin-core-dev
cbergqvist has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<b10c>
any reason why we check ">= MAX_BLOCK_SIGOPS" in BlockAssembler::TestPackage but "> MAX_BLOCK_SIGOPS_COST" in validation? One sigop is unused (this rarely matters, just wondering if there's an undocumented reason for this)
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
<_aj_>
b10c: it's already off by nBlockSigOpsCost=400, what's an extra off by 1?
<b10c>
_aj_: I'm aware - just wondering if there's an actual reason for it
<b10c>
so probably just an oversight (that rarely ever matters)
<_aj_>
if the nBlock numbers aren't already wild over-estimates, there's already a problem; if they are over-estimates, an off by one making them slightly worse over estimates is no big deal *shrug*
<bitcoin-git>
[bitcoin] sr-gi opened pull request #29748: test: Cleans some manual checks/drops when using wait_for_getdata (master...202403-waitforgetdata-cleanup) https://github.com/bitcoin/bitcoin/pull/29748
<sr_gi[m]>
maflcko: re #29736, I've also noticed that most of the `wait_for_*` methods that check whether a type of message is present in the collection do so like: `if not not self.last_message.get...` when the safe(r) way would be `... is not None` (given many things may evaluate to False). Is that worth fixing as well?
<gribble>
https://github.com/bitcoin/bitcoin/issues/29736 | test: Extends wait_for_getheaders so a specific block hash can be checked by sr-gi · Pull Request #29736 · bitcoin/bitcoin · GitHub
asher has quit [Ping timeout: 256 seconds]
<fanquake>
laawnj: might just be time to bite the bullet and ship everything codesigned for macOS. Running unsigned bins is going away with x86_64
<fanquake>
*laanwj
the_mariner has quit [Ping timeout: 240 seconds]
<stickies-v>
shipping codesigned arm64 makes sense imo, kinda awkward how the first interaction users have now is getting a message that the bins are damaged and should be trashed
<laanwj>
fanquake i'm not sure of the logistic issues involved with getting it to be that way with guix, but yes i think that makes sense
<willcl-ark>
Well I thought I understood the code signing debate that we had been having (in #15774), but thought it was only applying to Bitcoin-Qt.app for some reason
<willcl-ark>
But currently macOS users can't get pre built bitcoin-cli or bitcoind without this (undocumented?) step
<laanwj>
it has always been that way, though apple is as usual making things harder and harder
<fanquake>
will-clark: by pre-built do you mean guix?
<fanquake>
Compiing yourself always works, with no additional steps to codesign
<willcl-ark>
Sure:)
pablomartin has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sr-gi opened pull request #29750: test: makes timeout a forced named argument in tests methods that use it (master...202403-test-forced-timeout) https://github.com/bitcoin/bitcoin/pull/29750
BrandonOdiwuor has joined #bitcoin-core-dev
<luke-jr_>
laanwj: the .tar.gz typically are un-app-ified bins IIRC
AaronvanW has quit [Ping timeout: 256 seconds]
the_mariner has joined #bitcoin-core-dev
<laanwj>
luke-jr_: yes, it is... it makes sense, i had just forgotten why
<darosior>
#proposedmeetingtopic writeups and disclosure of historical bugs reported but were never published
<bitcoin-git>
gui-qml/main d47bc1a pablomartin4btc: qml, control: new IPAddressValueInput
<bitcoin-git>
gui-qml/main b6bf91f Hennadii Stepanov: Merge bitcoin-core/gui-qml#391: Introducing an improved IP Address and Por...
<bitcoin-git>
[gui-qml] hebasto merged pull request #391: Introducing an improved IP Address and Port input control in ProxySettings component (main...qml-ipaddress-valueinput) https://github.com/bitcoin-core/gui-qml/pull/391
infernix has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
puchka has quit [Ping timeout: 255 seconds]
puchka has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 256 seconds]
puchka has joined #bitcoin-core-dev
freesprung5126 has quit [Ping timeout: 260 seconds]
<bitcoin-git>
[bitcoin] AngusP opened pull request #29752: refactor: Use typesafe Wtxid in compact block encodings (master...typesafe-txid-in-cmpctblock) https://github.com/bitcoin/bitcoin/pull/29752
Guest79 has joined #bitcoin-core-dev
vasild_ has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
Novo has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] LarryRuane closed pull request #29163: bitcoin-cli help detail to show full help for all RPCs (master...2024-01-help-detailed) https://github.com/bitcoin/bitcoin/pull/29163
Talkless has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
Guest79 has quit [Quit: Client closed]
vostrnad has quit [Quit: Client closed]
Talkless has quit [Ping timeout: 255 seconds]
Talkless has joined #bitcoin-core-dev
Talkless has quit [Client Quit]
Talkless has joined #bitcoin-core-dev
Guest70 has quit [Quit: Client closed]
asher has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
Talkless has quit [Ping timeout: 264 seconds]
vasild has quit [Remote host closed the connection]