#bitcoin-core-dev on 2024-03-29 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:58 puchka has quit [Ping timeout: 256 seconds]

00:58 maflcko has quit [Quit: ZNC 1.8.2+deb2build5 - https://znc.in]

00:59 maflcko has joined #bitcoin-core-dev

01:27 jonatack has joined #bitcoin-core-dev

01:28 abubakarsadiq has quit [Quit: Connection closed for inactivity]

01:31 zeropoint has quit [Quit: leaving]

01:44 jamesob4 has joined #bitcoin-core-dev

01:45 jamesob has quit [Read error: Connection reset by peer]

01:45 jamesob4 is now known as jamesob

01:52 <bitcoin-git> [bitcoin] xiaoxianBoy opened pull request #29762: chore: fix typos (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/29762

03:03 asher has quit [Quit: Leaving]

03:14 brunoerg has joined #bitcoin-core-dev

03:19 brunoerg has quit [Ping timeout: 255 seconds]

03:27 preimage has quit [Quit: WeeChat 4.2.1]

03:41 vasild has quit [Remote host closed the connection]

03:41 vasild has joined #bitcoin-core-dev

04:00 kouloumos has quit [Ping timeout: 256 seconds]

04:00 vasild has quit [Remote host closed the connection]

04:00 vasild has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:03 kouloumos has joined #bitcoin-core-dev

05:00 Guest14 has joined #bitcoin-core-dev

05:02 Guest14 has quit [Client Quit]

05:04 Guest14 has joined #bitcoin-core-dev

05:04 Guest14 has quit [Client Quit]

05:27 puchka has joined #bitcoin-core-dev

06:01 AaronvanW has joined #bitcoin-core-dev

06:05 Guest23 has joined #bitcoin-core-dev

06:05 Guest23 has quit [Client Quit]

06:14 bitdex has joined #bitcoin-core-dev

06:54 kevkevin has joined #bitcoin-core-dev

06:59 kevkevin has quit [Ping timeout: 268 seconds]

07:08 <bitcoin-git> [bitcoin] maflcko closed pull request #29762: chore: fix typos (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/29762

08:13 kevkevin has joined #bitcoin-core-dev

08:18 kevkevin has quit [Ping timeout: 256 seconds]

08:34 <bitcoin-git> [bitcoin] laanwj opened pull request #29764: doc: Suggest installing dev packages for debian/ubuntu qt5 build (master...2024-03-debian-qt5-dep) https://github.com/bitcoin/bitcoin/pull/29764

08:36 conman has quit [Quit: Konversation terminated!]

08:52 Guyver2 has joined #bitcoin-core-dev

09:04 AaronvanW has quit [Remote host closed the connection]

09:17 AaronvanW has joined #bitcoin-core-dev

09:38 Guyver2 has left #bitcoin-core-dev [Closing Window]

10:25 gribble has quit [Remote host closed the connection]

10:28 AaronvanW has quit [Quit: Leaving...]

10:30 gribble has joined #bitcoin-core-dev

10:30 gribble has quit [Remote host closed the connection]

10:34 gribble has joined #bitcoin-core-dev

10:34 gribble has quit [Remote host closed the connection]

10:38 gribble has joined #bitcoin-core-dev

10:40 <bitcoin-git> [bitcoin] ryanofsky pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/d1e9a0212663...4373414d26ff

10:40 <bitcoin-git> bitcoin/master ef67458 Ava Chow: key: Add constructor for CExtKey that takes CExtPubKey and CKey

10:40 <bitcoin-git> bitcoin/master fe67841 Ava Chow: descriptor: Be able to get the pubkeys involved in a descriptor

10:40 <bitcoin-git> bitcoin/master fa6a259 Ava Chow: desc spkm: Add functions to retrieve specific private keys

10:40 <bitcoin-git> [bitcoin] ryanofsky merged pull request #29130: wallet: Add `createwalletdescriptor` and `gethdkeys` RPCs for adding new automatically generated descriptors (master...createwalletdescriptor-without-new-records) https://github.com/bitcoin/bitcoin/pull/29130

10:42 gribble has quit [Remote host closed the connection]

10:48 AaronvanW has joined #bitcoin-core-dev

10:49 AaronvanW has quit [Remote host closed the connection]

10:54 gribble has joined #bitcoin-core-dev

11:07 kevkevin has joined #bitcoin-core-dev

11:09 puchka has quit [Ping timeout: 272 seconds]

11:09 <vasild> this github CI job failed: https://github.com/bitcoin/bitcoin/actions/runs/8480127840/job/23235305043?pr=29415#step:7:1447 because a new file I added is not found. I double checked that I have not forgotten to commit it. I guess it is using some cache from a previous build which lacks the newly added file? If that is the case how should I resolve it?

11:12 kevkevin has quit [Ping timeout: 260 seconds]

11:30 Guest78 has joined #bitcoin-core-dev

11:36 <maflcko> vasild: Are you sure you also added it to the build system?

11:36 <vasild> ufff :)

11:37 Guest78 has quit [Quit: Client closed]

11:37 <vasild> I am sure I did not :P

11:37 <maflcko> cmake fixes this, but for now, you should be able to reproduce by doing an out-of-tree build

11:40 <hebasto> :D

11:41 <vasild> repushed, thanks!

12:03 mudsip has joined #bitcoin-core-dev

12:05 mudsip has quit [Client Quit]

12:27 preimage has joined #bitcoin-core-dev

13:00 kevkevin has joined #bitcoin-core-dev

13:05 kevkevin has quit [Ping timeout: 256 seconds]

13:05 bob_x4 has quit [Remote host closed the connection]

13:06 preimage has quit [Ping timeout: 268 seconds]

13:07 bob_x4 has joined #bitcoin-core-dev

13:15 kevkevin has joined #bitcoin-core-dev

13:20 kevkevin has quit [Ping timeout: 255 seconds]

13:22 brunoerg has joined #bitcoin-core-dev

14:02 the_mariner has quit [Ping timeout: 252 seconds]

14:18 vasild has quit [Ping timeout: 260 seconds]

14:20 vasild has joined #bitcoin-core-dev

14:22 <bitcoin-git> [bitcoin] maflcko opened pull request #29765: ci: Use clang-18 (master...2403-clang-18-) https://github.com/bitcoin/bitcoin/pull/29765

14:27 kevkevin has joined #bitcoin-core-dev

14:38 kevkevin has quit [Remote host closed the connection]

14:40 kevkevin has joined #bitcoin-core-dev

14:46 <bitcoin-git> [gui] furszy opened pull request #812: gui: fix create unsigned transaction fee bump (master...2024_gui_fix_create_unsigned_tx_fee_bump) https://github.com/bitcoin-core/gui/pull/812

14:48 bugs_ has joined #bitcoin-core-dev

15:14 brunoerg has quit [Remote host closed the connection]

15:21 kevkevin has quit [Remote host closed the connection]

15:47 vasild has quit [Ping timeout: 260 seconds]

15:48 brunoerg has joined #bitcoin-core-dev

15:48 brunoerg has quit [Remote host closed the connection]

15:49 vasild has joined #bitcoin-core-dev

15:51 kevkevin has joined #bitcoin-core-dev

15:56 kevkevin has quit [Ping timeout: 260 seconds]

15:59 vasild has quit [Remote host closed the connection]

15:59 vasild has joined #bitcoin-core-dev

16:01 kevkevin has joined #bitcoin-core-dev

16:04 zeropoint has joined #bitcoin-core-dev

16:07 kevkevin has quit [Ping timeout: 268 seconds]

16:13 kevkevin has joined #bitcoin-core-dev

16:24 ___nick___ has joined #bitcoin-core-dev

16:54 vasild has quit [Remote host closed the connection]

16:54 vasild has joined #bitcoin-core-dev

17:18 brunoerg has joined #bitcoin-core-dev

17:46 kevkevin has quit [Remote host closed the connection]

17:49 ___nick___ has quit [Ping timeout: 252 seconds]

17:49 ___nick___ has joined #bitcoin-core-dev

18:05 kevkevin has joined #bitcoin-core-dev

18:30 ___nick___ has quit [Ping timeout: 260 seconds]

18:33 ___nick___ has joined #bitcoin-core-dev

18:51 <instagibbs> achow101 #29724 rmf I think

18:51 <gribble> https://github.com/bitcoin/bitcoin/issues/29724 | 29242 Diagram check followups by instagibbs · Pull Request #29724 · bitcoin/bitcoin · GitHub

18:52 brunoerg has quit [Remote host closed the connection]

18:55 brunoerg has joined #bitcoin-core-dev

19:05 brunoerg has quit [Remote host closed the connection]

19:06 brunoerg has joined #bitcoin-core-dev

19:15 Cache_Money has joined #bitcoin-core-dev

19:17 brunoerg has quit [Remote host closed the connection]

19:18 brunoerg has joined #bitcoin-core-dev

19:20 Guest19 has joined #bitcoin-core-dev

19:25 Cache_Money has quit [Quit: Client closed]

19:27 Cache_Money has joined #bitcoin-core-dev

19:27 Cache_Money has quit [Write error: Broken pipe]

19:27 brunoerg has quit [Remote host closed the connection]

19:28 brunoerg has joined #bitcoin-core-dev

19:28 Cache_Money has joined #bitcoin-core-dev

19:35 kevkevin has quit [Remote host closed the connection]

19:35 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

19:37 ___nick___ has joined #bitcoin-core-dev

19:39 ___nick___ has quit [Client Quit]

19:41 ___nick___ has joined #bitcoin-core-dev

19:46 Guest19 has quit [Quit: Client closed]

19:53 brunoerg has quit [Remote host closed the connection]

19:55 brunoerg has joined #bitcoin-core-dev

20:00 brunoerg has quit [Ping timeout: 256 seconds]

20:02 yonson has quit [Remote host closed the connection]

20:04 yonson has joined #bitcoin-core-dev

20:26 bitdex has quit [Ping timeout: 260 seconds]

20:27 kevkevin has joined #bitcoin-core-dev

20:29 bitdex has joined #bitcoin-core-dev

20:33 brunoerg has joined #bitcoin-core-dev

20:33 kevkevin has quit [Ping timeout: 260 seconds]

20:35 AaronvanW has joined #bitcoin-core-dev

20:56 brunoerg has quit [Remote host closed the connection]

20:57 brunoerg has joined #bitcoin-core-dev

20:58 AaronvanW has quit [Quit: Leaving...]

21:01 brunoerg has quit [Remote host closed the connection]

21:04 ___nick___ has quit [Ping timeout: 268 seconds]

21:05 kevkevin has joined #bitcoin-core-dev

21:09 brunoerg has joined #bitcoin-core-dev

21:11 kevkevin has quit [Ping timeout: 260 seconds]

21:12 Cache_Money has quit [Ping timeout: 250 seconds]

21:18 brunoerg has quit [Ping timeout: 268 seconds]

21:27 cm_ has joined #bitcoin-core-dev

21:28 cm has quit [Ping timeout: 268 seconds]

21:28 cm_ is now known as cm

21:30 kevkevin has joined #bitcoin-core-dev

21:34 kevkevin has quit [Ping timeout: 240 seconds]

21:37 Randolf has joined #bitcoin-core-dev

21:42 cm has quit [Ping timeout: 255 seconds]

21:43 cm has joined #bitcoin-core-dev

21:45 kevkevin has joined #bitcoin-core-dev

21:50 kevkevin has quit [Ping timeout: 260 seconds]

22:02 conman has joined #bitcoin-core-dev

22:07 rolf has joined #bitcoin-core-dev

22:10 bugs_ has quit [Quit: Leaving]

22:13 Talkless has joined #bitcoin-core-dev

22:38 kevkevin has joined #bitcoin-core-dev

22:45 kevkevin has quit [Ping timeout: 268 seconds]

22:49 Talkless has quit [Ping timeout: 268 seconds]

22:56 bitdex has quit [Ping timeout: 260 seconds]

22:58 bitdex has joined #bitcoin-core-dev

22:59 bitdex has quit [Remote host closed the connection]

23:00 bitdex has joined #bitcoin-core-dev

23:04 bitdex has quit [Remote host closed the connection]

23:05 bitdex has joined #bitcoin-core-dev

23:12 kevkevin has joined #bitcoin-core-dev

23:21 kevkevin has quit [Ping timeout: 268 seconds]

23:24 the_mariner has joined #bitcoin-core-dev

23:29 kevkevin has joined #bitcoin-core-dev

23:46 the_mariner has quit [Ping timeout: 268 seconds]

23:53 <bitcoin-git> [bitcoin] achow101 pushed 18 commits to master: https://github.com/bitcoin/bitcoin/compare/4373414d26ff...61de64df6790

23:53 <bitcoin-git> bitcoin/master bb42402 Greg Sanders: doc: fix comment about non-existing CompareFeeFrac

23:53 <bitcoin-git> bitcoin/master b62e2c0 Greg Sanders: ImprovesFeerateDiagram: Spelling fix and removal of unused diagram vectors

23:53 <bitcoin-git> bitcoin/master c0c37f0 Greg Sanders: unit test: have CompareFeerateDiagram tested with diagrams both ways

23:53 <bitcoin-git> [bitcoin] achow101 merged pull request #29724: 29242 Diagram check followups (master...2024-03-diagram-followups) https://github.com/bitcoin/bitcoin/pull/29724