#bitcoin-core-dev on 2024-06-19 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:13 preimage has quit [Quit: WeeChat 4.3.2]

00:13 preimage has joined #bitcoin-core-dev

00:39 saffi48 has quit [Quit: Leaving.]

00:43 jon_atack has joined #bitcoin-core-dev

00:44 jonatack has quit [Ping timeout: 264 seconds]

00:47 mcey_ has joined #bitcoin-core-dev

00:48 emcy__ has joined #bitcoin-core-dev

00:50 mcey has quit [Ping timeout: 264 seconds]

00:52 mcey_ has quit [Ping timeout: 268 seconds]

01:00 kevkevin has quit [Remote host closed the connection]

01:02 mudsip has joined #bitcoin-core-dev

01:08 ThePlebRoad has joined #bitcoin-core-dev

01:17 BUSY has joined #bitcoin-core-dev

01:21 Mxthecomputerfox has joined #bitcoin-core-dev

01:22 kevkevin has joined #bitcoin-core-dev

01:27 kevkevin has quit [Ping timeout: 256 seconds]

01:35 zeropoint has quit [Quit: leaving]

01:40 Mxthecomputerfox has quit [Quit: Leaving]

01:41 Torr has quit [Quit: Torr]

01:46 preimage has quit [Quit: WeeChat 4.3.2]

02:00 kevkevin has joined #bitcoin-core-dev

02:05 kevkevin has quit [Ping timeout: 264 seconds]

02:08 mudsip has quit []

02:10 kevkevin has joined #bitcoin-core-dev

02:24 mudsip has joined #bitcoin-core-dev

02:24 mudsip has quit [Client Quit]

02:24 mudsip has joined #bitcoin-core-dev

02:25 mudsip has quit [Client Quit]

02:48 marsupialSoup has joined #bitcoin-core-dev

02:53 marsupialSoup has quit [Ping timeout: 268 seconds]

03:49 Earnestly has quit [Read error: Connection reset by peer]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:03 kevkevin has quit [Remote host closed the connection]

04:15 kevkevin has joined #bitcoin-core-dev

04:15 marsupialSoup has joined #bitcoin-core-dev

04:20 marsupialSoup has quit [Ping timeout: 260 seconds]

04:31 hax0kartik has joined #bitcoin-core-dev

04:35 vasild has quit [Remote host closed the connection]

04:36 vasild has joined #bitcoin-core-dev

04:44 hax0kartik has quit [Changing host]

04:44 hax0kartik has joined #bitcoin-core-dev

04:45 <hax0kartik> Hello, I was going through the PSBT deserialization code and I had a small question. I hope this is the right place to ask it.

04:46 <hax0kartik> My question is that why do we not set range_check to false when reading the keytype here?

04:46 <hax0kartik> https://github.com/bitcoin/bitcoin/blob/master/src/psbt.h#L815

04:46 <hax0kartik> From what I understand, "keytype" should qualify as a "generic number", why is this not the case?

05:09 marsupialSoup has joined #bitcoin-core-dev

05:14 kevkevin has quit [Remote host closed the connection]

05:17 marsupia1 has joined #bitcoin-core-dev

05:19 marsupialSoup has quit [Ping timeout: 268 seconds]

05:32 marsupia1 has quit [Quit: WeeChat 4.3.0]

05:38 hax0kartik has quit [Ping timeout: 268 seconds]

05:45 kevkevin has joined #bitcoin-core-dev

05:50 kevkevin has quit [Ping timeout: 268 seconds]

06:04 jonatack has joined #bitcoin-core-dev

06:04 jon_atack has quit [Ping timeout: 264 seconds]

06:16 oneeyedalien has joined #bitcoin-core-dev

06:23 kevkevin has joined #bitcoin-core-dev

06:29 kevkevin has quit [Ping timeout: 246 seconds]

06:36 <achow101> hax0kartik: the psbt code was written before that option existed.

06:42 oneeyedalien has quit [Quit: Leaving]

07:00 kevkevin has joined #bitcoin-core-dev

07:06 kevkevin has quit [Ping timeout: 260 seconds]

07:19 kevkevin has joined #bitcoin-core-dev

07:24 kevkevin has quit [Ping timeout: 268 seconds]

07:36 kevkevin has joined #bitcoin-core-dev

07:45 kevkevin has quit [Ping timeout: 256 seconds]

07:59 kevkevin has joined #bitcoin-core-dev

08:03 kevkevin has quit [Ping timeout: 246 seconds]

08:07 Guyver2 has joined #bitcoin-core-dev

08:08 hax0kartik has joined #bitcoin-core-dev

08:10 Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]

08:15 hax0kartik has quit [Changing host]

08:15 hax0kartik has joined #bitcoin-core-dev

08:15 <hax0kartik> achow101: yes, I am aware but I am not sure why "type" needs to be range checked at all

08:18 kevkevin has joined #bitcoin-core-dev

08:19 jon_atack has joined #bitcoin-core-dev

08:20 jonatack has quit [Ping timeout: 255 seconds]

08:20 jonatack has joined #bitcoin-core-dev

08:22 kevkevin has quit [Ping timeout: 260 seconds]

08:23 jon_atack has quit [Ping timeout: 246 seconds]

08:34 Earnestly has joined #bitcoin-core-dev

08:34 kevkevin has joined #bitcoin-core-dev

08:39 hax0kartik has quit [Ping timeout: 272 seconds]

08:40 kevkevin has quit [Ping timeout: 268 seconds]

08:44 Unknown404 has joined #bitcoin-core-dev

08:44 ThePlebRoad has quit [Read error: Connection reset by peer]

08:45 ThePlebRoad has joined #bitcoin-core-dev

08:45 Unknown404 has quit [Read error: Connection reset by peer]

08:45 ThePlebRoad has quit [Read error: Connection reset by peer]

08:46 Earnestly has quit [Quit: WeeChat 4.3.0-dev]

08:47 Earnestly has joined #bitcoin-core-dev

08:47 hax0kartik has joined #bitcoin-core-dev

08:52 hax0kartik has quit [Ping timeout: 256 seconds]

08:53 kevkevin has joined #bitcoin-core-dev

09:00 kevkevin has quit [Ping timeout: 256 seconds]

09:09 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c5cdf07f30f...ac4ea782af20

09:09 <bitcoin-git> bitcoin/master 8acdf66 Cory Fields: upnp: add compatibility for miniupnpc 2.2.8

09:09 <bitcoin-git> bitcoin/master ac4ea78 merge-script: Merge bitcoin/bitcoin#30283: upnp: fix build with miniupnpc 2.2.8

09:09 <bitcoin-git> [bitcoin] fanquake merged pull request #30283: upnp: fix build with miniupnpc 2.2.8 (master...fix-upnp-228) https://github.com/bitcoin/bitcoin/pull/30283

09:12 kevkevin has joined #bitcoin-core-dev

09:13 <bitcoin-git> [bitcoin] fanquake opened pull request #30305: [27.x] More backports (27.x...more_27_backports) https://github.com/bitcoin/bitcoin/pull/30305

09:15 jon_atack has joined #bitcoin-core-dev

09:16 jonatack has quit [Ping timeout: 268 seconds]

09:17 kevkevin has quit [Ping timeout: 256 seconds]

09:17 <bitcoin-git> [bitcoin] dergoegge opened pull request #30306: fuzz: Improve stability for txorphan and mini_miner harnesses (master...2024-06-itercomp-stab) https://github.com/bitcoin/bitcoin/pull/30306

09:19 jonatack has joined #bitcoin-core-dev

09:19 jon_atack has quit [Ping timeout: 268 seconds]

09:30 kevkevin has joined #bitcoin-core-dev

09:35 kevkevin has quit [Ping timeout: 260 seconds]

09:37 hax0kartik has joined #bitcoin-core-dev

09:48 kevkevin has joined #bitcoin-core-dev

09:51 hax0kartik has quit [Ping timeout: 260 seconds]

09:52 jonatack has quit [Ping timeout: 264 seconds]

09:53 hax0kartik has joined #bitcoin-core-dev

09:53 kevkevin has quit [Ping timeout: 268 seconds]

09:54 jonatack has joined #bitcoin-core-dev

09:58 jon_atack has joined #bitcoin-core-dev

10:00 jonatack has quit [Ping timeout: 252 seconds]

10:07 kevkevin has joined #bitcoin-core-dev

10:12 kevkevin has quit [Ping timeout: 240 seconds]

10:15 jonatack has joined #bitcoin-core-dev

10:15 jon_atack has quit [Ping timeout: 252 seconds]

10:23 jonatack has quit [Ping timeout: 256 seconds]

10:23 jonatack has joined #bitcoin-core-dev

10:25 kevkevin has joined #bitcoin-core-dev

10:29 katsu has quit [Quit: disconnected]

10:29 katsu_ has joined #bitcoin-core-dev

10:30 kevkevin has quit [Ping timeout: 246 seconds]

10:41 jonatack has quit [Ping timeout: 256 seconds]

10:42 jonatack has joined #bitcoin-core-dev

10:44 jonatack has quit [Excess Flood]

10:44 kevkevin has joined #bitcoin-core-dev

10:44 jonatack has joined #bitcoin-core-dev

10:49 kevkevin has quit [Ping timeout: 268 seconds]

10:54 pablomartin has joined #bitcoin-core-dev

10:54 jon_atack has joined #bitcoin-core-dev

10:55 jonatack has quit [Ping timeout: 272 seconds]

11:02 kevkevin has joined #bitcoin-core-dev

11:07 kevkevin has quit [Ping timeout: 260 seconds]

11:08 jonatack has joined #bitcoin-core-dev

11:10 jon_atack has quit [Ping timeout: 272 seconds]

11:21 kevkevin has joined #bitcoin-core-dev

11:24 vasild has quit [Ping timeout: 260 seconds]

11:25 <bitcoin-git> [qa-assets] marcofleon opened pull request #190: Initial vecdeque inputs (main...2024/06/add-vecdeque-inputs) https://github.com/bitcoin-core/qa-assets/pull/190

11:26 vasild has joined #bitcoin-core-dev

11:26 kevkevin has quit [Ping timeout: 268 seconds]

11:32 kartik_ has joined #bitcoin-core-dev

11:33 <bitcoin-git> [bitcoin] maflcko opened pull request #30307: fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error (master...2406-fuzz-wallet-bdb-32) https://github.com/bitcoin/bitcoin/pull/30307

11:35 hax0kartik has quit [Ping timeout: 268 seconds]

11:39 kevkevin has joined #bitcoin-core-dev

11:41 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac4ea782af20...2d21060af831

11:42 <bitcoin-git> bitcoin/master 4ccb3d6 Greg Sanders: fuzz: have package_rbf always make small txns

11:42 <bitcoin-git> bitcoin/master 2d21060 glozow: Merge bitcoin/bitcoin#30300: fuzz: have package_rbf always make small txns

11:42 <bitcoin-git> [bitcoin] glozow merged pull request #30300: fuzz: have package_rbf always make small txns (master...2024-06-package_rbf_fuzz_impr) https://github.com/bitcoin/bitcoin/pull/30300

11:43 josie_ has joined #bitcoin-core-dev

11:43 kevkevin has quit [Ping timeout: 260 seconds]

11:44 josie has quit [Ping timeout: 268 seconds]

11:44 BrandonOdiwuor has joined #bitcoin-core-dev

11:48 jon_atack has joined #bitcoin-core-dev

11:50 jonatack has quit [Ping timeout: 272 seconds]

11:51 puchka has quit [Ping timeout: 264 seconds]

11:55 jonatack has joined #bitcoin-core-dev

11:57 jon_atack has quit [Ping timeout: 264 seconds]

11:58 kevkevin has joined #bitcoin-core-dev

11:58 puchka has joined #bitcoin-core-dev

12:03 kevkevin has quit [Ping timeout: 240 seconds]

12:10 <vasild> hebasto: cmake/script/Coverage.cmake contains "if(EXTENDED_FUNCTIONAL_TESTS)" but that is the only reference to EXTENDED_FUNCTIONAL_TESTS (modulo Makefile.am and configure.ac). How is the user supposed to enable that?

12:30 jonatack has quit [Read error: Connection reset by peer]

12:30 jonatack has joined #bitcoin-core-dev

12:31 kevkevin has joined #bitcoin-core-dev

12:31 saffi48 has joined #bitcoin-core-dev

12:33 kartik_ has quit [Remote host closed the connection]

12:34 kartik_ has joined #bitcoin-core-dev

12:38 kartik_ has quit [Ping timeout: 256 seconds]

12:41 emcy__ has quit [Remote host closed the connection]

12:41 emcy__ has joined #bitcoin-core-dev

12:52 pablomartin has quit [Ping timeout: 268 seconds]

12:56 <hebasto> `cmake -DEXTENDED_FUNCTIONAL_TESTS=YES -P build/Coverage.cmake`

13:02 <vasild> hmm, ok, I guess it does not have to be defined in CMakeLists.txt

13:03 <hebasto> it is supposed to be defined by a user

13:17 saffi48 has quit [Changing host]

13:17 saffi48 has joined #bitcoin-core-dev

13:18 emcy__ has quit [Ping timeout: 252 seconds]

13:19 mcey has joined #bitcoin-core-dev

13:24 <vasild> hebasto: when using ninja multi-config, only RelWithDebInfo was build. Now, I guess that means from Coverage.cmake when that is execued as a script with cmake -P it should invoke ctest -C RelWithDebInfo, but I am struggling to retrieve that "RelWithDebInfo" from Coverage.cmake...

13:26 <vasild> all of CMAKE_DEFAULT_CONFIGS, CMAKE_CROSS_CONFIGS, CMAKE_DEFAULT_BUILD_TYPE, CMAKE_CONFIGURATION_TYPES, CMAKE_BUILD_TYPE are empty when I query them from Coverage.cmake :/

13:27 <hebasto> a script no nothing about configuration context

13:27 <hebasto> *know

13:27 <hebasto> *knows

13:27 <vasild> :|

13:33 pablomartin has joined #bitcoin-core-dev

13:34 bugs_ has joined #bitcoin-core-dev

13:55 jon_atack has joined #bitcoin-core-dev

13:57 kevkevin has quit [Remote host closed the connection]

13:57 jonatack has quit [Ping timeout: 252 seconds]

14:00 kevkevin has joined #bitcoin-core-dev

14:03 mudsip has joined #bitcoin-core-dev

14:04 mudsip has quit [Client Quit]

14:05 kevkevin has quit [Ping timeout: 268 seconds]

14:09 jonatack has joined #bitcoin-core-dev

14:11 jon_atack has quit [Ping timeout: 268 seconds]

14:20 kevkevin has joined #bitcoin-core-dev

14:21 Guyver2 has joined #bitcoin-core-dev

14:30 pablomartin4btc has joined #bitcoin-core-dev

14:31 pablomartin has quit [Ping timeout: 268 seconds]

15:00 <bitcoin-git> [bitcoin] luke-jr opened pull request #30308: QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core" (master...qa_feature_settings_pkgname) https://github.com/bitcoin/bitcoin/pull/30308

15:12 someone235 has joined #bitcoin-core-dev

15:24 mcey has quit [Read error: Connection reset by peer]

15:24 mcey has joined #bitcoin-core-dev

15:37 <bitcoin-git> [bitcoin] 0xB10C closed pull request #30112: rpc: introduce getversion RPC (master...2024-05-getversion-rpc) https://github.com/bitcoin/bitcoin/pull/30112

16:25 pablomartin4btc_ has joined #bitcoin-core-dev

16:27 pablomartin4btc has quit [Read error: Connection reset by peer]

16:34 saffi48 has quit [Ping timeout: 272 seconds]

16:48 noonien808310429 has joined #bitcoin-core-dev

16:51 saffi48 has joined #bitcoin-core-dev

17:15 pablomartin4btc_ has quit [Ping timeout: 240 seconds]

17:17 _andrewtoth_ has joined #bitcoin-core-dev

17:17 lbia has quit [Ping timeout: 252 seconds]

17:23 saffi48 has quit [Quit: Leaving.]

17:23 Talkless has joined #bitcoin-core-dev

17:26 saffi48 has joined #bitcoin-core-dev

17:31 saffi48 has quit [Ping timeout: 268 seconds]

17:35 <bitcoin-git> [bitcoin] furszy opened pull request #30309: wallet: notify when preset + automatic inputs exceed max weight (master...2024_wallet_max_weight) https://github.com/bitcoin/bitcoin/pull/30309

17:41 someone235 has quit [Quit: Connection closed for inactivity]

17:44 kevkevin has quit [Remote host closed the connection]

17:46 kevkevin has joined #bitcoin-core-dev

17:46 saffi48 has joined #bitcoin-core-dev

17:49 BrandonOdiwuor has quit [Quit: Client closed]

17:51 zeropoint has joined #bitcoin-core-dev

18:15 jon_atack has joined #bitcoin-core-dev

18:15 jonatack has quit [Ping timeout: 264 seconds]

18:22 saffi48 has quit [Ping timeout: 264 seconds]

18:34 Guyver2 has left #bitcoin-core-dev [Closing Window]

18:40 gribble has quit [Remote host closed the connection]

18:46 gribble has joined #bitcoin-core-dev

18:47 lbia has joined #bitcoin-core-dev

18:48 <bitcoin-git> [bitcoin] m3dwards opened pull request #30310: ci: add option for running tests without volume (master...240519-ci-gha-no-volume) https://github.com/bitcoin/bitcoin/pull/30310

19:05 pablomartin has joined #bitcoin-core-dev

19:06 Talkless has quit [Remote host closed the connection]

19:13 _andrewtoth_ has quit [Ping timeout: 260 seconds]

19:15 jamesob has quit [Ping timeout: 252 seconds]

19:30 _andrewtoth_ has joined #bitcoin-core-dev

20:00 saffi48 has joined #bitcoin-core-dev

20:04 kevkevin has quit [Remote host closed the connection]

20:28 saffi48 has quit [Quit: Leaving.]

20:34 kevkevin has joined #bitcoin-core-dev

20:36 saffi48 has joined #bitcoin-core-dev

20:41 saffi48 has quit [Ping timeout: 268 seconds]

20:54 saffi48 has joined #bitcoin-core-dev

21:07 mcey has quit [Ping timeout: 272 seconds]

21:18 mcey has joined #bitcoin-core-dev

21:19 pablomartin has quit [Ping timeout: 240 seconds]

21:21 mcey_ has joined #bitcoin-core-dev

21:24 mcey has quit [Ping timeout: 246 seconds]

21:25 mcey_ has quit [Client Quit]

21:45 lbia has quit [Ping timeout: 255 seconds]

21:48 jonatack has joined #bitcoin-core-dev

21:49 jon_atack has quit [Ping timeout: 255 seconds]

21:56 saffi48 has quit [Quit: Leaving.]

22:07 kevkevin has quit [Remote host closed the connection]

22:07 sohrab has quit [Ping timeout: 264 seconds]

22:09 S3RK has quit [Ping timeout: 255 seconds]

22:11 S3RK has joined #bitcoin-core-dev

22:27 saffi48 has joined #bitcoin-core-dev

22:31 _andrewtoth_ has quit [Ping timeout: 260 seconds]

22:37 kevkevin has joined #bitcoin-core-dev

22:42 bugs_ has quit [Quit: Leaving]

22:43 kevkevin has quit [Ping timeout: 246 seconds]

22:46 S3RK has quit [Ping timeout: 264 seconds]

22:46 S3RK has joined #bitcoin-core-dev

22:47 lbia has joined #bitcoin-core-dev

22:48 _andrewtoth_ has joined #bitcoin-core-dev

22:54 saffi48 has quit [Quit: Leaving.]

22:58 S3RK has quit [Ping timeout: 264 seconds]

23:04 lbia has quit [Ping timeout: 255 seconds]

23:08 S3RK has joined #bitcoin-core-dev

23:13 mcey has joined #bitcoin-core-dev

23:15 kevkevin has joined #bitcoin-core-dev

23:20 kevkevin has quit [Ping timeout: 260 seconds]

23:27 lbia has joined #bitcoin-core-dev

23:45 _andrewtoth_ has quit [Ping timeout: 260 seconds]

23:49 kevkevin has joined #bitcoin-core-dev

23:58 kevkevin has quit [Ping timeout: 268 seconds]