00:11
kevkevin has joined #bitcoin-core-dev
00:11
puchka has quit [Ping timeout: 264 seconds]
00:15
kevkevin has quit [Ping timeout: 255 seconds]
00:17
puchka has joined #bitcoin-core-dev
00:30
kevkevin has joined #bitcoin-core-dev
00:35
kevkevin has quit [Ping timeout: 268 seconds]
00:47
kevkevin has joined #bitcoin-core-dev
00:53
kevkevin has quit [Ping timeout: 260 seconds]
01:02
kevkevin has joined #bitcoin-core-dev
01:08
kevkevin has quit [Ping timeout: 268 seconds]
01:17
zeropoint has quit [Quit: leaving]
01:19
Torr has joined #bitcoin-core-dev
01:20
kevkevin has joined #bitcoin-core-dev
01:26
kevkevin has quit [Ping timeout: 272 seconds]
01:38
kevkevin has joined #bitcoin-core-dev
01:45
kevkevin has quit [Ping timeout: 268 seconds]
01:51
kevkevin has joined #bitcoin-core-dev
02:03
Torr has quit [Quit: Torr]
02:19
puchka has quit [Ping timeout: 256 seconds]
02:24
puchka has joined #bitcoin-core-dev
02:28
kevkevin has quit [Remote host closed the connection]
02:58
kevkevin has joined #bitcoin-core-dev
02:58
bitdex has joined #bitcoin-core-dev
04:01
cmirror has quit [Remote host closed the connection]
04:01
cmirror has joined #bitcoin-core-dev
04:18
mcey has quit [Ping timeout: 268 seconds]
04:23
mcey has joined #bitcoin-core-dev
04:44
Guest87 has joined #bitcoin-core-dev
04:45
Guest87 has quit [Client Quit]
04:50
kevkevin has quit [Remote host closed the connection]
05:17
nanotube has quit [Ping timeout: 264 seconds]
05:20
kevkevin has joined #bitcoin-core-dev
05:24
cryptapus has quit [Remote host closed the connection]
05:24
cryptapus has joined #bitcoin-core-dev
05:25
kevkevin has quit [Ping timeout: 246 seconds]
05:40
kevkevin has joined #bitcoin-core-dev
05:44
kevkevin has quit [Ping timeout: 264 seconds]
05:57
Hash has joined #bitcoin-core-dev
06:04
aleggg has quit [Ping timeout: 268 seconds]
06:05
aleggg has joined #bitcoin-core-dev
06:09
Hash has quit [Quit: Client closed]
06:29
gmaxwell has joined #bitcoin-core-dev
07:35
Guyver2 has joined #bitcoin-core-dev
07:37
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
07:39
jonatack has quit [Ping timeout: 264 seconds]
07:42
jonatack has joined #bitcoin-core-dev
08:03
abubakarsadiq has joined #bitcoin-core-dev
08:20
kevkevin has joined #bitcoin-core-dev
08:25
kevkevin has quit [Ping timeout: 260 seconds]
08:37
kevkevin has joined #bitcoin-core-dev
08:43
kevkevin has quit [Ping timeout: 268 seconds]
08:45
pablomartin has joined #bitcoin-core-dev
08:46
<
bitcoin-git >
bitcoin/master fa9cb10 MarcoFalke: refactor: Add explicit cast to expected_last_page to silence fuzz ISan
08:46
<
bitcoin-git >
bitcoin/master c6de072 merge-script: Merge bitcoin/bitcoin#30248: refactor: Add explicit cast to expected_last_...
08:53
<
bitcoin-git >
bitcoin/master fa7bc9b MarcoFalke: fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error
08:53
<
bitcoin-git >
bitcoin/master aa2ce2d merge-script: Merge bitcoin/bitcoin#30307: fuzz: Fix wallet_bdb_parser 32-bit unhandled ...
08:56
kevkevin has joined #bitcoin-core-dev
09:01
kevkevin has quit [Ping timeout: 246 seconds]
09:07
katsu_ is now known as katsu
09:15
kevkevin has joined #bitcoin-core-dev
09:21
kevkevin has quit [Ping timeout: 264 seconds]
09:23
mudsip has joined #bitcoin-core-dev
09:23
mudsip has quit [Client Quit]
09:24
puchka has quit [Ping timeout: 268 seconds]
09:28
puchka has joined #bitcoin-core-dev
09:35
kevkevin has joined #bitcoin-core-dev
09:41
kevkevin has quit [Ping timeout: 268 seconds]
09:51
kevkevin has joined #bitcoin-core-dev
09:54
vyHamii has quit [Ping timeout: 272 seconds]
09:56
kevkevin has quit [Ping timeout: 268 seconds]
10:09
kevkevin has joined #bitcoin-core-dev
10:15
kevkevin has quit [Ping timeout: 256 seconds]
10:28
kevkevin has joined #bitcoin-core-dev
10:33
Guest9 has joined #bitcoin-core-dev
10:33
kevkevin has quit [Ping timeout: 272 seconds]
10:34
Guest9 has quit [Client Quit]
10:46
kevkevin has joined #bitcoin-core-dev
10:51
kevkevin has quit [Ping timeout: 255 seconds]
11:18
kevkevin has joined #bitcoin-core-dev
11:24
kevkevin has quit [Ping timeout: 268 seconds]
11:34
Guest41 has joined #bitcoin-core-dev
11:34
jonatack has quit [Ping timeout: 256 seconds]
11:35
Guest41 has quit [Client Quit]
11:38
kevkevin has joined #bitcoin-core-dev
11:43
kevkevin has quit [Ping timeout: 260 seconds]
11:46
jonatack has joined #bitcoin-core-dev
12:11
puchka has quit [Ping timeout: 268 seconds]
12:12
kevkevin has joined #bitcoin-core-dev
12:13
puchka has joined #bitcoin-core-dev
12:18
kevkevin has quit [Ping timeout: 264 seconds]
12:20
mcey_ has joined #bitcoin-core-dev
12:23
emcy__ has joined #bitcoin-core-dev
12:23
mcey has quit [Ping timeout: 246 seconds]
12:26
mcey_ has quit [Ping timeout: 268 seconds]
12:27
mcey_ has joined #bitcoin-core-dev
12:30
pablomartin has quit [Ping timeout: 256 seconds]
12:31
emcy__ has quit [Ping timeout: 268 seconds]
12:32
kevkevin has joined #bitcoin-core-dev
12:37
bitdex has quit [Quit: = ""]
12:48
mcey_ has quit [Ping timeout: 264 seconds]
12:50
mcey has joined #bitcoin-core-dev
12:54
jon_atack has joined #bitcoin-core-dev
12:55
kevkevin has quit [Remote host closed the connection]
12:56
kevkevin has joined #bitcoin-core-dev
12:56
kevkevin has quit [Remote host closed the connection]
12:57
jonatack has quit [Ping timeout: 272 seconds]
12:57
kevkevin has joined #bitcoin-core-dev
13:05
jon_atack has quit [Quit: WeeChat 4.3.2]
13:09
mcey has quit [Read error: Connection reset by peer]
13:10
mcey has joined #bitcoin-core-dev
13:22 _andrewtoth_ has joined #bitcoin-core-dev
13:25
jonatack has joined #bitcoin-core-dev
13:26
jonatack has quit [Read error: Connection reset by peer]
13:27
jonatack has joined #bitcoin-core-dev
13:50
<
bitcoin-git >
qa-assets/main af7edb8 marcofleon: add initial vecdeque inputs
13:50
<
bitcoin-git >
qa-assets/main d101690 Niklas Gögge: Merge pull request #190 from marcofleon/2024/06/add-vecdeque-inputs
13:56
Emc99 has joined #bitcoin-core-dev
13:57
jon_atack has joined #bitcoin-core-dev
13:59
jonatack has quit [Ping timeout: 272 seconds]
14:00
<
achow101 >
#startmeeting
14:00
<
core-meetingbot >
Available commands: action commands idea info link nick
14:00
<
achow101 >
#bitcoin-core-dev Meeting: achow101
_aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
14:00
<
achow101 >
There are no pre-proposed meeting topics this week. Any last minute ones to add?
14:01
<
achow101 >
#topic package relay updates (glozow)
14:01
<
core-meetingbot >
topic: package relay updates (glozow)
14:01
<
dergoegge >
I'm doing gloria's update today
14:01
<
dergoegge >
"I'm on holiday June 20-30. #28984 was merged. We have a couple followups (#30272 and #30295). The new priority PR is #30111."
14:01
<
dergoegge >
that's all
14:02
<
achow101 >
#topic cluster mempool updates (sdaftuar)
14:02
<
core-meetingbot >
topic: cluster mempool updates (sdaftuar)
14:02
<
vasild >
wrt #30111 I wonder if there are better than manual ways to review such threading changes
14:03
jonatack has joined #bitcoin-core-dev
14:04
<
achow101 >
vasild: the thread safety annotations should help as clang will error
14:04
<
vasild >
no, they will not help with mutex order
14:05
<
dergoegge >
we have runtime lock order checks iirc
14:05
<
dergoegge >
TSan would also complain (i think)
14:05
jon_atack has quit [Ping timeout: 264 seconds]
14:05
<
vasild >
there is some partial order support in those annotations but we don't use that at all, it is like Mutex m WILL_LOCK_AFTER(another_mutex);
14:05
<
achow101 >
there's debug_lockorder for runtime checks
14:05
<
sipa >
I don't see sdaftuar. Since last meeting I've split up #30126 (adding #30286 and #30285), and opened a tracking issue #30283.
14:06
<
sipa >
I'm also working on another writeup with a gentler introduction to the linearization algorithms why and how
14:06
<
vasild >
yes, if the lock misorder happens during execution of testing, then yes, it will crash in a good way
14:06
<
achow101 >
sipa: which one of those should we review first?
14:07
<
sipa >
achow101: see the tracking issue! 30126
14:07
marcofleon has joined #bitcoin-core-dev
14:07
<
instagibbs >
sipa could you also do a tiny writeup on teh serialization/deser strategy in the fuzz test?
14:07
<
instagibbs >
mental model of what is happening
14:08
<
sipa >
instagibbs: on the serializer format itself, or on the "why use serialization.h instead of FuzzedDataProvider"?
14:09
<
instagibbs >
former mostly (I think I handled the latter)
14:09
<
sipa >
instagibbs: sure; i'll try to write a big comment explaining it in the code
14:10
<
achow101 >
#topic legacy wallet removal updates (achow101)
14:10
<
core-meetingbot >
topic: legacy wallet removal updates (achow101)
14:10
<
achow101 >
#26596 has been getting some review
14:11
<
achow101 >
gui#824 and #30265 are also open and easier to review
14:12
<
achow101 >
#topic Ad-hoc high priority for review
14:12
<
core-meetingbot >
topic: Ad-hoc high priority for review
14:13
<
sipa >
i'd like to get some attention to #29625 (it's already on the list)
14:13
<
achow101 >
I started reviewing that and then got lost
14:14
<
sipa >
can I do something to help the lostness?
14:16
<
achow101 >
looks like there's more smaller commits now, so I think that will help
14:16
<
sipa >
yeah, several things have been split up
14:17
<
achow101 >
Any other topics to discuss?
14:20
<
achow101 >
#endmeeting
14:20
<
core-meetingbot >
Meeting ended Thu Jun 20 14:20:23 2024 UTC.
14:22
jamesob443688173 has joined #bitcoin-core-dev
14:22
jamesob1 has joined #bitcoin-core-dev
14:24
Emc99 has quit [Quit: Client closed]
14:25
preimage has joined #bitcoin-core-dev
14:25
jetpack has quit [Ping timeout: 246 seconds]
14:25
Guest0 has joined #bitcoin-core-dev
14:27
jon_atack has joined #bitcoin-core-dev
14:29
jonatack has quit [Ping timeout: 252 seconds]
14:33
Emc99 has joined #bitcoin-core-dev
14:34
Emc99 has quit [Client Quit]
14:34
marcofleon has quit [Quit: Connection closed]
14:35
pablomartin has joined #bitcoin-core-dev
14:35
Guest0 has quit [Ping timeout: 250 seconds]
14:53
Guest8 has joined #bitcoin-core-dev
14:54
Guest8 has quit [Client Quit]
15:11
puchka has quit [Ping timeout: 268 seconds]
15:13
jonatack has joined #bitcoin-core-dev
15:14
jon_atack has quit [Ping timeout: 252 seconds]
15:17
puchka has joined #bitcoin-core-dev
15:20
pablomartin has quit [Ping timeout: 264 seconds]
15:23
jonatack has quit [Ping timeout: 264 seconds]
15:25
<
vasild >
dergoegge: our lock order checks don't catch this problem: lock m1 m2, unlock all, lock m2 m3, unlock all, lock m3 m1 <-- this is a bug
15:26
jonatack has joined #bitcoin-core-dev
15:29
<
vasild >
lets say that now you are introducing mutex m3. the code before is lock m1 m2 and you add m3 plus lock m2 m3 and lock m3 m1. You have to manually find that lock m1 m2 all over the code base :/
15:31
<
vasild >
I mean, since lock m2 m3 and lock m3 m1 implies lock order m2 before m1 then the developer has to check all the code base that nowhere m1 is locked before m2.
15:32
jonatack has quit [Ping timeout: 256 seconds]
15:50
Torr has joined #bitcoin-core-dev
15:59
jonatack has joined #bitcoin-core-dev
16:10
SpellChecker has quit [Remote host closed the connection]
16:11
SpellChecker has joined #bitcoin-core-dev
16:25
puchka has quit [Ping timeout: 256 seconds]
16:34
zeropoint has joined #bitcoin-core-dev
16:35
puchka has joined #bitcoin-core-dev
16:40
cedhouse has joined #bitcoin-core-dev
16:48
<
vasild >
hebasto: fanquake: I confirm this: on master when configured with --enable-fuzz but without --with-sanitizers, then the fuzz binary just hangs without printing anything: `FUZZ=addrman src/test/fuzz/fuzz` or `FUZZ=addrman src/test/fuzz/fuzz .../bitcoin-core/qa-assets/fuzz_seed_corpus/addrman`. Adding --with-sanitizers=fuzzer creates a working one.
16:49
cedhouse has quit [Quit: Client closed]
16:50
<
sipa >
vasild: huh, that's surprising; without --with-sanitizer=fuzzer there shouldn't be a main() function even (as it's provided by the sanitizer)
16:51
<
dergoegge >
i'm pretty sure it's waiting for input from stdin
16:51
<
dergoegge >
if you pass it a file or folder it won't hang
16:51
<
dergoegge >
s/won't/shouldn't/
16:53
<
sipa >
oh, so it's just doing the same as if you didn't pass --enable-fuzz in that case? (using our own dummy-fuzz main routine)
16:58
Talkless has joined #bitcoin-core-dev
17:01
bugs_ has joined #bitcoin-core-dev
17:04
<
dergoegge >
i thought so, can double check tomorrow
17:08
<
vasild >
well, if I press ctrl+D then it quits
17:10
<
vasild >
I said that it hangs with `FUZZ=addrman src/test/fuzz/fuzz .../bitcoin-core/qa-assets/fuzz_seed_corpus/addrman`, but it actually does something because it loads the CPU
17:10
<
vasild >
and eventually it prints "addrman: succeeded against 2064 files in 85s."
17:11
<
vasild >
nothing else, just this one line and quits
17:13
<
dergoegge >
That's the expected behaviour without the fuzzer sanitizer
17:13
<
vasild >
I am confused. Is this a fully functional fuzz binary (compiled with --enable-fuzz but without --with-sanitizers)?
17:17
<
sipa >
vasild: so if you build completely normally (no --enable-fuzz, and no --with-sanitizers=fuzzer), you still get a src/test/fuzz/fuzz binary
17:17
<
sipa >
vasild: that binary cannot do any actual fuzzing, but it can read a fuzz seed corpus, and feed it through the fuzzing harness
17:19
<
sipa >
and i suspect that if you build with --enable-fuzz but without --with-sanitizers=fuzzer, you get the same thing
17:20
<
vasild >
I will further investigate tomorrow, so far "only --enable-fuzz-binary" and "only --enable-fuzz" (without --with-sanitizers) seem to create the same binary
17:21
<
sipa >
it's pretty cool i think that we have this; it means we get to run our fuzz corpus tests on platforms/architectures that aren't actually supported by libfuzzer (including gcc, mingw32, msvc, ...)
17:23
<
sipa >
i think when we introduced this there was some talk of calling the binary phuzz (phony fuzz) rather than fuzz to not confuse the two
17:23
<
sipa >
maybe we should still do that
17:24
<
vasild >
so, all 3 produce the same phuzz binary: 1. without any option, 2. --enable-fuzz 3. --enable-fuzz-binary --> its all the same result
17:26
<
sipa >
it may be that these options only matter for other fuzzing systems
17:26
<
vasild >
and --with-sanitizers=fuzzer creates a true fuzz binary. Why do we disable building other executables when --enable-fuzz is used?
17:27
<
sipa >
i don't have experience with these, but it is/was possible to use afl or honggfuzz too
17:28
<
sipa >
vasild: when we're building for real fuzzing (which perhaps is what --enable-fuzz is trying to do, to the extent possible), we cannot build any other binaries (because the main() function is provided by the fuzzing framework)
17:28
sohrab has joined #bitcoin-core-dev
17:29
<
bitcoin-git >
bitcoin/master 9f66ac7 Pieter Wuille: net_processing: do not treat non-connecting headers as response
17:29
<
bitcoin-git >
bitcoin/master 944c542 Pieter Wuille: net_processing: drop Misbehavior for unconnecting headers
17:29
<
bitcoin-git >
bitcoin/master 5120ab1 Pieter Wuille: net_processing: drop 8 headers threshold for incoming BIP130
17:29
<
sipa >
\o/ no more DoS scores!
17:37
<
bitcoin-git >
bitcoin/master c3a8843 Lőrinc: Use SCRIPT_VERIFY_NONE instead of hard-coded 0 in transaction_tests
17:37
<
bitcoin-git >
bitcoin/master 1984187 Lőrinc: Validate transaction without inputs
17:37
<
bitcoin-git >
bitcoin/master 327a31d Lőrinc: Validate oversized transaction
17:45
<
bitcoin-git >
bitcoin/master 1245d13 Vasil Dimov: netbase: extend CreateSock() to support creating arbitrary sockets
17:45
<
bitcoin-git >
bitcoin/master a961ad1 Ava Chow: Merge bitcoin/bitcoin#30202: netbase: extend CreateSock() to support creat...
18:12
abubakarsadiq has quit [Quit: Connection closed for inactivity]
18:48
jonatack has quit [Ping timeout: 268 seconds]
18:50
mudsip has joined #bitcoin-core-dev
18:50
jonatack has joined #bitcoin-core-dev
19:10
mudsip has joined #bitcoin-core-dev
19:12
Talkless has quit [Remote host closed the connection]
19:18
pablomartin has joined #bitcoin-core-dev
19:36
jon_atack has joined #bitcoin-core-dev
19:38
jonatack has quit [Ping timeout: 264 seconds]
19:48
jon_atack has quit [Read error: Connection reset by peer]
19:50
jonatack has joined #bitcoin-core-dev
19:51
cm has quit [Quit: Bye.]
19:52
cm has joined #bitcoin-core-dev
19:59
pablomartin has quit [Remote host closed the connection]
19:59
pablomartin has joined #bitcoin-core-dev
20:39
preimage has quit [Quit: WeeChat 4.3.2]
21:09
pablomartin has quit [Ping timeout: 268 seconds]
21:20
jtraub91 has joined #bitcoin-core-dev
21:23
pablomartin has joined #bitcoin-core-dev
21:44
bugs_ has quit [Quit: Leaving]
22:04
jtraub91 has quit [Quit: WeeChat 3.8]
22:09
pablomartin has quit [Ping timeout: 252 seconds]
22:09
pablomartin4btc has joined #bitcoin-core-dev
22:13
pablomartin4btc has quit [Client Quit]
22:27
kevkevin has quit [Remote host closed the connection]
22:30
kevkevin has joined #bitcoin-core-dev
22:35
kevkevin has quit [Ping timeout: 264 seconds]
22:45
midnight has quit [Remote host closed the connection]
22:46
cold has quit [Remote host closed the connection]
22:56
cold has joined #bitcoin-core-dev
22:56
midnight has joined #bitcoin-core-dev
23:00
kevkevin has joined #bitcoin-core-dev
23:05
kevkevin has quit [Ping timeout: 256 seconds]
23:17
midnight has quit [Remote host closed the connection]
23:18
cold has quit [Remote host closed the connection]
23:19 _andrewtoth_ has quit [Ping timeout: 260 seconds]
23:28
cold has joined #bitcoin-core-dev
23:28
midnight has joined #bitcoin-core-dev
23:49
gribble has quit [Read error: Connection reset by peer]
23:50
gribble has joined #bitcoin-core-dev
23:52
Torr has quit [Quit: Torr]