kevkevin has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
<vasild>
sipa: "because the main() function is provided by the fuzzing framework)" -- seems that the fuzzing framework is engaged by --with-sanitizers=fuzzer, not by --enable-fuzz
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<vasild>
sipa: laanwj: wrt https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1644926540 with "static" it is enough to look to further than the function prototype to know that all callers are in the same file, whereas with anon namespace that is not immediately obvious and one may have to look e.g. 100 lines higher to see that this function is local. So I prefer "static" over anon namespace
<vasild>
(posting here to avoid bikeshed noise on the PR)
<vasild>
s/to further/no further/
<vasild>
when looking at a diff, then scrolling up to find the "namespace {" is difficult
<sipa>
vasild: fair point, but a downside is that you cannot have classes/types with "static"
<vasild>
right
<sipa>
i do like that it (slightly) incentivizes putting all the internal stuff and external stuff together (e.g. first all internal stuff in a namespace {}, then all external stuff), as the alternative is tons of opening/closing of the namespace
saffi48 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko closed pull request #29970: test: switch from curl to urllib for HTTP requests (master...feature/requests-library-usage) https://github.com/bitcoin/bitcoin/pull/29970
<laanwj>
i also have a slight preference for static, but that's mainly just because i'm used to it, i'll just follow whatever the project uses and that seems to be namespace{}
<bitcoin-git>
[bitcoin] fanquake opened pull request #30319: [26.x] upnp: fix build with miniupnpc 2.2.8 (26.x...backport_upnp_api_fix) https://github.com/bitcoin/bitcoin/pull/30319
mcey has quit [Read error: Connection reset by peer]
mcey has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
kevkevin has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] mzumsande opened pull request #30320: assumeutxo: Don't load a snapshot if it's not in the best header chain (master...202406_assumeutxo_bestheader) https://github.com/bitcoin/bitcoin/pull/30320
Momo7 has joined #bitcoin-core-dev
hernanmarino has quit [Ping timeout: 268 seconds]
Momo7 has quit [Quit: Client closed]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
vasild has quit [Remote host closed the connection]
zeropoint has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
<sipa>
laanwj, vasild: to be clear, my comment about this is really just a nit
saffi48 has quit [Quit: Leaving.]
saffi48 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
mcey_ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 264 seconds]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 272 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
kevkevin has joined #bitcoin-core-dev
saffi48 has quit [Ping timeout: 264 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
saffi48 has joined #bitcoin-core-dev
preimage is now known as lattice
saffi48 has quit [Changing host]
saffi48 has joined #bitcoin-core-dev
lattice has quit [Quit: WeeChat 4.3.2]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
Talkless has joined #bitcoin-core-dev
Guest27 has joined #bitcoin-core-dev
Guest27 has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
bugs_ has quit [Quit: Leaving]
saffi48 has quit [Quit: Leaving.]
lbia has quit [Ping timeout: 268 seconds]
jon_atack has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
bitdex has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
gabrielescipione has joined #bitcoin-core-dev
gabrielescipione has quit [Client Quit]
gabrielescipione has joined #bitcoin-core-dev
gabrielescipione has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
saffi48 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
lbia has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 252 seconds]
lbia has joined #bitcoin-core-dev
saffi48 has quit [Changing host]
saffi48 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
saffi48 has left #bitcoin-core-dev [#bitcoin-core-dev]