szkl has quit [Quit: Connection closed for inactivity]
zeropoint has quit [Quit: leaving]
<bitcoin-git>
[bitcoin] kevkevinpal opened pull request #30340: test: Added coverage to Block not found error using gettxoutsetinfo (master...testBlockNotFoundUsingGetTxOutSetInfo) https://github.com/bitcoin/bitcoin/pull/30340
Guest28 has quit [Quit: Client closed]
Randolf has joined #bitcoin-core-dev
Randolf has quit [Quit: Leaving]
kevkevin has quit [Remote host closed the connection]
jon_atack has quit [Ping timeout: 246 seconds]
jonatack has joined #bitcoin-core-dev
mudsip has quit []
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
tibocin has joined #bitcoin-core-dev
tibocin has quit [Client Quit]
bitdex has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Guest61 has joined #bitcoin-core-dev
Guest66 has joined #bitcoin-core-dev
Guest66 has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
Guest61 has quit [Quit: Client closed]
mcey has quit [Read error: Connection reset by peer]
mcey has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
Guest69 has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
Guest69 has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
aleggg has quit [Remote host closed the connection]
<cfields>
ryanofsky: I'll begin reviewing your draft and comparing it to mine while it's all fresh in my head, with the understanding that it still requires concept (n)acks from others.
<cfields>
personally I'm find with your approach. Whatever gets the job done.
<cfields>
ryanofsky: see also my questions to sipa above. At a quick glance, it looks like your branch isn't enough to completely get rid of the global logger, only from the major subsystems? Asking because I don't see changes to (for ex) random.cpp.
<cfields>
*get rid of the global logger from the kernel
<cfields>
TheCharlatan: is there any reason mempool_persist exists in the kernel?
<cfields>
It can be safely removed. Will PR the removal unless you left it in there to support loading/dumping for some reason.
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<ryanofsky>
cfields, interesting that branch is using source_location. But think the biggest difference between approaches is #30342 is trying to be incremental and not do a global search and replace of all log statements.
<ryanofsky>
I hadn't looked at random.cpp, but it seems like we could add a pointer to RNGState there.
<ryanofsky>
In general I don't think we should get rid of log statements. Being able to conveniently log from any part of the codebase is too important for debugging.
<cfields>
ryanofsky: yeah, that branch using source_location was before I realized the macros were necessary for avoiding evaluating the params, so I abandoned it. But the passing around of the log struct works the same with either approach.
<cfields>
agree about not getting rid of log statements. Random is just kinda a special case because it's so low-level and is setup so early.
<ryanofsky>
yeah the parts just passing the Logger are the same
<cfields>
ryanofsky: not to restart the war, but I do agree with aj about not removing category grep-ability from the code
* cfields
ducks
<ryanofsky>
interesting, i'm surpised anyone has grepped for log categories since they are not used very much
<ryanofsky>
also, the new LogInfo LogWarning LogError macros do not even accept categories, so things you can find searching for constants is pretty limited
<ryanofsky>
anyway, you could look into it, and say what api you do prefer, if not this one, which is basically similar to python's, supporting categories but logging through objects
<cfields>
will comment on the PR. I don't feel strongly enough to argue, just figured it was worth a comment here. The only thing I _do_ care about is being able to use an instance. I have a slight preference for explicitness of the instance in every call rather than hiding it sometimes (hence the huge scripted-diff in my PR), but again, whatever gets the job done is good enough for me.
<gmaxwell>
category grepability is also useful in reverse, making it easy to see "which category to I need to set to get this log I see in the code"-- particularly because the people doing that are sometimes non-developer ops staff and so their comfort reading code is pretty limited.
<ryanofsky>
that's a good point, but I don't think it is difficult to find categories in my PR. if you look at at code each source file has one category
<ryanofsky>
for the unusual cases where a single source file logs to multiple categories there are objects like log_mempool and log_reindex, which are named after the category
<ryanofsky>
or you can grep them and see the category
kevkevin has quit [Remote host closed the connection]
<ryanofsky>
anyway do agree with you (cfields) that just having ability to specify instances and categories is the main thing, doesn't matter to me if they are optional or required or how they are written
kevkevin has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.3.2]
cornfeedhobo has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
Torr has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]