ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
zeropoint has quit [Quit: leaving]
kevkevin has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<bitcoin-git> [bitcoin] ceffikhan opened pull request #30345: test: fix debug log assertion in p2p_i2p_ports test (master...master) https://github.com/bitcoin/bitcoin/pull/30345
saffi48 has quit [Quit: Leaving.]
saffi48 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
kevkevin has joined #bitcoin-core-dev
jamesob1 has quit [Ping timeout: 260 seconds]
jamesob443688173 has quit [Ping timeout: 260 seconds]
cornfeedhobo has quit [Quit: ZNC - https://znc.in]
cornfeedhobo has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<bitcoin-git> [bitcoincore.org] joetor5 opened pull request #1035: ES translation: Releases page title (fixes #1034) (master...es-trans) https://github.com/bitcoin-core/bitcoincore.org/pull/1035
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
Torr has quit [Quit: Torr]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
jon_atack has quit [Ping timeout: 246 seconds]
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
kevkevin has joined #bitcoin-core-dev
_andrewtoth_ has quit [Ping timeout: 260 seconds]
kevkevin has quit [Remote host closed the connection]
S3RK_ has quit [Ping timeout: 272 seconds]
S3RK has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
puchka has quit [Ping timeout: 264 seconds]
puchka has joined #bitcoin-core-dev
mcey has quit [Read error: Connection reset by peer]
mcey has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 268 seconds]
joetor5 has quit [Client Quit]
kevkevin has quit [Ping timeout: 246 seconds]
puchka has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
saffi48 has quit [Quit: Leaving.]
kevkevin has joined #bitcoin-core-dev
noonien808310429 has quit [Ping timeout: 260 seconds]
kevkevin has quit [Ping timeout: 256 seconds]
puchka has quit [Ping timeout: 240 seconds]
puchka has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
lbia has quit [Ping timeout: 264 seconds]
saffi48 has joined #bitcoin-core-dev
saffi48 has quit [Changing host]
saffi48 has joined #bitcoin-core-dev
lbia has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Guyver2 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
noonien808310429 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
noonien808310429 has quit [Ping timeout: 268 seconds]
Guest91 has joined #bitcoin-core-dev
Guest91 has quit [Client Quit]
saffi48 has quit [Quit: Leaving.]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
kevkevin has quit [Ping timeout: 268 seconds]
saffi48 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
saffi48 has quit [Ping timeout: 264 seconds]
kevkevin has quit [Ping timeout: 256 seconds]
saffi48 has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
saffi48 has quit [Ping timeout: 252 seconds]
gribble has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
puchka has quit [Ping timeout: 264 seconds]
saffi48 has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
saffi48 has quit [Quit: Leaving.]
puchka has joined #bitcoin-core-dev
saffi48 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
mailman has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
josie_ is now known as josie
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
saffi48 has quit [Quit: Leaving.]
<bitcoin-git> [bitcoin] ryanofsky opened pull request #30347: logging: Use LogFatal instead LogError for fatal errors (master...pr/logfat) https://github.com/bitcoin/bitcoin/pull/30347
kevkevin has joined #bitcoin-core-dev
saffi48 has joined #bitcoin-core-dev
saffi48 has quit [Changing host]
saffi48 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
lbia has quit [Ping timeout: 256 seconds]
<bitcoin-git> [btcdeb] RandyMcMillan opened pull request #152: 2023/849687/578280/f7362f0/79997f4 macos building (master...2023/849687/578280/f7362f0/79997f4-macos-building) https://github.com/bitcoin-core/btcdeb/pull/152
<bitcoin-git> [btcdeb] RandyMcMillan closed pull request #152: 2023/849687/578280/f7362f0/79997f4 macos building (master...2023/849687/578280/f7362f0/79997f4-macos-building) https://github.com/bitcoin-core/btcdeb/pull/152
kevkevin has quit [Remote host closed the connection]
Guyver2 has left #bitcoin-core-dev [Closing Window]
Guest123421 has joined #bitcoin-core-dev
Guest123421 has quit [Client Quit]
Emc99 has joined #bitcoin-core-dev
<achow101> #startmeeting
<core-meetingbot> Meeting started Thu Jun 27 14:00:02 2024 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<core-meetingbot> Available commands: action commands idea info link nick
<achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
<abubakarsadiq> hi
<darosior> hi
<jonatack> hi
<fjahr> hi
<achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
<lightlike> Hi
<sdaftuar> hi
<hebasto> hi
<achow101> #topic package relay updates (glozow)
<core-meetingbot> topic: package relay updates (glozow)
<Chris_Stewart_5> hi
<theStack> hi
<sipa> hi
<_aj_> hi
<achow101> i believe glozow is not here today, any
<achow101> can anyone give an update?
<furszy> hi
<willcl-ark> hi
<b10c> hi
<abubakarsadiq> from the tracking issue PR to review is #30111
<gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub
<achow101> #topic cluster mempool updates (sdaftuar)
<core-meetingbot> topic: cluster mempool updates (sdaftuar)
<abubakarsadiq> and some follow-ups #30295 and #30272
<gribble> https://github.com/bitcoin/bitcoin/issues/30295 | #28984 package rbf followups by instagibbs · Pull Request #30295 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/30272 | doc: use TRUC instead of v3 and add release note by glozow · Pull Request #30272 · bitcoin/bitcoin · GitHub
<sdaftuar> hi, not much of an update from me -- been traveling but trying to keep #28676 up-to-date with rebases as conflicts pop up in master. i think pieter may have an update on his PRs, which is where the review should be happening
<gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
<Murch[m]> hi
<sipa> i've mostly been working on a delving writeup to explain some of the background behind two of my PRs, i hope to post it soon
<bitcoin-git> [bitcoin] paplorinc opened pull request #30349: benchmark: Refactor SipHash_32b to improve accuracy and potential avoid optimization issues (master...paplorinc/remove_siphash_benchmark_recursion) https://github.com/bitcoin/bitcoin/pull/30349
<josie> hi
<sipa> i don't have much else to report on this topic
<tdb3_> hi
<achow101> #topic legacy wallet removal updates (achow101)
<core-meetingbot> topic: legacy wallet removal updates (achow101)
<achow101> #26596 has gotten a bit of review. latest major change was splitting IsMine stuff into s
<gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 · Pull Request #26596 · bitcoin/bitcoin · GitHub
<achow101> into a separate pr
<achow101> #30328
<gribble> https://github.com/bitcoin/bitcoin/issues/30328 | wallet: Remove IsMine from migration code by achow101 · Pull Request #30328 · bitcoin/bitcoin · GitHub
<cfields> hi
<achow101> #topic Ad-hoc high priority for review
<core-meetingbot> topic: Ad-hoc high priority for review
<achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
<maflcko> I'd like to have #29720 as "bugfix"
<gribble> https://github.com/bitcoin/bitcoin/issues/29720 | rpc: Avoid getchaintxstats invalid results by maflcko · Pull Request #29720 · bitcoin/bitcoin · GitHub
<achow101> maflcko: added
<maflcko> thx
<achow101> or any other topics to discuss
<achow101> #endmeeting
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
<core-meetingbot> Meeting ended Thu Jun 27 14:11:35 2024 UTC.
Emc99 has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
<cfields> ryanofsky: is there a meta-issue/project for general discustion of your logging PRs? They're beginning to pile up :)
<vasild> hi
dermoth has quit [Remote host closed the connection]
dermoth has joined #bitcoin-core-dev
<jonatack> With the growing proliferation of the Log{Level} macros, I suppose it's a matter of time before someone proposes a bunch of Log{Category} ones too for completeness ;)
<jonatack> imo one Log macro with a consistent interface was, and still is, the way to go
<Earnestly> Eventually you'll become mpv's --msg-level
<jonatack> put the developer-facing doxygen documentation next to the relevant code: the Level enum class
<jonatack> put the user-facing documentation in the RPC logging help output
<jonatack> simple and done
Guest7 has joined #bitcoin-core-dev
Guest7 has quit [Client Quit]
lbia has joined #bitcoin-core-dev
<vasild> fwiw I was thinking the same - one Log() (function or macro or whatever) would be nice, e.g. LogPrintLevel(BCLog::NET, BCLog::Level::Error, ... can be as short as Log(Log::NET, Log::Error, ...
<vasild> but I never dared to start the bikeshed about it
preimage has joined #bitcoin-core-dev
<bitcoin-git> [btcdeb] RandyMcMillan opened pull request #153: .github/workflows/c-cpp.yml:build matrix (master...2023/849697/563383/95762f8/e519eaa) https://github.com/bitcoin-core/btcdeb/pull/153
<bitcoin-git> [bitcoin] Sjors opened pull request #30350: [WIP] libbitcoin_net (master...2024/07/libbitcoin-net) https://github.com/bitcoin/bitcoin/pull/30350
<bitcoin-git> [bitcoin] Sjors closed pull request #30350: [WIP] libbitcoin_net (master...2024/07/libbitcoin-net) https://github.com/bitcoin/bitcoin/pull/30350
zeropoint has joined #bitcoin-core-dev
<darosior> dergoegge: finally got around to look into https://gnusha.org/bitcoin-core-dev/2024-06-03.log . I can't reproduce: i get 95% stability for `coins_db`, 92% stability for `coins_view` and 99% stability for `block_index`. But maybe it's me, i'm not super familiar with AFL++.
saffi48 has quit [Quit: Leaving.]
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] ternera opened pull request #30351: Fixed grammar in the README (master...master) https://github.com/bitcoin/bitcoin/pull/30351
<bitcoin-git> [bitcoin] maflcko closed pull request #30351: Fixed grammar in the README (master...master) https://github.com/bitcoin/bitcoin/pull/30351
andrewtoth_ has quit [Ping timeout: 260 seconds]
Talkless has joined #bitcoin-core-dev
dermoth has quit [Ping timeout: 264 seconds]
puchka1101 has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 252 seconds]
mjdietzx__ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b27afb7fb774...f0745d028e42
<bitcoin-git> bitcoin/master adc6ab2 josibake: wallet: use CRecipient instead of CTxOut
<bitcoin-git> bitcoin/master a9c7300 josibake: move-only: refactor CreateTransactionInternal
<bitcoin-git> bitcoin/master f0745d0 Ava Chow: Merge bitcoin/bitcoin#30050: refactor, wallet: get serialized size of `CRe...
<bitcoin-git> [bitcoin] achow101 merged pull request #30050: refactor, wallet: get serialized size of `CRecipient`s directly (master...serialize-size-for-crecipient) https://github.com/bitcoin/bitcoin/pull/30050
<bitcoin-git> [bitcoincore.org] murchandamus opened pull request #1036: Backfill lifecycle table (master...2024-06-improve-version-overview) https://github.com/bitcoin-core/bitcoincore.org/pull/1036
<bitcoin-git> [btcdeb] RandyMcMillan closed pull request #153: build matrix (master...2023/849697/563383/95762f8/e519eaa) https://github.com/bitcoin-core/btcdeb/pull/153
uasf has quit [Remote host closed the connection]
uasf has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] instagibbs opened pull request #30352: policy: Add `OP_TRUE 0x4e73` as a standard output script (master...2024-06-op_true_outputs) https://github.com/bitcoin/bitcoin/pull/30352
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<jonatack> vasild: yes exactly, simply Log(level, category)
<bitcoin-git> [bitcoin] furszy opened pull request #30353: test: fix inconsistency in fundrawtransaction weight limits test (master...2024_test_fix_max_weight_test) https://github.com/bitcoin/bitcoin/pull/30353
mjdietzx__ has quit [Quit: Connection closed for inactivity]
<jonatack> it would be good to have rough consensus on the log levels, and spec out the developer and user interfaces, to have a clearer roadmap
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
<bitcoin-git> [bitcoin] ryanofsky pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f0745d028e42...d38dbaad98c4
<bitcoin-git> bitcoin/master 7df03f1 willcl-ark: util: add perm string helper functions
<bitcoin-git> bitcoin/master f467aed willcl-ark: init: add option for rpccookie permissions
<bitcoin-git> bitcoin/master d2afa26 willcl-ark: test: add rpccookieperms test
<bitcoin-git> [bitcoin] ryanofsky merged pull request #28167: init: Add option for rpccookie permissions (replace 26088) (master...2023-07-rpccookie-perms) https://github.com/bitcoin/bitcoin/pull/28167
qxs has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
qxs has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.3.2]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d38dbaad98c4...2f6dca4d1c01
<bitcoin-git> bitcoin/master 83a9bef Sjors Provoost: Add missing include for mining interface
<bitcoin-git> bitcoin/master 75ce763 Sjors Provoost: refactor: testBlockValidity make out argument last
<bitcoin-git> bitcoin/master 5fb2b70 Sjors Provoost: Drop unneeded lock from createNewBlock
<bitcoin-git> [bitcoin] ryanofsky merged pull request #30335: Mining interface followups, reduce cs_main locking, test rpc bug fix (master...2024/06/mining-interface-followups) https://github.com/bitcoin/bitcoin/pull/30335
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev