achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 276 seconds]
joetor5 has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 276 seconds]
roconnor_ is now known as roconnor
jonatack has quit [Ping timeout: 265 seconds]
joetor5 has quit [Quit: joetor5]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Client Quit]
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
Guest67 has joined #bitcoin-core-dev
Guest67 has quit [Client Quit]
MrHAPPY has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
MrHAPPY has quit []
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 276 seconds]
jon_atack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 272 seconds]
Saturday7 has quit [Ping timeout: 268 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
jon_atack has quit [Ping timeout: 252 seconds]
Guest98 has joined #bitcoin-core-dev
Guest98 has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
Guyver2 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<Sjors[m]1> Who wants to help push #31679 over the finish line?
<corebot> https://github.com/bitcoin/bitcoin/issues/31679 | cmake: Move internal binaries from bin/ to libexec/ by ryanofsky · Pull Request #31679 · bitcoin/bitcoin · GitHub
kevkevin has quit [Ping timeout: 252 seconds]
conman has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
Nebraskka has quit [Quit: Good day old chaps]
Nebraskka has joined #bitcoin-core-dev
Cory74 has quit [Quit: Client closed]
Cory74 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Cory74 has quit [Quit: Client closed]
Cory74 has joined #bitcoin-core-dev
cotsuka has quit [Ping timeout: 260 seconds]
cotsuka has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #32856: Update `minisketch` subtree and switch to its build script (master...250702-minisketch) https://github.com/bitcoin/bitcoin/pull/32856
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa3359289883...7fa9b58bd907
<bitcoin-git> bitcoin/master 4be81e9 Greg Sanders: feature_taproot: sample tx version border values more
<bitcoin-git> bitcoin/master 7fa9b58 merge-script: Merge bitcoin/bitcoin#32841: feature_taproot: sample tx version border val...
<bitcoin-git> [bitcoin] fanquake merged pull request #32841: feature_taproot: sample tx version border values more (master...2025-06-std_tx_taproot) https://github.com/bitcoin/bitcoin/pull/32841
<bitcoin-git> [qa-assets] brunoerg closed pull request #215: add inputs for spkm_migration target (main...2024-12-spkm-migration) https://github.com/bitcoin-core/qa-assets/pull/215
kevkevin has quit [Ping timeout: 272 seconds]
jespada has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] hebasto closed pull request #31158: build, ci: Fix linking `bitcoin-chainstate.exe` to `bitcoinkernel.dll` on Windows (master...241025-kernel-dll) https://github.com/bitcoin/bitcoin/pull/31158
sbddesign has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
dunxen has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7fa9b58bd907...bf75c9964fb2
<bitcoin-git> bitcoin/master 4eb3cee Hennadii Stepanov: doc: Update NetBSD Build Guide
<bitcoin-git> bitcoin/master 5a5ddbd Hennadii Stepanov: build: Add workaround for NetBSD bug in `Boost::headers` target
<bitcoin-git> bitcoin/master bf75c99 merge-script: Merge bitcoin/bitcoin#32828: build, docs: Fix Boost-related issues on NetB...
<bitcoin-git> [bitcoin] fanquake merged pull request #32828: build, docs: Fix Boost-related issues on NetBSD (master...250629-netbsd-boost) https://github.com/bitcoin/bitcoin/pull/32828
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
kevkevin has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 245 seconds]
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #31053: RFC: build: support for pre-compiled headers. (master...cmake-pch) https://github.com/bitcoin/bitcoin/pull/31053
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #32787: bench: reduces unnecessary big vector definition (master...20250620-fix-rollingbloom-bench) https://github.com/bitcoin/bitcoin/pull/32787
<bitcoin-git> [bitcoin] hebasto closed pull request #32648: cmake, qt: Process `*.qrc` files manually (master...250530-qt-rcc) https://github.com/bitcoin/bitcoin/pull/32648
bugs_ has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto closed pull request #32289: doc: Add note for building on macOS (Intel) with CMake ≥ 4.0 (master...250416-macos-intel) https://github.com/bitcoin/bitcoin/pull/32289
<ghost43> are there known vulnerabilities for the witness commitment wtxid merkle tree? it uses the same construction as the block header txid merkle tree, so e.g. it would also be vulnerable against 64 byte txs, right? except 64 bytes is *just* barely not enough to serialize a tx with a witness, meaning none of the 64-byte tx concerns apply?
<ghost43> version: 4, marker+flag: 2, n_ins(0x01): 1, prevout_txid: 32, prevout_idx: 4, scriptSig_len(0x00): 1, nSequence: 4, n_outs(0x01): 1, out_amt: 8, spk_len: 1, spk: 1 (OP_RETURN <>), n_wit_elems: 1 byte (must be 0x00 ?, no space left), locktime: 4. that's already 64 B. but as the witness is empty, 0x00, the tx would have to be serialized without marker+flag and witness, using the old format.
<ghost43> so seems I cannot construct a 64 byte witness-serialized tx. is there any public writeup/discussion about this topic?
<bitcoin-git> [bitcoin] hebasto closed pull request #32668: refactor: Drop unused `#include boost/operators.hpp` (master...250602-boost-operators) https://github.com/bitcoin/bitcoin/pull/32668
kevkevin has quit [Ping timeout: 252 seconds]
<bitcoin-git> [qa-assets] maflcko opened pull request #227: Add fuzz inputs (main...main) https://github.com/bitcoin-core/qa-assets/pull/227
eugenesiegel has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
<_aj_> ghost43: there are the same number of entries in the witness merkle tree as in the tx merkle tree, so i don't think there's an additional ambiguity there
<ghost43> _aj_: right. what I am asking is which ambiguities are still present and apply
<ghost43> for example, the bip54 consensus cleanup mentions banning txs that serialize as 64 bytes using the old format. why is it not banning txs that serialize as 64 bytes using the new format?
<ghost43> (is it because there aren't any?)
<_aj_> ghost43: if they don't serialize to 64 bytes in the old format, you know exactly how many txs there are, and thus there's no ambiguity checking the witness merkle root
<ghost43> _aj_: but as a light client, if you want to witness-spv a tx, does that mean you also have to do the satoshi-spv using the block header merkle tree, and compare that the proof lengths are the same?
<_aj_> (if they don't --> if they aren't permitted to)
<ghost43> or how would you know if the two merkle trees contain the same number of txs
sbddesign has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #32397: doc: Add hint about avoiding spaces in paths when building on Windows (master...HintNoSpace) https://github.com/bitcoin/bitcoin/pull/32397
<_aj_> oh i see. witness-spv seems like a pain since you have to get and parse the coinbase as well
<ghost43> well, I guess the light client would need to satoshi-spv the coinbase tx anyway, so could just compare the length of the coinbase tx's merkle branch with the length of the witness merkle-branch proving the interesting tx
<sipa> right, is it possible to exploit the 64-byte (non-witness) txid merkle root if you know the correct number of *levels* in the tree, but not the exact number of leaves?
jespada has quit [Ping timeout: 248 seconds]
jespada has joined #bitcoin-core-dev
<_aj_> i think 020000000001017e44cfd662a5b224d0ffd016f6ae3903aa3d03ea35c1d864adb24b897f1c512513000000003b0000000102a12500000000000100010001000000 is the smallest possible tx with a witness at 65 bytes? i think a witness flag with an empty witness is invalid, no?
<sipa> _aj_: indeed
<sipa> and even if one would accept that in a deserializer (which i wouldn't recommend, but some software has accepted in the past), you should always use a canonically serialized form for computing wtxids
<_aj_> ah my bad, 020000000001017e44cfd662a5b224d0ffd016f6ae3903aa3d03ea35c1d864adb24b897f1c512513000000003b0000000102a125000000000000010001000000 gets to exactly 64 bytes
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bf75c9964fb2...a92e8b10a5fb
<bitcoin-git> bitcoin/master 1405216 Hennadii Stepanov: Revert "miniscript: make operator_mst consteval"
<bitcoin-git> bitcoin/master a34fb9a Pieter Wuille: miniscript: Make `operator""_mst` `consteval`
<bitcoin-git> bitcoin/master a92e8b1 merge-script: Merge bitcoin/bitcoin#32564: miniscript, refactor: Make `operator""_mst` `...
<bitcoin-git> [bitcoin] fanquake merged pull request #32564: miniscript, refactor: Make `operator""_mst` `consteval` (re-take) (master...250519-msvc-consteval) https://github.com/bitcoin/bitcoin/pull/32564
kevkevin has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #32857: wallet: allow skipping script paths (master...2025/07/no_script_path) https://github.com/bitcoin/bitcoin/pull/32857
<eugenesiegel> I want to measure leveldb usage in some specific scenarios, is there any way to simulate this? I basically want to use a mainnet-size leveldb to measure things I cannot really measure on mainnet.
sbddesign has quit [Ping timeout: 252 seconds]
sbddesign has joined #bitcoin-core-dev
<bitcoin-git> [gui-qml] hebasto pushed 24 commits to main: https://github.com/bitcoin-core/gui-qml/compare/07093a161c0d...8f7f8bd63a8a
<bitcoin-git> gui-qml/main 20d6bcd johnny9: qml: Introduce SendRecipientsListModel
<bitcoin-git> gui-qml/main 059a7a2 johnny9: qml: Add Multiple Recipients toggle to Send menu
<bitcoin-git> gui-qml/main 06e9586 johnny9: qml: Add Multiple Recipients bar to Send form
<bitcoin-git> [gui-qml] hebasto merged pull request #450: Add Multiple Recipients option to the Send form (main...recipients) https://github.com/bitcoin-core/gui-qml/pull/450
<bitcoin-git> [bitcoin] hebasto opened pull request #32858: doc: Add workaround for vcpkg issue with paths with embedded spaces (master...250702-vcpkg-spaces) https://github.com/bitcoin/bitcoin/pull/32858
sbddesign has quit [Remote host closed the connection]
sbddesign has joined #bitcoin-core-dev
<bitcoin-git> [qa-assets] murchandamus opened pull request #229: Add Murch’s inputs July 2025 (main...2025-07-murch-inputs) https://github.com/bitcoin-core/qa-assets/pull/229
Guyver2 has left #bitcoin-core-dev [Closing Window]
jonatack has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] instagibbs opened pull request #32859: functional test: correctly detect nonstd TRUC tx vsize in feature_taproot (master...2025-07-fixup-truc-taproot) https://github.com/bitcoin/bitcoin/pull/32859
eugenesiegel has quit [Ping timeout: 272 seconds]
eugenesiegel has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 276 seconds]
Cory74 has quit [Quit: Client closed]
Cory74 has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] PixelPil0t1 opened pull request #32860: Add BIP reference links to release notes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/32860
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #32860: Add BIP reference links to release notes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/32860
jonatack has quit [Ping timeout: 276 seconds]
sbddesign has quit [Ping timeout: 248 seconds]
sbddesign has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 272 seconds]
l0rinc has quit [Read error: Connection reset by peer]
mudsip has joined #bitcoin-core-dev
Cory74 has quit [Quit: Client closed]
Cory74 has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
jon_atack has quit [Ping timeout: 248 seconds]
mudsip has quit []
Emc99 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Emc99 has quit [Client Quit]
Talkless has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
jonatack has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 248 seconds]
sbddesign has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
Emc99 has quit [Client Quit]
eugenesiegel has quit [Ping timeout: 272 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
sbddesign has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
Cory74 has quit [Quit: Client closed]
Cory74 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 276 seconds]
Cory95 has joined #bitcoin-core-dev
Cory74 has quit [Ping timeout: 272 seconds]
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 245 seconds]
sbddesign has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
Talkless has quit [Quit: Konversation terminated!]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
Guest14 has joined #bitcoin-core-dev
Guest14 has quit [Client Quit]
Guest14 has joined #bitcoin-core-dev
Guest14 has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a92e8b10a5fb...35cae56a9292
<bitcoin-git> bitcoin/master d04f6a9 furszy: refactor: remove sqlite dir path back-and-forth conversion
<bitcoin-git> bitcoin/master 1de423e furszy: wallet: introduce method to return all db created files
<bitcoin-git> bitcoin/master e86d71b furszy: wallet: refactor, dedup wallet re-loading code
<bitcoin-git> [bitcoin] achow101 merged pull request #31423: wallet: migration, avoid creating spendable wallet from a watch-only legacy wallet (master...2024_migration_watch-only_migration) https://github.com/bitcoin/bitcoin/pull/31423
kevkevin has joined #bitcoin-core-dev
Cory81 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
Cory95 has quit [Ping timeout: 272 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/35cae56a9292...68ca13e1f96a
<bitcoin-git> bitcoin/master 26598ed pablomartin4btc: test: Clarify roles in outbound eviction comments
<bitcoin-git> bitcoin/master ec004cd pablomartin4btc: test: Use rehash() in outbound eviction block-relay
<bitcoin-git> bitcoin/master 68ca13e Ava Chow: Merge bitcoin/bitcoin#32823: test: Fix wait_for_getheaders() call in test_...
<bitcoin-git> [bitcoin] achow101 merged pull request #32823: test: Fix wait_for_getheaders() call in test_outbound_eviction_blocks_relay_only() (master...test_p2p_outbound_eviction_block_relay_fix) https://github.com/bitcoin/bitcoin/pull/32823
joetor5 has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 272 seconds]
l0rinc has quit [Ping timeout: 244 seconds]
Saturday7 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
eugenesiegel has quit [Quit: Client closed]
sbddesign has quit [Ping timeout: 245 seconds]
bugs_ has quit [Quit: Leaving]
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
<phantomcircuit> i want to separate activatebestchain running from downloading blocks during ibd, so that means a thread running activatebestchain, what should own that new thread?
jonatack has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 248 seconds]
jon_atack has quit [Ping timeout: 252 seconds]
<phantomcircuit> i was thinking owned by ChainStateManager ?
jon_atack has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68ca13e1f96a...192743235493
<bitcoin-git> bitcoin/master f0524cd Greg Sanders: functional test: correctly detect nonstd TRUC tx vsize in feature_taproot
<bitcoin-git> bitcoin/master 1927432 Ava Chow: Merge bitcoin/bitcoin#32859: functional test: correctly detect nonstd TRUC...
<bitcoin-git> [bitcoin] achow101 merged pull request #32859: functional test: correctly detect nonstd TRUC tx vsize in feature_taproot (master...2025-07-fixup-truc-taproot) https://github.com/bitcoin/bitcoin/pull/32859
sbddesign has quit [Ping timeout: 252 seconds]
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Remote host closed the connection]
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 276 seconds]
jadi has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]