achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
hernanmarino_ has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in]
hernanmarino has joined #bitcoin-core-dev
thelounge4966 has quit [Quit: The Lounge - https://thelounge.chat]
thelounge4966 has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 272 seconds]
thelounge4966 has quit [Client Quit]
thelounge4966 has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
hernanmarino_ has joined #bitcoin-core-dev
hernanmarino has quit [Ping timeout: 276 seconds]
joetor5 has quit [Quit: joetor5]
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
bitcoinlover has joined #bitcoin-core-dev
hacker4web3bitco has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
LainIwakura has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
l0rinc has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
kevkevin has quit [Ping timeout: 276 seconds]
trumae has quit [Quit: trumae]
Christoph_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
bitcoinlover has quit [Ping timeout: 248 seconds]
hacker4web3bitco has quit [Ping timeout: 248 seconds]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
hacker4web3bitco has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
f321x has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
kevkevin has quit [Ping timeout: 260 seconds]
<Sjors[m]1> Would be great to get some review on #32928 so we get better logging for these intermittent CI failures.
<corebot> https://github.com/bitcoin/bitcoin/issues/32928 | test: add logging to mock external signers by Sjors · Pull Request #32928 · bitcoin/bitcoin · GitHub
kevkevin has joined #bitcoin-core-dev
antanst9 has quit [Remote host closed the connection]
antanst9 has joined #bitcoin-core-dev
antanst9 is now known as antanst
Guyver2 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] Sjors opened pull request #33061: subprocess: always check result of close() (master...2025/07/subprocess) https://github.com/bitcoin/bitcoin/pull/33061
LainIwakura has joined #bitcoin-core-dev
rafael_xmr has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
LainIwakura has quit [Quit: Client closed]
LainIwakura has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5ad79b203505...443c32a3e686
<bitcoin-git> bitcoin/master fa11eea MarcoFalke: fuzz: Avoid non-determinism in process_message(s) target (PeerMan)
<bitcoin-git> bitcoin/master aeeeeec MarcoFalke: fuzz: Reset dirty connman state in process_message(s) targets
<bitcoin-git> bitcoin/master fa9a3de MarcoFalke: fuzz: DisableNextWrite
<bitcoin-git> [bitcoin] fanquake merged pull request #32822: fuzz: Make process_message(s) more deterministic (master...2506-fuzz-pm) https://github.com/bitcoin/bitcoin/pull/32822
hacker4web3bitco has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
f321x has quit [Quit: f321x]
Christoph_ has quit [Quit: Christoph_]
kevkevin has quit [Ping timeout: 276 seconds]
jespada has quit [Ping timeout: 248 seconds]
jespada has joined #bitcoin-core-dev
f321x has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
PaperSword has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [qa-assets] maflcko merged pull request #230: Add Murch’s Inputs July 2025 (2nd attempt) (main...2025-07-murch-inputs) https://github.com/bitcoin-core/qa-assets/pull/230
<bitcoin-git> [qa-assets] maflcko pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/fd7e08cd37a1...1b9ff439e9ef
<bitcoin-git> qa-assets/main 10347b1 Murch: Add Murch’s inputs July 2025
<bitcoin-git> qa-assets/main 1b9ff43 maflcko: Merge pull request #230 from murchandamus/2025-07-murch-inputs
Guyver2 has left #bitcoin-core-dev [Closing Window]
Guest16 has joined #bitcoin-core-dev
Guest16 has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/443c32a3e686...6cdc5a90cffe
<bitcoin-git> bitcoin/master fa18376 MarcoFalke: log: Remove function name from init logs
<bitcoin-git> bitcoin/master face812 MarcoFalke: log: [refactor] Use info level for init logs
<bitcoin-git> bitcoin/master 6cdc5a9 merge-script: Merge bitcoin/bitcoin#32967: log: [refactor] Use info level for init logs
<bitcoin-git> [bitcoin] fanquake merged pull request #32967: log: [refactor] Use info level for init logs (master...2507-log-info-init) https://github.com/bitcoin/bitcoin/pull/32967
LainIwakura has quit [Quit: Client closed]
kevkevin has quit [Ping timeout: 272 seconds]
flooded has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] HowHsu opened pull request #33062: truc: optimize the in package relation calculation (master...truc) https://github.com/bitcoin/bitcoin/pull/33062
kevkevin has joined #bitcoin-core-dev
_flood has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 248 seconds]
LainIwakura has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
b10c has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
b10c has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Remote host closed the connection]
joetor5 has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
<josie> i always forget this, but are we able to rerun failed github action jobs? it used to be we could for cirrus ci ones, but i dont see a way to do it on the github action jobs
cedwies has joined #bitcoin-core-dev
dviola has quit [Quit: WeeChat 4.6.3]
dviola has joined #bitcoin-core-dev
Saturday7 has quit [Quit: ZNC 1.10.1 - https://znc.in]
Saturday7 has joined #bitcoin-core-dev
<hebasto> in the GHA “Actor” filler I can see maintainers only. So feel free to ping me to restart a job anytime.
<hebasto> s/filler/filter/
<hebasto> done :)
bugs_ has joined #bitcoin-core-dev
joetor5 has quit [Ping timeout: 248 seconds]
cedwies has quit [Ping timeout: 272 seconds]
cedwies has joined #bitcoin-core-dev
cedwies has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] maflcko opened pull request #33063: util: Revert "common: Close non-std fds before exec in RunCommandJSON" (master...2507-tempoary-revert) https://github.com/bitcoin/bitcoin/pull/33063
cedwies has joined #bitcoin-core-dev
cedwies has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake opened pull request #33064: test: fix RPC coverage check (master...29387_rebased) https://github.com/bitcoin/bitcoin/pull/33064
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6cdc5a90cffe...633d8ea17b9f
<bitcoin-git> bitcoin/master fa1fd07 MarcoFalke: ci: Enable more shellcheck
<bitcoin-git> bitcoin/master 633d8ea merge-script: Merge bitcoin/bitcoin#32970: ci: Enable more shellcheck
<bitcoin-git> [bitcoin] fanquake merged pull request #32970: ci: Enable more shellcheck (master...2507-ci-shellcheck) https://github.com/bitcoin/bitcoin/pull/32970
jonatack has joined #bitcoin-core-dev
LainIwakura38 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors closed pull request #33061: subprocess: always check result of close() (master...2025/07/subprocess) https://github.com/bitcoin/bitcoin/pull/33061
LainIwakura has quit [Ping timeout: 272 seconds]
LainIwakura38 has quit [Ping timeout: 272 seconds]
eugenesiegel has joined #bitcoin-core-dev
<eugenesiegel> hi, does somebody have intuition on what the most expensive-to-validate non-standard tx would be? (assuming <100KvB and only the last input check fails)
<fanquake> cc darosior
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/633d8ea17b9f...fc162299f0cc
<bitcoin-git> bitcoin/master e5a7dfd Daniela Brozzoni: p2p: rename GetAddresses -> GetAddressesUnsafe
<bitcoin-git> bitcoin/master 1cb2399 Daniela Brozzoni: doc: clarify the GetAddresses/GetAddressesUnsafe documentation
<bitcoin-git> bitcoin/master fc16229 merge-script: Merge bitcoin/bitcoin#32994: p2p: rename GetAddresses -> GetAddressesUnsafe
<bitcoin-git> [bitcoin] fanquake merged pull request #32994: p2p: rename GetAddresses - GetAddressesUnsafe (master...docs/getaddresses) https://github.com/bitcoin/bitcoin/pull/32994
Christoph_ has quit [Quit: Christoph_]
LainIwakura has joined #bitcoin-core-dev
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to 29.x: https://github.com/bitcoin/bitcoin/compare/4bf77955edec...565af03c37d8
<bitcoin-git> bitcoin/29.x 735ffad glozow: [build] bump version to 29.1rc1
<bitcoin-git> bitcoin/29.x 06eb42d glozow: [doc] manpages for 29.1rc1
<bitcoin-git> bitcoin/29.x 4c2d285 glozow: [doc] update release notes for v29.1rc1
<bitcoin-git> [bitcoin] fanquake merged pull request #33056: [29.x] final changes for v29.1rc1 (29.x...2025-07-29.1rc1) https://github.com/bitcoin/bitcoin/pull/33056
jespada_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 265 seconds]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 244 seconds]
hacker4web3bitco has quit [Ping timeout: 248 seconds]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
f321x has quit [Quit: f321x]
<darosior> eugenesiegel: i think the worst case is the same between standard or not, because after the expensive computation was performed the attacker can choose to error on either a consensus or a standardness check. I'll share some private research of mine on this topic with you
<darosior> Are you asking in relation to #33050? _aj_ said something similar there
<corebot> https://github.com/bitcoin/bitcoin/issues/33050 | net, validation: don't punish peers for consensus-invalid txs by ajtowns · Pull Request #33050 · bitcoin/bitcoin · GitHub
zeropoint has joined #bitcoin-core-dev
<eugenesiegel> Partially because of that yeah, there is also this comment thread https://github.com/bitcoin/bitcoin/pull/21224#issuecomment-781541708
<bitcoin-git> [bitcoin] glozow pushed tag v29.1rc1: https://github.com/bitcoin/bitcoin/compare/v29.1rc1
<pinheadmz> go go gadget guix!
LainIwakura has quit [Ping timeout: 272 seconds]
<glozow> Woah, feature freeze is in 3 weeks
<darosior> 😬
<glozow> Should we have another call to triage the 30.0 milestone?
dviola has quit [Quit: WeeChat 4.6.3]
<bitcoin-git> [bitcoin] theStack opened pull request #33065: rpc, wallet: replace remaining hardcoded output types with `FormatAllOutputTypes` (master...202507-wallet-rpc_further_outputtypes_replacements) https://github.com/bitcoin/bitcoin/pull/33065
LainIwakura has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 252 seconds]
jespada has joined #bitcoin-core-dev
jespada_ has quit [Ping timeout: 265 seconds]
eugenesiegel38 has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 272 seconds]
eugenesiegel38 has quit [Ping timeout: 272 seconds]
jonatack has quit [Ping timeout: 265 seconds]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
Sam- has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
enochazariah has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
hernanmarino_ has quit [Ping timeout: 260 seconds]
enochazariah has quit [Remote host closed the connection]
enochazariah has joined #bitcoin-core-dev
LainIwakura has quit [Ping timeout: 272 seconds]
hernanmarino has joined #bitcoin-core-dev
hernanmarino has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
jespada_ has joined #bitcoin-core-dev
hernanmarino has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 265 seconds]
LainIwakura has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/fc162299f0cc...b08041cac863
<bitcoin-git> bitcoin/master b635bc0 pablomartin4btc: rpc, util: Add EnsureUniqueWalletName
<bitcoin-git> bitcoin/master 1fc3a8e pablomartin4btc: rpc, test: Add EnsureUniqueWalletName tests
<bitcoin-git> bitcoin/master 53ac704 pablomartin4btc: rpc, test: Fix error message in unloadwallet
<bitcoin-git> [bitcoin] achow101 merged pull request #32845: rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs (master...rpc-fix-unloadwallet-when-no-wallet-name-nor-context) https://github.com/bitcoin/bitcoin/pull/32845
ilghan has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b08041cac863...2e97541396b9
<bitcoin-git> bitcoin/master d89c6fa w0xlt: wallet: Remove `upgradewallet` RPC
<bitcoin-git> bitcoin/master 2e97541 Ava Chow: Merge bitcoin/bitcoin#32944: wallet: Remove `upgradewallet` RPC
<bitcoin-git> [bitcoin] achow101 merged pull request #32944: wallet: Remove `upgradewallet` RPC (master...remove_upgradewallet_rpc) https://github.com/bitcoin/bitcoin/pull/32944
<bitcoin-git> [gui-qml] hebasto closed pull request #470: [WIP] Sync with main repo: CMake + Qt 6 (main...cmake-qt6) https://github.com/bitcoin-core/gui-qml/pull/470
<bitcoin-git> [gui-qml] hebasto closed pull request #215: Create QML test automation target (qml/test/test_bitcoin-qt) (main...qmltest) https://github.com/bitcoin-core/gui-qml/pull/215
<bitcoin-git> [gui-qml] hebasto closed pull request #366: DRAFT: WSL-Ubuntu-Android Build Guide (main...wsl-install-guide) https://github.com/bitcoin-core/gui-qml/pull/366
<bitcoin-git> [gui-qml] hebasto closed pull request #424: QML Load Snapshot Signet (160,000 height) (main...qml-load-snapshot-signet) https://github.com/bitcoin-core/gui-qml/pull/424
<bitcoin-git> [gui-qml] hebasto closed pull request #433: Persist Proxy settings (main...qml-proxy-settings-persistence) https://github.com/bitcoin-core/gui-qml/pull/433
<bitcoin-git> [gui-qml] hebasto closed pull request #436: gui: add Clock icon in the nav bar refs #393 (main...clock-icon-in-navbar) https://github.com/bitcoin-core/gui-qml/pull/436
<bitcoin-git> [gui-qml] hebasto closed pull request #441: Rename Block Clock to Block Status (main...blockstatus) https://github.com/bitcoin-core/gui-qml/pull/441
<bitcoin-git> [gui-qml] hebasto closed pull request #446: [DRAFT] WIP QML Generate Snapshot Signet (main...qml-gen-snapshot-signet) https://github.com/bitcoin-core/gui-qml/pull/446
<bitcoin-git> [gui-qml] hebasto closed pull request #449: [DRAFT] WIP Qml Load Snapshot Onboarding (main...qml-load-snapshot-onboarding) https://github.com/bitcoin-core/gui-qml/pull/449
<bitcoin-git> [gui-qml] hebasto closed pull request #462: Add validation to the Send form (address and amount) (main...send-validation) https://github.com/bitcoin-core/gui-qml/pull/462
<bitcoin-git> [gui-qml] hebasto closed pull request #464: Connect Receive page to WalletQmlModel and Cleanup Layouts (main...paymentrequests) https://github.com/bitcoin-core/gui-qml/pull/464
enochazariah has quit [Ping timeout: 244 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
jespada_ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
<bitcoin-git> [bitcoin] glozow opened pull request #33066: p2p: never check tx rejections by txid (master...2025-07-wtxid-only-rej) https://github.com/bitcoin/bitcoin/pull/33066
Christoph_ has quit [Quit: Christoph_]
eugenesiegel has quit [Quit: Client closed]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
rafael_xmr has quit [Quit: rafael_xmr]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e97541396b9...3b188b8b3dae
<bitcoin-git> bitcoin/master c40dbbb Hennadii Stepanov: test: Move `script_assets_tests` into its own suite
<bitcoin-git> bitcoin/master 3b188b8 Ava Chow: Merge bitcoin/bitcoin#31576: test: Move `script_assets_tests` into its own...
<bitcoin-git> [bitcoin] achow101 merged pull request #31576: test: Move `script_assets_tests` into its own suite (master...241227-test-assets) https://github.com/bitcoin/bitcoin/pull/31576
joetor5 has joined #bitcoin-core-dev
ilghan has quit [Remote host closed the connection]
hoho has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 252 seconds]
jespada has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Guest7 has joined #bitcoin-core-dev
Guest7 has quit [Client Quit]
jon_atack has quit [Ping timeout: 244 seconds]
joetor5 has quit [Quit: joetor5]
enochazariah has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
enochazariah has quit [Remote host closed the connection]
enochazariah has joined #bitcoin-core-dev
LainIwakura has quit [Ping timeout: 272 seconds]