<bitcoin-git>
[bitcoin] l0rinc opened pull request #33021: test: revive test verifying that `GetCoinsCacheSizeState` switches from OK→LARGE→CRITICAL (master...l0rinc/validation_flush_tests) https://github.com/bitcoin/bitcoin/pull/33021
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
fgarau has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
kevkevin has quit [Ping timeout: 252 seconds]
entropyx has quit [Quit: no love here!]
kevkevin has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
fgarau has quit [Ping timeout: 245 seconds]
fgarau has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
fgarau has quit [Ping timeout: 265 seconds]
fgarau has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
entropyx has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
adil has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
Christoph_ has quit [Client Quit]
f321x has joined #bitcoin-core-dev
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
Guest57 has joined #bitcoin-core-dev
Guest57 has quit [Client Quit]
adil has quit [Quit: adil]
VonNaturAustreVe has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
Guest88 has joined #bitcoin-core-dev
Guest88 has quit [Client Quit]
Guyver2 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
jerryf has quit [Ping timeout: 244 seconds]
jerryf_ has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
jerryf_ has quit [Ping timeout: 244 seconds]
kevkevin has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Christoph_ has quit [Quit: Christoph_]
sliv3r__- has joined #bitcoin-core-dev
sliv3r__ has quit [Read error: Connection reset by peer]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
fgarau has quit [Ping timeout: 252 seconds]
kevkevin has quit [Ping timeout: 245 seconds]
kevkevin has joined #bitcoin-core-dev
adil has quit [Quit: adil]
joetor5 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
joetor5 has quit [Ping timeout: 276 seconds]
joetor5 has joined #bitcoin-core-dev
f321x has quit [Quit: f321x]
fgarau has joined #bitcoin-core-dev
CryptoZeroDay71 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
CryptoZeroDay71 has quit [Quit: Client closed]
CryptoZeroDay has joined #bitcoin-core-dev
conman has quit [Ping timeout: 245 seconds]
joetor5 has quit [Quit: joetor5]
f321x has joined #bitcoin-core-dev
CryptoZeroDay has quit [Quit: Client closed]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
fgarau has quit [Ping timeout: 276 seconds]
szkl has quit [Quit: Connection closed for inactivity]
bugs_ has quit [Quit: Leaving]
<phantomcircuit>
in CheckProofOfWork there is a (hardcoded per consensus params) minimum (maximum?) target, given how easy it is to generate headers with more work than this now, is there any reason to enforce this rule in CheckProofOfWork instead of in the nBits rules?
<phantomcircuit>
it's a kind of awkward function in that it's contextfreeish still needing the consensus params
Guest34 has joined #bitcoin-core-dev
Guest34 has quit [Client Quit]
<sipa>
hmm, given that we no longer process headers from the network which don't have known ancestry, i could imagine that being fine
<sipa>
still feels like a very cheap protection, though
<sipa>
i don't really see why needing consensus params is a problrm
kevkevin has quit [Remote host closed the connection]
f321x_ has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
<phantomcircuit>
sipa: im working on an immutableblock class, where accessing the consensus params is mildly annoying (or maybe im just retard)
<phantomcircuit>
but while doing that i'm noticing things like this where the exact way we're checking things probably doesn't make sense anymore
<phantomcircuit>
the logic goes back to satoshi and i think was the only check for nBits being more than minimum work at the time
f321x has quit [Quit: f321x]
<phantomcircuit>
but now i don't believe it's possible to activate the tip with a block with difficulty below the minimum required
<phantomcircuit>
or if we're not checking for minimum work we can fix that in the contextual check block header call
joetor5 has joined #bitcoin-core-dev
<phantomcircuit>
sipa: the immutableblock class is at least partially because unless i really misread things we're calculating the block header hash kinda a lot
Nebraskka has quit [Ping timeout: 240 seconds]
Nebraskka has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
aleggg has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
<bitcoin-git>
[bitcoin] bigshiny90 opened pull request #33023: test: Add functional tests for blockreconstructionextratxn parameter (master...compactblocks-extratxs-tests-core) https://github.com/bitcoin/bitcoin/pull/33023
Christoph_ has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword1 has quit [Client Quit]
PaperSword has quit [Ping timeout: 260 seconds]
PaperSword has joined #bitcoin-core-dev
joetor5 has quit [Ping timeout: 248 seconds]
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
VonNaturAustreVe has joined #bitcoin-core-dev
VonNaturAustreVe has joined #bitcoin-core-dev
VonNaturAustreVe has quit [Client Quit]
bugs_ has joined #bitcoin-core-dev
fgarau has joined #bitcoin-core-dev
fgarau has quit [Ping timeout: 252 seconds]
Nebraskka has quit [Ping timeout: 276 seconds]
<phantomcircuit>
sipa: always open to being hilariously wrong
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
fgarau has joined #bitcoin-core-dev
joetor5 has quit [Ping timeout: 240 seconds]
Nebraskka has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
Nebraskka has quit [Quit: Good day old chaps]
Nebraskka has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
yuvicc has joined #bitcoin-core-dev
yuvicc has joined #bitcoin-core-dev
yuvicc has quit [Client Quit]
ghost43 has quit [Quit: Leaving]
ghost43 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
satanonsolana has joined #bitcoin-core-dev
fgarau has quit [Ping timeout: 244 seconds]
<bitcoin-git>
[bitcoin] marshallshen opened pull request #33025: test: add unit test for psbt_wallet error messages (master...test-error-message) https://github.com/bitcoin/bitcoin/pull/33025
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 276 seconds]
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
fgarau has joined #bitcoin-core-dev
fgarau has quit [Remote host closed the connection]
jon_atack has quit [Ping timeout: 265 seconds]
<bitcoin-git>
[bitcoin] fjahr opened pull request #33026: test, refactor: Embedded ASmap selected preparatory work (master...2023-10-asmap-in-source-prep) https://github.com/bitcoin/bitcoin/pull/33026
bugs_ has quit [Quit: Leaving]
jerryf has quit [Remote host closed the connection]