achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
jespada has quit [Ping timeout: 260 seconds]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
sbddesign has quit [Remote host closed the connection]
memset has quit [Ping timeout: 244 seconds]
sbddesign has joined #bitcoin-core-dev
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
sbddesign has quit [Remote host closed the connection]
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Remote host closed the connection]
sbddesign has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 245 seconds]
hacker4web3bitco has joined #bitcoin-core-dev
Guest76 has joined #bitcoin-core-dev
Guest76 has quit [Client Quit]
joetor5 has quit [Quit: joetor5]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
<phantomcircuit> sipa: i probably did something that's not kosher with current practices but #32885 is at least correct
<corebot> https://github.com/bitcoin/bitcoin/issues/32885 | Cache m_cached_finished_ibd where SetTip is called. by pstratem · Pull Request #32885 · bitcoin/bitcoin · GitHub
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Nebraskka has quit [Quit: Good day old chaps]
Nebraskka has joined #bitcoin-core-dev
wafflefrie has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 276 seconds]
_flood has quit [Read error: Connection reset by peer]
_flood has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 248 seconds]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
<phantomcircuit> also why do we have CheckBlockHeader that only checks the pow... but also has a parameter to skip checking the pow?
jamesob156659 has quit [Read error: Connection reset by peer]
jamesob443688173 has quit [Read error: Connection reset by peer]
jamesob443688173 has joined #bitcoin-core-dev
jamesob156659 has joined #bitcoin-core-dev
f321x has joined #bitcoin-core-dev
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
Guyver2 has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 276 seconds]
hacker4web3bitco has joined #bitcoin-core-dev
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #32888: ci: Use optimized Debug build type in test-each-commit (master...2507-ci-each-commit-debug) https://github.com/bitcoin/bitcoin/pull/32888
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
f321x has quit [Quit: f321x]
kevkevin has quit [Ping timeout: 248 seconds]
greypw1495085720 has quit [Quit: Ping timeout (120 seconds)]
greypw1495085720 has joined #bitcoin-core-dev
<pinheadmz> phantomcircuit: just a guess, maybe for tests? For example to test downstream checks by mutating a valid block without having to solve the block again
<phantomcircuit> pinheadmz: the function used to do two things, one of them was moved and now it just does one check.. sometimes
f321x has joined #bitcoin-core-dev
cold has quit [Ping timeout: 260 seconds]
midnight has quit [Ping timeout: 260 seconds]
midnight has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
probot has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko closed pull request #32874: ci: Catch tests corrupting the source directory (master...2507-ci-less-corrupt) https://github.com/bitcoin/bitcoin/pull/32874
Nebraskka has quit [Quit: Good day old chaps]
kevkevin has quit [Ping timeout: 260 seconds]
Nebraskka has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
<phantomcircuit> should we even be processing full fat blocks we didn't request anymore?
<phantomcircuit> the only time a nodes going to receive a full fat block now is during IBD or if they're connected to an ancient peer?
l0rinc has quit [Quit: l0rinc]
enochazariah has quit [Quit: Client closed]
jespada has joined #bitcoin-core-dev
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #32890: bench: Avoid tmp files in pwd (master...2507-bench-less-clutter) https://github.com/bitcoin/bitcoin/pull/32890
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
<instagibbs> phantomcircuit we request one if compact blocks getblocktxns would be unhelpful (shortxid collision f.e.)
kevkevin has joined #bitcoin-core-dev
wafflefrie has quit [Quit: Connection closed for inactivity]
kevkevin has quit [Ping timeout: 272 seconds]
enochazariah has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
enochazariah has quit [Quit: Client closed]
enochazariah has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 248 seconds]
jonatack has quit [Ping timeout: 260 seconds]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
enochazariah has quit [Quit: Client closed]
enochazariah has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
enochazariah has quit [Remote host closed the connection]
enochazariah has joined #bitcoin-core-dev
enochazariah has quit [Remote host closed the connection]
enochazariah has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] 1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw opened pull request #32891: New SVG, Icons, PNGs and X PixMaps (master...master) https://github.com/bitcoin/bitcoin/pull/32891
kevkevin has quit [Ping timeout: 244 seconds]
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko closed pull request #32891: New SVG, Icons, PNGs and X PixMaps (master...master) https://github.com/bitcoin/bitcoin/pull/32891
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 252 seconds]
sbddesign has quit [Ping timeout: 252 seconds]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
jon_atack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 272 seconds]
joetor5 has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
kevkevin has joined #bitcoin-core-dev
joetor5 has quit [Client Quit]
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin is now known as pablomartin4btc
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3f416dbf763...d33c111448ac
<bitcoin-git> bitcoin/master de4eef5 Cory Fields: threading: use correct mutex name in reverse_lock fatal error messages
<bitcoin-git> bitcoin/master d33c111 merge-script: Merge bitcoin/bitcoin#32829: threading: use correct mutex name in reverse_...
<bitcoin-git> [bitcoin] fanquake merged pull request #32829: threading: use correct mutex name in reverse_lock fatal error messages (master...followupOnGtoCS) https://github.com/bitcoin/bitcoin/pull/32829
<bitcoin-git> [bitcoin] Sjors opened pull request #32892: rpc: use anti-fee-sniping by default (master...2025/07/locktime) https://github.com/bitcoin/bitcoin/pull/32892
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
Cory48 has quit [Quit: Client closed]
Cory48 has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 245 seconds]
jespada has joined #bitcoin-core-dev
hacker4web3bitco has quit [Remote host closed the connection]
joetor5 has quit [Ping timeout: 244 seconds]
joetor5 has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
f321x has quit [Quit: f321x]
sbddesign has quit [Ping timeout: 276 seconds]
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 276 seconds]
sbddesign has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 248 seconds]
sbddesign has joined #bitcoin-core-dev
Cory8 has joined #bitcoin-core-dev
Cory48 has quit [Ping timeout: 272 seconds]
sbddesign has quit [Ping timeout: 268 seconds]
sbddesign has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 244 seconds]
Talkless has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
jonatack has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #32893: doc: fix `BlockConnected` incorrect comment (master...07-2025-block-connected-comment-fix) https://github.com/bitcoin/bitcoin/pull/32893
Cory8 has quit [Quit: Client closed]
Cory8 has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
<bitcoin-git> [bitcoin] murchandamus opened pull request #32894: FUZZ: Test that BnB finds best solution (master...2025-07-bnb-is-optimal-fuzz) https://github.com/bitcoin/bitcoin/pull/32894
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Read error: Connection reset by peer]
jespada has quit [Ping timeout: 276 seconds]
l0rinc has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
Cory2 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
enochazariah has quit [Read error: Connection reset by peer]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
Cory8 has quit [Ping timeout: 272 seconds]
Guest30 has joined #bitcoin-core-dev
Guest30 has quit [Write error: Broken pipe]
<phantomcircuit> instagibbs: yeah thats why i said requested, but we'll process totally unrequested block messages still
jespada_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 248 seconds]
jespada_ has quit [Ping timeout: 252 seconds]
sbddesign has quit [Ping timeout: 248 seconds]
<instagibbs> sure, was responding to the statement right under that one
thoragh has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 opened pull request #32895: wallet: Prepare for future upgrades by recording versions of last client to open and decrypt (master...wallet-lastclient) https://github.com/bitcoin/bitcoin/pull/32895
<bitcoin-git> [bitcoin] ishaanam opened pull request #32896: wallet, rpc: add v3 transaction creation and wallet support (master...wallet_v3_txs) https://github.com/bitcoin/bitcoin/pull/32896
<bitcoin-git> [bitcoin] glozow pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/d33c111448ac...87ab69155d94
<bitcoin-git> bitcoin/master c4287b9 Pieter Wuille: txgraph: Add ability to configure maximum cluster size/weight (feature)
<bitcoin-git> bitcoin/master eabcd0e Greg Sanders: txgraph: remove unnecessary m_group_oversized (simplification)
<bitcoin-git> bitcoin/master 19b14e6 Pieter Wuille: txgraph: Permit transactions that exceed cluster size limit (feature)
<bitcoin-git> [bitcoin] glozow merged pull request #31553: cluster mempool: add TxGraph reorg functionality (master...202412_txgraph_trim) https://github.com/bitcoin/bitcoin/pull/31553
<instagibbs> \o/
Cory34 has joined #bitcoin-core-dev
Cory2 has quit [Ping timeout: 272 seconds]
l0rinc has quit [Quit: l0rinc]
<bitcoin-git> [bitcoin] glozow pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/87ab69155d94...09add84fc5ad
<bitcoin-git> bitcoin/master 9991f49 Ava Chow: test: Watchonly wallets should estimate larger size
<bitcoin-git> bitcoin/master d20dc9c Ava Chow: wallet: Wallets without private keys cannot grind R
<bitcoin-git> bitcoin/master e81d95d Ava Chow: wallet: Remove watchonly balances
<bitcoin-git> [bitcoin] glozow merged pull request #32618: wallet: Remove ISMINE_WATCHONLY and watchonly from RPCs (master...delete-ismine-watchonly) https://github.com/bitcoin/bitcoin/pull/32618
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 276 seconds]
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/09add84fc5ad...fc543f94a9c3
<bitcoin-git> bitcoin/master afaaba6 stratospher: test: refactor out same-txid-diff-wtxid tx to reuse in other tests
<bitcoin-git> bitcoin/master fc543f9 merge-script: Merge bitcoin/bitcoin#32385: test: refactor out same-txid-diff-wtxid tx to...
<bitcoin-git> [bitcoin] glozow merged pull request #32385: test: refactor out same-txid-diff-wtxid tx to reuse in other tests (master...2025_04_tx_malleate) https://github.com/bitcoin/bitcoin/pull/32385
<phantomcircuit> instagibbs: ah yes
<bitcoin-git> [bitcoin] ryanofsky opened pull request #32898: POC: IPC tracing interface (master...pr/trace) https://github.com/bitcoin/bitcoin/pull/32898
eugenesiegel has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 272 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 272 seconds]
<sipa> w00t
<sipa> to the rebase-mobile!
brunoerg_ has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
probot has quit [Quit: Connection closed for inactivity]
joetor5 has joined #bitcoin-core-dev
Guest29 has joined #bitcoin-core-dev
Guest29 has quit [Client Quit]
joetor5 has quit [Remote host closed the connection]
joetor5 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 245 seconds]
dongcarl has quit [Ping timeout: 260 seconds]
_flooded has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 244 seconds]
jonatack has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
sbddesign has quit [Ping timeout: 245 seconds]
bugs_ has quit [Quit: Leaving]
TallTim_ has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 260 seconds]
_flooded has quit [Remote host closed the connection]
_flooded has joined #bitcoin-core-dev
joetor5 has quit [Remote host closed the connection]
joetor5 has joined #bitcoin-core-dev