2019-04-09

< bitcoin-git> [bitcoin] jeffersoncarpenter closed pull request #15762: Declare iterators using auto (master...use-auto) https://github.com/bitcoin/bitcoin/pull/15762

2019-04-08

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15773: test: Add BitcoinTestFramework::sync_* methods (master...1904-qaSyncNew) https://github.com/bitcoin/bitcoin/pull/15773
< bitcoin-git> [bitcoin] kallewoof closed pull request #15753: RPC/testing: logprint RPC command (master...rpc-logprint) https://github.com/bitcoin/bitcoin/pull/15753
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15772: test: Properly log named args in authproxy (master...1904-qaLogNamedArgs) https://github.com/bitcoin/bitcoin/pull/15772
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15771: qa: Retry opening .cookie files (master...2019-04-retry-open-cookie) https://github.com/bitcoin/bitcoin/pull/15771
< instagibbs> wumpus, i sometimes get emails from random shitcoins that backport something I got merged into bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15763: Update bips.md for 0.18.0 (master...201904_updatebipsmd) https://github.com/bitcoin/bitcoin/pull/15763
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/297ea51caf2f...a238fccce84b
< bitcoin-git> bitcoin/master 65d2f5d Pieter Wuille: Update bips.md for 0.18.0
< bitcoin-git> bitcoin/master a238fcc MarcoFalke: Merge #15763: Update bips.md for 0.18.0
< bitcoin-git> [bitcoin] promag opened pull request #15770: rpc: Validate maxfeerate with AmountFromValue (master...2019-04-maxfeerate) https://github.com/bitcoin/bitcoin/pull/15770
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15760: doc: Clarify sendrawtransaction::maxfeerate==0 help (master...1904-docRpcRaw) https://github.com/bitcoin/bitcoin/pull/15760
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/414d8461fd67...297ea51caf2f
< bitcoin-git> bitcoin/master fa49db7 MarcoFalke: doc: Clarify sendrawtransaction::maxfeerate==0 help
< bitcoin-git> bitcoin/master 297ea51 MarcoFalke: Merge #15760: doc: Clarify sendrawtransaction::maxfeerate==0 help
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4e74f938b75...414d8461fd67
< bitcoin-git> bitcoin/master faf62d9 MarcoFalke: gui: Generate bech32 addresses by default
< bitcoin-git> bitcoin/master 414d846 MarcoFalke: Merge #15711: gui: Generate bech32 addresses by default
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15711: gui: Generate bech32 addresses by default (master...1904-guiBech32) https://github.com/bitcoin/bitcoin/pull/15711
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15446: Improve depends debuggability (master...2019-02-improve-depends-debuggability) https://github.com/bitcoin/bitcoin/pull/15446
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/327d2746fb92...b4e74f938b75
< bitcoin-git> bitcoin/master 80f0e05 Carl Dong: depends: Preprocessing doesn't care about deps
< bitcoin-git> bitcoin/master 6d44c5e Carl Dong: depends: Add commands for each package for each stage
< bitcoin-git> bitcoin/master b4e74f9 MarcoFalke: Merge #15446: Improve depends debuggability
< bitcoin-git> [bitcoin] domob1812 closed pull request #15381: Optionally return HTTP_OK for RPC errors (master...httprpc-error-code) https://github.com/bitcoin/bitcoin/pull/15381
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efbc86733a55...327d2746fb92
< bitcoin-git> bitcoin/master 8f5d943 Daniel Kraft: Add regtests for HTTP status codes.
< bitcoin-git> bitcoin/master 327d274 Jonas Schnelli: Merge #15495: Add regtests for HTTP status codes
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15495: Add regtests for HTTP status codes (master...test-http-code) https://github.com/bitcoin/bitcoin/pull/15495
< bitcoin-git> [bitcoin] crackercracked closed pull request #15769: Doc/Trivial change key name duration->duration-ms for getrpcinfo (master...fix-issue-15555-change-duration-key-getrpcinfo) https://github.com/bitcoin/bitcoin/pull/15769
< bitcoin-git> [bitcoin] crackercracked opened pull request #15769: Doc/Trivial change key name duration->duration-ms for getrpcinfo (master...fix-issue-15555-change-duration-key-getrpcinfo) https://github.com/bitcoin/bitcoin/pull/15769

2019-04-07

< bitcoin-git> [bitcoin] IPGlider opened pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
< bitcoin-git> [bitcoin] fanquake opened pull request #15765: doc: correct bitcoinconsensus_version in shared-libraries.md (master...bitcoin_consensus_version) https://github.com/bitcoin/bitcoin/pull/15765
< bitcoin-git> [bitcoin] hebasto opened pull request #15766: scripts and tools: Upgrade gitian image before signing (master...20190407-gitian-upgrade-image) https://github.com/bitcoin/bitcoin/pull/15766

2019-04-06

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15660: [qa] Overhaul p2p_compactblocks.py (master...2019-03-refactor-p2p-compactblocks-2) https://github.com/bitcoin/bitcoin/pull/15660
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e439aeb30c04...efbc86733a55
< bitcoin-git> bitcoin/master 7813eb1 Suhas Daftuar: [qa] Overhaul p2p_compactblocks.py
< bitcoin-git> bitcoin/master efbc867 MarcoFalke: Merge #15660: [qa] Overhaul p2p_compactblocks.py
< bitcoin-git> [bitcoin] achow101 opened pull request #15764: Native descriptor wallets (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/15764
< bitcoin-git> [bitcoin] sipa merged pull request #15508: Refactor analyzepsbt for use outside RPC code (master...feature-separate-analyzepsbt) https://github.com/bitcoin/bitcoin/pull/15508
< bitcoin-git> [bitcoin] sipa pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/35991b162fd1...e439aeb30c04
< bitcoin-git> bitcoin/master afd20a2 Glenn Willen: Move PSBT decoding functions from core_io to psbt.cpp
< bitcoin-git> bitcoin/master ef22fe8 Glenn Willen: Refactor analyzepsbt for use outside RPC code
< bitcoin-git> bitcoin/master 892eff0 Glenn Willen: Add documentation of struct PSBTAnalysis et al
< bitcoin-git> [bitcoin] sipa opened pull request #15763: Update bips.md for 0.18.0 (master...201904_updatebipsmd) https://github.com/bitcoin/bitcoin/pull/15763
< instagibbs> for elements we partially reverted #13005 because debugging was so annoying and locally in my bitcoin dir i do the same
< gribble> https://github.com/bitcoin/bitcoin/issues/13005 | Make --enable-debug to pick better options by practicalswift · Pull Request #13005 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jeffersoncarpenter opened pull request #15762: Declare iterators using auto (master...use-auto) https://github.com/bitcoin/bitcoin/pull/15762
< bitcoin-git> [bitcoin] achow101 opened pull request #15761: Replace -upgradewallet startup option with upgradewallet RPC (master...upgradewallet-rpc) https://github.com/bitcoin/bitcoin/pull/15761
< gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub

2019-04-05

< gmaxwell> $ grep 'Successfully reconstructed' ~/.bitcoin/debug.log.old | tail -n 144 | awk '{misses += $22>0} END {print misses/NR}'
< gmaxwell> echeveria: $ grep 'Successfully reconstructed' ~/.bitcoin/debug.log | tail -n 1008 | awk '{misses += $22>0} END {print misses/NR}'
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15759: [p2p] Add 2 outbound blocks-only connections (master...2019-03-blocksonly-edges) https://github.com/bitcoin/bitcoin/pull/15759
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15758: qa: Add further tests to wallet_balance (master...1904-qaWalletBal) https://github.com/bitcoin/bitcoin/pull/15758
< bitcoin-git> [bitcoin] sipa opened pull request #15757: List new RPCs in psbt.md and descriptors.md (master...201904_docupdate) https://github.com/bitcoin/bitcoin/pull/15757
< bitcoin-git> [bitcoin] promag opened pull request #15756: gui: Add shortcuts for tab tools (master...2019-04-tools-shortcuts) https://github.com/bitcoin/bitcoin/pull/15756
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15755: rpc: remove unused var in rawtransaction.cpp (master...remove-unused-var) https://github.com/bitcoin/bitcoin/pull/15755
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c83442e17412...35991b162fd1
< bitcoin-git> bitcoin/master 4831aec Peter Bushnell: Remove unused var
< bitcoin-git> bitcoin/master 35991b1 MarcoFalke: Merge #15755: rpc: remove unused var in rawtransaction.cpp
< bitcoin-git> [bitcoin] Bushstar opened pull request #15755: qt: remove unused var (master...remove-unused-var) https://github.com/bitcoin/bitcoin/pull/15755
< bitcoin-git> [bitcoin] benthecarman opened pull request #15754: rpc: getrpcinfo docs (master...rpc_get_info_doc) https://github.com/bitcoin/bitcoin/pull/15754
< bitcoin-git> [bitcoin] kallewoof opened pull request #15753: RPC/testing: logprint RPC command (master...rpc-logprint) https://github.com/bitcoin/bitcoin/pull/15753

2019-04-04

< bitcoin-git> [bitcoin] madeken opened pull request #15752: Remove redundant shuffle in KnapsackSolver (master...master) https://github.com/bitcoin/bitcoin/pull/15752
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/daef20fb50c0...c83442e17412
< bitcoin-git> bitcoin/master fa8548c MarcoFalke: net: Remove unused unsanitized user agent string CNode::strSubVer
< bitcoin-git> bitcoin/master c83442e MarcoFalke: Merge #15654: net: Remove unused unsanitized user agent string CNode::strS...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15654: net: Remove unused unsanitized user agent string CNode::strSubVer (master...1903-netUABytes) https://github.com/bitcoin/bitcoin/pull/15654
< bitcoin-git> [bitcoin] sipa opened pull request #15751: Speed up deriveaddresses for large ranges (master...201904_fasterderiveaddresses) https://github.com/bitcoin/bitcoin/pull/15751
< bitcoin-git> [bitcoin] jnewbery opened pull request #15750: [rpc] Remove the addresses field from the getaddressinfo return object (master...2019_04_remove_address_from_getaddressinfo) https://github.com/bitcoin/bitcoin/pull/15750
< bitcoin-git> [bitcoin] sipa opened pull request #15749: Fix: importmulti only imports origin info for PKH outputs (master...201904_importallorigins) https://github.com/bitcoin/bitcoin/pull/15749
< bitcoin-git> [bitcoin] jnewbery opened pull request #15748: [rpc] remove dead mining code (master...2019_04_simplify_generate) https://github.com/bitcoin/bitcoin/pull/15748
< gribble> https://github.com/bitcoin/bitcoin/issues/15725 | Manual coin control dialog interacts badly with multiple wallets · Issue #15725 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14626 | Select orphan transaction uniformly for eviction by sipa · Pull Request #14626 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15743 | getaddressinfo missing key origin information for multisig · Issue #15743 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] jamesob closed pull request #15735: Add scheduler deadlock detection (master...2019-04-serialize-scheduler) https://github.com/bitcoin/bitcoin/pull/15735
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15747: wallet: Remove plethora of Get*Balance (master...1903-walletBal) https://github.com/bitcoin/bitcoin/pull/15747
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15596: rpc: Ignore sendmany::minconf as dummy value (master...1903-rpcWalletDummySendmany_2) https://github.com/bitcoin/bitcoin/pull/15596
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ba54342c9dd3...daef20fb50c0
< bitcoin-git> bitcoin/master fae5f87 MarcoFalke: rpc: Document that minconf is an ignored dummy value
< bitcoin-git> bitcoin/master faa3a24 MarcoFalke: scripted-diff: wallet: Rename pcoin to wtx
< bitcoin-git> bitcoin/master fac1a0f MarcoFalke: wallet: Remove unused GetLegacyBalance
< araspitzu> Hi, does anybody have more info on the error "Transaction too large for fee policy"? Seems to happen at https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2986
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15746: rpc: RPCHelpMan: Always name dictionary keys (master...1904-rpcUtilFix) https://github.com/bitcoin/bitcoin/pull/15746
< bitcoin-git> [bitcoin] Empact opened pull request #15744: Extract ParseDescriptorRange (master...parse-descriptor-range) https://github.com/bitcoin/bitcoin/pull/15744
< gribble> https://github.com/bitcoin/bitcoin/issues/15743 | getaddressinfo missing key origin information for multisig · Issue #15743 · bitcoin/bitcoin · GitHub
< gwillen> btw supay, are you only using bitcoin core for rescuing this old wallet? I.e. you have no other funds in it?
< achow101> supay: bitcoin core's default wallet will generate 2000 keys automatically
< gribble> https://github.com/bitcoin/bitcoin/issues/15736 | Unable to importprivkey · Issue #15736 · bitcoin/bitcoin · GitHub
< achow101> supay: can you try `bitcoin-cli listaddressgroupings` and see if your address is in there?
< gwillen> if you are trying to import the master privkey, that is your problem -- bitcoin core does not know about bip 44, and won't try to derive the child keys automatically
< supay> gmaxwell: i've done: bitcoin-cli importprivkey the_key "" true -- and i wait about 25 mins or so for the rescan, and when i run bitcoin-cli getwalletinfo, the balances are still 0
< supay> i lost access to my bitcoin and scrubbed my system for any data i could find. found some bip32/44 paths. trying to import private keys into bitcoin core using importprivkey, but that isn't working. there aren't any errors either. any help?

2019-04-03

< bitcoin-git> [bitcoin] kallewoof closed pull request #13746: -masterdatadir for datadir bootstrapping (master...masterdatadir) https://github.com/bitcoin/bitcoin/pull/13746
< bitcoin-git> [bitcoin] achow101 opened pull request #15741: Batch write imported stuff in importmulti (master...batch-write-importmulti) https://github.com/bitcoin/bitcoin/pull/15741
< gribble> https://github.com/bitcoin/bitcoin/issues/15739 | large ranged descriptor imports are sloooooooooow. · Issue #15739 · bitcoin/bitcoin · GitHub
< gmaxwell> jl2012: there isn't a chinese version of bitcoin.org or something that only shows old links? I'm just at a loss as to what would be causing people to start new nodes using old code.
< bitcoin-git> [bitcoin] jamesob opened pull request #15735: Add scheduler deadlock detection (master...2019-04-serialize-scheduler) https://github.com/bitcoin/bitcoin/pull/15735
< instagibbs> the bitcoin-maintainer one is the more useful one IIRC
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15685: doc: rpc-mining: Clarify error messages (master...1903-docMining) https://github.com/bitcoin/bitcoin/pull/15685
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2c364fde423e...ba54342c9dd3
< bitcoin-git> bitcoin/master fa292ad MarcoFalke: doc: rpc-mining: Clarify error messages
< bitcoin-git> bitcoin/master ba54342 MarcoFalke: Merge #15685: doc: rpc-mining: Clarify error messages
< bitcoin-git> [bitcoin] promag opened pull request #15730: rpc: Show scanning details in getwalletinfo (master...2019-04-getwalletinfo-scanning) https://github.com/bitcoin/bitcoin/pull/15730
< cheetah2> im getting error code -28 prunning blockstore with bitcoin-cli getinfo does it mean its crashed or is it working?
< bitcoin-git> [bitcoin] promag opened pull request #15729: rpc: Ignore minconf parameter in getbalance (master...2019-04-drop-getbalance-minconf) https://github.com/bitcoin/bitcoin/pull/15729
< bitcoin-git> [bitcoin] jnewbery opened pull request #15728: [wallet] Refactor relay transactions (master...2019_03_refactor_relay_transactions) https://github.com/bitcoin/bitcoin/pull/15728
< bitcoin-git> [bitcoin] ajtowns opened pull request #15726: bitcoin-cli -yaml support (master...201904-cli-yaml) https://github.com/bitcoin/bitcoin/pull/15726
< gribble> https://github.com/bitcoin/bitcoin/issues/15725 | Manual coin control dialog interacts badly with multiple wallets · Issue #15725 · bitcoin/bitcoin · GitHub
< gmaxwell> jl2012: ^ any thoughts for this? is it possible some high visibility chinese language bitcoin resource links to 0.16.1 ?
< wumpus> (e.g. freeze one version of bitcoin core as "stable")
< jonasschnelli> cfields: 0.18.0rc3 osx detached signatures are here: https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/24
< wumpus> fanquake: thanks for keeping an eye on changes to the release notes-if this keeps up we'll have to restrict edits to people in the bitcoin-core org (I'd prefer not to as this loses some potential documentation-only contributors), but this may well be accidental and they fixed it
< gmaxwell> $ ./bitcoin-cli getblocktemplate
< gmaxwell> I'm just ./bitcoin-cli getblocktemplate '{"rules": ["segwit"]}' | jq '.transactions | .[] | select(.hash != .txid)' |less and hitting / and pasting in the txid.
< gmaxwell> I did: $ ./bitcoin-cli prioritisetransaction 35611cbad11967731aa122136bf90bd63c5224296c45c10a26885c3bb3fff6f6 0 100000
< gmaxwell> ./bitcoin-cli getblocktemplate '{"rules": ["segwit"]}' | jq '.transactions | .[] | select(.hash != .txid)'
< fanquake> I assume this was accidental, rather than spam (as it was reverted right after). Just need to keep an eye on the wiki.. https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft/_compare/af6d617%5E...af6d617

2019-04-02

< gwillen> achow101: also, can you advise me on the intended way of using https://github.com/bitcoin/bitcoin/pull/14075
< gmaxwell> the tests are in bitcoin/test/functional/mining_prioritisetransaction.py
< gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15722: doc: Change block chain to blockchain in doc (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/15722
< bitcoin-git> [bitcoin] emilengler opened pull request #15722: doc: Change block chain to blockchain in doc (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/15722
< bitcoin-git> [bitcoin] laanwj closed pull request #15712: Update Copyright -> 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15712
< gribble> https://github.com/bitcoin/bitcoin/issues/15717 | Changes to support NAT-PMP by MishraShivendra · Pull Request #15717 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8dbb2c5e6704...2c364fde423e
< bitcoin-git> bitcoin/master ac67582 fanquake: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
< bitcoin-git> bitcoin/master 2c364fd MarcoFalke: Merge #14853: depends: latest RapidCheck
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #14853: depends: latest RapidCheck (master...latest-rapidcheck) https://github.com/bitcoin/bitcoin/pull/14853
< bitcoin-git> [bitcoin] practicalswift opened pull request #15721: validation: Check absence of locks at compile-time (LOCKS_EXCLUDED) in addition to the current run-time checking (AssertLockNotHeld) (master...negative-locking-annotations) https://github.com/bitcoin/bitcoin/pull/15721
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5a2a9b5b0603...8dbb2c5e6704
< bitcoin-git> bitcoin/master f516245 John Newbery: [rpc] remove resendwallettransactions RPC
< bitcoin-git> bitcoin/master ea1a2d8 John Newbery: [wallet] Remove ResendWalletTransactionsBefore
< bitcoin-git> bitcoin/master 8dbb2c5 MarcoFalke: Merge #15680: Remove resendwallettransactions RPC method
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15680: Remove resendwallettransactions RPC method (master...2019_03_remove_resendwallettransactions) https://github.com/bitcoin/bitcoin/pull/15680
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc3
< bitcoin-git> [bitcoin] laanwj pushed 9 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/7bcf90cb01aa...32ec90085044
< bitcoin-git> bitcoin/0.18 6355214 Pieter Wuille: Simplify orphan processing in preparation for interruptibility
< bitcoin-git> bitcoin/0.18 bb60121 Pieter Wuille: [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx
< bitcoin-git> bitcoin/0.18 50c56f2 Pieter Wuille: Interrupt orphan processing after every transaction
< bitcoin-git> [bitcoin] laanwj merged pull request #15691: 0.18: rc3 backports (0.18...1904-18B) https://github.com/bitcoin/bitcoin/pull/15691
< gribble> https://github.com/bitcoin/bitcoin/issues/15691 | 0.18: rc3 backports by MarcoFalke · Pull Request #15691 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] scravy closed pull request #15715: Better support for mainframes and EBCDIC users in general (master...cater-mainframes-and-ebcdic-users) https://github.com/bitcoin/bitcoin/pull/15715
< bitcoin-git> [bitcoin] laanwj closed pull request #15714: tests: Volkswagen (master...1904-testsVolkswagen) https://github.com/bitcoin/bitcoin/pull/15714

2019-04-01

< bitcoin-git> [bitcoin] fanquake closed pull request #15720: Ssk22014 (master...ssk22014-patch-1) https://github.com/bitcoin/bitcoin/pull/15720
< bitcoin-git> [bitcoin] ssk22014 opened pull request #15720: Ssk22014 (master...ssk22014-patch-1) https://github.com/bitcoin/bitcoin/pull/15720
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15719: Drop Chain::requestMempoolTransactions method (master...pr/pool) https://github.com/bitcoin/bitcoin/pull/15719
< dongcarl> Can someone explain to me the context behind `GetGroup`? My git digging lead me to a +1041 −546 commit here: https://github.com/bitcoin/bitcoin/pull/735/commits/67a42f929b1434f647c63922fd02dc2b93b28060
< bitcoin-git> [bitcoin] dongcarl opened pull request #15718: [WIP] docs: Improve netaddress comments (master...2019-04-netaddr-comments) https://github.com/bitcoin/bitcoin/pull/15718
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15652: wallet: Update transactions with current mempool after load (master...2019-03-fix-15591) https://github.com/bitcoin/bitcoin/pull/15652
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/35477e9e4e3f...5a2a9b5b0603
< bitcoin-git> bitcoin/master 0440481 João Barbosa: wallet: Move CWallet::ReacceptWalletTransactions locks to callers
< bitcoin-git> bitcoin/master 57908a7 João Barbosa: interfaces: Add Chain::requestMempoolTransactions
< bitcoin-git> bitcoin/master 2ebf650 João Barbosa: wallet: Update transactions with current mempool after load
< bitcoin-git> [bitcoin] MishraShivendra opened pull request #15717: Changes to support NAT-PMP (master...master) https://github.com/bitcoin/bitcoin/pull/15717
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15644: Make orphan processing interruptible (master...201903_interruptibleorphans) https://github.com/bitcoin/bitcoin/pull/15644
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/79c345a0114c...35477e9e4e3f
< bitcoin-git> bitcoin/master 9453018 Pieter Wuille: Simplify orphan processing in preparation for interruptibility
< bitcoin-git> bitcoin/master 6e051f3 Pieter Wuille: [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx
< bitcoin-git> bitcoin/master 866c805 Pieter Wuille: Interrupt orphan processing after every transaction
< gribble> https://github.com/bitcoin/bitcoin/issues/15596 | rpc: Ignore sendmany::minconf as dummy value by MarcoFalke · Pull Request #15596 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] scravy opened pull request #15715: Better support for mainframes and EBCDIC users in general (master...cater-mainframes-and-ebcdic-users) https://github.com/bitcoin/bitcoin/pull/15715
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15714: tests: Volkswagen (master...1904-testsVolkswagen) https://github.com/bitcoin/bitcoin/pull/15714
< bitcoin-git> [bitcoin] ariard opened pull request #15713: refactor: Replace chain relayTransactions/submitMemoryPool by higher method (master...2019-03-refactor-relay-tx-submit-pool) https://github.com/bitcoin/bitcoin/pull/15713
< bitcoin-git> [bitcoin] jonathancross opened pull request #15712: Update Copyright -> 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15712

2019-03-31

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15711: gui: Generate bech32 addresses by default (master...1904-guiBech32) https://github.com/bitcoin/bitcoin/pull/15711
< bitcoin-git> [bitcoin] fanquake closed pull request #15692: doc: Mention wiki release notes draft in release-process (master...1904-docRel) https://github.com/bitcoin/bitcoin/pull/15692
< bitcoin-git> [bitcoin] Bushstar opened pull request #15710: Catch ios_base::failure specifically (master...walletdb-readthrow) https://github.com/bitcoin/bitcoin/pull/15710
< bitcoin-git> [bitcoin] Bushstar opened pull request #15709: Do not add setting as unknown (master...walletdb-settings) https://github.com/bitcoin/bitcoin/pull/15709
< wumpus> (there's nothing wrong with asking that question on twitter on your own personal accord, but having it come from "bitcoin core" is going to cause lots of noise)
< moneyball> i was just wondering if it is a communication option for things like this https://github.com/bitcoin/bitcoin/issues/15560#issuecomment-478300049

2019-03-30

< bitcoin-git> [bitcoin] vcgato29 opened pull request #15707: Local v0.17.1 (master...local-v0.17.1) https://github.com/bitcoin/bitcoin/pull/15707
< bitcoin-git> [bitcoin] fanquake closed pull request #15707: Local v0.17.1 (master...local-v0.17.1) https://github.com/bitcoin/bitcoin/pull/15707
< bitcoin-git> [bitcoin] lucayepa opened pull request #15706: Check QT library version (master...check-qt-version) https://github.com/bitcoin/bitcoin/pull/15706
< bitcoin-git> [bitcoin] luke-jr opened pull request #15704: Move Win32 defines to configure.ac to ensure they are globally defined (master...win32_defines_globally) https://github.com/bitcoin/bitcoin/pull/15704
< bitcoin-git> [bitcoin] sipa opened pull request #15703: Update secp256k1 subtree to latest upstream (master...201903_secp256k1) https://github.com/bitcoin/bitcoin/pull/15703

2019-03-29

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00ca24b68fc4...79c345a0114c
< bitcoin-git> bitcoin/master afc06fc Torkel Rogstad: rpc: Fix help text for signtransactionwithXXX
< bitcoin-git> bitcoin/master 79c345a MarcoFalke: Merge #15669: rpc: Fix help text for signtransactionwithXXX
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15669: rpc: Fix help text for signtransactionwithXXX (master...signrawtx-rpc-help) https://github.com/bitcoin/bitcoin/pull/15669
< bitcoin-git> bitcoin/master 1111f07 MarcoFalke: test: .style.yapf: Set column_limit=160
< bitcoin-git> bitcoin/master 00ca24b MarcoFalke: Merge #15533: test: .style.yapf: Set column_limit=160
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15533: test: .style.yapf: Set column_limit=160 (master...1903-testNoPep8Collim) https://github.com/bitcoin/bitcoin/pull/15533
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0baf4b1f9663...00ca24b68fc4
< bitcoin-git> [bitcoin] jnewbery closed pull request #15010: [wallet] Fix getbalance with minconf (master...fix_getbalance_with_minconf) https://github.com/bitcoin/bitcoin/pull/15010
< sipa> yeah, so your bitcoin core wallet will correspond to a union of several things that are (possibly) compatible with an electrum wallet individually
< bitcoin-git> [bitcoin] promag opened pull request #15700: rfc: Synchronize validation interface registration (master...2019-03-sync-validation-interface-registration) https://github.com/bitcoin/bitcoin/pull/15700
< bitcoin-git> [bitcoin] practicalswift opened pull request #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. (master...remove-CClientUIInterface-signal_name_disconnect) https://github.com/bitcoin/bitcoin/pull/15699
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic (master...1904-qaMagicAtomic) https://github.com/bitcoin/bitcoin/pull/15697
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15696: [qa] test_runner: Move feature_pruning to base tests (master...1904-qaPruning) https://github.com/bitcoin/bitcoin/pull/15696
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15683: Comment for seemingly duplicate LIBBITCOIN_SERVER (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15683
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dc5c2e440746...0baf4b1f9663
< bitcoin-git> bitcoin/master 2a1408c Peter Bushnell: Comment for seemingly duplicate LIBBITCOIN_SERVER
< bitcoin-git> bitcoin/master 0baf4b1 MarcoFalke: Merge #15683: Comment for seemingly duplicate LIBBITCOIN_SERVER
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15686: [tests] make pruning test faster (master...2019_03_faster_pruning_test) https://github.com/bitcoin/bitcoin/pull/15686
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/904129b35dd6...dc5c2e440746
< bitcoin-git> bitcoin/master 1c29ac4 John Newbery: [tests] style fixes in feature_pruning.py
< bitcoin-git> bitcoin/master 03d6d23 John Newbery: [tests] make pruning test faster
< bitcoin-git> bitcoin/master dc5c2e4 MarcoFalke: Merge #15686: [tests] make pruning test faster
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/edc68d40e968...904129b35dd6
< bitcoin-git> bitcoin/master 8b8d8ee Graham Krizek: Remove travis_wait from lint script
< bitcoin-git> bitcoin/master 904129b MarcoFalke: Merge #15255: [tests] Remove travis_wait from lint script
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15255: [tests] Remove travis_wait from lint script (master...remove-travis_wait) https://github.com/bitcoin/bitcoin/pull/15255
< gribble> https://github.com/bitcoin/bitcoin/issues/15255 | [tests] Remove travis_wait from lint script by gkrizek · Pull Request #15255 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e7dc682e0f6...edc68d40e968
< bitcoin-git> bitcoin/master f6ee177 practicalswift: Remove unused AES-128 code
< bitcoin-git> bitcoin/master edc68d4 Jonas Schnelli: Merge #15663: crypto: Remove unused AES-128 code
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15663: crypto: Remove unused AES-128 code (master...aes-128) https://github.com/bitcoin/bitcoin/pull/15663

2019-03-28

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15693: travis: Switch to ubuntu keyserver to avoid timeouts (master...1903-travisKeyTimeout) https://github.com/bitcoin/bitcoin/pull/15693
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15692: doc: Mention wiki release notes draft in release-process (master...1904-docRel) https://github.com/bitcoin/bitcoin/pull/15692
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15691: 0.18: rc3 backports (0.18...1904-18B) https://github.com/bitcoin/bitcoin/pull/15691
< jonasschnelli> "Digital Signature" shows "Bitcoin Core Code Signing Association"... Digest is sha1
< bitcoin-git> [bitcoin] dongcarl opened pull request #15689: netaddress: Update CNetAddr for ORCHIDv2 (master...2019-03-account-for-orchidv2) https://github.com/bitcoin/bitcoin/pull/15689
< gmaxwell> I've always made a point of CCing other people (usually wumpus and sipa) anytime I communicated something 'for bitcoin core project', even dumb stuff like lame whining at people for idiotic tweets. ... just so if I drop off the face of the earth someone has context.
< moneyball> this is a summary of our guidance https://github.com/bitcoin/bitcoin/issues/15560#issuecomment-471690972
< sipa> the left column which is mostly green on https://en.bitcoin.it/wiki/Bech32_adoption is pretty encouraging
< gmaxwell> I'm concerned that we're erroring a little too strongly towards total compatiblity, which is causing industry participants to make an economically rational decision to ignore updating their bitcoin support in favor of supporting more altcoins.
< gribble> https://github.com/bitcoin/bitcoin/issues/15560 | When to make bech32 the default -addresstype? · Issue #15560 · bitcoin/bitcoin · GitHub
< MarcoFalke> > htop is telling me bitcoin-opencon is responsible. Peers are neither added or dropped coinciding with the CPU spike
< gribble> https://github.com/bitcoin/bitcoin/issues/15665 | 0.18.0 rc2 CPU spike in thread bitcoin-opencon · Issue #15665 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15652 | wallet: Update transactions with current mempool after load by promag · Pull Request #15652 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15652 | wallet: Update transactions with current mempool after load by promag · Pull Request #15652 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< moneyball> we have 1 proposed topic! topic proposed by gmaxwell: Bech32 support shipped first in Bitcoin Core in Feb 2018, more than a year ago. We should consider making an announcement that Bitcoin Core intends to change the default addresstype from p2sh-segwit to bech32 in 0.19 or 0.20.
< bitcoin-git> [bitcoin] jonatack opened pull request #15687: test: tool wallet test coverage for unexpected writes to wallet (master...tool-wallet-tests-for-unexpected-writes-to-wallet-file) https://github.com/bitcoin/bitcoin/pull/15687
< bitcoin-git> [bitcoin] instagibbs closed pull request #15547: Switch wallet default to reject too-long transaction chains for mempool (master...walletreject_true) https://github.com/bitcoin/bitcoin/pull/15547
< bitcoin-git> [bitcoin] jnewbery opened pull request #15686: [tests] make pruning test faster (master...2019_03_faster_pruning_test) https://github.com/bitcoin/bitcoin/pull/15686
< bitcoin-git> [bitcoin] dongcarl closed pull request #15671: net: Don't return unreachable local addresses for peer (master...2019-03-fix-getlocal) https://github.com/bitcoin/bitcoin/pull/15671
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/32e0428e371e...9e7dc682e0f6
< bitcoin-git> bitcoin/master faad33f MarcoFalke: rpc: Clarify decodescript RPCResult doc
< bitcoin-git> bitcoin/master fa3caa1 MarcoFalke: rpc: decodescript use IsValidNumArgs over hardcoded check
< bitcoin-git> bitcoin/master fa926ec MarcoFalke: rpc: Mention all output types in decodescript doc
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15616: rpc: Clarify decodescript RPCResult doc (master...1903-rpcDocDecodeS) https://github.com/bitcoin/bitcoin/pull/15616
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15684: doc/dependencies: Fix typo libsrvg->librsvg (master...typo_libsrvg) https://github.com/bitcoin/bitcoin/pull/15684
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/edb8df4fea13...32e0428e371e
< bitcoin-git> bitcoin/master 7d01b5c Luke Dashjr: doc/dependencies: Fix typo libsrvg->librsvg
< bitcoin-git> bitcoin/master 32e0428 MarcoFalke: Merge #15684: doc/dependencies: Fix typo libsrvg->librsvg
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15685: doc: rpc-mining: Clarify error messages (master...1903-docMining) https://github.com/bitcoin/bitcoin/pull/15685
< bitcoin-git> [bitcoin] luke-jr opened pull request #15684: doc/dependencies: Fix typo libsrvg->librsvg (master...typo_libsrvg) https://github.com/bitcoin/bitcoin/pull/15684
< bitcoin-git> [bitcoin] Bushstar opened pull request #15683: Comment for seemingly duplicate LIBBITCOIN_SERVER (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15683
< bitcoin-git> [bitcoin] murrayn closed pull request #15500: Support for a bitcoind 'ready' file to indicate startup is complete. (master...ready_file) https://github.com/bitcoin/bitcoin/pull/15500
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/dcd96b84cf82...7bcf90cb01aa
< bitcoin-git> bitcoin/0.18 7bcf90c Wladimir J. van der Laan: doc: Update manpages for changes since rc2
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/f14a0aa99b84...dcd96b84cf82
< bitcoin-git> bitcoin/0.18 dcd96b8 Cory Fields: release: Update the Windows Codesigning certificate
< bitcoin-git> [bitcoin] laanwj merged pull request #15682: release: Update the Windows Codesigning certificate (master...new-win-cert) https://github.com/bitcoin/bitcoin/pull/15682
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3702e1c17b6c...edb8df4fea13
< bitcoin-git> bitcoin/master 43ae1e9 Cory Fields: release: Update the Windows Codesigning certificate
< bitcoin-git> bitcoin/master edb8df4 Wladimir J. van der Laan: Merge #15682: release: Update the Windows Codesigning certificate
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/7eab2db849d9...f14a0aa99b84
< bitcoin-git> bitcoin/0.18 09a05e8 Wladimir J. van der Laan: qt: Translations update pre-rc3
< bitcoin-git> bitcoin/0.18 f14a0aa Wladimir J. van der Laan: build: Bump to rc3
< wumpus> running bitcoin on an unupdated w7 ouch :)
< bitcoin-git> [bitcoin] theuni opened pull request #15682: release: Update the Windows Codesigning certificate (master...new-win-cert) https://github.com/bitcoin/bitcoin/pull/15682
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #15681: [mempool] Allow one extra single-ancestor transaction per package (master...2019-03-lightning-policy) https://github.com/bitcoin/bitcoin/pull/15681
< gribble> https://github.com/bitcoin/bitcoin/issues/15652 | wallet: Update transactions with current mempool after load by promag · Pull Request #15652 · bitcoin/bitcoin · GitHub

2019-03-27

< bitcoin-git> [bitcoin] jnewbery opened pull request #15680: Remove resendwallettransactions RPC method (master...2019_03_remove_resendwallettransactions) https://github.com/bitcoin/bitcoin/pull/15680
< gmaxwell> [largey offtopic] Gemini can send to bc1 addresses now: https://np.reddit.com/r/Bitcoin/comments/b66n0v/psa_gemini_is_full_on_with_native_segwit_and_uses/
< dongcarl> sipa: We don't exactly care about the socktype and protocol here, correct? As this function seems to not care about the service level and only care about resolving names? https://github.com/bitcoin/bitcoin/blob/3702e1c17b6ccb01de2c0cde66dac26bd05e3183/src/netbase.cpp#L80
< bitcoin-git> [bitcoin] sipa closed pull request #15678: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/15678
< bitcoin-git> [bitcoin] goldenglorys opened pull request #15678: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/15678