< gmaxwell> https://0bin.net/paste/B6nS3BwLEqbCbVDV#fsSRmV1lq1xfMokcx7lZzx5UOjC9FSDrvriNdOsFBrz here are the blocks with misses for me, out of the last 288 blocks.
< gmaxwell> second column is the number of missed txn.
< gmaxwell> The two highest miss counts claim to be by F2Pool. The third highest claims to be antpool.
< gmaxwell> random checking shows a bunch of other f2pool.
< gmaxwell> Lets see, first block-- I'd previously seen the one missed txn:
< gmaxwell> 2019-04-04T01:57:57.029028Z Requesting witness-tx 2dbdbed73281515c9d491c99c717f15acf3d3cb64ba9eebd18a90cf4d6cc6a65 peer=21876
< gmaxwell> I don't think my mempool was remotely near full so it was either non-standard or replaced (I don't have enough logging to tell)
< gmaxwell> it was long enough before the block that if it had been replaced, it probably wouldn't have been in the extra pool anymore.
< gmaxwell> it produced a 546 satoshi output, so-- non-standard, I think.
< * gmaxwell> turns up his logging
< gmaxwell> similar on a bunch of other ones, we probably really should get an extra extra pool going for rejected txn.
< CubicEarth> I've got another syncing question... It used to be that the cpu fans would only turn on at the end... was that back when there were checkpoints? It would only start doing 'full validation' after it passed the checkpoint?
< gwillen> I would really like to get #15508 merged, who do I pester for that at this point? :-) It has several acks.
< gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
< gmaxwell> CubicEarth: it didn't check signatures for the old history, it still doesn't (though for different reasons now)
< CubicEarth> When does the signature checking start?
< CubicEarth> 1 year back from current? Or at a block height set in each release?
< gmaxwell> CubicEarth: at the assumevalid block, or two weeks of blocks back, whichever is older.
< CubicEarth> thanks
< instagibbs> gwillen, time to bug maintainers about readiness to merge, imo
< gwillen> instagibbs: who is the right person to bug
< sipa> gwillen: 2 acks is a bit low
< sipa> and the wallet maintainer is meshcollider, but he's travelling now
< instagibbs> maybe i miscounted i saw 3
< gwillen> sipa: well, it has one from ryanofsky_, one from you, and one from achow101
< sipa> oh
< sipa> i'll merge when i get to a computer
< gwillen> thanks sipa! :-)
< bitcoin-git> [bitcoin] achow101 opened pull request #15761: Replace -upgradewallet startup option with upgradewallet RPC (master...upgradewallet-rpc) https://github.com/bitcoin/bitcoin/pull/15761
< jonasschnelli> If I debug on my macOS 10.14 with lldb, unused variables are optimized away with the default --enable-debug flags of -Og -g3
< jonasschnelli> I have to switch to -O0 -g
< jonasschnelli> is that intentionally?
< bitcoin-git> [bitcoin] jeffersoncarpenter opened pull request #15762: Declare iterators using auto (master...use-auto) https://github.com/bitcoin/bitcoin/pull/15762
< luke-jr> jonasschnelli: #llvm ? :Pp
< jonasschnelli> I'm asking here because it looks like we changed that recently...
< luke-jr> -Og is supposed to be good for debugging
< luke-jr> so if it's a bug, it's a compiler bug
< jonasschnelli> luke-jr: maybe not all compilers support -Og
< jonasschnelli> though we check for it...
< luke-jr> jonasschnelli: not all compilers support -O0 either :p
< luke-jr> (I actually have my x86 compiler set to fail hard if it sees -O0; such that configure would be stopped and not allowed to continue at all)
< instagibbs> for elements we partially reverted #13005 because debugging was so annoying and locally in my bitcoin dir i do the same
< gribble> https://github.com/bitcoin/bitcoin/issues/13005 | Make --enable-debug to pick better options by practicalswift · Pull Request #13005 · bitcoin/bitcoin · GitHub
< instagibbs> 0g is allowed to optimize out whatever from my reading
< jonasschnelli> thanks instagibbs
< bitcoin-git> [bitcoin] sipa opened pull request #15763: Update bips.md for 0.18.0 (master...201904_updatebipsmd) https://github.com/bitcoin/bitcoin/pull/15763
< bitcoin-git> [bitcoin] sipa pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/35991b162fd1...e439aeb30c04
< bitcoin-git> bitcoin/master afd20a2 Glenn Willen: Move PSBT decoding functions from core_io to psbt.cpp
< bitcoin-git> bitcoin/master ef22fe8 Glenn Willen: Refactor analyzepsbt for use outside RPC code
< bitcoin-git> bitcoin/master 892eff0 Glenn Willen: Add documentation of struct PSBTAnalysis et al
< bitcoin-git> [bitcoin] sipa merged pull request #15508: Refactor analyzepsbt for use outside RPC code (master...feature-separate-analyzepsbt) https://github.com/bitcoin/bitcoin/pull/15508
< bitcoin-git> [bitcoin] achow101 opened pull request #15764: Native descriptor wallets (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/15764
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e439aeb30c04...efbc86733a55
< bitcoin-git> bitcoin/master 7813eb1 Suhas Daftuar: [qa] Overhaul p2p_compactblocks.py
< bitcoin-git> bitcoin/master efbc867 MarcoFalke: Merge #15660: [qa] Overhaul p2p_compactblocks.py
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15660: [qa] Overhaul p2p_compactblocks.py (master...2019-03-refactor-p2p-compactblocks-2) https://github.com/bitcoin/bitcoin/pull/15660