< bitcoin-git> [bitcoin] crackercracked opened pull request #15769: Doc/Trivial change key name duration->duration-ms for getrpcinfo (master...fix-issue-15555-change-duration-key-getrpcinfo) https://github.com/bitcoin/bitcoin/pull/15769
< bitcoin-git> [bitcoin] crackercracked closed pull request #15769: Doc/Trivial change key name duration->duration-ms for getrpcinfo (master...fix-issue-15555-change-duration-key-getrpcinfo) https://github.com/bitcoin/bitcoin/pull/15769
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efbc86733a55...327d2746fb92
< bitcoin-git> bitcoin/master 8f5d943 Daniel Kraft: Add regtests for HTTP status codes.
< bitcoin-git> bitcoin/master 327d274 Jonas Schnelli: Merge #15495: Add regtests for HTTP status codes
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15495: Add regtests for HTTP status codes (master...test-http-code) https://github.com/bitcoin/bitcoin/pull/15495
< bitcoin-git> [bitcoin] domob1812 closed pull request #15381: Optionally return HTTP_OK for RPC errors (master...httprpc-error-code) https://github.com/bitcoin/bitcoin/pull/15381
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/327d2746fb92...b4e74f938b75
< bitcoin-git> bitcoin/master 80f0e05 Carl Dong: depends: Preprocessing doesn't care about deps
< bitcoin-git> bitcoin/master 6d44c5e Carl Dong: depends: Add commands for each package for each stage
< bitcoin-git> bitcoin/master b4e74f9 MarcoFalke: Merge #15446: Improve depends debuggability
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15446: Improve depends debuggability (master...2019-02-improve-depends-debuggability) https://github.com/bitcoin/bitcoin/pull/15446
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4e74f938b75...414d8461fd67
< bitcoin-git> bitcoin/master faf62d9 MarcoFalke: gui: Generate bech32 addresses by default
< bitcoin-git> bitcoin/master 414d846 MarcoFalke: Merge #15711: gui: Generate bech32 addresses by default
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15711: gui: Generate bech32 addresses by default (master...1904-guiBech32) https://github.com/bitcoin/bitcoin/pull/15711
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/414d8461fd67...297ea51caf2f
< bitcoin-git> bitcoin/master fa49db7 MarcoFalke: doc: Clarify sendrawtransaction::maxfeerate==0 help
< bitcoin-git> bitcoin/master 297ea51 MarcoFalke: Merge #15760: doc: Clarify sendrawtransaction::maxfeerate==0 help
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15760: doc: Clarify sendrawtransaction::maxfeerate==0 help (master...1904-docRpcRaw) https://github.com/bitcoin/bitcoin/pull/15760
< bitcoin-git> [bitcoin] promag opened pull request #15770: rpc: Validate maxfeerate with AmountFromValue (master...2019-04-maxfeerate) https://github.com/bitcoin/bitcoin/pull/15770
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/297ea51caf2f...a238fccce84b
< bitcoin-git> bitcoin/master 65d2f5d Pieter Wuille: Update bips.md for 0.18.0
< bitcoin-git> bitcoin/master a238fcc MarcoFalke: Merge #15763: Update bips.md for 0.18.0
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15763: Update bips.md for 0.18.0 (master...201904_updatebipsmd) https://github.com/bitcoin/bitcoin/pull/15763
< jnewbery> achow101: #15764 requires #15741 and #15761. Would you like to add either of those to high priority for review?
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
< achow101> Sure. Can you add #15741?
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< jnewbery> done
< wumpus> is this real or some phishing/fake url thing?
< wumpus> oh it's not even our repo, somehow I get mails for this
< instagibbs> wumpus, i sometimes get emails from random shitcoins that backport something I got merged into bitcoin core
< instagibbs> no idea why
< sipa> instagibbs: do. not. ever. put. github. usernames. in. commits.
< sipa> :)
< sipa> you'll get emailed for them over and over when altcoins port the commit
< instagibbs> merge commits too? :O
< wumpus> only backports AFAIK, if they simply pull and push and merge you won't get notification of it
< wumpus> but if they create new commits with the same commit message and it has your @, yep, you'll get email
< bitcoin-git> [bitcoin] promag opened pull request #15771: qa: Retry opening .cookie files (master...2019-04-retry-open-cookie) https://github.com/bitcoin/bitcoin/pull/15771
< gwillen> okay, I have more descriptor questions
< gwillen> I am importing a descriptor that looks like "tprvXXX/blah/blah/blah/*"
< gwillen> and Core tells me that it does not have private keys and cannot sign
< gwillen> I assume this is a "we didn't implement that yet"
< gwillen> (actually just to make this simpler: I just tried one with only hardened deriv and only a single key, no star at the end, and it still does not love me)
< gwillen> also just to give the endgame here: I eventually want derived-multisig-signing support for PSBT use
< gwillen> but I figure that starting with derived-single-key is better ;-)
< sipa> yeah, not implemented; achow101's native descriptor wallet includes code to implement that
< gwillen> actuall hmm, it does it even for e.g. sh(wpkh(tprvXXX)) with no derivation path
< sipa> gwillen: you mean for importmulti?
< achow101> gwillen: currently private keys aren't derived
< gwillen> yeah
< gwillen> I am using importmulti
< sipa> you need to specify the private keys separately from the descriptors
< achow101> gwillen: the base private key (i.e. the one provided in the descriptor itself) will be extracted. derived private keys in the range will not be
< sipa> achow101: no
< sipa> the private key in the descriptor is used to derive pubkeys (for hardened paths), but not imported itself
< gwillen> sadness
< gwillen> where do I find achow101's native descriptor wallet
< gwillen> this sounds like the Promised Future
< achow101> gwillen: it's my latest PR
< achow101> also #15024 may be of interest to you. I borrowed a commit from there for the private key stuff
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< gwillen> ahaaa
< achow101> sipa: isn't the private key add to out.keys? which is then imported?
< achow101> IIRC I didn't have to make any changes to get the master private key from a descriptor
< gwillen> I just tried and it didn't seem to work for me, but I didn't try very hard, and also it was a tprv, not a WIF, if that affects it
< sipa> achow101: no
< sipa> the keys variable (which the parser puts private keys in) is not used for anything but passing it to the Expand function later
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15772: test: Properly log named args in authproxy (master...1904-qaLogNamedArgs) https://github.com/bitcoin/bitcoin/pull/15772
< achow101> gwillen: #15764
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< achow101> sipa: oh, i see. Parse() will extract private keys specified, but importmulti doesn't import them
< gwillen> achow101: it seems like all I need is #15024 for my purposes
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< gwillen> although native descriptor wallet sounds great
< gwillen> but I'm trying not to depend on too much FutureTech
< bitcoin-git> [bitcoin] kallewoof closed pull request #15753: RPC/testing: logprint RPC command (master...rpc-logprint) https://github.com/bitcoin/bitcoin/pull/15753
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15773: test: Add BitcoinTestFramework::sync_* methods (master...1904-qaSyncNew) https://github.com/bitcoin/bitcoin/pull/15773