< bitcoin-git> [bitcoin] jeffersoncarpenter closed pull request #15762: Declare iterators using auto (master...use-auto) https://github.com/bitcoin/bitcoin/pull/15762
< wumpus> FWIW i've reported the deepcode bot thing I mentioned yesterday to github, it's spamming commits and it looks like a phishing attempt to get access to people's github account (requesting more or less full access)
< wumpus> (while masquerading as some kind of code analysis)
< gmaxwell> ::sigh::
< gmaxwell> wumpus: thanks.
< wumpus> fanquake: oh, so, apple thought up a new set of hoops that developers have to jump through
< fanquake> wumpus yea, they'll give our binary a free malware scan
< wumpus> good!
< fanquake> wumpus 15757, 15765 can probably go in
< gmaxwell> watch it start rejecting it. "wallet_theif32 detected!"
< echeveria> it's not worthy of ridicule really.
< echeveria> severe whitelisting is the only way of keeping the general public safe on computers.
< echeveria> on an average day, no user of a computer needs to run anything but a handful of well known binaries.
< wumpus> please, save us the 'users are stupid' discourse
< wumpus> I think this kind of thinking is the reason much of the world is so fucked up, the idea that people can't take care of themselves and they need 'us' (or whatever group), and instead of teaching them, restricting them and ever increasing control and authority
< wumpus> it's not up to you to decide what people, even average people, 'need'
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a238fccce84b...79f73436a910
< bitcoin-git> bitcoin/master 28d78de Pieter Wuille: Mention new PSBT RPCs in psbt.md
< bitcoin-git> bitcoin/master 9b085f4 Pieter Wuille: Mention new descriptor RPCs in descriptors.md
< bitcoin-git> bitcoin/master 79f7343 Wladimir J. van der Laan: Merge #15757: List new RPCs in psbt.md and descriptors.md
< wumpus> fanquake: thanks!
< bitcoin-git> [bitcoin] laanwj merged pull request #15757: List new RPCs in psbt.md and descriptors.md (master...201904_docupdate) https://github.com/bitcoin/bitcoin/pull/15757
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79f73436a910...8088ff21e401
< bitcoin-git> bitcoin/master 8ae6d02 fanquake: doc: correct bitcoinconsensus_version in shared-libraries
< bitcoin-git> bitcoin/master 8088ff2 Wladimir J. van der Laan: Merge #15765: doc: correct bitcoinconsensus_version in shared-libraries.md...
< bitcoin-git> [bitcoin] laanwj merged pull request #15765: doc: correct bitcoinconsensus_version in shared-libraries.md (master...bitcoin_consensus_version) https://github.com/bitcoin/bitcoin/pull/15765
< fanquake> wumpus np. Will you backport 15757 directly?
< bitcoin-git> [bitcoin] fanquake opened pull request #15775: [0.18] Doc Backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15775
< wumpus> fanquake: sure, though if the current rc is going to be final, it's the question whether things should still be backported (in this case it's doc-only so could make an exception) or wait for post-0.18.0
< fanquake> wumpus sure. I bundled the doc changes into 15775. Can just get bumped to 0.18.1 if need be.
< tryphe> the donation link seems to be broken on this page: https://bitcoin.org/en/support-bitcoin
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8088ff21e401...db2985651d9f
< bitcoin-git> bitcoin/master fa57411 MarcoFalke: wallet: Get all balances in one call
< bitcoin-git> bitcoin/master db29856 MeshCollider: Merge #15747: wallet: Remove plethora of Get*Balance
< bitcoin-git> [bitcoin] ajtowns opened pull request #15776: Expire inflight GETDATA requests (master...201904-inflighttxtimeout) https://github.com/bitcoin/bitcoin/pull/15776
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15747: wallet: Remove plethora of Get*Balance (master...1903-walletBal) https://github.com/bitcoin/bitcoin/pull/15747
< luke-jr> tryphe: that has nothing to do with Bitcoin Core; https://github.com/bitcoin-dot-org/bitcoin.org
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/db2985651d9f...54798c3a31b0
< tryphe> luke-jr, wow... that's amazingly fraudulent
< bitcoin-git> bitcoin/master 9a93c91 Pieter Wuille: Keep full pubkeys in FlatSigningProvider::origins
< bitcoin-git> bitcoin/master 6e59700 Pieter Wuille: Import all origin info in importmulti; even for non-importing pubkeys
< bitcoin-git> bitcoin/master b5d3987 Pieter Wuille: Take non-importing keys into account for spendability warning in descripto...
< tryphe> luke-jr, but at least the link is broken
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15749: Fix: importmulti only imports origin info for PKH outputs (master...201904_importallorigins) https://github.com/bitcoin/bitcoin/pull/15749
< luke-jr> tryphe: eh, the link doesn't say it's to donate to Bitcoin or Bitcoin Core
< luke-jr> maybe it can be clearer, but I wouldn't call it fraudulent
< tryphe> luke-jr, ahh, i guess it is the same. the segwit donation address at the bottom of the page is identical to the one on github
< luke-jr> tryphe: that one is to support bitcoin.org, again not related to Bitcoin Core
< tryphe> luke-jr, ohh sorry, i misinterpreted what you said.
< luke-jr> tryphe: either way, it's bitcoin.org you want to report any issues to
< tryphe> luke-jr, so where are the real bitcoin core donation addresses?
< luke-jr> tryphe: Bitcoin Core is an open source project many different people contribute to; there's no centralised entity accepting/distributing donations on everyone's behalf
< tryphe> luke-jr, thank you!
< luke-jr> the closest thing to that would probably be the funding for real-world meetup expenses, but I'm not sure where the donation point is for that
< luke-jr> (and it only goes to such meeting expenses, not other expenses or developers themselves)
< tryphe> luke-jr, i see, that makes sense. but i got the knack that bitcoin devs earned come income from donations somehow or some sort of community funding. not so?
< tryphe> sp/come/some*
< luke-jr> tryphe: a few of us do, but on an individual basis
< tryphe> luke-jr, wow, okay. that's pretty cool!
< luke-jr> eg, for myself personally, I have a Patreon at https://www.patreon.com/LukeDashjr and people who prefer to give bitcoins can contact me directly for unique addresses
< echeveria> tryphe: I would not ever expect to be supported by donations.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54798c3a31b0...f3ecf3025f82
< bitcoin-git> bitcoin/master fa07898 MarcoFalke: test: Properly log named args in authproxy
< bitcoin-git> bitcoin/master f3ecf30 MarcoFalke: Merge #15772: test: Properly log named args in authproxy
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15772: test: Properly log named args in authproxy (master...1904-qaLogNamedArgs) https://github.com/bitcoin/bitcoin/pull/15772
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/32ec90085044...164082c822b0
< bitcoin-git> bitcoin/0.18 538fef6 Pieter Wuille: Update bips.md for 0.18.0
< bitcoin-git> bitcoin/0.18 956c0aa fanquake: doc: correct bitcoinconsensus_version in shared-libraries
< bitcoin-git> bitcoin/0.18 1b0752a Pieter Wuille: Mention new PSBT RPCs in psbt.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15775: [0.18] Doc Backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15775
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3ecf3025f82...f9f6c11a7422
< bitcoin-git> bitcoin/master 90bce24 João Barbosa: qa: Prevent concurrency issues reading .cookie file
< bitcoin-git> bitcoin/master f9f6c11 MarcoFalke: Merge #15771: qa: Prevent concurrency issues reading .cookie file
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15771: qa: Prevent concurrency issues reading .cookie file (master...2019-04-retry-open-cookie) https://github.com/bitcoin/bitcoin/pull/15771
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f9f6c11a7422...23712f8ab951
< bitcoin-git> bitcoin/master fa36a33 MarcoFalke: travis: Switch to ubuntu keyserver to avoid timeouts
< bitcoin-git> bitcoin/master fa2056a MarcoFalke: travis: Properly cache and error on timeout
< bitcoin-git> bitcoin/master 23712f8 MarcoFalke: Merge #15693: travis: Switch to ubuntu keyserver to avoid timeouts
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15693: travis: Switch to ubuntu keyserver to avoid timeouts (master...1903-travisKeyTimeout) https://github.com/bitcoin/bitcoin/pull/15693
< bitcoin-git> [bitcoin] jnewbery opened pull request #15777: [docs] Add doxygen comments for keypool classes (master...2019_04_keypool_comments) https://github.com/bitcoin/bitcoin/pull/15777
< dongcarl> luke-jr: Is the reason that we shouldn't subtree NAT-PMP because even tho we only use a subset of its functionality, the rest won't be linked in anyway?
< luke-jr> dongcarl: there's numerous reasons to never subtree anything; the only reason we have exceptions are when it's consensus-critical
< dongcarl> Roger
< bitcoin-git> [bitcoin] jnewbery opened pull request #15778: Mmove maxtxfee from node (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/23712f8ab951...93de9abe6d68
< bitcoin-git> bitcoin/master f463cd1 John Newbery: [wallet] Keep track of the best block time in the wallet
< bitcoin-git> bitcoin/master 52b760f John Newbery: [wallet] Schedule tx rebroadcasts in wallet
< bitcoin-git> bitcoin/master 833d98a John Newbery: [wallet] Remove unnecessary Chain::Lock parameter from ResendWalletTransac...
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15632: Remove ResendWalletTransactions from the Validation Interface (master...no_resend_wallet_txs) https://github.com/bitcoin/bitcoin/pull/15632
< gwillen> can someone give me context or background on the "hdseedid" key in the output of getaddressinfo? It is described as "(string, optional) The Hash160 of the HD seed" -- is that something one ever has or uses for something?
< gwillen> (I am getting it as "0000000000000000000000000000000000000000", which seems like, if the key is optional, it should instead be left out.)
< gwillen> (I am testing https://github.com/bitcoin/bitcoin/pull/15024, but I don't know that it's related)
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779
< sipa> gwillen: hardly
< sipa> 4 bytes of it (the first 4?) are the key id that goes into the origin info
< meshcollider> sipa: isnt that the ID of the master key, not of the seed
< sipa> meshcollider: oh yes
< meshcollider> also, congrats on 20k commits \o/
< gwillen> wow, nice :D
< gwillen> and yeah, the fingerprint _is_ available and works fine (it's different from the fingerprint I thought my test key had, but I got that from bip32.org and I'm sure I was just holding it wrong.)