< bitcoin-git> [bitcoin] kallewoof opened pull request #12911: wallet: Show fee in results for signrawtransaction* when complete=true (master...sign-show-fees) https://github.com/bitcoin/bitcoin/pull/12911
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/048ac8326b69...d6f10b248a58
< bitcoin-git> bitcoin/master 3ebfb2d MarcoFalke: tests: Avoid test suite name collision in wallet crypto_tests
< bitcoin-git> bitcoin/master dc8067b practicalswift: tests: Add note about uniqueness requirement for test suite names
< bitcoin-git> bitcoin/master d1b622b practicalswift: tests: Add check for test suite name uniqueness in lint-tests.sh
< bitcoin-git> [bitcoin] laanwj closed pull request #12895: tests: Add note about test suite name uniqueness requirement to developer notes (master...check-uniqueness-of-test-suite-names) https://github.com/bitcoin/bitcoin/pull/12895
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d6f10b248a58...3190785c11f7
< bitcoin-git> bitcoin/master 5c21e6c John Newbery: [logging] Comment all continuing logs....
< bitcoin-git> bitcoin/master d207207 John Newbery: [logging] add lint-logs.sh to check for newline termination....
< bitcoin-git> bitcoin/master 3190785 Wladimir J. van der Laan: Merge #12891: [logging] add lint-logs.sh to check for newline termination....
< bitcoin-git> [bitcoin] laanwj closed pull request #12891: [logging] add lint-logs.sh to check for newline termination. (master...log_lint) https://github.com/bitcoin/bitcoin/pull/12891
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3190785c11f7...24133b177a85
< bitcoin-git> bitcoin/master 0e7c52d Suhas Daftuar: Shut down if trying to connect a corrupted block...
< bitcoin-git> bitcoin/master 24133b1 Wladimir J. van der Laan: Merge #12561: Check for block corruption in ConnectBlock()...
< bitcoin-git> [bitcoin] laanwj closed pull request #12561: Check for block corruption in ConnectBlock() (master...2018-02-improve-checkblock-failure) https://github.com/bitcoin/bitcoin/pull/12561
< bitcoin-git> [bitcoin] murrayn opened pull request #12912: Minor readability/maintainability changes to warnings.cpp (master...warnings) https://github.com/bitcoin/bitcoin/pull/12912
< wumpus> I think https://github.com/bitcoin-core/bitcoin-incubator should be removed, it was never used for the purpose it was created for
< bitcoin-git> [bitcoin] practicalswift opened pull request #12914: scripted-diff: Remove redundant license reference (HTTP URL). Update copyright year. (master...copyright-headers) https://github.com/bitcoin/bitcoin/pull/12914
< fanquake> wumpus ack
< bitcoin-git> [bitcoin] fanquake closed pull request #12192: Trivial: Update http URL of MIT license to use https (master...12190-UPDATE_MIT_LINK_TO_HTTPS) https://github.com/bitcoin/bitcoin/pull/12192
< sipa> wumpus: agree; we can always revive it when there is a need
< wumpus> sipa: right - it still seems like a good idea, but it hasn't turned out to become the actual way of working :)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/24133b177a85...7e23972d1f71
< bitcoin-git> bitcoin/master 01189ab practicalswift: build: Show enabled sanitizers in configure output
< bitcoin-git> bitcoin/master 7e23972 MarcoFalke: Merge #12901: build: Show enabled sanitizers in configure output...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12901: build: Show enabled sanitizers in configure output (master...print-enabled-sanitizers-in-configure-output) https://github.com/bitcoin/bitcoin/pull/12901
< bitcoin-git> [bitcoin] jonasschnelli pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/7e23972d1f71...25c56cdbe748
< bitcoin-git> bitcoin/master 11b6b5b Anthony Towns: Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName
< bitcoin-git> bitcoin/master 834d303 Anthony Towns: [tests] Add unit tests for GetChainName
< bitcoin-git> bitcoin/master 6d5815a Anthony Towns: Separate out ReadConfigStream from ReadConfigFile
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12878: [refactor] Config handling refactoring in preparation for network-specific sections (master...netconf-refactor) https://github.com/bitcoin/bitcoin/pull/12878
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12587: Introduce g_wallet_manager, prepare for better dynamic wallet loading/unloading (master...2018/03/dyn_wallet) https://github.com/bitcoin/bitcoin/pull/12587
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/25c56cdbe748...15c3bb4268f3
< bitcoin-git> bitcoin/master e36a0c0 Suhas Daftuar: [qa] Ensure bitcoind processes are cleaned up when tests end
< bitcoin-git> bitcoin/master 15c3bb4 Wladimir J. van der Laan: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end...
< bitcoin-git> [bitcoin] laanwj closed pull request #12904: [qa] Ensure bitcoind processes are cleaned up when tests end (master...2018-04-always-kill-bitcoind) https://github.com/bitcoin/bitcoin/pull/12904
< MarcoFalke> wumpus: ACK on removing "incubator"
< wumpus> /home/orion/projects/bitcoin/bitcoin/src/interfaces/wallet.cpp:427:18: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
< wumpus> [fn, this](CWallet*, const uint256& txid, ChangeType status) { fn(txid, status); }));
< wumpus> MarcoFalke: sipa: fanquake: Your repository "bitcoin-core/bitcoin-incubator" was successfully deleted.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/15c3bb4268f3...97785863e2fa
< bitcoin-git> bitcoin/master 833bc08 Pieter Wuille: Add Slice: a (pointer, size) array view that acts like a container
< bitcoin-git> bitcoin/master 9272d70 Pieter Wuille: Support serializing Span<unsigned char> and use that instead of FLATDATA
< bitcoin-git> bitcoin/master 9778586 Wladimir J. van der Laan: Merge #12886: Introduce Span type and use it instead of FLATDATA...
< bitcoin-git> [bitcoin] laanwj closed pull request #12886: Introduce Span type and use it instead of FLATDATA (master...201803_slice) https://github.com/bitcoin/bitcoin/pull/12886
< bitcoin-git> [bitcoin] sipa opened pull request #12916: Introduce BigEndian wrapper and use it for netaddress ports (master...201804_beport) https://github.com/bitcoin/bitcoin/pull/12916
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12917: qa: Windows fixups for functional tests (master...Mf1804-qaWinFixups) https://github.com/bitcoin/bitcoin/pull/12917
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/97785863e2fa...bd42b85e8b42
< bitcoin-git> bitcoin/master 662d19f Suhas Daftuar: [rpcwallet] Clamp walletpassphrase value at 100M seconds...
< bitcoin-git> bitcoin/master 2b2b96c Suhas Daftuar: Use std::bind instead of boost::bind to re-lock the wallet...
< bitcoin-git> bitcoin/master bd42b85 MarcoFalke: Merge #12905: [rpcwallet] Clamp walletpassphrase value at 100M seconds...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12905: [rpcwallet] Clamp walletpassphrase value at 100M seconds (master...2018-04-wallet-encryption-timeout) https://github.com/bitcoin/bitcoin/pull/12905
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd42b85e8b42...27278dffe877
< bitcoin-git> bitcoin/master c9cce0a Will Ayd: Tests: Add Metaclass for BitcoinTestFramework...
< bitcoin-git> bitcoin/master 27278df Wladimir J. van der Laan: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework...
< bitcoin-git> [bitcoin] laanwj closed pull request #12856: Tests: Add Metaclass for BitcoinTestFramework (master...meta-tst) https://github.com/bitcoin/bitcoin/pull/12856
< luke-jr> wumpus: (re 0.17.0 relnotes issue) well, it did solicit newbie devs.. ;)
< Guest34> that was me :-)
< Guest34> I don't want to spam the ticket, but I really don't understand the "good first issue to read" logic
< Guest34> I mean, the tricky part is getting your code merged, whether it'll bee released 2 months later or 6 months later is secondary
< Guest34> you might as well make a ticket called "read the developer notes" and tag it as "good first issue" if the intention is to provide recommended reading material
< Guest34> anyways, just my two cents, feel free to ignore
< bitcoin-git> [bitcoin] kallewoof opened pull request #12918: test: Assert on correct variable (master...test-typo-rpcrawtx) https://github.com/bitcoin/bitcoin/pull/12918