< bitcoin-git> [bitcoin] promag opened pull request #13070: Split event handlers by wallet (master...2018-04-split-handlers-by-wallet) https://github.com/bitcoin/bitcoin/pull/13070
< wumpus> gahhh github unicorns again
< kallewoof> same here
< wumpus> speaking about single points of failure :)
< aj> really?
< aj> tried clearing your cookies?
< wumpus> no, will try that if it doesn't resolve itself
< wumpus> are functional tests supposed to log everything to console now? or is that an oversight in #13004?
< gribble> https://github.com/bitcoin/bitcoin/issues/13004 | Print to console by default when not run with -daemon by practicalswift · Pull Request #13004 · bitcoin/bitcoin · GitHub
< wumpus> I seem to keep strugging with that one, am I the only one?
< bitcoin-git> [bitcoin] laanwj opened pull request #13071: test: Don't log to stdout in functional tests (master...2018_04_test_output) https://github.com/bitcoin/bitcoin/pull/13071
< wumpus> ^
< aj> wumpus: logtoconsole? should be printtoconsole?
< bitcoin-git> [bitcoin] ajtowns opened pull request #13072: Update createmultisig RPC to support segwit (master...signmultisig) https://github.com/bitcoin/bitcoin/pull/13072
< bitcoin-git> [bitcoin] laanwj closed pull request #13071: test: Don't log to stdout in functional tests (master...2018_04_test_output) https://github.com/bitcoin/bitcoin/pull/13071
< wumpus> aj: you're right - I don't understand what went wrong there, or why that appeared to fix it
< wumpus> aj: it's already supposed to pass noprinttoconsole, but it was spitting out pages of logging
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a0079d4b6dc6...e074097c1ba3
< bitcoin-git> bitcoin/master fa811b0 MarcoFalke: qa: Normalize executable location
< bitcoin-git> bitcoin/master e074097 Wladimir J. van der Laan: Merge #13051: qa: Normalize executable location...
< bitcoin-git> [bitcoin] laanwj closed pull request #13051: qa: Normalize executable location (master...Mf1804-qaDefaultConfig) https://github.com/bitcoin/bitcoin/pull/13051
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e074097c1ba3...106d9297801c
< bitcoin-git> bitcoin/master 6674a75 Qasim Javed: [tests] Make rpcauth.py testable and add unit tests...
< bitcoin-git> bitcoin/master 106d929 Wladimir J. van der Laan: Merge #13056: [tests] Make rpcauth.py testable and add unit tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #13056: [tests] Make rpcauth.py testable and add unit tests (master...rpcauth) https://github.com/bitcoin/bitcoin/pull/13056
< bitcoin-git> [bitcoin] laanwj opened pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (master...2018_04_rpcauth_unittest_outoftree) https://github.com/bitcoin/bitcoin/pull/13073
< wumpus> whops
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/106d9297801c...a785bc3667d3
< bitcoin-git> bitcoin/master 3e53004 Wladimir J. van der Laan: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...
< bitcoin-git> bitcoin/master a785bc3 MarcoFalke: Merge #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (master...2018_04_rpcauth_unittest_outoftree) https://github.com/bitcoin/bitcoin/pull/13073
< jimpo> Anyone feel like reviewing my logging refactor? #12954
< gribble> https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo · Pull Request #12954 · bitcoin/bitcoin · GitHub
< jimpo> Will trade reviews
< jamesob> jimpo: I'll do it if you take a look at https://github.com/bitcoin/bitcoin/pull/12830
< jimpo> Sweet, will do
< wumpus> jamesob: that one looks ready for merge looking at all the(ut)ACKs?
< jamesob> wumpus: I reckon so, but that's your department :)
< wumpus> jamesob: I get a compile error when I try to compile it against current master: /.../bitcoin/src/qt/test/addressbooktests.cpp:106:5: error: use of undeclared identifier 'vpwallets'; did you mean 'wallet'?
< wumpus> jamesob: might need rebase
< jamesob> wumpus: ah yes, probably needs a rebase. will do now.
< jamesob> jimpo: in any case, will get around to the logging PR today.
< wumpus> oh sorry to distract you from reviewing
< jamesob> not at all
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/a785bc3667d3...25ad2f75f5d1
< bitcoin-git> bitcoin/master c5b2770 James O'Beirne: Add purpose arg to Wallet::getAddress...
< bitcoin-git> bitcoin/master 8cdcaee James O'Beirne: [qt] Display more helpful message when adding a send address has failed...
< bitcoin-git> bitcoin/master 9c01be1 James O'Beirne: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage...
< bitcoin-git> [bitcoin] laanwj closed pull request #12830: [qt] [tests] Clarify address book error messages, add tests (master...2018-03-27-send-recv-addressbook-error) https://github.com/bitcoin/bitcoin/pull/12830
< jimpo> jamesob: Left a post-merge review. You can ignore the nits, but I'd test out editing existing entries with either duplicate or new address values. I don't that's working correctly.
< jamesob> jimpo: thanks for the look! Will test per your notes after reviewing your logging change.
< jamesob> jimpo: any idea whether the behavior you're describing there was pre-existing? There's definitely some current weirdness with the address book.
< jimpo> Almost certainly pre-existing
< jimpo> but getDuplicateAddressWarning() shows the improved error with the line "mode == NewSendingAddress || mode == EditSendingAddress", which makes it seem like it should work with the edit flow
< aj> wumpus: it wasn't test_runner auto-calling combine_logs after a test failure maybe?
< bitcoin-git> [bitcoin] jnewbery opened pull request #13074: [trivial] Correct help text for `importaddress` RPC (master...importaddress_help_text) https://github.com/bitcoin/bitcoin/pull/13074
< jamesob> do we want to avoid using CCriticalSection in lieu of std::mutex when introducing new class-scoped locks?
< bitcoin-git> [bitcoin] jnewbery opened pull request #13075: Remove 'account' API from wallet functional tests (master...remove_functional_tests_accounts) https://github.com/bitcoin/bitcoin/pull/13075
< skeees> jamesob: i think pref is to avoid re-entrant locks if you can - can use CWaitableCriticalSection - which is more or less a type-alias for std::mutex
< jamesob> skeees: good call, thanks
< jamesob> another qq: would people be amenable to adding thread name to CLockLocation for easier deadlock debugging, and possibly to log statements as well?
< bitcoin-git> [bitcoin] Empact opened pull request #13076: Fix ScanForWalletTransactions to return a bool indicating success or failure (master...scan-for-wallet-transactions-ret) https://github.com/bitcoin/bitcoin/pull/13076
< jamesob> and if so, would want to piggyback on the bitcoin-* 16 character pthread names or just have some peripheral mapping of boost thread ids to arbitrary length names?
< bitcoin-git> [bitcoin] practicalswift opened pull request #13077: Add compile time checking for all cs_KeyStore runtime locking assertions (master...cs_KeyStore) https://github.com/bitcoin/bitcoin/pull/13077
< bitcoin-git> [bitcoin] Empact opened pull request #13079: Fix ScanForWalletTransactions to report progress correctly when a pindexStop is supplied (master...scan-for-wallet-stopblock-progress) https://github.com/bitcoin/bitcoin/pull/13079
< bitcoin-git> [bitcoin] practicalswift opened pull request #13080: Add compile time checking for all ::mempool.cs runtime locking assertions (master...mempool.cs) https://github.com/bitcoin/bitcoin/pull/13080
< bitcoin-git> [bitcoin] practicalswift opened pull request #13081: Add compile time checking for all cs_wallet runtime locking assertions (master...cs_wallet-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/13081
< bitcoin-git> [bitcoin] kristapsk opened pull request #13082: Don't test against min relay fee information in mining_prioritisetransaction.py (master...dont-hardcode-134) https://github.com/bitcoin/bitcoin/pull/13082
< bitcoin-git> [bitcoin] practicalswift opened pull request #13083: Add compile time checking for all cs_main runtime locking assertions (master...cs_main) https://github.com/bitcoin/bitcoin/pull/13083
< bitcoin-git> [bitcoin] sipa opened pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084