< bitcoin-git>
[bitcoin] laanwj opened pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (master...2018_04_rpcauth_unittest_outoftree) https://github.com/bitcoin/bitcoin/pull/13073
< wumpus>
jamesob: that one looks ready for merge looking at all the(ut)ACKs?
< jamesob>
wumpus: I reckon so, but that's your department :)
< wumpus>
jamesob: I get a compile error when I try to compile it against current master: /.../bitcoin/src/qt/test/addressbooktests.cpp:106:5: error: use of undeclared identifier 'vpwallets'; did you mean 'wallet'?
< wumpus>
jamesob: might need rebase
< jamesob>
wumpus: ah yes, probably needs a rebase. will do now.
< jamesob>
jimpo: in any case, will get around to the logging PR today.
< jimpo>
jamesob: Left a post-merge review. You can ignore the nits, but I'd test out editing existing entries with either duplicate or new address values. I don't that's working correctly.
< jamesob>
jimpo: thanks for the look! Will test per your notes after reviewing your logging change.
< jamesob>
jimpo: any idea whether the behavior you're describing there was pre-existing? There's definitely some current weirdness with the address book.
< jimpo>
Almost certainly pre-existing
< jimpo>
but getDuplicateAddressWarning() shows the improved error with the line "mode == NewSendingAddress || mode == EditSendingAddress", which makes it seem like it should work with the edit flow
< aj>
wumpus: it wasn't test_runner auto-calling combine_logs after a test failure maybe?
< bitcoin-git>
[bitcoin] jnewbery opened pull request #13074: [trivial] Correct help text for `importaddress` RPC (master...importaddress_help_text) https://github.com/bitcoin/bitcoin/pull/13074
< jamesob>
do we want to avoid using CCriticalSection in lieu of std::mutex when introducing new class-scoped locks?
< bitcoin-git>
[bitcoin] jnewbery opened pull request #13075: Remove 'account' API from wallet functional tests (master...remove_functional_tests_accounts) https://github.com/bitcoin/bitcoin/pull/13075
< skeees>
jamesob: i think pref is to avoid re-entrant locks if you can - can use CWaitableCriticalSection - which is more or less a type-alias for std::mutex
< jamesob>
skeees: good call, thanks
< jamesob>
another qq: would people be amenable to adding thread name to CLockLocation for easier deadlock debugging, and possibly to log statements as well?
< bitcoin-git>
[bitcoin] Empact opened pull request #13076: Fix ScanForWalletTransactions to return a bool indicating success or failure (master...scan-for-wallet-transactions-ret) https://github.com/bitcoin/bitcoin/pull/13076
< jamesob>
and if so, would want to piggyback on the bitcoin-* 16 character pthread names or just have some peripheral mapping of boost thread ids to arbitrary length names?
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13077: Add compile time checking for all cs_KeyStore runtime locking assertions (master...cs_KeyStore) https://github.com/bitcoin/bitcoin/pull/13077
< bitcoin-git>
[bitcoin] Empact opened pull request #13079: Fix ScanForWalletTransactions to report progress correctly when a pindexStop is supplied (master...scan-for-wallet-stopblock-progress) https://github.com/bitcoin/bitcoin/pull/13079
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13080: Add compile time checking for all ::mempool.cs runtime locking assertions (master...mempool.cs) https://github.com/bitcoin/bitcoin/pull/13080
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13081: Add compile time checking for all cs_wallet runtime locking assertions (master...cs_wallet-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/13081
< bitcoin-git>
[bitcoin] kristapsk opened pull request #13082: Don't test against min relay fee information in mining_prioritisetransaction.py (master...dont-hardcode-134) https://github.com/bitcoin/bitcoin/pull/13082
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13083: Add compile time checking for all cs_main runtime locking assertions (master...cs_main) https://github.com/bitcoin/bitcoin/pull/13083
< bitcoin-git>
[bitcoin] sipa opened pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084