< fanquake> kallewoof Would you be able to share your clang static analyzer setup?
< kallewoof> fanquake: Absolutely. It was awhile ago that I set it up though, but I'll write a gist on how to get it up on a mac.
< kallewoof> fanquake: Lemme know if this works? https://gist.github.com/kallewoof/8984c56399e8d23ee54dd695d2660b7a
< fanquake> kallewoof cheers, I'll be playing around with it this arvo
< fanquake> wumpus hanging around to do a bit of merging?
<@wumpus> fanquake: sure, if you have any suggestions
< fanquake> wumpus #12986 is something trivial to get started
< gribble> https://github.com/bitcoin/bitcoin/issues/12986 | Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 by okayplanet · Pull Request #12986 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e76acf3384ac...3fef58c82d7a
< bitcoin-git> bitcoin/master d1b828b okayplanet: correcting the array name from pnSeeds6 to pnSeed6
< bitcoin-git> bitcoin/master 3fef58c Wladimir J. van der Laan: Merge #12986: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6...
< bitcoin-git> [bitcoin] laanwj closed pull request #12986: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 (master...comment_correction) https://github.com/bitcoin/bitcoin/pull/12986
< fanquake> wumpus #12951 is another
< gribble> https://github.com/bitcoin/bitcoin/issues/12951 | [doc] Fix comment in FindForkInGlobalIndex by jamesob · Pull Request #12951 · bitcoin/bitcoin · GitHub
<@wumpus> thank!
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fef58c82d7a...6df0c6cb4169
< bitcoin-git> bitcoin/master 0ef7b40 James O'Beirne: [doc] Fix comment in FindForkInGlobalIndex...
< bitcoin-git> bitcoin/master 6df0c6c Wladimir J. van der Laan: Merge #12951: [doc] Fix comment in FindForkInGlobalIndex...
< bitcoin-git> [bitcoin] laanwj closed pull request #12951: [doc] Fix comment in FindForkInGlobalIndex (master...2018-04-11-findforkinglobalindex-doc) https://github.com/bitcoin/bitcoin/pull/12951
< fanquake> wumpus your leveldb work in #12968 does that comflict with anything being done upstream? Just looking at https://github.com/bitcoin-core/leveldb/pull/17/commits/5c39524f3639e6bf6ab49215152d24273e662986
< gribble> https://github.com/bitcoin/bitcoin/issues/12968 | leveldb: Add ARMv8 CRC32C support by laanwj · Pull Request #12968 · bitcoin/bitcoin · GitHub
< fanquake> Wondering if we want to try and get https://github.com/bitcoin-core/leveldb/pull/17 in soon.
<@wumpus> fanquake: oh, didn't know about that!
<@wumpus> looks like I pretty much wasted my time there :/
< fanquake> :( I had half a thought you might be re-doing some work
< fanquake> Although Ideally you've got something to contribute back upstream?
<@wumpus> that's what you get for actually trying to write some code for a change :-)
< jonasschnelli> Oh. They also did SEE CRC! :(
< bitcoin-git> [bitcoin] laanwj closed pull request #12968: leveldb: Add ARMv8 CRC32C support (master...2018_04_armv8_crc32c) https://github.com/bitcoin/bitcoin/pull/12968
< fanquake> I guess we should prioritze https://github.com/bitcoin-core/leveldb/pull/17 then. It also cleans up some of those annoying static analyzer warnings..
< fanquake> A shame we can't add PRs from other repos to our project lists.
<@wumpus> fanquake: yes good idea i'll have a look at that
< aj> can have PRs from multiple repos if the project is an org-project, i think? https://github.com/orgs/bitcoin/projects
< fanquake> aj unfortunately all of the /bitcoin subtrees are at /bitcoin-core
< aj> ah good point
< fanquake> aj did you end up getting the static analyzer working?
< aj> fanquake: no, haven't tried the gist though (i didn't run autogen.sh through scan-build when i tried)
< fanquake> aj ok. I'll be having a look at it again shortly.
< fanquake> Thinking out load, not that we are seeing a lot more "Fix warning from analyzer X" type PRs. I think it'd be beneficial (maybe in a PR template?) to add some guidelines around opening those sort of PRs.
<@wumpus> I agree
< fanquake> At least including the compiler/version, the tool/version, which flags your passing to ./configure, which commit your building etc.
<@wumpus> we're only interested in seeing such PRs *if* they fix issues that would be an issue without the static analyser as well, e.g. actual problems
< fanquake> Otherwise, I look at a PR (for example) like #12882, and don't really have a quick way to just setup and atleast test the changes.
<@wumpus> not 'work around bugs in my tool'
< gribble> https://github.com/bitcoin/bitcoin/issues/12882 | tests: Make test_bitcoin pass under ThreadSanitzer (clang). Fix lock-order-inversion (potential deadlock). by practicalswift · Pull Request #12882 · bitcoin/bitcoin · GitHub
< fanquake> wumpus yes. And being able to reproduce issues quickly and easier is key to that.
< fanquake> I don't really want to waste time trying to recreate some obscure issue, and then findout they were using HEAD version of X tool, which may or may not produce correct results.
<@wumpus> right
< fanquake> Or using some *older* version of a tool that spews since-fixed warnings.
<@wumpus> my point is also that the kind of changes we're interested in are usually easy to inspect, I mean, the static analyser finds a bug that normal review would also have found given enough eyes on the matter
< fanquake> wumpus sure
<@wumpus> if some obscure, hand-rolled analysis tool finds an important bug we'd be very thankful, but not if it comes with 20 screenfuls of false positives
< fanquake> wumpus I agree, I'm not advocating "against" people hammering the codebase with whatever tools they want. Just want to make sure that when it appears in a PR it's something useful.
<@wumpus> indeed
< fanquake> I feel like if at some point we write enough bash scripts & linters, the repository will just about be able to maintain itself indefinitely
<@wumpus> a kind of mutation engine for software evolution
< sipa> i think we should be able to write scripted diffs into the blockchain and have them be applied automatically to the source code
< fanquake> heh the *real* devcoin
< * sipa> is reminded of BIP 2112
<@wumpus> hehehe
< sipa> is that really 6 years old already :o
< Kanna> any idea about soft fork ? and how to do this ?
< fanquake> Kanna in what conext?
< sipa> consensus changes to bitcoin are generally discussed on the mailing list
< Kanna> I want to do the bitcoin fork with some predefined block size for example 4mb [ Testing ]
< Kanna> <fanquake> my fork should happen on this parameter Max Blocksize 8MB Block time 2 mins or 2.5 [ to test the bitcoin fork ]
< bitcoin-git> [bitcoin] practicalswift opened pull request #12993: tests: Remove compatibility code not needed now when we're on Python 3 (master...remove-python-2-compatibility-code) https://github.com/bitcoin/bitcoin/pull/12993
< sipa> Kanna: other currencies are off topic here
< fanquake> Has anyone recreated #12990 ? I'm unable to on Ubuntu with GCC8.0.1 20180414
< gribble> https://github.com/bitcoin/bitcoin/issues/12990 | depends: Fix libX11 build on gcc 8 by MarcoFalke · Pull Request #12990 · bitcoin/bitcoin · GitHub
< Kanna> How to reduce the latency of the transaction ? Do i need to consder block size on this ?
<@wumpus> Kanna: off topic here, go to #bitcoin
< jonasschnelli> I just tried to run the "bitcoin-0.16.99-arm-linux-gnueabihf-debug.tar.gz" debug binaries on my arm machine but get a "cannot execute binary file: Exec format error"
< jonasschnelli> readelf -A bitcoin-tx.dbg tells me it should be executable
< jonasschnelli> I probably doing something wrong...
< jonasschnelli> Here is a typical connect block debug bench on the Odroid XU4 / SSD [USB3] (Cortex A15):
< jonasschnelli> Odroid XU4 SSD via USB3 sync against random peers with 600MB dbcache maxmempool 50MB: 42 hours (2573 minutes)
< jonasschnelli> (no assumevalid point given)
< jonasschnelli> fricking github unicorn
<@wumpus> github: everyone's favourite unicorn farming game
<@wumpus> jonasschnelli: @I just tried to run the "bitcoin-0.16.99-arm-linux-gnueabihf-debug.tar.gz": that's expected, the debug files contain separate debug information for the main executables, they're not executable in themselves
< jonasschnelli> wumpus: Then I guess I need to run the split-debug.sh script
< fanquake> wumpus need to swap unicorns for black holes
<@wumpus> fanquake: yess
<@wumpus> jonasschnelli: if you wnt to debug something, gdb can cope with external debug symbols, but yes another option is to re-merge the debug information into the executable
< jonasschnelli> wumpus: I want to time profile the binary... I cross compile armv7 with -O2 -g not via depends. But callgrind is extremly (too) slow
< jonasschnelli> *cross compiled*
<@wumpus> ok
< jonasschnelli> any time profiling recommendation?
< jonasschnelli> (currently trying to compile "perf")
<@wumpus> perf! (@eklitzke)
<@wumpus> IIRC perf is a sampling profiler instead of an instrumenting one so it has less effect on runtime speed
< jonasschnelli> yes. that is what I want... it just don't come out-of-the box for Odroid XU4
<@wumpus> what rootfs do you use?
< jonasschnelli> I'm currently using the SD card they provide
< jonasschnelli> some ubuntu derivate
<@wumpus> ah right, perf is part of the kernel tools, at least on ubuntu it matches the kernel version (linux-tools-x.y.z)
<@wumpus> no "linux-tools-c2" package
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6df0c6cb4169...0d6992168c2b
< bitcoin-git> bitcoin/master b95f9a6 practicalswift: tests: Remove compatibility code not needed now when we're on Python 3
< bitcoin-git> bitcoin/master 0d69921 Wladimir J. van der Laan: Merge #12993: tests: Remove compatibility code not needed now when we're on Python 3...
< bitcoin-git> [bitcoin] laanwj closed pull request #12993: tests: Remove compatibility code not needed now when we're on Python 3 (master...remove-python-2-compatibility-code) https://github.com/bitcoin/bitcoin/pull/12993
< sdaftuar> wumpus: #11739 could benefit from concentrated review, it's collected ACKs over several months but due to rebase and nit-fixes, there's only one ACK on the current commit. would this be a reasonable PR to tag "high priority for review"?
< gribble> https://github.com/bitcoin/bitcoin/issues/11739 | Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis by sdaftuar · Pull Request #11739 · bitcoin/bitcoin · GitHub
< sdaftuar> wumpus: to be clear, it's not blocking me on anything
< bitcoin-git> [bitcoin] practicalswift opened pull request #12996: tests: Remove redundant bytes(…) calls (master...bytes²) https://github.com/bitcoin/bitcoin/pull/12996
< jnewbery> sdaftuar: +1. It'd be good to get that one merged. I also plan to rebase #12360 on it (they conflict so there's no point in rebasing mine until yours gets in)
< gribble> https://github.com/bitcoin/bitcoin/issues/12360 | Bury bip9 deployments by jnewbery · Pull Request #12360 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12997: [doc] build-windows: Switch to Artful, since Zesty is EOL (master...Mf1804-docBuildWinArtful) https://github.com/bitcoin/bitcoin/pull/12997
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12998: Default to defining endian-conversion DECLs in compat w/o config (master...2018-04-default-decls) https://github.com/bitcoin/bitcoin/pull/12998
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0d6992168c2b...fe8fa22d7a4a
< bitcoin-git> bitcoin/master f020aca practicalswift: Minor Python cleanups to make flake8 pass with the new rules enabled
< bitcoin-git> bitcoin/master 643aad1 practicalswift: Enable additional flake8 rules
< bitcoin-git> bitcoin/master fe8fa22 MarcoFalke: Merge #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis (master...enable-flake8-checks) https://github.com/bitcoin/bitcoin/pull/12987
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fe8fa22d7a4a...6a278e064009
< bitcoin-git> bitcoin/master 9db48c5 practicalswift: tests: Remove redundant bytes²
< bitcoin-git> bitcoin/master 6a278e0 MarcoFalke: Merge #12996: tests: Remove redundant bytes(…) calls...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12996: tests: Remove redundant bytes(…) calls (master...bytes²) https://github.com/bitcoin/bitcoin/pull/12996
< bitcoin-git> [bitcoin] ken2812221 opened pull request #12999: qt: Show the Window when double clicking the taskbar icon (master...qt-fix) https://github.com/bitcoin/bitcoin/pull/12999
< jamesob> the only reason ActivateBestChain is split up into steps is to reduce cs_main contention, right?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13000: travis: Switch to xenial (master...Mf1804-travisXenial) https://github.com/bitcoin/bitcoin/pull/13000
< sipa> jamesob: yes, note that it performs an entire reorg if necessary
< sipa> so there's no real bound on how long it takes
< jamesob> sipa: and gets a single large call during reindexing, no?
< jamesob> s/large/long
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13000: travis: Switch to xenial (master...Mf1804-travisXenial) https://github.com/bitcoin/bitcoin/pull/13000
< sipa> jamesob: right, after reindexing, it's called as part of the node startup to switch to the best chain
< jamesob> (which made, e.g., https://github.com/bitcoin/bitcoin/pull/11824 necessary)
< sipa> in case of a real reindex, that means one call does the entire activation
<@wumpus> sdaftuar: sure, agree, added
< jimpo> Travis isn't running on two of my PRs :-(: 12954 & 12647.
<@wumpus> isn't running? or failing?
< jimpo> Isn't running. Or at least not reporting back to GitHub.
< jimpo> I'll check if there's actually a build on travis-ci
< jimpo> I can't find them if they're there
< jonasschnelli> dcousens: where is you indexd (python index daemon) source code? Can't find it.
< jamesob> @jimpo any chance Travis has flagged your account for abuse? happened to me recently
< jimpo> Haha, I have no idea. How do you find out?
< jonasschnelli> happend to me before as well
< jamesob> (if you dare click an imgur link during work hours ;)
< jonasschnelli> jimpo: you can try a force push and I'll check what happend in the "requests" area in travis
< jonasschnelli> (can only see the last ~20 requests and those look good)
< jimpo> Just force pushed #12647
< gribble> https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo · Pull Request #12647 · bitcoin/bitcoin · GitHub
< jonasschnelli> "Abuse detected" (jimpo)
< jonasschnelli> I guess your blocked... you need to write an email to the travis support team
< jimpo> :-(
< votefrac> Also Travis is slow sometimes isn't it
< votefrac> Wouldn't move to Jenkins be helpful
< jonasschnelli> no
< bitcoin-git> [bitcoin] laanwj pushed 12 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a278e064009...4366f61cc9d4
< bitcoin-git> bitcoin/master 3673ca3 Anthony Towns: ArgsManager: keep command line and config file arguments separate
< bitcoin-git> bitcoin/master 4d34fcc Anthony Towns: ArgsManager: drop m_negated_args...
< bitcoin-git> bitcoin/master 95eb66d Anthony Towns: ArgsManager: support config file sections
< bitcoin-git> [bitcoin] laanwj closed pull request #11862: Network specific conf sections (master...netconf-sections) https://github.com/bitcoin/bitcoin/pull/11862
< jnewbery> \o/
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4366f61cc9d4...07825088f9cf
< bitcoin-git> bitcoin/master 958bf40 practicalswift: add lint tool to check python3 shebang
< bitcoin-git> bitcoin/master 2bff472 John Newbery: [contrib] convert test-security-check to python3
< bitcoin-git> bitcoin/master 0782508 MarcoFalke: Merge #12972: Add python3 script shebang lint...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12972: Add python3 script shebang lint (master...explicit_python3) https://github.com/bitcoin/bitcoin/pull/12972