< bitcoin-git> [bitcoin] promag opened pull request #12929: Remove CWallet dependency from CWalletTx (master...2018-04-wallettx) https://github.com/bitcoin/bitcoin/pull/12929
< bitcoin-git> [bitcoin] conscott opened pull request #12930: WIP Refactor large transaction generation for tests and make generic (master...CRS_tests_flexible_tx_size) https://github.com/bitcoin/bitcoin/pull/12930
< wumpus> jnewbery: you should be able to triage too
< bitcoin-git> [bitcoin] ajtowns opened pull request #12931: Use winehq debs for i686 win32 tests (master...travis-win32) https://github.com/bitcoin/bitcoin/pull/12931
< wumpus> I think the ideal would be to add things to 'high priority for review' only during/after the meeting, but if there's something really important it's fine to deviate from that (if you mention here)
< aj> wumpus: ^^ is a first pass at stopping 686-w32 travis builds from being constantly horrible
< wumpus> aj: thank you, will take a look
< aj> wumpus: so i think switching travis over to xenial would mean doing docker based builds?
< wumpus> I don't know
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/727175a08dff...dd1ca9e0b300
< bitcoin-git> bitcoin/master 66f3255 Cory Fields: tests: split up actual tests and helper files
< bitcoin-git> bitcoin/master 156db42 Cory Fields: tests: run tests in parallel
< bitcoin-git> bitcoin/master f6dfb0f Pieter Wuille: Reorder travis builds
< bitcoin-git> [bitcoin] laanwj closed pull request #12926: Run unit tests in parallel (master...201804_parunit) https://github.com/bitcoin/bitcoin/pull/12926
< bitcoin-git> [bitcoin] laanwj opened pull request #12932: wallet: Remove redundant lambda function arg in handleTransactionChanged (master...2018_04_redundant_argument) https://github.com/bitcoin/bitcoin/pull/12932
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dd1ca9e0b300...ebd786b72a2a
< bitcoin-git> bitcoin/master fa385c3 MarcoFalke: [doc] devtools: Setup ots git integration
< bitcoin-git> bitcoin/master ebd786b Wladimir J. van der Laan: Merge #12852: [doc] devtools: Setup ots git integration...
< bitcoin-git> [bitcoin] laanwj closed pull request #12852: [doc] devtools: Setup ots git integration (master...Mf1803-docOtsGit) https://github.com/bitcoin/bitcoin/pull/12852
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ebd786b72a2a...5ca1509d6af5
< bitcoin-git> bitcoin/master b63f23c Luke Dashjr: Add P2P, Network, and Qt categories to the desktop icon
< bitcoin-git> bitcoin/master 5ca1509 Wladimir J. van der Laan: Merge #12854: Add P2P, Network, and Qt categories to the desktop icon...
< cfields> wumpus: heh, i didn't see that you proposed the parallel tests via makefile as a joke :)
< bitcoin-git> [bitcoin] laanwj closed pull request #12854: Add P2P, Network, and Qt categories to the desktop icon (master...desktop_categories) https://github.com/bitcoin/bitcoin/pull/12854
< wumpus> cfields: it seemed like a hacky low-tech way to parallelize something, but thinking about it more it's actually a good solution that integrates well with the build system
< cfields> heh, agree on both fronts
< promag> wumpus: do you think #12929 makes sense?
< gribble> https://github.com/bitcoin/bitcoin/issues/12929 | Remove CWallet dependency from CWalletTx by promag · Pull Request #12929 · bitcoin/bitcoin · GitHub
< wumpus> haven't looked at it yet
< wumpus> I think we should get the label stuff done first now
< promag> oh ok
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ca1509d6af5...8d651ae32013
< bitcoin-git> bitcoin/master 9b9d717 Wladimir J. van der Laan: wallet: Remove redundant lambda function arg in handleTransactionChanged...
< bitcoin-git> bitcoin/master 8d651ae MarcoFalke: Merge #12932: wallet: Remove redundant lambda function arg in handleTransactionChanged...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12932: wallet: Remove redundant lambda function arg in handleTransactionChanged (master...2018_04_redundant_argument) https://github.com/bitcoin/bitcoin/pull/12932
< promag> jnewbery: should listlabels give sorted labels? if so update help message? if not then my suggestion is valid
< jnewbery> I don't think the help message needs to be updated. What other sane way would there be to display a list of strings?
< jnewbery> dictionary sorted is the obvious choice
< jnewbery> thanks for the review BTW :)
< jnewbery> I've added a code comment to explain why the labels are added to a list and then inserted into the univalue array
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12831: [WIP] Run unit tests in parallel (master...Mf1803-qaUnitParallel) https://github.com/bitcoin/bitcoin/pull/12831
< bitcoin-git> [bitcoin] sipa closed pull request #12890: [DEBUG TRAVIS] Detailed unit test report for win32 (master...201803_debugtravis) https://github.com/bitcoin/bitcoin/pull/12890
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8d651ae32013...a84b056d5f1b
< bitcoin-git> bitcoin/master 5805d6f Gregory Sanders: feebumper: discard change outputs below discard rate
< bitcoin-git> bitcoin/master f526046 Gregory Sanders: adapt bumpfee change discard test to be more strict and add note on p2sh discrep
< bitcoin-git> bitcoin/master a84b056 Wladimir J. van der Laan: Merge #12749: [wallet] feebumper: discard change outputs below discard rate...
< bitcoin-git> [bitcoin] laanwj closed pull request #12749: [wallet] feebumper: discard change outputs below discard rate (master...discardbump) https://github.com/bitcoin/bitcoin/pull/12749
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12933: Revert "Add Travis check for duplicate includes" (master...Mf1804-docIncludes) https://github.com/bitcoin/bitcoin/pull/12933
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a84b056d5f1b...0a8054e7cd5c
< bitcoin-git> bitcoin/master 818dc74 Pieter Wuille: Support serialization as another type without casting...
< bitcoin-git> bitcoin/master 0a8054e Wladimir J. van der Laan: Merge #12731: Support serialization as another type without casting...
< bitcoin-git> [bitcoin] laanwj closed pull request #12731: Support serialization as another type without casting (master...201803_astype) https://github.com/bitcoin/bitcoin/pull/12731
< jamesob> man, travis feels a lot snapper today :)
< jamesob> *snappier
< * sipa> wonders why!
< jamesob> who'dve thought it'd be because of automake
< jamesob> sipa: oh wait - it's also because we now have 15 travis jobs :)
< jonasschnelli> Yes. Seems like the Chaincode/Travis action seems to work
< sipa> jamesob: how many did we have before?
< jamesob> sipa: they no longer show it on their pricing page, but I think it was something like 5? cc MarcoFalke
< jonasschnelli> jamesob: I guess you don't need to include src/qt/locale/bitcoin_en.ts in #12830
< gribble> https://github.com/bitcoin/bitcoin/issues/12830 | [qt] [tests] Clarify address book error messages, add tests by jamesob · Pull Request #12830 · bitcoin/bitcoin · GitHub
< jonasschnelli> It's autogenerated by the maintainers
< jamesob> jonasschnelli: okay, will revert
< luke-jr> I don't suppose anyone knows how to make vmbuilder work with Debian stable? :/
< joshb[m]> vm...builder...?
< joshb[m]> I might ask...why...first
< luke-jr> yes, the first step to setting up gitian
< bitcoin-git> [bitcoin] skeees opened pull request #12934: [WIP] [net] [validation] Call ProcessNewBlock() asynchronously (master...module-isolation) https://github.com/bitcoin/bitcoin/pull/12934
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12935: Add ProcessOrphans (move-only) (master...Mf1804-ProcessOrphans) https://github.com/bitcoin/bitcoin/pull/12935