BlueMatt: re #12897, practicalswift rushed to implement my suggestion in #12782 without further feedback. I think you are right that it's not worth it, but it's also not that bad.
https://github.com/bitcoin/bitcoin/issues/12897 | Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash by practicalswift · Pull Request #12897 · bitcoin/bitcoin · GitHub
;;later tell promag I'm not really sure either 12897 or 12782 are worth it....changing a ptr dereference to an assert, followed by a ptr dereference is just more code for no reason, its not "explicitly stating" an assumption - the assumption was already clear when we dereferenced the pointer
The operation succeeded.
MarcoFalke: or someone wanna re-ack-and-merge #12791 ?
jimpo: re txindex in the background...
my peer is sometimes blocked for 1min with "BlockUntilSyncedToCurrentChain: txindex is catching up on block notifications"
[bitcoin] practicalswift closed pull request #12897: Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash (master...GetBlockIndex) https://github.com/bitcoin/bitcoin/pull/12897