< bitcoin-git> [bitcoin] sipa opened pull request #13002: Do not treat bare multisig outputs as IsMine unless watched (master...201804_cleanismine) https://github.com/bitcoin/bitcoin/pull/13002
< bitcoin-git> [bitcoin] sipa closed pull request #12874: Only accept bare multisig outputs after addmultisigaddress (master...201803_nowalletbaremultisig) https://github.com/bitcoin/bitcoin/pull/12874
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13003: qa: Add test for orphan handling (master...Mf1804-qaOrphans) https://github.com/bitcoin/bitcoin/pull/13003
< bitcoin-git> [bitcoin] ajtowns closed pull request #12931: Use winehq debs for win32 tests (master...travis-win32) https://github.com/bitcoin/bitcoin/pull/12931
< fanquake> Turns out if you close/crash Bitcoin Core in the way described in #12838, it just refuses to launch again.
< gribble> https://github.com/bitcoin/bitcoin/issues/12838 | QT: double click bitcoin icon on the task bar with setting minimize to the tray cause a blank window · Issue #12838 · bitcoin/bitcoin · GitHub
< fanquake> Looking at the docs for QLocalServer::removeServer, "On Windows, this function does nothing; on Unix, ...". Could be the cause of the problem.
< aj> fanquake: the gist static analyser instructions worked fine for me btw (well, i used the clang-tools-7 package on debian rather than downloading directly)
< fanquake> aj Cool. Found anything interesting yet :p
< aj> fanquake: no, tried tracing something back but got confused before i got to the root cause. looks good though
< jonasschnelli> Is there a way to get the CBlockIndex in the main chain from a CDiskBlockPos object?
< sipa> get the hash of the CDiskBlockPos object, look it up in mapBlockIndex ?
< jonasschnelli> sipa: I'd like to check if the CDiskTxPos object refers to a pruned block... I guess this is not possible though.
< jonasschnelli> I can check if the file exists,... though would prefer to check if HAVE_DATA
< bitcoin-git> [bitcoin] practicalswift opened pull request #13004: Print to console by default when not run with -daemon (master...printtoconsole) https://github.com/bitcoin/bitcoin/pull/13004
< bitcoin-git> [bitcoin] fanquake closed pull request #12689: Smarter default behavior for -printtoconsole (master...console) https://github.com/bitcoin/bitcoin/pull/12689
< bitcoin-git> [bitcoin] practicalswift opened pull request #13005: Make --enable-debug to pick better options (master...enabledebug-again) https://github.com/bitcoin/bitcoin/pull/13005
< bitcoin-git> [bitcoin] fanquake closed pull request #12695: [build] Make --enable-debug pick better options (master...enabledebug) https://github.com/bitcoin/bitcoin/pull/12695
< jonasschnelli> Since days, I can't view #11857, always get a unicorn... anyone else?
< gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
< jonasschnelli> ping jimpo
< jonasschnelli> jimpo: maybe rebase regardless of merge conflicts... eventually its stuck in github caches
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/07825088f9cf...307699304886
< bitcoin-git> bitcoin/master 2eb5036 Akio Nakamura: macOS: Prevent Xcode 9.3 build warnings...
< bitcoin-git> bitcoin/master 3076993 Jonas Schnelli: Merge #12899: macOS: Prevent Xcode 9.3 build warnings...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12899: macOS: Prevent Xcode 9.3 build warnings (master...preventxcodebuildwarnings) https://github.com/bitcoin/bitcoin/pull/12899
< kallewoof> jonasschnelli: Getting unicorn too, for ^...
< jonasschnelli> Does the txindex (or txdb) support multiple values per a single key? If I use leveldb->Write(), will it overwrite a possible existing value for a key if the key already exists?
< jonasschnelli> It is probably configurable per db env?
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/307699304886...434150aef798
< bitcoin-git> bitcoin/master 1936125 João Barbosa: wallet: Make WalletInitInterface members const
< bitcoin-git> bitcoin/master 6ec78f1 João Barbosa: wallet: Refactor g_wallet_init_interface to const reference
< bitcoin-git> bitcoin/master 434150a Wladimir J. van der Laan: Merge #12977: Refactor g_wallet_init_interface to const reference...
<@wumpus> jonasschnelli: like a map, leveldb has a strict one key to one value mapping, so yes if you Write another value to the same key it will overwrite that
<@wumpus> (maybe I misunderstand your question though)
< bitcoin-git> [bitcoin] laanwj closed pull request #12977: Refactor g_wallet_init_interface to const reference (master...2018-04-walletinitinterface) https://github.com/bitcoin/bitcoin/pull/12977
< instagibbs> "Our team are currently investigating timeouts with some pull requests and I've added your report to our list." I reported the unicorn, no ETA but at least it's in a queue...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/434150aef798...39e0c65b29eb
< bitcoin-git> bitcoin/master d86edd3 Jesse Cohen: Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip...
< bitcoin-git> bitcoin/master 39e0c65 Wladimir J. van der Laan: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal...
< bitcoin-git> [bitcoin] laanwj closed pull request #12988: Hold cs_main while calling UpdatedBlockTip() signal (master...updatedblocktip-race) https://github.com/bitcoin/bitcoin/pull/12988
< jonasschnelli> wumpus: thanks. I thought writing multiple values with the same key will be accessible via a cursor with seek() and next() ... it seems to be the case for LMDB
< promag> I'd love some feedback on #12639, ty
< gribble> https://github.com/bitcoin/bitcoin/issues/12639 | Reduce cs_main lock in listunspent by promag · Pull Request #12639 · bitcoin/bitcoin · GitHub
<@wumpus> jonasschnelli: TIL! apparently lmdb seems to support "dups", which I assume is multiple values per key
< jonasschnelli> wumpus: seems pretty handy for 1-to-n "relations"
<@wumpus> yes - I never used it in that way, only in the same way as leveldb
< promag> jonasschnelli: do you think WalletInitInterface should be the "new wallet manager"?
< jonasschnelli> promag: I haven't look at it too closely... but I guess it could be
< promag> are you planning working on that?
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/39e0c65b29eb...58bbc5521235
< bitcoin-git> bitcoin/master 6a3b0d3 Evan Klitzke: Print to console by default when not run with -daemon...
< bitcoin-git> bitcoin/master 58bbc55 Wladimir J. van der Laan: Merge #13004: Print to console by default when not run with -daemon...
< bitcoin-git> [bitcoin] laanwj closed pull request #13004: Print to console by default when not run with -daemon (master...printtoconsole) https://github.com/bitcoin/bitcoin/pull/13004
< jonasschnelli> promag: haven't looked at it. The wallet manager seems no longer be relevant (isince the wallet interface). I think next step is dynamic creating/loading of wallets
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/58bbc5521235...a63b4e349346
< bitcoin-git> bitcoin/master cd0e1e9 Russell Yanofsky: Fix inconsistent namespace formatting guidelines...
< bitcoin-git> bitcoin/master a63b4e3 MarcoFalke: Merge #12982: Fix inconsistent namespace formatting guidelines...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12982: Fix inconsistent namespace formatting guidelines (master...pr/namespace) https://github.com/bitcoin/bitcoin/pull/12982
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a63b4e349346...6b46288a0853
< bitcoin-git> bitcoin/master fae58ec MarcoFalke: tests: Avoid copies of CTransaction
< bitcoin-git> bitcoin/master 6b46288 MarcoFalke: Merge #12949: tests: Avoid copies of CTransaction...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12949: tests: Avoid copies of CTransaction (master...Mf1804-testNoCopyTx) https://github.com/bitcoin/bitcoin/pull/12949
< bitcoin-git> [bitcoin] promag opened pull request #13007: Fix dangling wallet pointer in vpwallets (master...2018-04-fixwallettest) https://github.com/bitcoin/bitcoin/pull/13007
< promag> BlueMatt: re #12897, practicalswift rushed to implement my suggestion in #12782 without further feedback. I think you are right that it's not worth it, but it's also not that bad.
< gribble> https://github.com/bitcoin/bitcoin/issues/12897 | Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash by practicalswift · Pull Request #12897 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12782 | Explicitly state our assumptions about LookupBlockIndex(...) return values by practicalswift · Pull Request #12782 · bitcoin/bitcoin · GitHub
< BlueMatt> ;;later tell promag I'm not really sure either 12897 or 12782 are worth it....changing a ptr dereference to an assert, followed by a ptr dereference is just more code for no reason, its not "explicitly stating" an assumption - the assumption was already clear when we dereferenced the pointer
< gribble> The operation succeeded.
< BlueMatt> MarcoFalke: or someone wanna re-ack-and-merge #12791 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/12791 | Expose a transactions weight via RPC by TheBlueMatt · Pull Request #12791 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/6b46288a0853...3a8a4dc4a130
< bitcoin-git> bitcoin/master 2874709 Matt Corallo: Expose a transaction's weight via RPC
< bitcoin-git> bitcoin/master d0d9112 Matt Corallo: Test new weight field in p2p_segwit
< bitcoin-git> bitcoin/master 9e50c33 Matt Corallo: Note new weight field in release-notes.
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12791: Expose a transaction's weight via RPC (master...2018-03-weight) https://github.com/bitcoin/bitcoin/pull/12791
< bitcoin-git> [bitcoin] IPGlider opened pull request #13008: rpc: Rename size to vsize in mempool related calls (master...rename-size-to-vsize) https://github.com/bitcoin/bitcoin/pull/13008
< jonasschnelli> jimpo: re txindex in the background...
< jonasschnelli> my peer is sometimes blocked for 1min with "BlockUntilSyncedToCurrentChain: txindex is catching up on block notifications"
< bitcoin-git> [bitcoin] practicalswift closed pull request #12897: Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash (master...GetBlockIndex) https://github.com/bitcoin/bitcoin/pull/12897
< bitcoin-git> [bitcoin] wbarobinson opened pull request #13010: Trivial: Language Cleanup (master...master) https://github.com/bitcoin/bitcoin/pull/13010
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13011: Cache witness hash in CTransaction (master...Mf1804-cacheWitnessHash) https://github.com/bitcoin/bitcoin/pull/13011
< bitcoin-git> [bitcoin] jamesob opened pull request #13012: [doc] Add comments for chainparams.h, validation.cpp (master...2018-04-17-doc-chainparams-validation) https://github.com/bitcoin/bitcoin/pull/13012
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13013: bench: Amend mempool_eviction test for witness txs (master...Mf1804-benchWitnessMempool) https://github.com/bitcoin/bitcoin/pull/13013