< bitcoin-git>
[bitcoin] sipa opened pull request #13002: Do not treat bare multisig outputs as IsMine unless watched (master...201804_cleanismine) https://github.com/bitcoin/bitcoin/pull/13002
< bitcoin-git>
[bitcoin] sipa closed pull request #12874: Only accept bare multisig outputs after addmultisigaddress (master...201803_nowalletbaremultisig) https://github.com/bitcoin/bitcoin/pull/12874
< fanquake>
Turns out if you close/crash Bitcoin Core in the way described in #12838, it just refuses to launch again.
< gribble>
https://github.com/bitcoin/bitcoin/issues/12838 | QT: double click bitcoin icon on the task bar with setting minimize to the tray cause a blank window · Issue #12838 · bitcoin/bitcoin · GitHub
< fanquake>
Looking at the docs for QLocalServer::removeServer, "On Windows, this function does nothing; on Unix, ...". Could be the cause of the problem.
< aj>
fanquake: the gist static analyser instructions worked fine for me btw (well, i used the clang-tools-7 package on debian rather than downloading directly)
< fanquake>
aj Cool. Found anything interesting yet :p
< aj>
fanquake: no, tried tracing something back but got confused before i got to the root cause. looks good though
< jonasschnelli>
Is there a way to get the CBlockIndex in the main chain from a CDiskBlockPos object?
< sipa>
get the hash of the CDiskBlockPos object, look it up in mapBlockIndex ?
< jonasschnelli>
sipa: I'd like to check if the CDiskTxPos object refers to a pruned block... I guess this is not possible though.
< jonasschnelli>
I can check if the file exists,... though would prefer to check if HAVE_DATA
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13004: Print to console by default when not run with -daemon (master...printtoconsole) https://github.com/bitcoin/bitcoin/pull/13004
< kallewoof>
jonasschnelli: Getting unicorn too, for ^...
< jonasschnelli>
Does the txindex (or txdb) support multiple values per a single key? If I use leveldb->Write(), will it overwrite a possible existing value for a key if the key already exists?
< jonasschnelli>
It is probably configurable per db env?
< bitcoin-git>
bitcoin/master 1936125 João Barbosa: wallet: Make WalletInitInterface members const
< bitcoin-git>
bitcoin/master 6ec78f1 João Barbosa: wallet: Refactor g_wallet_init_interface to const reference
< bitcoin-git>
bitcoin/master 434150a Wladimir J. van der Laan: Merge #12977: Refactor g_wallet_init_interface to const reference...
<@wumpus>
jonasschnelli: like a map, leveldb has a strict one key to one value mapping, so yes if you Write another value to the same key it will overwrite that
<@wumpus>
(maybe I misunderstand your question though)
< instagibbs>
"Our team are currently investigating timeouts with some pull requests and I've added your report to our list." I reported the unicorn, no ETA but at least it's in a queue...
< bitcoin-git>
bitcoin/master d86edd3 Jesse Cohen: Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip...
< bitcoin-git>
bitcoin/master 39e0c65 Wladimir J. van der Laan: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal...
< bitcoin-git>
[bitcoin] laanwj closed pull request #12988: Hold cs_main while calling UpdatedBlockTip() signal (master...updatedblocktip-race) https://github.com/bitcoin/bitcoin/pull/12988
< jonasschnelli>
wumpus: thanks. I thought writing multiple values with the same key will be accessible via a cursor with seek() and next() ... it seems to be the case for LMDB
< bitcoin-git>
bitcoin/master 6a3b0d3 Evan Klitzke: Print to console by default when not run with -daemon...
< bitcoin-git>
bitcoin/master 58bbc55 Wladimir J. van der Laan: Merge #13004: Print to console by default when not run with -daemon...
< bitcoin-git>
[bitcoin] laanwj closed pull request #13004: Print to console by default when not run with -daemon (master...printtoconsole) https://github.com/bitcoin/bitcoin/pull/13004
< jonasschnelli>
promag: haven't looked at it. The wallet manager seems no longer be relevant (isince the wallet interface). I think next step is dynamic creating/loading of wallets
< promag>
BlueMatt: re #12897, practicalswift rushed to implement my suggestion in #12782 without further feedback. I think you are right that it's not worth it, but it's also not that bad.
< gribble>
https://github.com/bitcoin/bitcoin/issues/12897 | Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash by practicalswift · Pull Request #12897 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/12782 | Explicitly state our assumptions about LookupBlockIndex(...) return values by practicalswift · Pull Request #12782 · bitcoin/bitcoin · GitHub
< BlueMatt>
;;later tell promag I'm not really sure either 12897 or 12782 are worth it....changing a ptr dereference to an assert, followed by a ptr dereference is just more code for no reason, its not "explicitly stating" an assumption - the assumption was already clear when we dereferenced the pointer
< gribble>
The operation succeeded.
< BlueMatt>
MarcoFalke: or someone wanna re-ack-and-merge #12791 ?
< bitcoin-git>
[bitcoin] IPGlider opened pull request #13008: rpc: Rename size to vsize in mempool related calls (master...rename-size-to-vsize) https://github.com/bitcoin/bitcoin/pull/13008
< jonasschnelli>
jimpo: re txindex in the background...
< jonasschnelli>
my peer is sometimes blocked for 1min with "BlockUntilSyncedToCurrentChain: txindex is catching up on block notifications"
< bitcoin-git>
[bitcoin] practicalswift closed pull request #12897: Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash (master...GetBlockIndex) https://github.com/bitcoin/bitcoin/pull/12897