< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3e60b9cfa768...65d7083f152e
< bitcoin-git> bitcoin/master 6efd964 João Barbosa: refactor: Drop CWalletRef typedef
< bitcoin-git> bitcoin/master 373aee2 João Barbosa: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets...
< bitcoin-git> bitcoin/master 3c058fd João Barbosa: wallet: Add HasWallets
< bitcoin-git> [bitcoin] laanwj closed pull request #13017: Add wallets management functions (master...2018-04-vpwallets) https://github.com/bitcoin/bitcoin/pull/13017
< bitcoin-git> [bitcoin] laanwj opened pull request #13055: qt: Don't log to console by default (master...2018_04_gui_console) https://github.com/bitcoin/bitcoin/pull/13055
<@wumpus> this weekend I recovered a node that was crashing with database corruption errors (after, I think, a hard poweroff corrupted it - the log was padded with sudden \0\0\0\0\0\0) simply by deleting leveldb's .log file.
<@wumpus> after that and restarted, the node succesfully picked up verification again, phew, no reindex
< bitcoin-git> [bitcoin] nixbox opened pull request #13056: [tests] Make rpcauth.py testable and add unit tests (master...rpcauth) https://github.com/bitcoin/bitcoin/pull/13056
<@wumpus> error was "error in middle of record" in log_reader
<@wumpus> maybe such an automatic recovery would be possible in some cases, when only the log is corrupt and not any ldb files, it'd just amount to a rollback
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65d7083f152e...e2746db66fd5
< bitcoin-git> bitcoin/master 3cc9094 Ben Woosley: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks...
< bitcoin-git> bitcoin/master e2746db Wladimir J. van der Laan: Merge #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks...
< bitcoin-git> [bitcoin] laanwj closed pull request #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (master...g-failed-blocks) https://github.com/bitcoin/bitcoin/pull/13016
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2746db66fd5...8b4081a889b3
< bitcoin-git> bitcoin/master cf02779 Wladimir J. van der Laan: Add logging and error handling for file syncing...
< bitcoin-git> bitcoin/master 8b4081a Wladimir J. van der Laan: Merge #13039: Add logging and error handling for file syncing...
< bitcoin-git> [bitcoin] laanwj closed pull request #13039: Add logging and error handling for file syncing (master...2018_04_fsync_noignore) https://github.com/bitcoin/bitcoin/pull/13039
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8b4081a889b3...4741ca5dc8fd
< bitcoin-git> bitcoin/master e4d0b44 Ben Woosley: Consistently log CValidationState on failure...
< bitcoin-git> bitcoin/master 4741ca5 Wladimir J. van der Laan: Merge #13020: Consistently log CValidationState on call failure...
< bitcoin-git> [bitcoin] laanwj closed pull request #13020: Consistently log CValidationState on call failure (master...log-cvalidation-state) https://github.com/bitcoin/bitcoin/pull/13020
< bitcoin-git> [bitcoin] instagibbs opened pull request #13057: remove redundant pre-selected coin code (master...selectedcoins) https://github.com/bitcoin/bitcoin/pull/13057
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4741ca5dc8fd...d5b2e98250f6
< bitcoin-git> bitcoin/master e87fefc Wladimir J. van der Laan: test: Add rpc_bind test to default-run tests...
< bitcoin-git> bitcoin/master d5b2e98 Wladimir J. van der Laan: Merge #12510: test: Add rpc_bind test to default-run tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d5b2e98250f6...5713994de98e
< bitcoin-git> bitcoin/master 6ad47b0 practicalswift: trivial: Fix relevent typo
< bitcoin-git> bitcoin/master 5713994 MarcoFalke: Merge #13052: trivial: Fix relevent typo...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13052: trivial: Fix relevent typo (master...relevent) https://github.com/bitcoin/bitcoin/pull/13052
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5713994de98e...d1e3c5e73cfc
< bitcoin-git> bitcoin/master 18326ae James O'Beirne: [doc] Add comments for chainparams.h, validation.cpp
< bitcoin-git> bitcoin/master d1e3c5e Wladimir J. van der Laan: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp...
< bitcoin-git> [bitcoin] laanwj closed pull request #13012: [doc] Add comments for chainparams.h, validation.cpp (master...2018-04-17-doc-chainparams-validation) https://github.com/bitcoin/bitcoin/pull/13012
< jnewbery> provoostenator: Yes, agree that 4000 lines is probably too much log. I'd ACK a PR to reduce it. (counter argument is that this is only printed when a script fails, so we want as much logging as possible)
< jonasschnelli> hmm... localhost p2p getblocks transfer rate up to block 250000 is roughly 70MB/s (SSD with usual rate of 300MB/s). Reasonable overhead.
<@wumpus> jonasschnelli: any idea where the overhead is? the deserialize->serialize round trip?
<@wumpus> or just 'random seeking and reading' wrt i/o, because this concerns such small blocks
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d1e3c5e73cfc...84efa9a0f752
< bitcoin-git> bitcoin/master 0851a75 João Barbosa: rpc: Interrupt block generation on shutdown request
< bitcoin-git> bitcoin/master 84efa9a Wladimir J. van der Laan: Merge #12448: Interrupt block generation on shutdown request...
< bitcoin-git> [bitcoin] laanwj closed pull request #12448: Interrupt block generation on shutdown request (master...2018-02-interrupt-generate-blocks) https://github.com/bitcoin/bitcoin/pull/12448
< promag> wumpus: that was unexpected
<@wumpus> promag: :-)
< jonasschnelli> wumpus: not sure where the bottleneck is. need to analyze more. I first need the make sure it's not the client (pure C p2p client)
< bitcoin-git> [bitcoin] jnewbery opened pull request #13058: [wallet] `createwallet` RPC - create new wallet at runtime (master...create_wallet) https://github.com/bitcoin/bitcoin/pull/13058
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/84efa9a0f752...d3f04c0e81a6
< bitcoin-git> bitcoin/master 3476e3c John Newbery: [wallet] Fix zapwallettxes/multiwallet interaction....
< bitcoin-git> bitcoin/master 1f83839 John Newbery: [wallet] [tests] Test disallowed multiwallet params...
< bitcoin-git> bitcoin/master d3f04c0 Wladimir J. van der Laan: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction....
< bitcoin-git> [bitcoin] laanwj closed pull request #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. (master...fix_zapwallet_multiwallet_interaction) https://github.com/bitcoin/bitcoin/pull/13030
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3f04c0e81a6...8609ddb36821
< bitcoin-git> bitcoin/master 67bf2aa Chun Kuan Lee: qt:Show the entire Window when double clicking on taskbar
< bitcoin-git> bitcoin/master 8609ddb Wladimir J. van der Laan: Merge #12999: qt: Show the Window when double clicking the taskbar icon...
< bitcoin-git> [bitcoin] laanwj closed pull request #12999: qt: Show the Window when double clicking the taskbar icon (master...qt-fix) https://github.com/bitcoin/bitcoin/pull/12999
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8609ddb36821...a49381dfa3ee
< bitcoin-git> bitcoin/master 2fb168b Pieter Wuille: Make iterators in CScript::FindAndDelete const
< bitcoin-git> bitcoin/master 33a8ecf Pieter Wuille: Delete unused non-const-iterator CSCript::GetOp overloads
< bitcoin-git> bitcoin/master 6a7456a Pieter Wuille: [MOVEONLY] Move CSCript::FindAndDelete to interpreter
< bitcoin-git> [bitcoin] laanwj closed pull request #12885: Reduce implementation code inside CScript (master...201803_reducescript) https://github.com/bitcoin/bitcoin/pull/12885
< jonasschnelli> wumpus: here is the flamgraph during 3.8GB blockserving on localhost: https://bitcoin.jonasschnelli.ch/perf-heavy-blockserving.svg
< jonasschnelli> Not sure why I can't untangle the callstack in msghandler 37.68% is spent in "Lloop1_26"
< bitcoin-git> [bitcoin] jnewbery opened pull request #13060: [wallet] [rpc] Remove getlabeladdress RPC (master...remove_getlabeladdress) https://github.com/bitcoin/bitcoin/pull/13060
< Chris_Stewart_5> If a node receives blocks in an order like: 1,2,4,3 (where 4 references previous block hash of 3) on the p2p network, will zmq relay 4 after it has successfully connected it with 3?
< sipa> Chris_Stewart_5: no, it just notifies for new tips
< sipa> as ZMQ is not reliable, you shouldn't use it as more than a notification service anyway
< sipa> Chris_Stewart_5: actually, i think that can't happen
< sipa> as we always fetch blocks in order
< Chris_Stewart_5> sipa: Wouldn't 4 end up as the cannonical tip?
< sipa> but a similar scenario can occur during a reorg
< sipa> in which case ZMQ will just report the new tip after the reorg, and not the intermediary blocks (afaik, not entirely sure)
< Chris_Stewart_5> so basically if there is a reorg that is like 6 blocks deep, you will just be notified of the new tip of that reorg, *not* all the intermittent blocks that happened in the reorg correct?
< skeees> In the current state you'll be notified after every ActivateBestChainStep()
< skeees> which will definitely give you the new tip
< skeees> possibly some of the block in between, but not guaranteed every single one
< skeees> the notifications will be pushed to zmq in order (i don't know what ordering guarantees zmq gives you though)
< Chris_Stewart_5> skeees: Thanks! :-)
< sipa> Chris_Stewart_5: you basically can't rely on ZMQ to relay you everything regardless
< sipa> you can use it as a notification that there are new things you should look at (through rpc or rest)
< sipa> (and IMHO it was a mistake to make it relay full blocks in the first place, as it confusingly gives you the impression it will give you everything)
< bitcoin-git> [bitcoin] jnewbery closed pull request #9806: txoutsbyaddress index (take 3) (master...gettxoutsbyaddress) https://github.com/bitcoin/bitcoin/pull/9806
< bitcoin-git> [bitcoin] bmwiedemann opened pull request #13061: Make tests pass after 2020 (master...ftbfs-2020) https://github.com/bitcoin/bitcoin/pull/13061
< midnightmagic> w 80
< aj> jtimon: can still drop "assert_contains" from rpc_getblockstats.py
< jtimon> yeah, unused, thanks
< jtimon> aj: also I just noticed I forgot this nit: https://github.com/bitcoin/bitcoin/pull/10757/files#r181616478
< bitcoin-git> [bitcoin] sipa opened pull request #13062: Make script interpreter independent from storage type CScript (master...201804_spaninterpret) https://github.com/bitcoin/bitcoin/pull/13062
< bitcoin-git> [bitcoin] promag closed pull request #11402: Use shared pointer for wallet instances (master...2017-09-wallet-shared-pointer) https://github.com/bitcoin/bitcoin/pull/11402
< promag> jnewbery: you might want to rebase on top of #13063
< gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
< jtimon> aj: right, thanks
< bitcoin-git> [bitcoin] sipa opened pull request #13064: List support for BIP173 in bips.md (master...201804_docbip173) https://github.com/bitcoin/bitcoin/pull/13064
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a49381dfa3ee...bdda14d1c01c
< bitcoin-git> bitcoin/master aee80b0 Wladimir J. van der Laan: qt: Don't log to console by default...
< bitcoin-git> bitcoin/master bdda14d MarcoFalke: Merge #13055: qt: Don't log to console by default...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13055: qt: Don't log to console by default (master...2018_04_gui_console) https://github.com/bitcoin/bitcoin/pull/13055
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13065: Let travis to run verify-commits.sh without errors (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13065