< bitcoin-git> [bitcoin] Empact opened pull request #12937: Handle witness version and OP_N results as an unsigned char (master...unsigned-char-witnessversion) https://github.com/bitcoin/bitcoin/pull/12937
< bitcoin-git> [bitcoin] Empact opened pull request #12938: Overload CScript::IsWitnessProgram with a test-only version (master...test-only-iswitnessprogram) https://github.com/bitcoin/bitcoin/pull/12938
< bitcoin-git> [bitcoin] Empact opened pull request #12939: Extract consts for WITNESS_V0 hash sizes (master...hash-size-constants) https://github.com/bitcoin/bitcoin/pull/12939
< wumpus> luke-jr: wasn't aware that it doesn't work
< wumpus> though I can't say it surprises me either, debian stable would be better off called 'software archeology museum'
< aj> wumpus: a friend likes to nickname stable and unstable as "stale and usable"
< wumpus> aj: heh, that's a good one
< wumpus> removing letters to reveal hidden facts :-)
< luke-jr> wumpus: it's newer than our current Ubuntu..
< wumpus> luke-jr: can you pastebin the error message?
< luke-jr> wumpus: it's something about GRUB. I've had to reboot since.
< luke-jr> Xenial (Ubuntu 16.04) fails with a /etc/sudoers conflict of sorts
< wumpus> don't remember ever seeing that
< luke-jr> there was also an issue with dpkg-reconfigure locale, but I hacked that
< bitcoin-git> [bitcoin] Empact opened pull request #12940: rpc: Fix estimatesmartfee to properly handle a null estimate_mode arg (master...fix-estimatesmartfee-null-estimatemode) https://github.com/bitcoin/bitcoin/pull/12940
< jonasschnelli> Since new OSX version 10.12 I get tons of warnings for the boost test framework...
< jonasschnelli> things like BOOST_CHECK_EQUAL(list.size(), 1);
< jonasschnelli> warning: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Wsign-compare]
< jonasschnelli> Would it be ugly to fix it with comparing against 1l instead of 1?
< luke-jr> that won't fix it
< jonasschnelli> it did on my side... though plenty of code parts
< luke-jr> you'd need 1UL or somth
< luke-jr> odd
< jonasschnelli> 1UL would be more precise, right.
< jonasschnelli> There is apparently already a PR: #12920
< gribble> https://github.com/bitcoin/bitcoin/issues/12920 | test: Fix sign for expected values by kallewoof · Pull Request #12920 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #12941: [Trivial] Ignore macOS daemon() depracation warning (master...2018/04/daemon_osx) https://github.com/bitcoin/bitcoin/pull/12941
< aj> (sp: deprecation)
< bitcoin-git> [bitcoin] Empact opened pull request #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args (master...redundant-type-check-signtransaction) https://github.com/bitcoin/bitcoin/pull/12942
< jonasschnelli> If nScriptCheckThreads is == 0, CCheckQueueControl is initiated with no queue which looks like no script verification are done... though I guess it only means no concurrency.
< jonasschnelli> Though I fail to see where the script are getting checked if nScriptCheckThreads == 0...
< jonasschnelli> nm: found the part (validation.cpp / } else if (!check()) {)
< kallewoof> achow101: Would you be up for reviewing #12257, considering your work on the coin selection code?
< gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8054e7cd5c...9b3370d1c612
< bitcoin-git> bitcoin/master 189e0ef Wladimir J. van der Laan: [wallet] [rpc] introduce 'label' API for wallet...
< bitcoin-git> bitcoin/master 41ba061 John Newbery: [docs] Add release notes for wallet 'label' API.
< bitcoin-git> bitcoin/master 9b3370d Wladimir J. van der Laan: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet...
< bitcoin-git> [bitcoin] laanwj closed pull request #12892: [wallet] [rpc] introduce 'label' API for wallet (master...7729_jnewbery) https://github.com/bitcoin/bitcoin/pull/12892
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b3370d1c612...807d2ac1867c
< bitcoin-git> bitcoin/master 12e7c55 Jonas Schnelli: Ignore macOS daemon() depracation warning
< bitcoin-git> bitcoin/master 807d2ac Wladimir J. van der Laan: Merge #12941: [Trivial] Ignore macOS daemon() depracation warning...
< fanquake> wumpus heh, was just about to say I've got some notes to add to that PR. Will add post anyways.
< wumpus> fanquake: oh sorry
< wumpus> fanquake: it seemed trivial enough to just merge on the reasoning alone
< bitcoin-git> [bitcoin] laanwj closed pull request #12941: [Trivial] Ignore macOS daemon() depracation warning (master...2018/04/daemon_osx) https://github.com/bitcoin/bitcoin/pull/12941
< fanquake> wumpus np, was just going to dump some apple deprecation info in there
< stevenroose> sipa: have a sec?
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/807d2ac1867c...7b6041d1a70c
< bitcoin-git> bitcoin/master ece88fd Pieter Wuille: Introduce BigEndian wrapper and use it for netaddress ports
< bitcoin-git> bitcoin/master 7b6041d Wladimir J. van der Laan: Merge #12916: Introduce BigEndian wrapper and use it for netaddress ports...
< bitcoin-git> [bitcoin] laanwj closed pull request #12916: Introduce BigEndian wrapper and use it for netaddress ports (master...201804_beport) https://github.com/bitcoin/bitcoin/pull/12916
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b6041d1a70c...f15b72f482f0
< bitcoin-git> bitcoin/master 40c5886 251: Fix illegal default `addProxy` and `addrSeparateProxyTor` settings.
< bitcoin-git> bitcoin/master f15b72f Wladimir J. van der Laan: Merge #12650: gui: Fix issue: "default port not shown correctly in settings dialog"...
< bitcoin-git> [bitcoin] laanwj closed pull request #12650: gui: Fix issue: "default port not shown correctly in settings dialog" (master...patch/12623/default-port-not-shown) https://github.com/bitcoin/bitcoin/pull/12650
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f15b72f482f0...b1fdfc1a8c07
< bitcoin-git> bitcoin/master c55aa4f Karl-Johan Alm: test: Fix sign for expected values...
< bitcoin-git> bitcoin/master b1fdfc1 Wladimir J. van der Laan: Merge #12920: test: Fix sign for expected values...
< bitcoin-git> [bitcoin] laanwj closed pull request #12920: test: Fix sign for expected values (master...test-signs) https://github.com/bitcoin/bitcoin/pull/12920
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b1fdfc1a8c07...1b5723ee5748
< bitcoin-git> bitcoin/master 2311c7c practicalswift: Call FlushStateToDisk(...) regardless of fCheckForPruning...
< bitcoin-git> bitcoin/master 0000d8f practicalswift: Document how FlushStateMode::NONE is handled
< bitcoin-git> bitcoin/master 1b5723e Wladimir J. van der Laan: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning...
< bitcoin-git> [bitcoin] laanwj closed pull request #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning (master...cs_LastBlockFile-fCheckForPruning) https://github.com/bitcoin/bitcoin/pull/11617
< bitcoin-git> [bitcoin] instagibbs opened pull request #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty (master...scandirty) https://github.com/bitcoin/bitcoin/pull/12944
< provoostenator> Just noticed on macOS 10.13.4 I had to use the depends system to build (--without-gui --disable-tests --disable-bench). That's new for me...
< provoostenator> *to be build 0.15.1 and older
< fanquake> provoostenator What do you mean? You can't build bitcoin-qt with homebrew installed dependencies after 0.15.1 ?
< provoostenator> I didn't build QT.
< provoostenator> I mean I can build v0.16.0 and master just fine with the homebrew stuff on my machine, but not the older versions.
< provoostenator> So I guess some recent update in a homebrew package wasn't backwards compatible.
< fanquake> Do you know which dependency is the issue?
< fanquake> Homebrew the package manager itself should still have *some* support back to osx 10.7, there are 10.7 changes in the 1.6.0 release notes.
< fanquake> As for the actual packages, I'm unsure.
< fanquake> Apparently they will now also warn if the Xcode on your machine is too old to install a certain formula, so basically, upgrade to a newer macOS.
< provoostenator> Not sure, but here's the build log: https://gist.github.com/Sjors/40eddc5bb38f6acb05058e5dd74af159
< fanquake> Off the top of my head, I think that is missing a backport
< fanquake> Probably #12032
< gribble> https://github.com/bitcoin/bitcoin/issues/12032 | [backport] #11847 Make boost::multi_index comparators const by fanquake · Pull Request #12032 · bitcoin/bitcoin · GitHub
< provoostenator> It worked for me as recent as January 12th 2018 (although I don't konw if my brews were up to date)
< provoostenator> I see, so I should try the 0.15 branch instead of the tag?
< fanquake> If you've upgraded to boost > 1.66.0 that might have been what changed
< fanquake> Yea, try the branch instead.
< provoostenator> That did the trick.
< provoostenator> In fact, that specific commit indeed does the trick.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b5723ee5748...fefb817009fc
< bitcoin-git> bitcoin/master 459ea58 Ben Woosley: rpc: Drop redundant testing of signrawtransaction prevtxs args...
< bitcoin-git> bitcoin/master fefb817 Wladimir J. van der Laan: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args...
< bitcoin-git> [bitcoin] laanwj closed pull request #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args (master...redundant-type-check-signtransaction) https://github.com/bitcoin/bitcoin/pull/12942
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fefb817009fc...fb17faefb8a3
< bitcoin-git> bitcoin/master 1499fdc practicalswift: Add shell script linting: Check for shellcheck warnings in shell scripts
< bitcoin-git> bitcoin/master fb17fae MarcoFalke: Merge #12871: Add shell script linting: Check for shellcheck warnings in shell scripts...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12871: Add shell script linting: Check for shellcheck warnings in shell scripts (master...lint-shell) https://github.com/bitcoin/bitcoin/pull/12871
< instagibbs> someone with deeper wallet knowledge check on 12944? I'm having trouble reproducing my bug in regtest, curious if someone else can figure it out
< fanquake> I'm sure every-time I go to retrieve a Qt patch it gets slightly more convoluted and difficult to do
< wumpus> heh
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fb17faefb8a3...6d3de17a226b
< bitcoin-git> bitcoin/master cab0824 Jonas Schnelli: Logprint the start of a rescan
< bitcoin-git> bitcoin/master 6d3de17 Wladimir J. van der Laan: Merge #12925: wallet: Logprint the start of a rescan...
< bitcoin-git> [bitcoin] laanwj closed pull request #12925: wallet: Logprint the start of a rescan (master...2018/04/rescan) https://github.com/bitcoin/bitcoin/pull/12925
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d3de17a226b...3cf76c23fbfc
< bitcoin-git> bitcoin/master fad0fc3 MarcoFalke: Refine travis check for duplicate includes...
< bitcoin-git> bitcoin/master 3cf76c2 MarcoFalke: Merge #12933: doc: Refine header include policy...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12933: doc: Refine header include policy (master...Mf1804-docIncludes) https://github.com/bitcoin/bitcoin/pull/12933
< fanquake> "something something linter hell"
< wumpus> yes...
< fanquake> At least the whitespace linter no longer complains about .patches, otherwise I really would be groaning in a minute.
< wumpus> at least the requirement for new linters is that they should serve to find potential bugs, not style issues
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12937: Handle witness version and OP_N results as an unsigned char (master...unsigned-char-witnessversion) https://github.com/bitcoin/bitcoin/pull/12937
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12912: Minor readability/maintainability changes to warnings.cpp (master...warnings) https://github.com/bitcoin/bitcoin/pull/12912
< bitcoin-git> [bitcoin] fanquake opened pull request #12946: depends: Fix Qt build with XCode 9.3 (master...fix-qt-xcode93) https://github.com/bitcoin/bitcoin/pull/12946
< bitcoin-git> [bitcoin] fanquake closed pull request #10619: [rpc]Avoid possibility of NULL pointer dereference in getblockchaininfo(...) (master...fix01) https://github.com/bitcoin/bitcoin/pull/10619
< bitcoin-git> [bitcoin] instagibbs opened pull request #12947: Wallet hd functional test speedup and clarification (master...wallet_hd_speedup) https://github.com/bitcoin/bitcoin/pull/12947
< instagibbs> re:12944, nevermind it's still valid but basically impossible to test, I think, removed errant test
< bitcoin-git> [bitcoin] achow101 closed pull request #11497: Hide accounts system behind deprecation switch (master...deprecate-account-rpcs) https://github.com/bitcoin/bitcoin/pull/11497
< achow101> kallewoof: I'll try to review it
< provoostenator> I restarted the failed Travis job for #12946 (p2p_compactblocks.py failure seems unrelated). TIL I have that power.
< gribble> https://github.com/bitcoin/bitcoin/issues/12946 | depends: Fix Qt build with XCode 9.3 by fanquake · Pull Request #12946 · bitcoin/bitcoin · GitHub
< provoostenator> My browser is having a hard time with 6000+ line Travis logs by the way.
< wumpus> provoostenator: yes ... :(
< wumpus> provoostenator: the 'travis' command line utility would be extremely useful there (https://github.com/travis-ci/travis.rb), except that it has problems with large logs too (https://github.com/travis-ci/travis.rb/issues/578) :P
< wumpus> I have a "curl https://api.travis-ci.org/v3/job/$1/log.txt | less -r" script that's sometimes useful
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12949: tests: Avoid copies of CTransaction (master...Mf1804-testNoCopyTx) https://github.com/bitcoin/bitcoin/pull/12949
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12950: bitcoin-tx: Flatten for loop over one element (master...Mf1804-bitcoinTxUnusedLoop) https://github.com/bitcoin/bitcoin/pull/12950
< bitcoin-git> [bitcoin] jamesob opened pull request #12951: [doc] Fix comment in FindForkInGlobalIndex (master...2018-04-11-findforkinglobalindex-doc) https://github.com/bitcoin/bitcoin/pull/12951
< jtimon> review/re-review begging https://github.com/bitcoin/bitcoin/pull/10757
< provoostenator> Added to list.
< cfields> feel a bit out of the loop. Did the parallel tests change end up borking everything? Several PRs atm that seem unrelated to the actual changes.
< cfields> *several failing PRs
< cfields> #12899 for example
< gribble> https://github.com/bitcoin/bitcoin/issues/12899 | macOS: Prevent Xcode 9.3 build warnings by AkioNak · Pull Request #12899 · bitcoin/bitcoin · GitHub
< wumpus> cfields: haven't noticed any problems with the parallel unit tests yet
< wumpus> cfields: are the unit tests failing on that?
< cfields> wumpus: ah right, it's bitcoin-util-test.py
< cfields> hmm
< wumpus> oh
< bitcoin-git> [bitcoin] jnewbery opened pull request #12953: Deprecate accounts (master...deprecate_accounts) https://github.com/bitcoin/bitcoin/pull/12953
< drexl> what marks an output as P2SH?
< drexl> is it the scriptPubKey starting with OP_HASH160 and ending with OP_EQUAL ?
< wumpus> drexl: correct, see CScript::IsPayToScriptHash
< drexl> great ty
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12526: Docs: Minor description fix to build procedure on Debian wrt BerkeleyDB (master...debian9-build-hint-update) https://github.com/bitcoin/bitcoin/pull/12526
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3cf76c23fbfc...7c06171b3d26
< bitcoin-git> bitcoin/master 05c03d1 joemphilips: rpc: fix type mistmatch in listreceivedbyaddress
< bitcoin-git> bitcoin/master 7c06171 MarcoFalke: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12837: rpc: fix type mistmatch in `listreceivedbyaddress` (master...fix_listreceivedbyaddress_type) https://github.com/bitcoin/bitcoin/pull/12837
< cfields> wumpus: I restarted that job and it failed again. I'm stumped as to why.
< wumpus> cfields: maybe flush the cache
< cfields> good idea. I'd kinda hate it if that fixed it, though
< wumpus> same, though I'd prefer a cosmic ray having corrupted the cache to the trivial build system change in #12899 mysteriously corrupting the excutable enough to fail the util test
< gribble> https://github.com/bitcoin/bitcoin/issues/12899 | macOS: Prevent Xcode 9.3 build warnings by AkioNak · Pull Request #12899 · bitcoin/bitcoin · GitHub
< cfields> heh, true
< wumpus> I can't reproduce it locally at least
< cfields> wumpus: thanks for testing
< cfields> wumpus: do you happen to have the travis-cli thing handy? The webui only shows caches for so many PRs, and 12899 isn't one of 'em :\
< wumpus> yep
< cfields> thanks
< wumpus> deleted all caches for PR.12899
< bitcoin-git> [bitcoin] conscott closed pull request #12930: WIP Refactor large transaction generation for tests and make generic (master...CRS_tests_flexible_tx_size) https://github.com/bitcoin/bitcoin/pull/12930
< cfields> great, thanks again. restarted one.
< promag> I'd love to have some feedback in #12929, ty
< gribble> https://github.com/bitcoin/bitcoin/issues/12929 | Remove CWallet dependency from CWalletTx by promag · Pull Request #12929 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c06171b3d26...979f59850c72
< bitcoin-git> bitcoin/master 6cba60a Gregory Sanders: speed up wallet_hd.py and clarify/augment checks
< bitcoin-git> bitcoin/master 979f598 MarcoFalke: Merge #12947: Wallet hd functional test speedup and clarification...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12947: Wallet hd functional test speedup and clarification (master...wallet_hd_speedup) https://github.com/bitcoin/bitcoin/pull/12947
< bitcoin-git> [bitcoin] jimpo opened pull request #12954: util: Refactor logging code into a global object (master...logging) https://github.com/bitcoin/bitcoin/pull/12954
< fanquake> cfields wumpus I noticed the same on 12899, looks like wiping the cache hasn't fixed the issue either.. I'll open a new issue with some info.
< dongcarl> Looking at https://github.com/bitcoin/bitcoin/issues/3171 here, wondering about the specifics: Should we bootstrap and measure every time an RC release is tagged? Would this be on some bare metal cloud instance? How would this be funded?