00:37 < tynes> its the same fingerprint used in bip173 right?

00:38 < gwillen> tynes: you mean 174? Yeah, it's that fingerprint.

01:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/93de9abe6d68...5392aee64fa2

01:17 < bitcoin-git> bitcoin/master dddd6f0 MarcoFalke: init: Throw error when network specific config is ignored

01:17 < bitcoin-git> bitcoin/master fa4a922 MarcoFalke: qa: Add test for missing testnet section in conf file

01:17 < bitcoin-git> bitcoin/master fa9058f MarcoFalke: doc: Add release notes for 15629

01:17 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15629: init: Throw error when network specific config is ignored (master...1903-InitErrorConf) https://github.com/bitcoin/bitcoin/pull/15629

01:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5392aee64fa2...8c022e8ac401

01:21 < bitcoin-git> bitcoin/master fa652b2 MarcoFalke: rpc: Add some doxygen comments to utils

01:21 < bitcoin-git> bitcoin/master fa26eb5 MarcoFalke: rpc: RPCHelpMan: Always push_name when outer type is an object

01:21 < bitcoin-git> bitcoin/master 8c022e8 MarcoFalke: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys

01:22 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15746: rpc: RPCHelpMan: Always name dictionary keys (master...1904-rpcUtilFix) https://github.com/bitcoin/bitcoin/pull/15746

02:42 < bitcoin-git> [bitcoin] kallewoof opened pull request #15780: wallet: add cachable accounts for caching credit/debit values (master...cachable-accounts) https://github.com/bitcoin/bitcoin/pull/15780

02:51 < tynes> gwillen: ah yes, 174. thanks for the correction :)

04:42 < kallewoof> Would appreciate any help reviewing #15780 so I can finally try to push to get #13756 merged!

04:42 < gribble> https://github.com/bitcoin/bitcoin/issues/15780 | wallet: add cachable accounts for caching credit/debit values by kallewoof · Pull Request #15780 · bitcoin/bitcoin · GitHub

04:42 < gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub

11:27 < bitcoin-git> [bitcoin] Bushstar opened pull request #15782: Avoid redefine warning (master...warning-redefine) https://github.com/bitcoin/bitcoin/pull/15782

13:18 < wumpus> git log --color-moved=dimmed_zebra is really neat

13:20 < sipa> yes

13:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c022e8ac401...e82f6ad6f270

13:25 < bitcoin-git> bitcoin/master f4b7a2f Ben Carman: rpc: getrpcinfo docs

13:25 < bitcoin-git> bitcoin/master e82f6ad MarcoFalke: Merge #15754: rpc: getrpcinfo docs

13:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15754: rpc: getrpcinfo docs (master...rpc_get_info_doc) https://github.com/bitcoin/bitcoin/pull/15754

13:32 < bitcoin-git> [bitcoin] Bushstar opened pull request #15783: Remove braces previously used for locks (master...unused-braces) https://github.com/bitcoin/bitcoin/pull/15783

13:35 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e82f6ad6f270...e3a0688f8275

13:35 < bitcoin-git> bitcoin/master c968780 r8921039: [docs] fix comment: the return value of findFork is _not_ an ancestor when...

13:35 < bitcoin-git> bitcoin/master e3a0688 MarcoFalke: Merge #15659: [docs] fix findFork comment

13:35 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15659: [docs] fix findFork comment (master...fix_findFork_comment) https://github.com/bitcoin/bitcoin/pull/15659

13:38 < luke-jr> only with -p ?

13:38 < wumpus> I think so, yes

13:38 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15783: Remove braces previously used for locks (master...unused-braces) https://github.com/bitcoin/bitcoin/pull/15783

13:51 < bitcoin-git> [bitcoin] ariard opened pull request #15784: rpc: Remove dependency on interfaces::Chain in SignTransaction (master...2019-04-remove-chain-sign-tx-utility) https://github.com/bitcoin/bitcoin/pull/15784

13:52 < bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/e3a0688f8275...6a135fbe5b30

13:52 < bitcoin-git> bitcoin/master fdf8888 John Newbery: [build] Move CheckTransaction from lib_server to lib_consensus

13:52 < bitcoin-git> bitcoin/master 4a75c9d John Newbery: [build] Move policy settings to new src/policy/settings unit

13:52 < bitcoin-git> bitcoin/master 1acc61f John Newbery: [build] Move rpc utility methods to rpc/util

13:53 < bitcoin-git> [bitcoin] laanwj merged pull request #15638: Move-only: Pull wallet code out of libbitcoin_server (master...pr/link) https://github.com/bitcoin/bitcoin/pull/15638

13:54 < fanquake> Probably just broke the record for time from PR opened to rebased required.

13:54 < fanquake> < 2 minutes :p

13:55 < wumpus> lol if only ariard had waited a few minutes

13:57 < wumpus> (or, had I managed to merge it sooner, I had github-merged it twice before and run the usual test-steps but there was a merge in between every time :-) )

14:31 < luke-jr> wumpus: of course, it's the branch time that matters, not the PR open time

14:43 < wumpus> luke-jr: sure

16:15 < dongcarl> Does anyone know what `nameProxy` does here: https://github.com/bitcoin/bitcoin/blob/6a135fbe5b30c3603616589b4779b1ce602c9392/src/netbase.cpp#L35

16:16 < dongcarl> It seems to be used in `ConnectNode` when we can't resolve to a "valid" `CNetAddr`

16:18 < dongcarl> But Tor-representing addresses are considered "valid", so I'm not sure when this would be used

16:28 < dongcarl> wumpus: I see your comments here: https://github.com/bitcoin/bitcoin/pull/6053#issuecomment-128671852

16:29 < dongcarl> However, looking at call sites of `SetNameProxy` there's only one and it sets it to be the same as all other nets

18:31 < bitcoin-git> [bitcoin] jnewbery closed pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778

20:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15788: test: Unify testing setups for fuzz, bench, and unit tests (master...1904-testUnify) https://github.com/bitcoin/bitcoin/pull/15788

21:27 < bitcoin-git> [bitcoin] jnewbery reopened pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778

21:52 < jnewbery> Are people seeing more Travis timeouts that before on their PRs?

21:52 < jnewbery> Error! Initial build successful, but not enough time remains to run later build stages and tests. Please manually re-run this job by using the travis restart button or asking a bitcoin maintainer to restart. The next run should not time out because the build cache has been saved.

21:52 < jnewbery> *more than before

21:53 < jnewbery> Seems to happen on most of my PRs these days