02:18 < phantomcircuit> luke-jr, it seems to be random whether they accept them or not

11:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c65c77c721b6...653b2b4426cf

11:28 < bitcoin-git> bitcoin/master 25b0786 Gregory Sanders: Fix missing input template by making minimal tx

11:28 < bitcoin-git> bitcoin/master cc556e4 Gregory Sanders: Add test for superfluous witness record in deserialization

11:28 < bitcoin-git> bitcoin/master 653b2b4 MarcoFalke: Merge #15893: Add test for superfluous witness record in deserialization

11:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15893: Add test for superfluous witness record in deserialization (master...test_super_witness) https://github.com/bitcoin/bitcoin/pull/15893

11:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/653b2b4426cf...f73a3c618b87

11:50 < bitcoin-git> bitcoin/master a014373 Luke Dashjr: QA: Avoid re-reading config.ini unnecessarily

11:50 < bitcoin-git> bitcoin/master f73a3c6 MarcoFalke: Merge #15895: QA: Avoid re-reading config.ini unnecessarily

11:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15895: QA: Avoid re-reading config.ini unnecessarily (master...redundant_configini) https://github.com/bitcoin/bitcoin/pull/15895

12:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f73a3c618b87...5046d4e911aa

12:18 < bitcoin-git> bitcoin/master fcc443b Luke Dashjr: QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages ...

12:18 < bitcoin-git> bitcoin/master 5046d4e MarcoFalke: Merge #15896: QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAM...

12:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15896: QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core (master...qa_pkgname) https://github.com/bitcoin/bitcoin/pull/15896

13:04 < meshcollider> Reminder the wallet meeting is this week, in about 6 hours

14:05 < promag> #15463 was merged, #14984 could also be merged

14:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15463 | rpc: Speedup getaddressesbylabel by promag · Pull Request #15463 · bitcoin/bitcoin · GitHub

14:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14984 | rpc: Speedup getrawmempool when verbose=true by promag · Pull Request #14984 · bitcoin/bitcoin · GitHub

14:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15899: rpc: Document iswitness flag and fix bug in converttopsbt (master...1904-docIsWitness) https://github.com/bitcoin/bitcoin/pull/15899

16:44 < bitcoin-git> [bitcoin] andrewtoth opened pull request #15901: wallet: log on rescan completion (master...log-rescan-completed) https://github.com/bitcoin/bitcoin/pull/15901

16:46 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/5046d4e911aa...b1e013e4fa21

16:46 < bitcoin-git> bitcoin/master d8ab8dc Luke Dashjr: configure: Invert --enable-asm help string since default is now enabled

16:46 < bitcoin-git> bitcoin/master afe0875 Luke Dashjr: configure: Skip assembly support checks, when assembly is disabled

16:46 < bitcoin-git> bitcoin/master 4207c1b Luke Dashjr: configure: Initialise assembly enable_* variables

16:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #13788: Fix --disable-asm for newer assembly checks/code (master...bugfix_asm_opt) https://github.com/bitcoin/bitcoin/pull/13788

17:07 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15903: appveyor: Write @PACKAGE_NAME@ to config (master...1904-appveyorPackage) https://github.com/bitcoin/bitcoin/pull/15903

17:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b1e013e4fa21...d76b72a454a1

17:11 < bitcoin-git> bitcoin/master 5d26205 James O'Beirne: doc: explain AcceptToMemoryPoolWorker's coins_to_uncache

17:11 < bitcoin-git> bitcoin/master d76b72a MarcoFalke: Merge #15267: doc: explain AcceptToMemoryPoolWorker's coins_to_uncache

17:11 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15267: doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (master...2019-01-atmpw-uncache-coins-doc) https://github.com/bitcoin/bitcoin/pull/15267

17:17 < hebasto> It seems merged #15896 broke interface_bitcoin_cli.py in AppVeyor.

17:17 < gribble> https://github.com/bitcoin/bitcoin/issues/15896 | QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core by luke-jr · Pull Request #15896 · bitcoin/bitcoin · GitHub

17:25 < luke-jr> why isn't AppVeyor using normal build stuff?

18:06 < provoostenator> luke-jr what do you mean by (ab)normal?

19:00 < meshcollider> #startmeeting

19:00 < lightningbot> Meeting started Fri Apr 26 19:00:17 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.

19:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.

19:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb

19:00 < provoostenator> hi

19:00 < achow101> hi

19:00 < meshcollider> Ok, topics this week?

19:00 < instagibbs> hi

19:00 < phantomcircuit> hi

19:01 < sipa> hi

19:02 < gwillen> hi

19:02 < midnightmagic> hi

19:02 < instagibbs> achow101, descriptor wallet updates?

19:03 < achow101> I narrowed the scope and added some tests

19:03 < achow101> it could probably use more tests. just waiting on review now

19:04 < meshcollider> #15764

19:04 < gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub

19:05 < sipa> i'll try to find the time to review that, but probably too busy with other things the next week or so

19:06 < meshcollider> Its definitely on my list to review too, its very large though so it'll take a while

19:07 < achow101> i broke up the big commit into a bunch of smaller ones so hopefuly it will be easier to review

19:08 < meshcollider> Any other things anyone wants to discuss?

19:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d76b72a454a1...ec519d4d5489

19:08 < bitcoin-git> bitcoin/master faebd8c MarcoFalke: appveyor: Write @PACKAGE_NAME@ to config

19:08 < bitcoin-git> bitcoin/master ec519d4 MarcoFalke: Merge #15903: appveyor: Write @PACKAGE_NAME@ to config

19:08 < meshcollider> The meeting yesterday was very short, looks like this one will be too :)

19:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15903: appveyor: Write @PACKAGE_NAME@ to config (master...1904-appveyorPackage) https://github.com/bitcoin/bitcoin/pull/15903

19:09 < sipa> i don't have anything

19:10 < provoostenator> Me neither, just making incremental improvements to #14912

19:10 < gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub

19:10 < meshcollider> Ok let's leave it there, thanks everyone

19:10 < meshcollider> #endmeeting

19:10 < lightningbot> Meeting ended Fri Apr 26 19:10:53 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)

19:10 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-26-19.00.html

19:10 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-26-19.00.txt

19:10 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-26-19.00.log.html

22:21 < bitcoin-git> [bitcoin] andrewtoth opened pull request #15904: trivial: Fix typo (0.18...patch-1) https://github.com/bitcoin/bitcoin/pull/15904

22:26 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/379f71ea4f27...825ecb5758f6

22:26 < bitcoin-git> bitcoin/0.18 fad9eb1 MarcoFalke: doc: 0.18: Remove TODO from release notes

22:26 < bitcoin-git> bitcoin/0.18 825ecb5 MarcoFalke: Merge #15852: doc: 0.18: Remove TODO from release notes

22:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15852: doc: 0.18: Remove TODO from release notes (0.18...1904-docRel18) https://github.com/bitcoin/bitcoin/pull/15852

22:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec519d4d5489...65ec4d6fb2be

22:33 < bitcoin-git> bitcoin/master 201393f Hennadii Stepanov: Align code example with clang-format

22:33 < bitcoin-git> bitcoin/master 65ec4d6 MarcoFalke: Merge #15887: docs: Align code example style with clang-format

22:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15887: docs: Align code example style with clang-format (master...20190424-coding-style) https://github.com/bitcoin/bitcoin/pull/15887

22:50 < bitcoin-git> [bitcoin] andrewtoth closed pull request #15904: trivial: Fix typo (0.18...patch-1) https://github.com/bitcoin/bitcoin/pull/15904