01:06 < meshcollider> #15622 rtm?

01:06 < gribble> https://github.com/bitcoin/bitcoin/issues/15622 | Remove globals: Avoid using the global namespace if possible by practicalswift · Pull Request #15622 · bitcoin/bitcoin · GitHub

01:17 < meshcollider> sipa: re #15371, is that even allowed to just capitalize the HRP? won't that invalidate the checksum? I'm not sure if I am remembering rightly

01:17 < gribble> https://github.com/bitcoin/bitcoin/issues/15371 | gui: Uppercase bech32 addresses in qr codes by benthecarman · Pull Request #15371 · bitcoin/bitcoin · GitHub

01:20 < sipa> meshcollider: mixed case is not allowed

01:20 < sipa> but uppercasing everything is allowed, and recommended inside qr codes

01:21 < sipa> the checksum is case insensitive

01:22 < meshcollider> sipa: oh, is the hrp always converted to lowercase before processing

01:22 < meshcollider> I thought the hrp was processed using the ascii values which would be different for upper and lower case

01:23 < sipa> the whole thing is converted to lowercase before computing the checksum

01:23 < meshcollider> ah ok, that makes sense then

01:23 < meshcollider> does it say that in the BIP?

01:24 < sipa> yes

01:24 < sipa> The lowercase form is used when determining a character's value for checksum purposes.

01:24 < meshcollider> ah, i thought that was just referring to the data part

01:24 < meshcollider> ok

01:24 < sipa> For presentation, lowercase is usually preferable, but inside QR codes uppercase SHOULD be used.

04:09 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/66ce95a43400...adc55dbac5b5

04:09 < bitcoin-git> bitcoin/master 9819ad6 John Newbery: [rpc] simplify generate RPC

04:09 < bitcoin-git> bitcoin/master 1b46a48 John Newbery: [cleanup] Remove unused CReserveKey

04:09 < bitcoin-git> bitcoin/master adc55db MeshCollider: Merge #15748: [rpc] remove dead mining code

04:10 < bitcoin-git> [bitcoin] meshcollider merged pull request #15748: [rpc] remove dead mining code (master...2019_04_simplify_generate) https://github.com/bitcoin/bitcoin/pull/15748

09:54 < bitcoin-git> [bitcoin] promag closed pull request #14458: WIP: Add JSON-RPC interface documentation (master...2018-10-doc-json-rpc) https://github.com/bitcoin/bitcoin/pull/14458

13:36 < bitcoin-git> [bitcoin] practicalswift opened pull request #15814: Remove all untested unused methods. Add test for bitcoinconsensus_version() to make it technically in use. (master...untested-unused-methods) https://github.com/bitcoin/bitcoin/pull/15814

14:05 < bitcoin-git> [bitcoin] promag closed pull request #15656: wallet: Keep all outputs in bumpfee (master...2019-03-bumpall) https://github.com/bitcoin/bitcoin/pull/15656

16:20 < bitcoin-git> [bitcoin] r8921039 opened pull request #15815: remove duplicate boundary check in script.cpp (master...remove_duplicate_boundary_check) https://github.com/bitcoin/bitcoin/pull/15815

17:49 < ujjwalt> I'm looking to build some apps on top of Bitcoin Core. Where can I learn more about running BC in production?

20:42 < bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/adc55dbac5b5...4f4ef3138b06

20:42 < bitcoin-git> bitcoin/master 0ea47ba Gregory Sanders: generalize bumpfee to add inputs when needed

20:42 < bitcoin-git> bitcoin/master d08becf Gregory Sanders: add functional tests for feerate bumpfee with adding inputs

20:42 < bitcoin-git> bitcoin/master 184f878 Gregory Sanders: wallet_bumpfee.py: add test for change key preservation

20:43 < bitcoin-git> [bitcoin] meshcollider merged pull request #15557: Enhance `bumpfee` to include inputs when targeting a feerate (master...bumpall) https://github.com/bitcoin/bitcoin/pull/15557