strange, how to get an old wallet to generate a p2sh-segwit of bech32 receiving address? I don't seem to be able to from the GUI, I've done -upgradewallet and it upgrades the wallet in the log, but still, I get a 1xxxxx address when I generate a receiving address (and I've tried to uncheck "generate legacy address"
fwiw it did "Performing wallet upgrade to 169900" "Upgrading wallet to HD" "Upgrading wallet to use HD chain split"
we might want to disable that checkbox completely in this case
wumpus: the wallet version shouldn't matter
try setting addresstype=p2sh-segwit?
I've done that, didn't work, I don't think that's supposed to affect the GUI. Also checked that it did work with a new wallet.
I was asking in case the answer was obvious and I was missing soething, but apparently not :) I'll investigate deeper later, have some administration to do now
it's supposed to effect the gui and it has been for me (at least addresstype=bech32 does)
addresstype=bech32 should indeed affect the GUI, but it merely changes the default checkbox. 1x addresses suggest a different problem.
gmaxwell: i wonder if we should just revert #14897 for 0.18? i would like those changes to go in but i'm nervous about the edge cases we have overlooked thus far, which result in things like tx relay failing en masse and fill-up-your-memory attacks.