< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #15906: [wallet] Remove AvailableCoins nMinDepth argument (master...refactor_available_coins) https://github.com/bitcoin/bitcoin/pull/15906
< luke-jr> prevector.h:438:32: runtime error: reference binding to misaligned address 0x7ffcbf3f7962 for type 'prevector<28, unsigned char, unsigned int, int>::size_type' (aka 'unsigned int'), which requires 4 byte alignment
< luke-jr> is this something to be concerned about? shouldn't Travis be detecting it?
< sipa> that sounds concerning
< sipa> i don't think we support any platform where this actually matters, but if we're violating an alignment it should be fixed
< luke-jr> I've seen misaligned stuff crash on x86, but presumably not this particular case
< sipa> there are some sse instructions that actually require alignment, but afaik for everything else it's at worst a performance penalty
< gmaxwell> sipa: misalignment is usually also UB, ... also the compiler will emit aligned SSE instructions when it can, and they will crash the program (unfortunately only when the misaligment is on a page boundary, so it can work correctly 99/100 times)
< luke-jr> 4093/4096? :P
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65ec4d6fb2be...703414994aa4
< bitcoin-git> bitcoin/master 99e88a3 Antoine Riard: rpc: Remove dependency on interfaces::Chain in SignTransaction
< bitcoin-git> bitcoin/master 7034149 MeshCollider: Merge #15784: rpc: Remove dependency on interfaces::Chain in SignTransacti...
< bitcoin-git> [bitcoin] meshcollider merged pull request #15784: rpc: Remove dependency on interfaces::Chain in SignTransaction (master...2019-04-remove-chain-sign-tx-utility) https://github.com/bitcoin/bitcoin/pull/15784
< bitcoin-git> [bitcoin] hebasto opened pull request #15908: scripts and tools, docs: Align MSVC build options with Linux build ones (master...20190427-align-msvc-linux) https://github.com/bitcoin/bitcoin/pull/15908
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/703414994aa4...b025aa3b9e1d
< bitcoin-git> bitcoin/master c634b1e Pieter Wuille: [POLICY] Make sending to future native witness outputs standard
< bitcoin-git> bitcoin/master b025aa3 MeshCollider: Merge #15846: [POLICY] Make sending to future native witness outputs stand...
< bitcoin-git> [bitcoin] meshcollider merged pull request #15846: [POLICY] Make sending to future native witness outputs standard (master...201904_futuresegwitstandard) https://github.com/bitcoin/bitcoin/pull/15846
< fanquake> wumpus: "less than 100000 words of code" is a bit of a weird metric
< fanquake> hebasto: We try and keep @mentions out of PR descriptions, as they mostly just lead to spam when downstream projects pull our commits (which is why I removed the "@" from 15908).
< hebasto> fanquake: ok, sorry for that.
< fanquake> hebasto no worries!
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b025aa3b9e1d...3356799ee3f5
< bitcoin-git> bitcoin/master 5c759c7 John Newbery: [wallet] Move maxTxFee to wallet
< bitcoin-git> bitcoin/master 3356799 MarcoFalke: Merge #15778: [wallet] Move maxtxfee from node to wallet
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< bitcoin-git> [bitcoin] darosior opened pull request #15909: Use 'CreateProcess' instead of 'wsystem' in 'runCommand' for Windows. (master...windows_blocknotify_blink) https://github.com/bitcoin/bitcoin/pull/15909
< ElePHPhant> I just made a Bitcoin payment and the merchant uses Bitpay. First of all, the webpage displayed a "We see you are using Bitcoin Core" message which freaked me out. How can they know that? Secondly, I got this weird Bitcoin Core error popup when actually performing the payment (which had a green coloring around it): "Error communicating with https://bitpay.com/i/<REDACTED>: Error transferring https://bitpay.com/i/<REDACTED> - server
< ElePHPhant> replied: Bad Request" ... But in spite of the error, the webpage said in a few seconds: "You have fully paid the invoice."
< Lauda> ElePHPhant: it's been like that for a while now
< ElePHPhant> Lauda: Why? What does it mean?
< ElePHPhant> Is it a bug with Bitpay or Bitcoin Core?
< gmaxwell> Bitpay implements BIP70 incorrectly and requires their incorrect implementation (which also creates security vulnerabilities)
< gmaxwell> We're removing BIP70 from bitcoin core completely, since essentially nothing uses it (except bitpay) --- we were close to removing it when they made it mandatory, then we held off, but since their implementation is hardly compatible there really isn't much reason to not remove it just for them.
< Lauda> it's a Bitpay problem not a core problem, thus not relevant here
< Lauda> really*
< bitcoin-git> [bitcoin] Sjors opened pull request #15911: Use wallet RBF default for walletcreatefundedpsbt (master...2019/04/walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/15911
< provoostenator> ^ one sec, simplifying it a bit...
< ElePHPhant> gmaxwell: Will that mean that Bitcoin Core will no longer work with Bitpay payments?
< ElePHPhant> gmaxwell: And still, how did they detect which software I ran?
< midnightmagic> ElePHPhant: #bitcoin, please. The topic here is very specifically for development of bitcoin core and not support questions.
< ElePHPhant> Right... but that room doesn't let me speak.