01:27 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e796fdd4cb8e...a1d14f522c45

01:27 < bitcoin-git> bitcoin/master 3340dba Andrew Chow: Remove -zapwallettxes

01:27 < bitcoin-git> bitcoin/master a1d14f5 fanquake: Merge #19671: wallet: Remove -zapwallettxes

01:27 < bitcoin-git> [bitcoin] fanquake merged pull request #19671: wallet: Remove -zapwallettxes (master...rm-zapwallettxes) https://github.com/bitcoin/bitcoin/pull/19671

02:22 < achow101> is there a way to do uint256 set hex without the byte reversing thing?

02:24 < sipa> ParseHex + std::copy ?

02:27 < achow101> ah, ther's a non-const begin()

06:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a1d14f522c45...bab4cce1b0ee

06:28 < bitcoin-git> bitcoin/master af9ea55 Hennadii Stepanov: Use LockAssertion utility class instead of AssertLockHeld()

06:28 < bitcoin-git> bitcoin/master 3ddc150 Hennadii Stepanov: Add missed thread safety annotations

06:28 < bitcoin-git> bitcoin/master 23d71d1 Hennadii Stepanov: Do not hide compile-time thread safety warnings

06:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19668: Do not hide compile-time thread safety warnings (master...200805-assert) https://github.com/bitcoin/bitcoin/pull/19668

07:14 < gleb> sdaftuar: I see. In isolation, the second solution is probably better: block-relay-only rotation makes perfect sense. But I'd keep in mind other ideas... Like sending transaction to a random node and disconnecting (for the sake of privacy), or self-advertising to a random node.

07:16 < gleb> These can't work with block-relay-only, because they'd relay transactions and addrs... And we'll need new connection types here anyway? Now it's just a code organization question. You probably have a better idea of what it might look like. I'm just suggesting to consider these potential plans as well.

09:49 < bitcoin-git> [bitcoin] hebasto opened pull request #19854: Avoid locking CTxMemPool::cs recursively in simple cases (master...200901-mmx3) https://github.com/bitcoin/bitcoin/pull/19854

09:49 < vasild> https://github.com/bitcoin/bitcoin/blob/master/test/functional/p2p_leak.py#L7-L8 "A node should never send anything other than VERSION/VERACK until it's received a VERACK" -- is this comment correct?

09:50 < bitcoin-git> [bitcoin] hebasto closed pull request #19647: Add thread safety annotations to CTxMemPool methods (master...200802-mmx-1) https://github.com/bitcoin/bitcoin/pull/19647

09:50 < vasild> A node that has received in inbound connection would send WTXIDRELAY message as a reply to the VERSION message, without waiting for VERACK: https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L2431

09:52 < vasild> A node that is making an outbound connection would send WTXIDRELAY as above + also GETADDR without waiting for VERACK: https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L2490

10:07 < gleb> vasild: correct w.r.t what? You're right that this comment doesn't reflect the current codebase :)

10:07 < vasild> :-D

10:08 < vasild> If the code and the comments disagree, then both are probably wrong.

10:08 < vasild> -- Norm Schryer

10:50 < jonatack> vasild: see https://bitcoincore.reviews/18044#l-171

11:22 < vasild> jonatack: I read it, thanks

15:36 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bab4cce1b0ee...48c108363268

15:36 < bitcoin-git> bitcoin/master ab30cec Fabian Jahr: test: Move modinv to util and add unit test

15:36 < bitcoin-git> bitcoin/master b85543c Pieter Wuille: test: Add Python MuHash3072 implementation to test framework

15:36 < bitcoin-git> bitcoin/master 0e2b400 Fabian Jahr: test: Add basic Python/C++ Muhash implementation parity unit test

15:37 < bitcoin-git> [bitcoin] laanwj merged pull request #19105: Add Muhash3072 implementation in Python (master...csi-2-muhash-py) https://github.com/bitcoin/bitcoin/pull/19105

15:37 < aj> woooah

15:57 < bitcoin-git> [bitcoin] jonatack opened pull request #19857: net: improve nLastBlockTime and nLastTXTime documentation (master...nLast-documentation) https://github.com/bitcoin/bitcoin/pull/19857

16:44 < sdaftuar> vasild: yeah i was unaware of that test when i submitted the wtxidrelay PR. that comment should be fixed.

21:09 < bitcoin-git> [bitcoin] sdaftuar opened pull request #19858: Periodically make block-relay connections and sync headers (master...2020-08-blocks-only-rotation) https://github.com/bitcoin/bitcoin/pull/19858