< sipa>
aaaargh... it's possible to send a P2P message, and then call an RPC, and have the RPC processed before the P2P message :(
< sipa>
this shouldn't have taken me hours to figure out...
< aj>
sipa: "overhaul threading" pr coming up?
< sipa>
"Make bitcoind single-threaded"
< fanquake>
😢
< midnight>
explicit state machines. :( Very difficult for threading apps. I've never seen anyone get it right the first time in an evolving codebase. fwiw.
< sipa>
it was trivially fixed using a p.sync_with_ping()
< sipa>
midnight: don't worry, it was a very simple test
< midnight>
:-)
< sipa>
i just kind of forgot there was a p2p network buffer
< midnight>
no worries here, just seen the same kind of thing from multi-billion dollar projects to two-man operations-- from amdocs to google to games companies and tools companies. So relatively mild problems like this are unsurprising and I feel sympathy for the annoyance of tracking it down.
< midnight>
I tracked down a threading issue in a qt app once where an object was in the midst of being constructed before the result was passed to a slot, and so on very specific kinds of machines it'd be trying to access a null pointer because the dev team didn't serialize that particular object's construction.
< midnight>
:-( I hate that that took six hours of my life grovelling through backtraces.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20028: test: Check that invalid peer traffic is accounted for (master...2009-testInvalidTraffic) https://github.com/bitcoin/bitcoin/pull/20028
< harding>
Can someone with either Travis access or GitHub admin access for the bitcoin-core organization take a look at https://github.com/bitcoin-core/bitcoincore.org/pull/722 please? I'd like to merge it but its travis job is stuck and the master branch is protected against merges that haven't passed CI.
< provoostenator>
Tempted to ask achow101 to just add a --without-bdb config option to #19077
< gribble>
https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< provoostenator>
And NO_BDB to the depends build
< luke-jr>
provoostenator: that won't fix it :p
< luke-jr>
I mean, if you don't have a bdb wallet (which most macOS users do..), you could even just ignore the warning
< luke-jr>
did anyone post the real config.log anywhere?