05:15 < bitcoin-git> [bitcoin] monperrus opened pull request #19987: fix: remove confusing warning (#16343 #19603) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19987

05:19 < bitcoin-git> [bitcoin] fanquake closed pull request #19987: fix: remove confusing warning (#16343 #19603) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19987

07:17 < bitcoin-git> [bitcoin] sipa closed pull request #19184: Overhaul transaction request logic (master...202004_txrequest_rand) https://github.com/bitcoin/bitcoin/pull/19184

07:21 < bitcoin-git> [bitcoin] sipa opened pull request #19988: Overhaul transaction request logic (master...202009_txrequest_rand_wtxid) https://github.com/bitcoin/bitcoin/pull/19988

09:39 < gleb> 3 ACKs on what seems to be a well-reviewed not-so-difficult PR, perhaps a little more attention and we can merge it off the high-prio list :) #19697

09:39 < gribble> https://github.com/bitcoin/bitcoin/issues/19697 | Improvements on ADDR caching by naumenkogs · Pull Request #19697 · bitcoin/bitcoin · GitHub

09:54 < kallewoof> Signet PR now has 2 tACKs, 1 Approach ACK, and one misc review; please add yours :) https://github.com/bitcoin/bitcoin/pull/18267

11:47 < vasild> hebasto: https://github.com/bitcoin/bitcoin/pull/18750#pullrequestreview-492222732 -- what is that crash? Do you think it may be related to the PR in some way?

14:17 < hebasto> vasild: on master it works fine. It seems like with `--enable-suppress-external-warnings` system headers are used

14:19 < vasild> hmm

14:24 < vasild> hebasto: I don't get it. Are you saying that same steps on master work, whereas on #18750 produce a crash immediately at startup? And CI is green.

14:24 < gribble> https://github.com/bitcoin/bitcoin/issues/18750 | build: optionally skip external warnings by vasild · Pull Request #18750 · bitcoin/bitcoin · GitHub

14:32 < hebasto> does any CI build use depends + clang + `libc++` + `--enable-suppress-external-warnings`?

14:36 < vasild> no

14:37 < hebasto> vasild: https://github.com/bitcoin/bitcoin/pull/18750#pullrequestreview-492222732 exploits such setup

14:38 < vasild> I guess I have to reproduce this somehow in order to understand and fix it.

14:40 < hebasto> vasild: I deliberately setup a system with two sets of headers that are incompatible -- in `/usr/include` is built against `libstdc++`, and in depends which is built against `libc++`

17:37 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b99a1633b270...c0c409dcd330

17:37 < bitcoin-git> bitcoin/master 42ec558 Gleb Naumenko: Justify the choice of ADDR cache lifetime

17:37 < bitcoin-git> bitcoin/master 81b00f8 Gleb Naumenko: Add indexing ADDR cache by local socket addr

17:37 < bitcoin-git> bitcoin/master 83ad65f Gleb Naumenko: Address nits in ADDR caching

17:38 < bitcoin-git> [bitcoin] laanwj merged pull request #19697: Improvements on ADDR caching (master...2020-08-addr-cache-follow-up) https://github.com/bitcoin/bitcoin/pull/19697

18:04 < jaybny> test

18:59 < hebasto> wumpus: fanquake: MarcoFalke: #17785 has five ACKs from amiti, fjahr, jnewbery, gleb, and benthecarman. Is it rtm?

18:59 < gribble> https://github.com/bitcoin/bitcoin/issues/17785 | p2p: Unify Send and Receive protocol versions by hebasto · Pull Request #17785 · bitcoin/bitcoin · GitHub

20:33 < bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/c0c409dcd330...8c5f68118cd0

20:33 < bitcoin-git> bitcoin/master a2147d7 Karl-Johan Alm: validation: move GetWitnessCommitmentIndex to consensus/validation

20:33 < bitcoin-git> bitcoin/master 404682b Karl-Johan Alm: add signet basic support (signet.cpp)

20:33 < bitcoin-git> bitcoin/master e8990f1 Karl-Johan Alm: add signet chain and accompanying parameters

20:35 < bitcoin-git> [bitcoin] laanwj merged pull request #18267: BIP-325: Signet [consensus] (master...2003-signet-consensus) https://github.com/bitcoin/bitcoin/pull/18267

20:39 < jonatack> \o/ congrats kallewoof and aj

20:39 < wumpus> yess

20:40 < fjahr> \o/

20:58 < instagibbs> woop

22:15 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8c5f68118cd0...77376034d4ab

22:15 < bitcoin-git> bitcoin/master e9a6d8b Hennadii Stepanov: p2p: Unify Send and Receive protocol versions

22:15 < bitcoin-git> bitcoin/master 8d20267 Hennadii Stepanov: refactor: Rename local variable nSendVersion

22:15 < bitcoin-git> bitcoin/master e084d45 Hennadii Stepanov: p2p: Remove SetCommonVersion() from VERACK handler

22:16 < bitcoin-git> [bitcoin] laanwj merged pull request #17785: p2p: Unify Send and Receive protocol versions (master...20191220-unify-protocol-versions) https://github.com/bitcoin/bitcoin/pull/17785