< bitcoin-git> [bitcoin] theStack opened pull request #19890: refactor: remove unused header <arpa/inet.h> in protocol.cpp (master...20200823-refactor-remove-unsused-include-in-protocol-cpp) https://github.com/bitcoin/bitcoin/pull/19890
< dhruvm> May I please request a CI job restart? https://travis-ci.org/github/bitcoin/bitcoin/jobs/724564326
< sipa> dhruvm: done
< dhruvm> sipa: thanks
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3ba25e3bdde3...03689317021a
< bitcoin-git> bitcoin/master fa8e148 MarcoFalke: ci: Double tsan CPU and Memory to avoid global timeout
< bitcoin-git> bitcoin/master 0368931 MarcoFalke: Merge #19881: ci: Double tsan CPU and Memory to avoid global timeout
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19881: ci: Double tsan CPU and Memory to avoid global timeout (master...2008-ciGlobalTimeout) https://github.com/bitcoin/bitcoin/pull/19881
< bitcoin-git> [bitcoin] hebasto opened pull request #19891: depends: Fix `make --just-print` command (master...200906-dry) https://github.com/bitcoin/bitcoin/pull/19891
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03689317021a...c91f955f4490
< bitcoin-git> bitcoin/master 56b018c Fabian Jahr: test: Fix flaky wallet_basic test
< bitcoin-git> bitcoin/master c91f955 MarcoFalke: Merge #19887: test: Fix flaky wallet_basic test
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19887: test: Fix flaky wallet_basic test (master...flaky_wallet) https://github.com/bitcoin/bitcoin/pull/19887
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c91f955f4490...68d1f1698f50
< bitcoin-git> bitcoin/master 2f79e9d Sebastian Falbesoner: refactor: remove unused header <arpa/inet.h> in protocol.cpp
< bitcoin-git> bitcoin/master 68d1f16 Wladimir J. van der Laan: Merge #19890: refactor: remove unused header <arpa/inet.h> in protocol.cpp...
< bitcoin-git> [bitcoin] laanwj merged pull request #19890: refactor: remove unused header <arpa/inet.h> in protocol.cpp (master...20200823-refactor-remove-unsused-include-in-protocol-cpp) https://github.com/bitcoin/bitcoin/pull/19890
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19893: test: Remove or explain syncwithvalidationinterfacequeue (master...2009-testSync) https://github.com/bitcoin/bitcoin/pull/19893
< bitcoin-git> [bitcoin] verretor opened pull request #19897: Revert "change blacklist to blocklist" (master...blocklist) https://github.com/bitcoin/bitcoin/pull/19897
< promag> party at #19897?
< gribble> https://github.com/bitcoin/bitcoin/issues/19897 | Revert "change blacklist to blocklist" by verretor · Pull Request #19897 · bitcoin/bitcoin · GitHub
< achow101> promag: I think nopara's comment sums it up perfectly
< promag> I didn't realise there's so much ready to jump on these discussions
< promag> ... so many people ready ..
< achow101> should've been locked to contributors only after the third comment imo
< promag> I'll name all my variables blocklist, hope to get more reviewers
< MarcoFalke> Agree that this should be locked to contributors. Couldn't find the button, though. *Shrug*
< promag> MarcoFalke: you need to be maintainer X)
< achow101> MarcoFalke: it's supposed to be a button on the right side underneath the participant icon list
< MarcoFalke> yeah, I see that. but that is also going to lock out contributors that don't have write access
< MarcoFalke> I think GitHub still hasn't fixed their permissions
< achow101> all of the people who can manage issues have "write" access, so that's probably fine?
< bitcoin-git> [bitcoin] n-thumann opened pull request #19898: log: print unexpected version warning in validation log category (master...log-fix-unexpected-version) https://github.com/bitcoin/bitcoin/pull/19898
< promag> achow101: btw I've added your suggestion in #19738
< gribble> https://github.com/bitcoin/bitcoin/issues/19738 | wallet: Avoid multiple BerkeleyBatch in DelAddressBook by promag · Pull Request #19738 · bitcoin/bitcoin · GitHub
< luke-jr> promag: now if only we could find a way to teach them to review code..
< luke-jr> achow101: most of us can't manage issues afaik? or have I been specifically excluded for some reason?
< promag> I can't add labels on my pulls/issues too
< achow101> luke-jr: neither can I, but I also don't care enough to ask someone for the permission to
< luke-jr> achow101: so you're saying actually block the PR entirely rather than limit real review of it?
< achow101> luke-jr: if you really want to review it, you can ask for the permissions?
< luke-jr> I don't care *that* much to review it..
< achow101> it also seems reasonable that the frequence contributors group should also have issue management permissions too
< luke-jr> achow101: I did suggest that [prior to] a few meetings ago, but wumpus didn't like the idea
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68d1f1698f50...af8135e369da
< bitcoin-git> bitcoin/master 637d8bc Benoit Verret: Change FILE_CHAR_BLOCKLIST to FILE_CHARS_DISALLOWED
< bitcoin-git> bitcoin/master af8135e Wladimir J. van der Laan: Merge #19897: Change FILE_CHAR_BLOCKLIST to FILE_CHARS_DISALLOWED
< bitcoin-git> [bitcoin] laanwj merged pull request #19897: Change FILE_CHAR_BLOCKLIST to FILE_CHARS_DISALLOWED (master...blocklist) https://github.com/bitcoin/bitcoin/pull/19897
< MarcoFalke> wumpus: Thanks for merging. Hopefully we can focus on important changes now.
< promag> oh show's over
< theStack> MarcoFalke: +1
< luke-jr> disallowed is technically wrong, but whatever
< luke-jr> hopefully it makes the political commentators happy
< theStack> yes, i hope there is not another PR coming reverting the previous two ;-)
< promag> luke-jr: it's not that bad tbh
< luke-jr> promag: well, it's not about allowing or disallowing anything, but.. it's a var name, so who cares XD
< promag> luke-jr: i'd name it lviggiano
< luke-jr> wut
< luke-jr> how about `CHARS_THE_OS_IS_BIGOTED_AGAINST` ? :p
< promag> :D
< TallTim> Nice, revisionists are rather annoying and also myopic.
< bitcoin-git> [bitcoin] lviggiano opened pull request #19900: Revert back to FILE_CHARS_BLOCKLIST (master...master) https://github.com/bitcoin/bitcoin/pull/19900
< hebasto> theStack: ^
< elichai2> Damn it
< bitcoin-git> [bitcoin] laanwj closed pull request #19900: Revert back to FILE_CHARS_BLOCKLIST (master...master) https://github.com/bitcoin/bitcoin/pull/19900
< wumpus> ok, if this goes on i'm going to ban people from the organization, i don't care about your political bs don't waste my (and other devs) time with this
< sipa> +1
< luke-jr> sigh
< bitcoin-git> [bitcoin] hebasto opened pull request #19901: Avoid locking CTxMemPool::cs recursively in CTxMemPool::DynamicMemoryUsage() (master...200906-pool) https://github.com/bitcoin/bitcoin/pull/19901
< elichai2> amiti: looking at #19879, does `m_unbroadcast_txids` need to be ordered?
< gribble> https://github.com/bitcoin/bitcoin/issues/19879 | [p2p] miscellaneous wtxid followups by amitiuttarwar · Pull Request #19879 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] lviggiano opened pull request #19902: Revert back to FILE_CHARS_BLACKLIST (master...master) https://github.com/bitcoin/bitcoin/pull/19902
< amiti> elichai2: don't think so? anything specific you're concerned about?
< elichai2> not concerned :) just trying to understand the code of that class while reviewing and wondered if the ordering is used or not
< amiti> gotcha. I don't expect order to be important or relevant, but please fact check me :)
< jnewbery> can someone block lviggiano from the repo?
< bitcoin-git> [bitcoin] jnewbery closed pull request #19902: Revert back to FILE_CHARS_BLACKLIST (master...master) https://github.com/bitcoin/bitcoin/pull/19902
< sipa> blocked
< jnewbery> thanks!
< promag> this means he won't be able to review?
< promag> that sucks
< bitcoin-git> [bitcoin] hebasto closed pull request #19882: depends: Export PATH variable rather passing it to the `call` function (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882
< bitcoin-git> [bitcoin] hebasto reopened pull request #19882: depends: Export PATH variable rather passing it to the `call` function (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882
< instagibbs> I don't think this cirrus ci error is my fault, can I get a restart? https://github.com/bitcoin/bitcoin/runs/1075836171
< sipa> instagibbs: done, though it does look quite real
< instagibbs> ok meanwhile let me try to trigger it locally
< bitcoin-git> [bitcoin] meshcollider pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/af8135e369da...56d47e19edca
< bitcoin-git> bitcoin/master 288b4ff Russell Yanofsky: Remove WalletLocation class
< bitcoin-git> bitcoin/master b5b4141 Russell Yanofsky: wallet: Add MakeDatabase function
< bitcoin-git> bitcoin/master 0d94e60 Russell Yanofsky: refactor: Use DatabaseStatus and DatabaseOptions types
< bitcoin-git> [bitcoin] meshcollider merged pull request #19619: Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp (master...pr/path) https://github.com/bitcoin/bitcoin/pull/19619
< achow101> \o/
< achow101> Time for sqlite wallets